Re: Review Request 69851: Added end-to-end test for operations affecting agent default resources.

2019-01-29 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69851/#review212432
---



PASS: Mesos patch 69851 was successfully built and tested.

Reviews applied: `['69786', '69723', '69790', '69791', '69792', '69793', 
'69794', '69795', '69825', '69851']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2828/mesos-review-69851

- Mesos Reviewbot Windows


On Jan. 29, 2019, 9:56 p.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69851/
> ---
> 
> (Updated Jan. 29, 2019, 9:56 p.m.)
> 
> 
> Review request for mesos, Benno Evers and Greg Mann.
> 
> 
> Bugs: MESOS-9356
> https://issues.apache.org/jira/browse/MESOS-9356
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added end-to-end test for operations affecting agent default resources.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 9168e06348a83dcb20400a2fe0e3bb1f26e6ff1b 
> 
> 
> Diff: https://reviews.apache.org/r/69851/diff/2/
> 
> 
> Testing
> ---
> 
> `GLOG_v=1 bin/mesos-tests.sh --verbose 
> --gtest_filter="*Slave*RetryOperationStatusUpdateAfterRecovery*" 
> --gtest_repeat=5000 --gtest_break_on_failure` passed on CentOS 7.4.1708.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>

Re: Review Request 69851: Added end-to-end test for operations affecting agent default resources.

2019-01-29 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69851/#review212431
---


Ship it!




Ship It!

- Greg Mann


On Jan. 29, 2019, 9:56 p.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69851/
> ---
> 
> (Updated Jan. 29, 2019, 9:56 p.m.)
> 
> 
> Review request for mesos, Benno Evers and Greg Mann.
> 
> 
> Bugs: MESOS-9356
> https://issues.apache.org/jira/browse/MESOS-9356
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added end-to-end test for operations affecting agent default resources.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 9168e06348a83dcb20400a2fe0e3bb1f26e6ff1b 
> 
> 
> Diff: https://reviews.apache.org/r/69851/diff/2/
> 
> 
> Testing
> ---
> 
> `GLOG_v=1 bin/mesos-tests.sh --verbose 
> --gtest_filter="*Slave*RetryOperationStatusUpdateAfterRecovery*" 
> --gtest_repeat=5000 --gtest_break_on_failure` passed on CentOS 7.4.1708.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>

Re: Review Request 69851: Added end-to-end test for operations affecting agent default resources.

2019-01-29 Thread Gastón Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69851/
---

(Updated Jan. 29, 2019, 1:56 p.m.)


Review request for mesos, Benno Evers and Greg Mann.


Changes
---

Addressed feedback.


Bugs: MESOS-9356
https://issues.apache.org/jira/browse/MESOS-9356


Repository: mesos


Description
---

Added end-to-end test for operations affecting agent default resources.


Diffs (updated)
-

  src/tests/slave_tests.cpp 9168e06348a83dcb20400a2fe0e3bb1f26e6ff1b 


Diff: https://reviews.apache.org/r/69851/diff/2/

Changes: https://reviews.apache.org/r/69851/diff/1-2/


Testing
---

`GLOG_v=1 bin/mesos-tests.sh --verbose 
--gtest_filter="*Slave*RetryOperationStatusUpdateAfterRecovery*" 
--gtest_repeat=5000 --gtest_break_on_failure` passed on CentOS 7.4.1708.


Thanks,

Gastón Kleiman

Re: Review Request 69851: Added end-to-end test for operations affecting agent default resources.

2019-01-29 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69851/#review212416
---




src/tests/slave_tests.cpp
Lines 11436-11437 (patched)


Let's be explicit in this comment that we are verifying that the agent's 
checkpointing/recovery logic works.



src/tests/slave_tests.cpp
Lines 11437 (patched)


Add a period.



src/tests/slave_tests.cpp
Lines 11440 (patched)


s/Send/Sends/



src/tests/slave_tests.cpp
Lines 11441-11442 (patched)


This is incorrect, right? Looks like the test allows the update to go 
through but uses the acknowledgement to control the removal of the operation 
from the agent's state.



src/tests/slave_tests.cpp
Lines 11464 (patched)


Let's use `DEFAULT_TEST_ROLE` here.


- Greg Mann


On Jan. 28, 2019, 11:24 p.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69851/
> ---
> 
> (Updated Jan. 28, 2019, 11:24 p.m.)
> 
> 
> Review request for mesos, Benno Evers and Greg Mann.
> 
> 
> Bugs: MESOS-9356
> https://issues.apache.org/jira/browse/MESOS-9356
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added end-to-end test for operations affecting agent default resources.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 9168e06348a83dcb20400a2fe0e3bb1f26e6ff1b 
> 
> 
> Diff: https://reviews.apache.org/r/69851/diff/1/
> 
> 
> Testing
> ---
> 
> `GLOG_v=1 bin/mesos-tests.sh --verbose 
> --gtest_filter="*Slave*RetryOperationStatusUpdateAfterRecovery*" 
> --gtest_repeat=5000 --gtest_break_on_failure` passed on CentOS 7.4.1708.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>

Re: Review Request 69851: Added end-to-end test for operations affecting agent default resources.

2019-01-28 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69851/#review212397
---



PASS: Mesos patch 69851 was successfully built and tested.

Reviews applied: `['69786', '69723', '69790', '69791', '69792', '69793', 
'69794', '69795', '69825', '69851']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2823/mesos-review-69851

- Mesos Reviewbot Windows


On Jan. 28, 2019, 3:24 p.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69851/
> ---
> 
> (Updated Jan. 28, 2019, 3:24 p.m.)
> 
> 
> Review request for mesos, Benno Evers and Greg Mann.
> 
> 
> Bugs: MESOS-9356
> https://issues.apache.org/jira/browse/MESOS-9356
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added end-to-end test for operations affecting agent default resources.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 9168e06348a83dcb20400a2fe0e3bb1f26e6ff1b 
> 
> 
> Diff: https://reviews.apache.org/r/69851/diff/1/
> 
> 
> Testing
> ---
> 
> `GLOG_v=1 bin/mesos-tests.sh --verbose 
> --gtest_filter="*Slave*RetryOperationStatusUpdateAfterRecovery*" 
> --gtest_repeat=5000 --gtest_break_on_failure` passed on CentOS 7.4.1708.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>

Review Request 69851: Added end-to-end test for operations affecting agent default resources.

2019-01-28 Thread Gastón Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69851/
---

Review request for mesos, Benno Evers and Greg Mann.


Bugs: MESOS-9356
https://issues.apache.org/jira/browse/MESOS-9356


Repository: mesos


Description
---

Added end-to-end test for operations affecting agent default resources.


Diffs
-

  src/tests/slave_tests.cpp 9168e06348a83dcb20400a2fe0e3bb1f26e6ff1b 


Diff: https://reviews.apache.org/r/69851/diff/1/


Testing
---

`GLOG_v=1 bin/mesos-tests.sh --verbose 
--gtest_filter="*Slave*RetryOperationStatusUpdateAfterRecovery*" 
--gtest_repeat=5000 --gtest_break_on_failure` passed on CentOS 7.4.1708.


Thanks,

Gastón Kleiman