Re: Review Request 69908: Removed unreachable tasks from `Master::Framework` on agent GC.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69908/#review212849 --- Ship it! Ship It! - Gastón Kleiman On Feb. 6, 2019, 8:38 a.m., Vinod Kone wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69908/ > --- > > (Updated Feb. 6, 2019, 8:38 a.m.) > > > Review request for mesos, Gastón Kleiman and Greg Mann. > > > Bugs: MESOS-8887 > https://issues.apache.org/jira/browse/MESOS-8887 > > > Repository: mesos > > > Description > --- > > Unreachable tasks are stored in `Slaves` and `Framework` structs of > the master, but they were only being removed from the former when > an unreachable agent is GCed from the registry. This patch fixes it > so that the latter is also cleaned up. > > > Diffs > - > > src/master/master.cpp 4c9ef2528d0ab74b565dcb03d05c5189d0aa0c0f > > > Diff: https://reviews.apache.org/r/69908/diff/1/ > > > Testing > --- > > make check (Updated test in next patch) > > > Thanks, > > Vinod Kone > >
Re: Review Request 69908: Removed unreachable tasks from `Master::Framework` on agent GC.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69908/#review212611 --- PASS: Mesos patch 69908 was successfully built and tested. Reviews applied: `['69907', '69908']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2858/mesos-review-69908 - Mesos Reviewbot Windows On Feb. 6, 2019, 4:38 p.m., Vinod Kone wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69908/ > --- > > (Updated Feb. 6, 2019, 4:38 p.m.) > > > Review request for mesos, Gastón Kleiman and Greg Mann. > > > Bugs: MESOS-8887 > https://issues.apache.org/jira/browse/MESOS-8887 > > > Repository: mesos > > > Description > --- > > Unreachable tasks are stored in `Slaves` and `Framework` structs of > the master, but they were only being removed from the former when > an unreachable agent is GCed from the registry. This patch fixes it > so that the latter is also cleaned up. > > > Diffs > - > > src/master/master.cpp 4c9ef2528d0ab74b565dcb03d05c5189d0aa0c0f > > > Diff: https://reviews.apache.org/r/69908/diff/1/ > > > Testing > --- > > make check (Updated test in next patch) > > > Thanks, > > Vinod Kone > >
Review Request 69908: Removed unreachable tasks from `Master::Framework` on agent GC.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69908/ --- Review request for mesos, Gastón Kleiman and Greg Mann. Bugs: MESOS-8887 https://issues.apache.org/jira/browse/MESOS-8887 Repository: mesos Description --- Unreachable tasks are stored in `Slaves` and `Framework` structs of the master, but they were only being removed from the former when an unreachable agent is GCed from the registry. This patch fixes it so that the latter is also cleaned up. Diffs - src/master/master.cpp 4c9ef2528d0ab74b565dcb03d05c5189d0aa0c0f Diff: https://reviews.apache.org/r/69908/diff/1/ Testing --- make check (Updated test in next patch) Thanks, Vinod Kone