Re: Review Request 70092: Updated to pylint-2.3.0.

[Benjamin Bannier]

> On March 3, 2019, 9:25 a.m., Armand Grillet wrote:
> > support/mesos-style.py
> > Lines 251 (patched)
> > 
> >
> > Why is this necessary? The directory `.tox` should mainly have `.py` 
> > and `.pyc` but no C++ source files.

You are correct, not needed here ATM, removing.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70092/#review213364
---


On March 3, 2019, 11:36 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70092/
> ---
> 
> (Updated March 3, 2019, 11:36 a.m.)
> 
> 
> Review request for mesos and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated to pylint-2.3.0.
> 
> 
> Diffs
> -
> 
>   src/python/cli_new/tox.ini 236adc7425a57d3e1fae35432527c83ccb46a4c7 
>   src/python/lib/tox.ini 3ee77681a9b802cd5b4a7910779b8d50aac4cf69 
> 
> 
> Diff: https://reviews.apache.org/r/70092/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> This currently triggers MESOS-9629 if one invokes a linter. It does not fail 
> `make check` unless we implement MESOS-9628.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 70092: Updated to pylint-2.3.0.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70092/
---

(Updated March 3, 2019, 11:36 a.m.)


Review request for mesos and Armand Grillet.


Changes
---

Address issue raised by Armand


Repository: mesos


Description
---

Updated to pylint-2.3.0.


Diffs (updated)
-

  src/python/cli_new/tox.ini 236adc7425a57d3e1fae35432527c83ccb46a4c7 
  src/python/lib/tox.ini 3ee77681a9b802cd5b4a7910779b8d50aac4cf69 


Diff: https://reviews.apache.org/r/70092/diff/2/

Changes: https://reviews.apache.org/r/70092/diff/1-2/


Testing
---

`make check`

This currently triggers MESOS-9629 if one invokes a linter. It does not fail 
`make check` unless we implement MESOS-9628.


Thanks,

Benjamin Bannier

Re: Review Request 70092: Updated to pylint-2.3.0.

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70092/#review213364
---




support/mesos-style.py
Lines 251 (patched)


Why is this necessary? The directory `.tox` should mainly have `.py` and 
`.pyc` but no C++ source files.


- Armand Grillet


On March 3, 2019, 2:01 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70092/
> ---
> 
> (Updated March 3, 2019, 2:01 a.m.)
> 
> 
> Review request for mesos and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated to pylint-2.3.0.
> 
> 
> Diffs
> -
> 
>   src/python/cli_new/tox.ini 236adc7425a57d3e1fae35432527c83ccb46a4c7 
>   src/python/lib/tox.ini 3ee77681a9b802cd5b4a7910779b8d50aac4cf69 
>   support/mesos-style.py 11d5f96d4ca534a7d51ed93d2d6b0c528d31fad4 
> 
> 
> Diff: https://reviews.apache.org/r/70092/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> This currently triggers MESOS-9629 if one invokes a linter. It does not fail 
> `make check` unless we implement MESOS-9628.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Review Request 70092: Updated to pylint-2.3.0.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70092/
---

Review request for mesos and Armand Grillet.


Repository: mesos


Description
---

Updated to pylint-2.3.0.


Diffs
-

  src/python/cli_new/tox.ini 236adc7425a57d3e1fae35432527c83ccb46a4c7 
  src/python/lib/tox.ini 3ee77681a9b802cd5b4a7910779b8d50aac4cf69 
  support/mesos-style.py 11d5f96d4ca534a7d51ed93d2d6b0c528d31fad4 


Diff: https://reviews.apache.org/r/70092/diff/1/


Testing
---

`make check`

This currently triggers MESOS-9629 if one invokes a linter. It does not fail 
`make check` unless we implement MESOS-9628.


Thanks,

Benjamin Bannier