Re: Review Request 70468: Fixed crash when recovering a volume failed to publish with CSI v1.

2019-04-12 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70468/#review214643
---


Ship it!




Ship It!

- Benjamin Bannier


On April 12, 2019, 11:57 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70468/
> ---
> 
> (Updated April 12, 2019, 11:57 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-9729
> https://issues.apache.org/jira/browse/MESOS-9729
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The CSI v1 volume manager falsely assumed that the target path always
> exists when unpublishing a volume, which is not true if there is a
> failure when publishing the volume.
> 
> 
> Diffs
> -
> 
>   src/csi/v1_volume_manager.cpp bf640f9ee836f6d8cc6bb2364f2cdeddc51a7cf3 
> 
> 
> Diff: https://reviews.apache.org/r/70468/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> Testing of this bug is done later in the chain.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>



Review Request 70468: Fixed crash when recovering a volume failed to publish with CSI v1.

2019-04-12 Thread Chun-Hung Hsiao

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70468/
---

Review request for mesos and Benjamin Bannier.


Bugs: MESOS-9729
https://issues.apache.org/jira/browse/MESOS-9729


Repository: mesos


Description
---

The CSI v1 volume manager falsely assumed that the target path always
exists when unpublishing a volume, which is not true if there is a
failure when publishing the volume.


Diffs
-

  src/csi/v1_volume_manager.cpp bf640f9ee836f6d8cc6bb2364f2cdeddc51a7cf3 


Diff: https://reviews.apache.org/r/70468/diff/1/


Testing
---

make check
Testing of this bug is done later in the chain.


Thanks,

Chun-Hung Hsiao