Re: Review Request 70627: Explicitly marked agent resource provider config calls as experimental.

2019-05-10 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70627/#review215196
---



Patch looks great!

Reviews applied: [70627]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On May 10, 2019, 9:17 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70627/
> ---
> 
> (Updated May 10, 2019, 9:17 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and James DeFelice.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The resource provider feature has been marked as experimental, so we
> should also call out the related config API calls are experimental.
> 
> 
> Diffs
> -
> 
>   include/mesos/agent/agent.proto ff408a4a1f144237e7425961aa3d11cba163e7c0 
>   include/mesos/v1/agent/agent.proto 19d6c424365f8fd6e6d4a5bb7a61fbe5a66f031d 
> 
> 
> Diff: https://reviews.apache.org/r/70627/diff/1/
> 
> 
> Testing
> ---
> 
> N/A
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>



Re: Review Request 70627: Explicitly marked agent resource provider config calls as experimental.

2019-05-10 Thread James DeFelice

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70627/#review215195
---


Ship it!




Ship It!

- James DeFelice


On May 10, 2019, 9:17 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70627/
> ---
> 
> (Updated May 10, 2019, 9:17 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and James DeFelice.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The resource provider feature has been marked as experimental, so we
> should also call out the related config API calls are experimental.
> 
> 
> Diffs
> -
> 
>   include/mesos/agent/agent.proto ff408a4a1f144237e7425961aa3d11cba163e7c0 
>   include/mesos/v1/agent/agent.proto 19d6c424365f8fd6e6d4a5bb7a61fbe5a66f031d 
> 
> 
> Diff: https://reviews.apache.org/r/70627/diff/1/
> 
> 
> Testing
> ---
> 
> N/A
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>



Review Request 70627: Explicitly marked agent resource provider config calls as experimental.

2019-05-10 Thread Chun-Hung Hsiao

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70627/
---

Review request for mesos, Benjamin Bannier and James DeFelice.


Repository: mesos


Description
---

The resource provider feature has been marked as experimental, so we
should also call out the related config API calls are experimental.


Diffs
-

  include/mesos/agent/agent.proto ff408a4a1f144237e7425961aa3d11cba163e7c0 
  include/mesos/v1/agent/agent.proto 19d6c424365f8fd6e6d4a5bb7a61fbe5a66f031d 


Diff: https://reviews.apache.org/r/70627/diff/1/


Testing
---

N/A


Thanks,

Chun-Hung Hsiao