Re: Review Request 70765: Renamed struct `ProfileRecord` to `ProfileData` for consistency.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70765/#review215711 --- Bad review! Reviews applied: [70765, 70766, 70622, 70621, 70620] Error: 2019-06-06 05:28:23 URL:https://reviews.apache.org/r/70765/diff/raw/ [2910/2910] -> "70765.patch" [1] error: patch failed: src/resource_provider/storage/uri_disk_profile_adaptor.cpp:278 error: src/resource_provider/storage/uri_disk_profile_adaptor.cpp: patch does not apply - Mesos Reviewbot On May 31, 2019, 3:12 a.m., Chun-Hung Hsiao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70765/ > --- > > (Updated May 31, 2019, 3:12 a.m.) > > > Review request for mesos, Benjamin Bannier and Benjamin Mahler. > > > Repository: mesos > > > Description > --- > > Renamed struct `ProfileRecord` to `ProfileData` for consistency. > > > Diffs > - > > src/resource_provider/storage/uri_disk_profile_adaptor.hpp > a5a34dc4dc1d518dc69aeb15fe62bd124d828ed3 > src/resource_provider/storage/uri_disk_profile_adaptor.cpp > 215f7f92b5c2a0e60555134ce9887e8a187e3b1d > > > Diff: https://reviews.apache.org/r/70765/diff/1/ > > > Testing > --- > > make check > > > Thanks, > > Chun-Hung Hsiao > >
Re: Review Request 70765: Renamed struct `ProfileRecord` to `ProfileData` for consistency.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70765/#review215609 --- Patch looks great! Reviews applied: [70766, 70765] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On May 31, 2019, 3:12 a.m., Chun-Hung Hsiao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70765/ > --- > > (Updated May 31, 2019, 3:12 a.m.) > > > Review request for mesos, Benjamin Bannier and Benjamin Mahler. > > > Repository: mesos > > > Description > --- > > Renamed struct `ProfileRecord` to `ProfileData` for consistency. > > > Diffs > - > > src/resource_provider/storage/uri_disk_profile_adaptor.hpp > a5a34dc4dc1d518dc69aeb15fe62bd124d828ed3 > src/resource_provider/storage/uri_disk_profile_adaptor.cpp > 215f7f92b5c2a0e60555134ce9887e8a187e3b1d > > > Diff: https://reviews.apache.org/r/70765/diff/1/ > > > Testing > --- > > make check > > > Thanks, > > Chun-Hung Hsiao > >
Review Request 70765: Renamed struct `ProfileRecord` to `ProfileData` for consistency.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70765/ --- Review request for mesos, Benjamin Bannier and Benjamin Mahler. Repository: mesos Description --- Renamed struct `ProfileRecord` to `ProfileData` for consistency. Diffs - src/resource_provider/storage/uri_disk_profile_adaptor.hpp a5a34dc4dc1d518dc69aeb15fe62bd124d828ed3 src/resource_provider/storage/uri_disk_profile_adaptor.cpp 215f7f92b5c2a0e60555134ce9887e8a187e3b1d Diff: https://reviews.apache.org/r/70765/diff/1/ Testing --- make check Thanks, Chun-Hung Hsiao