Re: Review Request 70829: Added logrotate option to force Jenkins into removing older artefacts.

2019-06-11 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70829/#review215798
---



Patch looks great!

Reviews applied: [70829]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On June 11, 2019, 5:12 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70829/
> ---
> 
> (Updated June 11, 2019, 5:12 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   support/jenkins/Jenkinsfile-packaging-centos 
> de688f45f6530c48f13930cbd78f772873a1bc84 
> 
> 
> Diff: https://reviews.apache.org/r/70829/diff/1/
> 
> 
> Testing
> ---
> 
> Untested but based on documentation and hope: 
> https://support.cloudbees.com/hc/en-us/articles/115000237071-How-do-I-set-discard-old-builds-for-a-Multi-Branch-Pipeline-Job-
> 
> This should remove old logfiles and artefacts after 30 days.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>



Re: Review Request 70829: Added logrotate option to force Jenkins into removing older artefacts.

2019-06-11 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70829/#review215791
---


Ship it!




Ship It!

- Benjamin Bannier


On June 11, 2019, 1:42 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70829/
> ---
> 
> (Updated June 11, 2019, 1:42 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   support/jenkins/Jenkinsfile-packaging-centos 
> de688f45f6530c48f13930cbd78f772873a1bc84 
> 
> 
> Diff: https://reviews.apache.org/r/70829/diff/1/
> 
> 
> Testing
> ---
> 
> Untested but based on documentation and hope: 
> https://support.cloudbees.com/hc/en-us/articles/115000237071-How-do-I-set-discard-old-builds-for-a-Multi-Branch-Pipeline-Job-
> 
> This should remove old logfiles and artefacts after 30 days.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>



Review Request 70829: Added logrotate option to force Jenkins into removing older artefacts.

2019-06-11 Thread Till Toenshoff via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70829/
---

Review request for mesos, Benjamin Bannier and Vinod Kone.


Repository: mesos


Description
---

See summary.


Diffs
-

  support/jenkins/Jenkinsfile-packaging-centos 
de688f45f6530c48f13930cbd78f772873a1bc84 


Diff: https://reviews.apache.org/r/70829/diff/1/


Testing
---

Untested but based on documentation and hope: 
https://support.cloudbees.com/hc/en-us/articles/115000237071-How-do-I-set-discard-old-builds-for-a-Multi-Branch-Pipeline-Job-

This should remove old logfiles and artefacts after 30 days.


Thanks,

Till Toenshoff