Re: Review Request 70845: Added the test `NamespacesIsolatorTest.ROOT_ShareIPCNamespace`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70845/#review216589 --- Ship it! Ship It! - Gilbert Song On July 13, 2019, 1:16 a.m., Qian Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70845/ > --- > > (Updated July 13, 2019, 1:16 a.m.) > > > Review request for mesos, Andrei Budnik and Gilbert Song. > > > Bugs: MESOS-9788 > https://issues.apache.org/jira/browse/MESOS-9788 > > > Repository: mesos > > > Description > --- > > Added the test `NamespacesIsolatorTest.ROOT_ShareIPCNamespace`. > > > Diffs > - > > src/tests/containerizer/isolator_tests.cpp > bb2cda47ad1fdd7ad16c419eb04f2e0b9293d2b6 > > > Diff: https://reviews.apache.org/r/70845/diff/3/ > > > Testing > --- > > sudo make check > > > Thanks, > > Qian Zhang > >
Re: Review Request 70845: Added the test `NamespacesIsolatorTest.ROOT_ShareIPCNamespace`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70845/ --- (Updated July 13, 2019, 4:16 p.m.) Review request for mesos, Andrei Budnik and Gilbert Song. Changes --- Enabled `docker/runtime` isolator by default. Bugs: MESOS-9788 https://issues.apache.org/jira/browse/MESOS-9788 Repository: mesos Description --- Added the test `NamespacesIsolatorTest.ROOT_ShareIPCNamespace`. Diffs (updated) - src/tests/containerizer/isolator_tests.cpp bb2cda47ad1fdd7ad16c419eb04f2e0b9293d2b6 Diff: https://reviews.apache.org/r/70845/diff/3/ Changes: https://reviews.apache.org/r/70845/diff/2-3/ Testing --- sudo make check Thanks, Qian Zhang
Re: Review Request 70845: Added the test `NamespacesIsolatorTest.ROOT_ShareIPCNamespace`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70845/#review216551 --- seems like this test fails consistently? - Gilbert Song On June 12, 2019, 11:57 p.m., Qian Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70845/ > --- > > (Updated June 12, 2019, 11:57 p.m.) > > > Review request for mesos, Andrei Budnik and Gilbert Song. > > > Bugs: MESOS-9788 > https://issues.apache.org/jira/browse/MESOS-9788 > > > Repository: mesos > > > Description > --- > > Added the test `NamespacesIsolatorTest.ROOT_ShareIPCNamespace`. > > > Diffs > - > > src/tests/containerizer/isolator_tests.cpp > 9c14f3acbc19631b2f5cac4dc7cd9caba8527712 > > > Diff: https://reviews.apache.org/r/70845/diff/2/ > > > Testing > --- > > sudo make check > > > Thanks, > > Qian Zhang > >
Re: Review Request 70845: Added the test `NamespacesIsolatorTest.ROOT_ShareIPCNamespace`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70845/ --- (Updated June 13, 2019, 2:57 p.m.) Review request for mesos, Andrei Budnik and Gilbert Song. Bugs: MESOS-9788 https://issues.apache.org/jira/browse/MESOS-9788 Repository: mesos Description --- Added the test `NamespacesIsolatorTest.ROOT_ShareIPCNamespace`. Diffs (updated) - src/tests/containerizer/isolator_tests.cpp 9c14f3acbc19631b2f5cac4dc7cd9caba8527712 Diff: https://reviews.apache.org/r/70845/diff/2/ Changes: https://reviews.apache.org/r/70845/diff/1-2/ Testing --- sudo make check Thanks, Qian Zhang
Re: Review Request 70845: Added the test `NamespacesIsolatorTest.ROOT_ShareIPCNamespace`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70845/#review215860 --- Patch looks great! Reviews applied: [70773, 70774, 70775, 70798, 70844, 70820, 70845] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On June 12, 2019, 2:38 p.m., Qian Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70845/ > --- > > (Updated June 12, 2019, 2:38 p.m.) > > > Review request for mesos, Andrei Budnik and Gilbert Song. > > > Bugs: MESOS-9788 > https://issues.apache.org/jira/browse/MESOS-9788 > > > Repository: mesos > > > Description > --- > > Added the test `NamespacesIsolatorTest.ROOT_ShareIPCNamespace`. > > > Diffs > - > > src/tests/containerizer/isolator_tests.cpp > 9c14f3acbc19631b2f5cac4dc7cd9caba8527712 > > > Diff: https://reviews.apache.org/r/70845/diff/1/ > > > Testing > --- > > sudo make check > > > Thanks, > > Qian Zhang > >
Review Request 70845: Added the test `NamespacesIsolatorTest.ROOT_ShareIPCNamespace`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70845/ --- Review request for mesos, Andrei Budnik and Gilbert Song. Bugs: MESOS-9788 https://issues.apache.org/jira/browse/MESOS-9788 Repository: mesos Description --- Added the test `NamespacesIsolatorTest.ROOT_ShareIPCNamespace`. Diffs - src/tests/containerizer/isolator_tests.cpp 9c14f3acbc19631b2f5cac4dc7cd9caba8527712 Diff: https://reviews.apache.org/r/70845/diff/1/ Testing --- sudo make check Thanks, Qian Zhang
