Re: Review Request 70862: Update `EXPECT` to `ASSERT` in blkio tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70862/#review215940 --- Ship it! Ship It! - Gilbert Song On June 16, 2019, 7:13 p.m., James Peach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70862/ > --- > > (Updated June 16, 2019, 7:13 p.m.) > > > Review request for mesos, Gilbert Song and Qian Zhang. > > > Repository: mesos > > > Description > --- > > Since the blkio cgroup tests immediately require the result of > `blkio_statistics()`, we should test for the presence of statistics > with `ASSERT_TRUE` rather than `EXPECT_TRUE`. > > > Diffs > - > > src/tests/containerizer/cgroups_isolator_tests.cpp > eef8eb28ea57ef0a2a3c626ac9aee202eb7231d9 > > > Diff: https://reviews.apache.org/r/70862/diff/1/ > > > Testing > --- > > make check (Fedora 30) > > > Thanks, > > James Peach > >
Re: Review Request 70862: Update `EXPECT` to `ASSERT` in blkio tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70862/#review215928 --- Ship it! Ship It! - Jiang Yan Xu On June 16, 2019, 7:13 p.m., James Peach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70862/ > --- > > (Updated June 16, 2019, 7:13 p.m.) > > > Review request for mesos, Gilbert Song and Qian Zhang. > > > Repository: mesos > > > Description > --- > > Since the blkio cgroup tests immediately require the result of > `blkio_statistics()`, we should test for the presence of statistics > with `ASSERT_TRUE` rather than `EXPECT_TRUE`. > > > Diffs > - > > src/tests/containerizer/cgroups_isolator_tests.cpp > eef8eb28ea57ef0a2a3c626ac9aee202eb7231d9 > > > Diff: https://reviews.apache.org/r/70862/diff/1/ > > > Testing > --- > > make check (Fedora 30) > > > Thanks, > > James Peach > >
Re: Review Request 70862: Update `EXPECT` to `ASSERT` in blkio tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70862/#review215920 --- Patch looks great! Reviews applied: [70862] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On June 17, 2019, 2:13 a.m., James Peach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70862/ > --- > > (Updated June 17, 2019, 2:13 a.m.) > > > Review request for mesos, Gilbert Song and Qian Zhang. > > > Repository: mesos > > > Description > --- > > Since the blkio cgroup tests immediately require the result of > `blkio_statistics()`, we should test for the presence of statistics > with `ASSERT_TRUE` rather than `EXPECT_TRUE`. > > > Diffs > - > > src/tests/containerizer/cgroups_isolator_tests.cpp > eef8eb28ea57ef0a2a3c626ac9aee202eb7231d9 > > > Diff: https://reviews.apache.org/r/70862/diff/1/ > > > Testing > --- > > make check (Fedora 30) > > > Thanks, > > James Peach > >
Review Request 70862: Update `EXPECT` to `ASSERT` in blkio tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70862/ --- Review request for mesos, Gilbert Song and Qian Zhang. Repository: mesos Description --- Since the blkio cgroup tests immediately require the result of `blkio_statistics()`, we should test for the presence of statistics with `ASSERT_TRUE` rather than `EXPECT_TRUE`. Diffs - src/tests/containerizer/cgroups_isolator_tests.cpp eef8eb28ea57ef0a2a3c626ac9aee202eb7231d9 Diff: https://reviews.apache.org/r/70862/diff/1/ Testing --- make check (Fedora 30) Thanks, James Peach
