Re: Review Request 70921: Added OpenSSL-related changes to CHANGELOG.

[Benno Evers]

> On July 4, 2019, 3:12 p.m., Till Toenshoff wrote:
> > docs/upgrades.md
> > Lines 527 (patched)
> > 
> >
> > This is really hard to parse but right now I am unable to come up with 
> > something easier for the eye -- lets try to improve this with some native 
> > speaker help.

Since all native speakers I know where unavailable due to June 4th festivities, 
I committed this as-is for now, but will make sure to follow up with one to 
improve on it later on.


- Benno


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70921/#review216382
---


On July 4, 2019, 5:34 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70921/
> ---
> 
> (Updated July 4, 2019, 5:34 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Joseph Wu, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added OpenSSL-related changes to CHANGELOG.
> 
> 
> Diffs
> -
> 
>   CHANGELOG ecd01d6f415859eb6b9cfa3468db02d1810a3998 
>   docs/upgrades.md 4a818df4993093770b49efb675b8078c42144241 
> 
> 
> Diff: https://reviews.apache.org/r/70921/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 70921: Added OpenSSL-related changes to CHANGELOG.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70921/
---

(Updated July 4, 2019, 5:34 p.m.)


Review request for mesos, Benjamin Mahler, Joseph Wu, and Till Toenshoff.


Repository: mesos


Description
---

Added OpenSSL-related changes to CHANGELOG.


Diffs (updated)
-

  CHANGELOG ecd01d6f415859eb6b9cfa3468db02d1810a3998 
  docs/upgrades.md 4a818df4993093770b49efb675b8078c42144241 


Diff: https://reviews.apache.org/r/70921/diff/3/

Changes: https://reviews.apache.org/r/70921/diff/2-3/


Testing
---


Thanks,

Benno Evers

Re: Review Request 70921: Added OpenSSL-related changes to CHANGELOG.

[Till Toenshoff via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70921/#review216382
---


Fix it, then Ship it!




Ship It!


CHANGELOG
Lines 9 (patched)


s/should/will/



CHANGELOG
Lines 27 (patched)


How about:

... will now forego TLS certificate verification ...



CHANGELOG
Lines 27 (patched)


How about:

... will now forego TLS certificate verification ...



docs/upgrades.md
Lines 516 (patched)


s/change/configure/



docs/upgrades.md
Lines 526 (patched)


How about?
```  * For incoming connections, certificates are not verified unless 
`LIBPROCESS_SSL_REQUIRE_CERT` is set to true.
```



docs/upgrades.md
Lines 527 (patched)


This is really hard to parse but right now I am unable to come up with 
something easier for the eye -- lets try to improve this with some native 
speaker help.


- Till Toenshoff


On June 21, 2019, 3:02 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70921/
> ---
> 
> (Updated June 21, 2019, 3:02 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Joseph Wu, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added OpenSSL-related changes to CHANGELOG.
> 
> 
> Diffs
> -
> 
>   CHANGELOG ecd01d6f415859eb6b9cfa3468db02d1810a3998 
>   docs/upgrades.md 4a818df4993093770b49efb675b8078c42144241 
> 
> 
> Diff: https://reviews.apache.org/r/70921/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>