Re: Review Request 71072: Renamed agent flag `--default_shm_size`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71072/#review216639 --- Ship it! Ship It! - Gilbert Song On July 14, 2019, 11:18 p.m., Qian Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71072/ > --- > > (Updated July 14, 2019, 11:18 p.m.) > > > Review request for mesos and Gilbert Song. > > > Bugs: MESOS-9833 > https://issues.apache.org/jira/browse/MESOS-9833 > > > Repository: mesos > > > Description > --- > > Renamed agent flag `--default_shm_size`. > > > Diffs > - > > docs/configuration/agent.md 2046bf25838c4bba9409b0d5e7b29c35882356d2 > docs/isolators/namespaces-ipc.md 43ed8423a7d3877f02408947b78989b79dcd4907 > include/mesos/mesos.proto e0a23913ed64ff6e82c07db227e9d6e0f71a8b55 > include/mesos/v1/mesos.proto af29a140dc7f0a869c8e3b606ec4fb9a22ba1f7b > src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp > 9a984765a317e540e8c7c630dc46cf911f2a33a7 > src/slave/flags.hpp a10bf698dc447b1411c06083c2ba7585d7a78389 > src/slave/flags.cpp b4e3eb99221a09404dbbf813da33607867a78691 > src/tests/containerizer/isolator_tests.cpp > a493a309464f8c7b3cb6f0fc45a2762d12071c67 > > > Diff: https://reviews.apache.org/r/71072/diff/1/ > > > Testing > --- > > sudo make check > > > Thanks, > > Qian Zhang > >
Re: Review Request 71072: Renamed agent flag `--default_shm_size`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71072/#review216604 --- Patch looks great! Reviews applied: [71072] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On July 15, 2019, 6:18 a.m., Qian Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71072/ > --- > > (Updated July 15, 2019, 6:18 a.m.) > > > Review request for mesos and Gilbert Song. > > > Bugs: MESOS-9833 > https://issues.apache.org/jira/browse/MESOS-9833 > > > Repository: mesos > > > Description > --- > > Renamed agent flag `--default_shm_size`. > > > Diffs > - > > docs/configuration/agent.md 2046bf25838c4bba9409b0d5e7b29c35882356d2 > docs/isolators/namespaces-ipc.md 43ed8423a7d3877f02408947b78989b79dcd4907 > include/mesos/mesos.proto e0a23913ed64ff6e82c07db227e9d6e0f71a8b55 > include/mesos/v1/mesos.proto af29a140dc7f0a869c8e3b606ec4fb9a22ba1f7b > src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp > 9a984765a317e540e8c7c630dc46cf911f2a33a7 > src/slave/flags.hpp a10bf698dc447b1411c06083c2ba7585d7a78389 > src/slave/flags.cpp b4e3eb99221a09404dbbf813da33607867a78691 > src/tests/containerizer/isolator_tests.cpp > a493a309464f8c7b3cb6f0fc45a2762d12071c67 > > > Diff: https://reviews.apache.org/r/71072/diff/1/ > > > Testing > --- > > sudo make check > > > Thanks, > > Qian Zhang > >
Review Request 71072: Renamed agent flag `--default_shm_size`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71072/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-9833 https://issues.apache.org/jira/browse/MESOS-9833 Repository: mesos Description --- Renamed agent flag `--default_shm_size`. Diffs - docs/configuration/agent.md 2046bf25838c4bba9409b0d5e7b29c35882356d2 docs/isolators/namespaces-ipc.md 43ed8423a7d3877f02408947b78989b79dcd4907 include/mesos/mesos.proto e0a23913ed64ff6e82c07db227e9d6e0f71a8b55 include/mesos/v1/mesos.proto af29a140dc7f0a869c8e3b606ec4fb9a22ba1f7b src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp 9a984765a317e540e8c7c630dc46cf911f2a33a7 src/slave/flags.hpp a10bf698dc447b1411c06083c2ba7585d7a78389 src/slave/flags.cpp b4e3eb99221a09404dbbf813da33607867a78691 src/tests/containerizer/isolator_tests.cpp a493a309464f8c7b3cb6f0fc45a2762d12071c67 Diff: https://reviews.apache.org/r/71072/diff/1/ Testing --- sudo make check Thanks, Qian Zhang
