Re: Review Request 71338: Moved OpenSSL-related ifdef to a central location.

[Till Toenshoff via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71338/#review217353
---


Fix it, then Ship it!




Thanks Benno for fixing my ugly patch.


3rdparty/libprocess/src/openssl.cpp
Lines 55 (patched)


As nicely noted by BenjaminB in my previous less beautiful RR, we might 
want to explain what version this was; "(OpenSSL 1.1.0)" as done above.


- Till Toenshoff


On Aug. 21, 2019, 1:34 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71338/
> ---
> 
> (Updated Aug. 21, 2019, 1:34 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A previous commit introduced an preprocessor directive that would
> split up code between brackets, confusing syntax highlighters and
> making the logic hard to read.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/openssl.cpp 
> 4aeab855b29837dc6bf93104afc62f111c38626c 
> 
> 
> Diff: https://reviews.apache.org/r/71338/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 71338: Moved OpenSSL-related ifdef to a central location.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71338/
---

(Updated Aug. 21, 2019, 1:34 p.m.)


Review request for mesos, Benjamin Bannier and Till Toenshoff.


Repository: mesos


Description
---

A previous commit introduced an preprocessor directive that would
split up code between brackets, confusing syntax highlighters and
making the logic hard to read.


Diffs (updated)
-

  3rdparty/libprocess/src/openssl.cpp 4aeab855b29837dc6bf93104afc62f111c38626c 


Diff: https://reviews.apache.org/r/71338/diff/2/

Changes: https://reviews.apache.org/r/71338/diff/1-2/


Testing
---


Thanks,

Benno Evers

Review Request 71338: Moved OpenSSL-related ifdef to a central location.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71338/
---

Review request for mesos, Benjamin Bannier and Till Toenshoff.


Repository: mesos


Description
---

A previous commit introduced an preprocessor directive that would
split up code between brackets, confusing syntax highlighters and
making the logic hard to read.


Diffs
-

  3rdparty/libprocess/src/openssl.cpp 4aeab855b29837dc6bf93104afc62f111c38626c 


Diff: https://reviews.apache.org/r/71338/diff/1/


Testing
---


Thanks,

Benno Evers