Re: Review Request 72093: Added to `ObjectApprovers` a method to approve arbitrary action.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72093/ --- (Updated Feb. 27, 2020, 6:36 p.m.) Review request for mesos, Benjamin Mahler and Greg Mann. Changes --- rebased Bugs: MESOS-10056 https://issues.apache.org/jira/browse/MESOS-10056 Repository: mesos Description --- This is needed to use `ObjectApprovers` for authorizing scheduler API calls. Diffs (updated) - src/common/http.hpp 4a0f4a8c2ee9f07032d082ed039c4ea3bba6137a Diff: https://reviews.apache.org/r/72093/diff/5/ Changes: https://reviews.apache.org/r/72093/diff/4-5/ Testing --- Thanks, Andrei Sekretenko
Re: Review Request 72093: Added to `ObjectApprovers` a method to approve arbitrary action.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72093/#review219616 --- Ship it! Ship It! - Benjamin Mahler On Feb. 7, 2020, 5:32 p.m., Andrei Sekretenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72093/ > --- > > (Updated Feb. 7, 2020, 5:32 p.m.) > > > Review request for mesos, Benjamin Mahler and Greg Mann. > > > Bugs: MESOS-10056 > https://issues.apache.org/jira/browse/MESOS-10056 > > > Repository: mesos > > > Description > --- > > This is needed to use `ObjectApprovers` for authorizing scheduler API > calls. > > > Diffs > - > > src/common/http.hpp 5fc19fdd16138eb4c7d14fd29b1a56a53f6323a9 > > > Diff: https://reviews.apache.org/r/72093/diff/4/ > > > Testing > --- > > > Thanks, > > Andrei Sekretenko > >
Re: Review Request 72093: Added to `ObjectApprovers` a method to approve arbitrary action.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72093/#review219528 --- I'm a bit confused by this one, the existing method already has action in the template parameters, what does this accomplish? An explanation and maybe an example code snippet in the description would be helpful for the reader - Benjamin Mahler On Feb. 7, 2020, 5:32 p.m., Andrei Sekretenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72093/ > --- > > (Updated Feb. 7, 2020, 5:32 p.m.) > > > Review request for mesos, Benjamin Mahler and Greg Mann. > > > Bugs: MESOS-10056 > https://issues.apache.org/jira/browse/MESOS-10056 > > > Repository: mesos > > > Description > --- > > This is needed to use `ObjectApprovers` for authorizing scheduler API > calls. > > > Diffs > - > > src/common/http.hpp 5fc19fdd16138eb4c7d14fd29b1a56a53f6323a9 > > > Diff: https://reviews.apache.org/r/72093/diff/1/ > > > Testing > --- > > > Thanks, > > Andrei Sekretenko > >
Review Request 72093: Added to `ObjectApprovers` a method to approve arbitrary action.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72093/ --- Review request for mesos, Benjamin Mahler and Greg Mann. Bugs: MESOS-10056 https://issues.apache.org/jira/browse/MESOS-10056 Repository: mesos Description --- This is needed to use `ObjectApprovers` for authorizing scheduler API calls. Diffs - src/common/http.hpp 5fc19fdd16138eb4c7d14fd29b1a56a53f6323a9 Diff: https://reviews.apache.org/r/72093/diff/1/ Testing --- Thanks, Andrei Sekretenko
