Re: Review Request 72770: Updated the help message of the agent flag `--csi_plugin_config_dir`.

2020-08-13 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72770/#review221573
---


Ship it!




Ship It!

- Greg Mann


On Aug. 13, 2020, 8:46 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72770/
> ---
> 
> (Updated Aug. 13, 2020, 8:46 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10151
> https://issues.apache.org/jira/browse/MESOS-10151
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is to make the help message of the agent flag `--csi_plugin_config_dir`
> aligned with the latest protobuf message `CSIPluginInfo`.
> 
> 
> Diffs
> -
> 
>   docs/configuration/agent.md e8608d977652baf02b4474bb48d3f4598cfa5f3f 
>   src/slave/flags.cpp 02a5568f29927e767029a53f05f3b3e97ed0d1f8 
> 
> 
> Diff: https://reviews.apache.org/r/72770/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>



Re: Review Request 72770: Updated the help message of the agent flag `--csi_plugin_config_dir`.

2020-08-13 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72770/#review221565
---



Patch looks great!

Reviews applied: [72770]

Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/jenkins/buildbot.sh

- Mesos Reviewbot


On Aug. 13, 2020, 8:46 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72770/
> ---
> 
> (Updated Aug. 13, 2020, 8:46 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10151
> https://issues.apache.org/jira/browse/MESOS-10151
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is to make the help message of the agent flag `--csi_plugin_config_dir`
> aligned with the latest protobuf message `CSIPluginInfo`.
> 
> 
> Diffs
> -
> 
>   docs/configuration/agent.md e8608d977652baf02b4474bb48d3f4598cfa5f3f 
>   src/slave/flags.cpp 02a5568f29927e767029a53f05f3b3e97ed0d1f8 
> 
> 
> Diff: https://reviews.apache.org/r/72770/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>



Review Request 72770: Updated the help message of the agent flag `--csi_plugin_config_dir`.

2020-08-13 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72770/
---

Review request for mesos, Andrei Budnik and Greg Mann.


Bugs: MESOS-10151
https://issues.apache.org/jira/browse/MESOS-10151


Repository: mesos


Description
---

This is to make the help message of the agent flag `--csi_plugin_config_dir`
aligned with the latest protobuf message `CSIPluginInfo`.


Diffs
-

  docs/configuration/agent.md e8608d977652baf02b4474bb48d3f4598cfa5f3f 
  src/slave/flags.cpp 02a5568f29927e767029a53f05f3b3e97ed0d1f8 


Diff: https://reviews.apache.org/r/72770/diff/1/


Testing
---


Thanks,

Qian Zhang