Re: Review Request 73004: Documented setting offer constraints via the scheduler API.

2020-11-04 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73004/#review222167
---



Patch looks great!

Reviews applied: [73004]

Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/jenkins/buildbot.sh

- Mesos Reviewbot


On Nov. 5, 2020, 1:26 a.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73004/
> ---
> 
> (Updated Nov. 5, 2020, 1:26 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-10193
> https://issues.apache.org/jira/browse/MESOS-10193
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented setting offer constraints via the scheduler API.
> 
> 
> Diffs
> -
> 
>   docs/app-framework-development-guide.md 
> 8f30045b04d1a8f3c0d078ff79e65ba9c1e7c94a 
>   docs/scheduler-http-api.md e447ffb43253fd927bdb266ad12a4554c69e0ee8 
> 
> 
> Diff: https://reviews.apache.org/r/73004/diff/1/
> 
> 
> Testing
> ---
> 
> Tested manually how Github renders this:
> https://github.com/asekretenko/mesos/blob/offer_constraints_doc/docs/app-framework-development-guide.md
> https://github.com/asekretenko/mesos/blob/offer_constraints_doc/docs/scheduler-http-api.md
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>



Re: Review Request 73004: Documented setting offer constraints via the scheduler API.

2020-11-04 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73004/#review222166
---


Ship it!




Ship It!

- Vinod Kone


On Nov. 4, 2020, 7:56 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73004/
> ---
> 
> (Updated Nov. 4, 2020, 7:56 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-10193
> https://issues.apache.org/jira/browse/MESOS-10193
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented setting offer constraints via the scheduler API.
> 
> 
> Diffs
> -
> 
>   docs/app-framework-development-guide.md 
> 8f30045b04d1a8f3c0d078ff79e65ba9c1e7c94a 
>   docs/scheduler-http-api.md e447ffb43253fd927bdb266ad12a4554c69e0ee8 
> 
> 
> Diff: https://reviews.apache.org/r/73004/diff/1/
> 
> 
> Testing
> ---
> 
> Tested manually how Github renders this:
> https://github.com/asekretenko/mesos/blob/offer_constraints_doc/docs/app-framework-development-guide.md
> https://github.com/asekretenko/mesos/blob/offer_constraints_doc/docs/scheduler-http-api.md
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>



Review Request 73004: Documented setting offer constraints via the scheduler API.

2020-11-04 Thread Andrei Sekretenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73004/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-10193
https://issues.apache.org/jira/browse/MESOS-10193


Repository: mesos


Description
---

Documented setting offer constraints via the scheduler API.


Diffs
-

  docs/app-framework-development-guide.md 
8f30045b04d1a8f3c0d078ff79e65ba9c1e7c94a 
  docs/scheduler-http-api.md e447ffb43253fd927bdb266ad12a4554c69e0ee8 


Diff: https://reviews.apache.org/r/73004/diff/1/


Testing
---

Tested manually how Github renders this:
https://github.com/asekretenko/mesos/blob/offer_constraints_doc/docs/app-framework-development-guide.md
https://github.com/asekretenko/mesos/blob/offer_constraints_doc/docs/scheduler-http-api.md


Thanks,

Andrei Sekretenko