Re: Review Request 41843: Moved docker spec tests to a separate file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41843/#review112418 --- Ship it! Ship It! - Gilbert Song On Jan. 1, 2016, 1:23 p.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41843/ > --- > > (Updated Jan. 1, 2016, 1:23 p.m.) > > > Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen. > > > Repository: mesos > > > Description > --- > > Moved docker spec tests to a separate file. > > This is a part of a series patchs to clean up docker related code. > > > Diffs > - > > src/Makefile.am b58d6b560858d318058be766456dd5c5ef98c23e > src/tests/containerizer/docker_spec_tests.cpp PRE-CREATION > src/tests/containerizer/provisioner_docker_tests.cpp > d51f342dabf386fb618ef72ce3e36a8bd8c82b5f > > Diff: https://reviews.apache.org/r/41843/diff/ > > > Testing > --- > > make check > > > Thanks, > > Jie Yu > >
Re: Review Request 41842: Small style fixes in docker tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41842/#review112425 --- Ship it! Ship It! - Timothy Chen On Jan. 1, 2016, 9:22 p.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41842/ > --- > > (Updated Jan. 1, 2016, 9:22 p.m.) > > > Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen. > > > Repository: mesos > > > Description > --- > > Small style fixes in docker tests. > > This is a part of a series patchs to clean up docker related code. > > > Diffs > - > > src/tests/containerizer/docker_tests.cpp > 83eceacaddc38d0ccfc42e65e700a09406d8df36 > > Diff: https://reviews.apache.org/r/41842/diff/ > > > Testing > --- > > make check > > > Thanks, > > Jie Yu > >
Review Request 41840: Moved docker spec to the top level.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41840/ --- Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen. Repository: mesos Description --- Moved docker spec to the top level. This is a part of a series patchs to clean up docker related code. Diffs - src/Makefile.am b58d6b560858d318058be766456dd5c5ef98c23e src/docker/v1.hpp PRE-CREATION src/docker/v2.hpp PRE-CREATION src/slave/containerizer/mesos/provisioner/docker/message.hpp 5c071432724f1c583b4dba1ed391e4af22c6ba8f src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp e73d4d785bccf1d50af9e91d2d20dafb444bec68 src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 4e305ade1f9f8b42de5c8db636c6d3f5d8e2444f src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 049d46cad5cf94a3fb5d74cbfe649850311d35ad src/slave/containerizer/mesos/provisioner/docker/spec.hpp 1bd4ac10373fd95d2a22658715c6dbf81fbb567f src/slave/containerizer/mesos/provisioner/docker/spec.cpp 5bbd98cb1c5f3aefd9050859d066b43360e6eb75 src/slave/containerizer/mesos/provisioner/docker/v1.proto 5aec78b51726e4c840ffb47aacca0e1ec13c80d3 src/slave/containerizer/mesos/provisioner/docker/v2.proto fdf159d003f8e5718de0f4d8bf9a2b1374cc11a2 src/tests/containerizer/provisioner_docker_tests.cpp d51f342dabf386fb618ef72ce3e36a8bd8c82b5f Diff: https://reviews.apache.org/r/41840/diff/ Testing --- make check Thanks, Jie Yu
Review Request 41841: Renamed Signatures in docker v2 image manifest to Signature.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41841/ --- Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen. Repository: mesos Description --- Renamed Signatures in docker v2 image manifest to Signature. This is a part of a series patchs to clean up docker related code. Diffs - src/docker/v2.proto fdf159d003f8e5718de0f4d8bf9a2b1374cc11a2 Diff: https://reviews.apache.org/r/41841/diff/ Testing --- make check Thanks, Jie Yu
Review Request 41839: Renamed FsLayers in docker v2 image manifest to FsLayer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41839/ --- Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen. Repository: mesos Description --- Renamed FsLayers in docker v2 image manifest to FsLayer. This is a part of a series patchs to clean up docker related code. Diffs - src/slave/containerizer/mesos/provisioner/docker/spec.cpp 5bbd98cb1c5f3aefd9050859d066b43360e6eb75 src/slave/containerizer/mesos/provisioner/docker/v2.proto fdf159d003f8e5718de0f4d8bf9a2b1374cc11a2 Diff: https://reviews.apache.org/r/41839/diff/ Testing --- make check Thanks, Jie Yu
Re: Review Request 41810: Added credential to Docker image protobuf.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41810/#review112419 --- Ship it! Ship It! - Gilbert Song On Dec. 30, 2015, 3:16 p.m., Timothy Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41810/ > --- > > (Updated Dec. 30, 2015, 3:16 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese. > > > Repository: mesos > > > Description > --- > > Added credential to Docker image protobuf. > > > Diffs > - > > include/mesos/mesos.proto 2431fdd6b84625c6140a2b3913736bffada4e7f6 > > Diff: https://reviews.apache.org/r/41810/diff/ > > > Testing > --- > > make > > > Thanks, > > Timothy Chen > >
Re: Review Request 41731: Removed docker puller flag.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41731/#review112420 --- Ship it! Ship It! - Gilbert Song On Dec. 30, 2015, 3:08 p.m., Timothy Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41731/ > --- > > (Updated Dec. 30, 2015, 3:08 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese. > > > Repository: mesos > > > Description > --- > > Removed docker puller flag. > > > Diffs > - > > docs/configuration.md a33e802a3ff1246d25f52b15da7905c5b22e339d > docs/mesos-provisioner.md fdb298c2a954e903317ef56abbcfe2470a2dfd23 > src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp > 025d96c80529024f6a1c1e2c15e1eda513c680fd > src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp > f71b572a32443a6715acb4d3541aec60e0437b30 > src/slave/containerizer/mesos/provisioner/docker/puller.cpp > dd17acf6a6e5c306029198dbb2a7e2d059f87f75 > src/slave/flags.hpp 2b2679c1ae68d120756eaf81e5728d20791d6746 > src/slave/flags.cpp a60d3c8022aba93fbd17a46dfff601fb1b25bbee > src/tests/containerizer/provisioner_docker_tests.cpp > d51f342dabf386fb618ef72ce3e36a8bd8c82b5f > > Diff: https://reviews.apache.org/r/41731/diff/ > > > Testing > --- > > make check > > > Thanks, > > Timothy Chen > >
Re: Review Request 41334: Added helper functions to filter allocation slack resources.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41334/ --- (Updated 一月 2, 2016, 1:14 a.m.) Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma. Bugs: MESOS-4146 https://issues.apache.org/jira/browse/MESOS-4146 Repository: mesos Description --- This helper function is used to filter out allocation slack resources. Diffs (updated) - include/mesos/resources.hpp 9c8bfb0e7e1e40ca99b4cc75079e5b950630243d include/mesos/v1/resources.hpp db87c992e2ec466cb1d4d17775bf6423a2fb15aa src/common/resources.cpp b9d31aef8babee212374e352c57fadbff02167f3 src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320 src/v1/resources.cpp 0c0eee6b3b7ae3254d7dc7b06187855c9b873764 Diff: https://reviews.apache.org/r/41334/diff/ Testing --- make make check Thanks, Guangya Liu
Re: Review Request 41769: Made allocator traverse all roles for quota allocation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41769/#review112427 --- Patch looks great! Reviews applied: [41769] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Dec. 31, 2015, 11:34 p.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41769/ > --- > > (Updated Dec. 31, 2015, 11:34 p.m.) > > > Review request for mesos, Alexander Rukletsov, Klaus Ma, and Neil Conway. > > > Repository: mesos > > > Description > --- > > Made allocator traverse all roles for quota allocation. > > > Diffs > - > > src/master/allocator/mesos/hierarchical.cpp > 7f900c4e024485704d79e57ae22407557598fe6c > > Diff: https://reviews.apache.org/r/41769/diff/ > > > Testing > --- > > make > make check > > > Thanks, > > Guangya Liu > >
Re: Review Request 41842: Small style fixes in docker tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41842/#review112417 --- Ship it! Ship It! - Gilbert Song On Jan. 1, 2016, 1:22 p.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41842/ > --- > > (Updated Jan. 1, 2016, 1:22 p.m.) > > > Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen. > > > Repository: mesos > > > Description > --- > > Small style fixes in docker tests. > > This is a part of a series patchs to clean up docker related code. > > > Diffs > - > > src/tests/containerizer/docker_tests.cpp > 83eceacaddc38d0ccfc42e65e700a09406d8df36 > > Diff: https://reviews.apache.org/r/41842/diff/ > > > Testing > --- > > make check > > > Thanks, > > Jie Yu > >
Re: Review Request 41841: Renamed Signatures in docker v2 image manifest to Signature.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41841/#review112416 --- Ship it! Ship It! - Gilbert Song On Jan. 1, 2016, 1:22 p.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41841/ > --- > > (Updated Jan. 1, 2016, 1:22 p.m.) > > > Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen. > > > Repository: mesos > > > Description > --- > > Renamed Signatures in docker v2 image manifest to Signature. > > This is a part of a series patchs to clean up docker related code. > > > Diffs > - > > src/docker/v2.proto fdf159d003f8e5718de0f4d8bf9a2b1374cc11a2 > > Diff: https://reviews.apache.org/r/41841/diff/ > > > Testing > --- > > make check > > > Thanks, > > Jie Yu > >
Re: Review Request 40529: Added helper function to get stateless resources.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40529/ --- (Updated 一月 2, 2016, 1:15 a.m.) Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma. Bugs: MESOS-3955 https://issues.apache.org/jira/browse/MESOS-3955 Repository: mesos Description --- Added helper function to get stateless resources. Diffs (updated) - include/mesos/resources.hpp 9c8bfb0e7e1e40ca99b4cc75079e5b950630243d include/mesos/v1/resources.hpp db87c992e2ec466cb1d4d17775bf6423a2fb15aa src/common/resources.cpp b9d31aef8babee212374e352c57fadbff02167f3 src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320 src/v1/resources.cpp 0c0eee6b3b7ae3254d7dc7b06187855c9b873764 Diff: https://reviews.apache.org/r/40529/diff/ Testing --- make make check Thanks, Guangya Liu
Re: Review Request 41772: Added helper function to flatten resources.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41772/ --- (Updated 一月 2, 2016, 1:16 a.m.) Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma. Summary (updated) - Added helper function to flatten resources. Repository: mesos Description --- Added two new helper functions to flatten resources. 1) Flatten reserved resources. 2) Flatten allocation slack revocable resources. Diffs - include/mesos/resources.hpp 9c8bfb0e7e1e40ca99b4cc75079e5b950630243d include/mesos/v1/resources.hpp db87c992e2ec466cb1d4d17775bf6423a2fb15aa src/common/resources.cpp b9d31aef8babee212374e352c57fadbff02167f3 src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320 src/v1/resources.cpp 0c0eee6b3b7ae3254d7dc7b06187855c9b873764 Diff: https://reviews.apache.org/r/41772/diff/ Testing --- make make check Thanks, Guangya Liu
Re: Review Request 41333: Added helper functions to filter usage slack resources.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41333/ --- (Updated 一月 2, 2016, 1:15 a.m.) Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma. Bugs: MESOS-4146 https://issues.apache.org/jira/browse/MESOS-4146 Repository: mesos Description (updated) --- Added helper functions to filter usage slack resources. This helper function will be used to validate if the task is using usage slack resource or not so as to make sure that one task or executor can only use same kind of resources. Diffs (updated) - include/mesos/resources.hpp 9c8bfb0e7e1e40ca99b4cc75079e5b950630243d include/mesos/v1/resources.hpp db87c992e2ec466cb1d4d17775bf6423a2fb15aa src/common/resources.cpp b9d31aef8babee212374e352c57fadbff02167f3 src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320 src/v1/resources.cpp 0c0eee6b3b7ae3254d7dc7b06187855c9b873764 Diff: https://reviews.apache.org/r/41333/diff/ Testing --- make make check Thanks, Guangya Liu
Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/ --- (Updated 一月 2, 2016, 1:17 a.m.) Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu. Bugs: MESOS-3887 https://issues.apache.org/jira/browse/MESOS-3887 Repository: mesos Description (updated) --- Added a flag to master to enable oversubscription for reservations. Diffs - include/mesos/master/allocator.hpp f7ada68d7111486d264284990996413bb3d6 src/master/allocator/mesos/allocator.hpp 50ef3b20f34bc6d87cbeccabcebec9a5031a6554 src/master/allocator/mesos/hierarchical.hpp 86ea5a402ed67f8f22f11d5730147cd907d66a08 src/master/allocator/mesos/hierarchical.cpp 7f900c4e024485704d79e57ae22407557598fe6c src/master/flags.hpp 9af6c68eef6bcf39d5776809fab6c66dc95da6b2 src/master/flags.cpp 800e54a302386f26f9b2f21edacad8840abbb42d src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 src/tests/allocator.hpp 9bdfaecf1a148f113ad52956b50ed7cabe0902ef src/tests/hierarchical_allocator_tests.cpp e044f832c2c16e53e663c6ced5452649bb0dcb59 src/tests/master_allocator_tests.cpp cba7c36471f93b678d94e1da0251a28a893696b1 src/tests/master_quota_tests.cpp 2f1bc3ae6a370e466f7cea9b597f51d7eccb1b33 src/tests/persistent_volume_endpoints_tests.cpp c0feedee393b8475fd27b0af9344d306a392893e src/tests/reservation_endpoints_tests.cpp b8edd6fafedd4c2221a8d19c1ebc71254071a8c7 src/tests/reservation_tests.cpp 69ddf906f2041bba84d7e1a20f90ee18817b4e64 src/tests/resource_offers_tests.cpp 0bad45dd1dabecc88fef1ab46e8ea26718070b33 src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8 Diff: https://reviews.apache.org/r/40339/diff/ Testing --- Ubuntu 14.04 make make check Thanks, Guangya Liu
Re: Review Request 40632: WIP: Enabled oversubscribed resources for reservations in allocator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/ --- (Updated 一月 2, 2016, 1:18 a.m.) Review request for mesos, Klaus Ma and Jian Qiu. Repository: mesos Description --- Enabled oversubscribed resources for reservations in allocator. Diffs (updated) - src/master/allocator/mesos/hierarchical.cpp 7f900c4e024485704d79e57ae22407557598fe6c Diff: https://reviews.apache.org/r/40632/diff/ Testing --- make make check Thanks, Guangya Liu
Re: Review Request 41829: WIP: Added test cases for allocator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41829/#review112422 --- Patch looks great! Reviews applied: [40375, 41334, 40529, 41772, 40339, 40632, 41791, 41829] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Dec. 31, 2015, 10:44 p.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41829/ > --- > > (Updated Dec. 31, 2015, 10:44 p.m.) > > > Review request for mesos and Klaus Ma. > > > Repository: mesos > > > Description > --- > > WIP: Added test cases for allocator. > > > Diffs > - > > src/tests/hierarchical_allocator_tests.cpp > e044f832c2c16e53e663c6ced5452649bb0dcb59 > > Diff: https://reviews.apache.org/r/41829/diff/ > > > Testing > --- > > make > make check > > > Thanks, > > Guangya Liu > >
Review Request 41843: Moved docker spec tests to a separate file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41843/ --- Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen. Repository: mesos Description --- Moved docker spec tests to a separate file. This is a part of a series patchs to clean up docker related code. Diffs - src/Makefile.am b58d6b560858d318058be766456dd5c5ef98c23e src/tests/containerizer/docker_spec_tests.cpp PRE-CREATION src/tests/containerizer/provisioner_docker_tests.cpp d51f342dabf386fb618ef72ce3e36a8bd8c82b5f Diff: https://reviews.apache.org/r/41843/diff/ Testing --- make check Thanks, Jie Yu
Review Request 41842: Small style fixes in docker tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41842/ --- Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen. Repository: mesos Description --- Small style fixes in docker tests. This is a part of a series patchs to clean up docker related code. Diffs - src/tests/containerizer/docker_tests.cpp 83eceacaddc38d0ccfc42e65e700a09406d8df36 Diff: https://reviews.apache.org/r/41842/diff/ Testing --- make check Thanks, Jie Yu
Re: Review Request 41839: Renamed FsLayers in docker v2 image manifest to FsLayer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41839/#review112415 --- Ship it! Ship It! - Gilbert Song On Jan. 1, 2016, 1:21 p.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41839/ > --- > > (Updated Jan. 1, 2016, 1:21 p.m.) > > > Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen. > > > Repository: mesos > > > Description > --- > > Renamed FsLayers in docker v2 image manifest to FsLayer. > > This is a part of a series patchs to clean up docker related code. > > > Diffs > - > > src/slave/containerizer/mesos/provisioner/docker/spec.cpp > 5bbd98cb1c5f3aefd9050859d066b43360e6eb75 > src/slave/containerizer/mesos/provisioner/docker/v2.proto > fdf159d003f8e5718de0f4d8bf9a2b1374cc11a2 > > Diff: https://reviews.apache.org/r/41839/diff/ > > > Testing > --- > > make check > > > Thanks, > > Jie Yu > >
Re: Review Request 41843: Moved docker spec tests to a separate file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41843/#review112428 --- Patch looks great! Reviews applied: [41839, 41840, 41841, 41842, 41843] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Jan. 1, 2016, 9:23 p.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41843/ > --- > > (Updated Jan. 1, 2016, 9:23 p.m.) > > > Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen. > > > Repository: mesos > > > Description > --- > > Moved docker spec tests to a separate file. > > This is a part of a series patchs to clean up docker related code. > > > Diffs > - > > src/Makefile.am b58d6b560858d318058be766456dd5c5ef98c23e > src/tests/containerizer/docker_spec_tests.cpp PRE-CREATION > src/tests/containerizer/provisioner_docker_tests.cpp > d51f342dabf386fb618ef72ce3e36a8bd8c82b5f > > Diff: https://reviews.apache.org/r/41843/diff/ > > > Testing > --- > > make check > > > Thanks, > > Jie Yu > >
