Review Request 72922: Re-added the obsolete `updateFramework` signature into libmesos-java.so.

2020-10-01 Thread Andrei Sekretenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72922/
---

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-10189
https://issues.apache.org/jira/browse/MESOS-10189


Repository: mesos


Description
---

This patch converts the implementation of the obsolete 2-parameter
`SchedulerDriver.updateFramework(frameworkInfo, suppressedRoles)`
from a wrapper around the new signature back into a JNI method
that 930c7e98d17e71192dae1d49b4b2217cc2dbd8b2 attempted to remove.

This is needed to keep compatibility between older versions of
`mesos.jar` and newer versions of `libmesos-java.so`.


Diffs
-

  src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 
4efde3083bb62253f3ad512b40a291fd7f7f7a78 
  src/java/src/org/apache/mesos/MesosSchedulerDriver.java 
4fdae338491709574775c52438e41d03b39917bd 


Diff: https://reviews.apache.org/r/72922/diff/1/


Testing
---

`make check`


Thanks,

Andrei Sekretenko

Re: Review Request 72922: Re-added the obsolete `updateFramework` signature into libmesos-java.so.

2020-10-01 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72922/#review221983
---



Bad patch!

Reviews applied: [72922]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:16.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh 2>&1 | 
tee build_72922"]

Error:
..
urceProviderTest_OperatorOperationsWithResourceProviderResources_v1_veS9qF/2GB-d4391ddc-fb38-4008-84fd-9b88de3bec09,test)]:2048;
 cpus(allocated: storage/default-role):2; mem(allocated: 
storage/default-role):1024; disk(allocated: storage/default-role):1024 (total: 
cpus:2; mem:1024; disk:1024; ports:[31000-32000]; disk(reservations: 
[(DYNAMIC,storage),(DYNAMIC,storage/default-role,test-principal)])[MOUNT(org.apache.mesos.csi.test.local,/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_veS9qF/2GB-d4391ddc-fb38-4008-84fd-9b88de3bec09,test)]:2048,
 offered or allocated: {}) on agent c99d5606-f994-4763-9b89-727b120219a3-S0 
from framework c99d5606-f994-4763-9b89-727b120219a3-
I1001 17:19:09.191968  4237 master.cpp:11878] Removing offer 
c99d5606-f994-4763-9b89-727b120219a3-O3
I1001 17:19:09.194526  4215 hierarchical.cpp:1725] Framework 
c99d5606-f994-4763-9b89-727b120219a3- filtered agent 
c99d5606-f994-4763-9b89-727b120219a3-S0 for 5secs
I1001 17:19:09.198184  4225 master.cpp:11743] Sending operation '' (uuid: 
168cf993-f4ab-4ebd-bfff-426277ff7973) to agent 
c99d5606-f994-4763-9b89-727b120219a3-S0 at slave(1248)@172.17.0.2:42997 
(efbfcd8a60cb)
I1001 17:19:09.199028  4218 slave.cpp:4576] Ignoring new checkpointed resources 
and operations identical to the current version
I1001 17:19:09.203171  4226 provider.cpp:498] Received APPLY_OPERATION event
I1001 17:19:09.203235  4226 provider.cpp:1352] Received CREATE operation '' 
(uuid: 168cf993-f4ab-4ebd-bfff-426277ff7973)
I1001 17:19:09.203455  4214 master.cpp:5622] Processing REVIVE call for 
framework c99d5606-f994-4763-9b89-727b120219a3- (default) at 
scheduler-5b2ec02f-494d-4385-9fa4-12aca29ce565@172.17.0.2:42997
I1001 17:19:09.204115  4214 hierarchical.cpp:1821] Unsuppressed offers and 
cleared filters for roles { storage/default-role } of framework 
c99d5606-f994-4763-9b89-727b120219a3-
I1001 17:19:09.206825  4214 hierarchical.cpp:1953] Performed allocation for 1 
agents in 2.365724ms
I1001 17:19:09.207392  4214 hierarchical.cpp:1953] Performed allocation for 1 
agents in 220667ns
I1001 17:19:09.207789  4237 master.cpp:9579] Sending offers [ 
c99d5606-f994-4763-9b89-727b120219a3-O4 ] to framework 
c99d5606-f994-4763-9b89-727b120219a3- (default) at 
scheduler-5b2ec02f-494d-4385-9fa4-12aca29ce565@172.17.0.2:42997
I1001 17:19:09.208570  4222 sched.cpp:937] Scheduler::resourceOffers took 
90272ns
I1001 17:19:09.218515  4229 http.cpp:1436] HTTP POST for 
/slave(1248)/api/v1/resource_provider from 172.17.0.2:45986
I1001 17:19:09.220041  4235 slave.cpp:8733] Handling resource provider message 
'UPDATE_OPERATION_STATUS: (uuid: 4c05a3f5-3afd-4e98-b8c9-e16897f9d2ca) for 
framework  (latest state: OPERATION_FINISHED, status update state: 
OPERATION_FINISHED)'
I1001 17:19:09.220289  4235 slave.cpp:9186] Updating the state of operation 
with no ID (uuid: 4c05a3f5-3afd-4e98-b8c9-e16897f9d2ca) for an operation API 
call (latest state: OPERATION_FINISHED, status update state: OPERATION_FINISHED)
I1001 17:19:09.220348  4235 slave.cpp:8940] Forwarding status update of 
operation with no ID (operation_uuid: 4c05a3f5-3afd-4e98-b8c9-e16897f9d2ca) for 
an operator API call
I1001 17:19:09.220696  4223 master.cpp:11395] Updating the state of operation 
'' (uuid: 4c05a3f5-3afd-4e98-b8c9-e16897f9d2ca) for an operator API call 
(latest state: OPERATION_PENDING, status update state: OPERATION_FINISHED)
I1001 17:19:09.221287  4233 slave.cpp:4576] Ignoring new checkpointed resources 
and operations identical to the current version
I1001 17:19:09.324309  4222 status_update_manager_process.hpp:152] Received 
operation status update OPERATION_FINISHED (Status UUID: 
ed599d37-596e-4f97-b17a-08b72c985140) for operation UUID 
168cf993-f4ab-4ebd-bfff-426277ff7973 on agent 
c99d5606-f994-4763-9b89-727b120219a3-S0
I1001 17:19:09.324409  4222 status_update_manager_process.hpp:414] Creating 
operation status update stream 168cf993-f4ab-4ebd-bfff-426277ff7973 
checkpoint=true
I1001 17:19:09.324478  4226 provider.cpp:498] Received 
ACKNOWLEDGE_OPERATION_STATUS event
I1001 17:19:09.324823  4222 status_update_manager_process.hpp:929] 
Checkpointing UPDATE for operation status update OPERATION_FINISHED (Status 
UUID: ed599d37-596e-4f97-b17a-08b72c985140) for operation UUID 
168cf993-f4ab-4ebd-bfff-426277ff7973 on agent 
c99d5606-f994-4763-9b89-727b120219a3-S0

Re: Review Request 72922: Re-added the obsolete `updateFramework` signature into libmesos-java.so.

2020-10-01 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72922/#review221984
---


Fix it, then Ship it!





src/java/src/org/apache/mesos/MesosSchedulerDriver.java
Line 411 (original), 411-414 (patched)


Use javadoc style here?

Also, can we put a @deprecated attribute?



src/java/src/org/apache/mesos/MesosSchedulerDriver.java
Lines 416-418 (patched)


Use javadoc style here? maybe make this clear that it's a note for us and 
not the user looking at the interface?


- Benjamin Mahler


On Oct. 1, 2020, 2:01 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72922/
> ---
> 
> (Updated Oct. 1, 2020, 2:01 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-10189
> https://issues.apache.org/jira/browse/MESOS-10189
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch converts the implementation of the obsolete 2-parameter
> `SchedulerDriver.updateFramework(frameworkInfo, suppressedRoles)`
> from a wrapper around the new signature back into a JNI method
> that 930c7e98d17e71192dae1d49b4b2217cc2dbd8b2 attempted to remove.
> 
> This is needed to keep compatibility between older versions of
> `mesos.jar` and newer versions of `libmesos-java.so`.
> 
> 
> Diffs
> -
> 
>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 
> 4efde3083bb62253f3ad512b40a291fd7f7f7a78 
>   src/java/src/org/apache/mesos/MesosSchedulerDriver.java 
> 4fdae338491709574775c52438e41d03b39917bd 
> 
> 
> Diff: https://reviews.apache.org/r/72922/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>