Re: Review Request 37315: Added basic authentication documentation

[Tim Anderegg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37315/
---

(Updated Aug. 11, 2015, 10:10 p.m.)


Review request for mesos.


Changes
---

Fixed various issues that Vinod raised


Bugs: MESOS-1838
https://issues.apache.org/jira/browse/MESOS-1838


Repository: mesos


Description
---

Added basic authentication documentation


Diffs (updated)
-

  docs/authentication.md PRE-CREATION 

Diff: https://reviews.apache.org/r/37315/diff/


Testing
---

Ran git hook to validate formatting.


Thanks,

Tim Anderegg

Re: Review Request 37315: Added basic authentication documentation

[Tim Anderegg]

 On Aug. 10, 2015, 9:33 p.m., Vinod Kone wrote:
  Thanks for doing this. Looking pretty good, just some minor comments.
 
 Tim Anderegg wrote:
 Thanks for taking the time to review, Vinod.  I'll make those changes 
 tomorrow.

OK, submitted a revision.  I'm not sure why the Mesos bot build failed, it 
seems one file was left behind during the make process, but it was not a file 
that was touched by this commit.  If somehow I mucked things up, I'll try and 
fix it.


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37315/#review94799
---


On Aug. 11, 2015, 10:10 p.m., Tim Anderegg wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37315/
 ---
 
 (Updated Aug. 11, 2015, 10:10 p.m.)
 
 
 Review request for mesos.
 
 
 Bugs: MESOS-1838
 https://issues.apache.org/jira/browse/MESOS-1838
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Added basic authentication documentation
 
 
 Diffs
 -
 
   docs/authentication.md PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/37315/diff/
 
 
 Testing
 ---
 
 Ran git hook to validate formatting.
 
 
 Thanks,
 
 Tim Anderegg
 

Re: Review Request 37315: Added basic authentication documentation

[Tim Anderegg]

 On Aug. 11, 2015, 10:19 p.m., Vinod Kone wrote:
  Thank you. 
  
  Ignore the bot failure. It's not related to your patch.

Cool, I thought as much, thanks again for the feedback.


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37315/#review95018
---


On Aug. 11, 2015, 10:10 p.m., Tim Anderegg wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37315/
 ---
 
 (Updated Aug. 11, 2015, 10:10 p.m.)
 
 
 Review request for mesos.
 
 
 Bugs: MESOS-1838
 https://issues.apache.org/jira/browse/MESOS-1838
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Added basic authentication documentation
 
 
 Diffs
 -
 
   docs/authentication.md PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/37315/diff/
 
 
 Testing
 ---
 
 Ran git hook to validate formatting.
 
 
 Thanks,
 
 Tim Anderegg
 

Review Request 37315: Added basic authentication documentation

[Tim Anderegg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37315/
---

Review request for mesos.


Bugs: MESOS-1838
https://issues.apache.org/jira/browse/MESOS-1838


Repository: mesos


Description
---

Added basic authentication documentation


Diffs
-

  docs/authentication.md PRE-CREATION 

Diff: https://reviews.apache.org/r/37315/diff/


Testing
---

Ran git hook to validate formatting.


Thanks,

Tim Anderegg

Re: Review Request 37315: Added basic authentication documentation

[Tim Anderegg]

 On Aug. 10, 2015, 9:33 p.m., Vinod Kone wrote:
  Thanks for doing this. Looking pretty good, just some minor comments.

Thanks for taking the time to review, Vinod.  I'll make those changes tomorrow.


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37315/#review94799
---


On Aug. 10, 2015, 9 p.m., Tim Anderegg wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37315/
 ---
 
 (Updated Aug. 10, 2015, 9 p.m.)
 
 
 Review request for mesos.
 
 
 Bugs: MESOS-1838
 https://issues.apache.org/jira/browse/MESOS-1838
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Added basic authentication documentation
 
 
 Diffs
 -
 
   docs/authentication.md PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/37315/diff/
 
 
 Testing
 ---
 
 Ran git hook to validate formatting.
 
 
 Thanks,
 
 Tim Anderegg
 

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

[Tim Anderegg]

> On April 4, 2016, 6:13 p.m., Gilbert Song wrote:
> > src/cli/execute.cpp, line 287
> > 
> >
> > This is incorrect. We handle this merging operation in runtime isolator.

I was testing out a similar implementation of this feature on my own machine, 
but using AppC instead of Docker.  Since AppC has no runtime isolator in Mesos 
(yet), I think it would make sense to support merging the arguments within 
mesos-execute to enable easy testing of container images that have no runtime 
isolator, no?  Would the Docker runtime isolator properly handle the arguments 
if they came pre-merged?


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/#review126880
---


On April 3, 2016, 1:42 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1/
> ---
> 
> (Updated April 3, 2016, 1:42 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, haosdent huang, 
> and Jie Yu.
> 
> 
> Bugs: MESOS-4882
> https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 
> 
> Diff: https://reviews.apache.org/r/1/diff/
> 
> 
> Testing
> ---
> 
> 1) with docker entry point
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell
> I0403 21:35:42.949331 12369 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> 
> 2) With command 1
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd"
> I0403 21:36:55.703246 12483 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0001
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 3) With command 2
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd,/etc/passwd"
> I0403 21:37:22.901828 12548 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0002
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 4) With command 3
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="cat,/etc/passwd,/etc/passwd"
> I0403 21:39:35.986281 12651 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0003
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 46469: Added support for credentials to mesos-execute.

[Tim Anderegg]

> On April 22, 2016, 1:19 a.m., Vinod Kone wrote:
> > src/cli/execute.cpp, line 754
> > <https://reviews.apache.org/r/46469/diff/1/?file=1354332#file1354332line754>
> >
> > I think it is ok to set principal and not secret. We should just set 
> > the framework info principal in that case.
> > 
> > also, s/cred/credential_/

Thanks for reviewing Vinod!  I'll make the change shortly.  I think 
authentication requires both, but I agree there may be some cases where folks 
would want to set the principal even when not using authentication.


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46469/#review130012
-------


On April 22, 2016, 1:20 a.m., Tim Anderegg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46469/
> ---
> 
> (Updated April 22, 2016, 1:20 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3402
> https://issues.apache.org/jira/browse/MESOS-3402
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added support for credentials to mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp 087a73143d739f41638b8335c7e24dfcd14bc7fb 
> 
> Diff: https://reviews.apache.org/r/46469/diff/
> 
> 
> Testing
> ---
> 
> $ ./mesos-execute --master=127.0.0.1:5050 --name=auth_test --command="while 
> true; do echo 'Hello'; sleep 2; done"
> I0420 21:55:11.347501  2751 scheduler.cpp:177] Version: 0.29.0
> Received an ERROR event: Received unexpected '401 Unauthorized' () for 
> SUBSCRIBE
> 
> $ ./mesos-execute --master=127.0.0.1:5050 --name=auth_test --command="while 
> true; do echo 'Hello'; sleep 2; done" --principal=principal --secret=secret
> I0420 21:54:02.924027  2587 scheduler.cpp:177] Version: 0.29.0
> Subscribed with ID '81fe5703-ccae-4c6e-8e39-a246109d812e-0001'
> Submitted task 'auth_test' to agent '9edb64fe-5b97-43d3-81fe-81f0cdcea0b4-S0'
> Received status update TASK_RUNNING for task 'auth_test'
>   source: SOURCE_EXECUTOR
> 
> 
> Thanks,
> 
> Tim Anderegg
> 
>

Re: Review Request 46469: Added support for credentials to mesos-execute.

[Tim Anderegg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46469/
---

(Updated April 22, 2016, 3:15 p.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-3402
https://issues.apache.org/jira/browse/MESOS-3402


Repository: mesos


Description
---

Added support for credentials to mesos-execute.


Diffs (updated)
-

  src/cli/execute.cpp 087a73143d739f41638b8335c7e24dfcd14bc7fb 

Diff: https://reviews.apache.org/r/46469/diff/


Testing
---

$ ./mesos-execute --master=127.0.0.1:5050 --name=auth_test --command="while 
true; do echo 'Hello'; sleep 2; done"
I0420 21:55:11.347501  2751 scheduler.cpp:177] Version: 0.29.0
Received an ERROR event: Received unexpected '401 Unauthorized' () for SUBSCRIBE

$ ./mesos-execute --master=127.0.0.1:5050 --name=auth_test --command="while 
true; do echo 'Hello'; sleep 2; done" --principal=principal --secret=secret
I0420 21:54:02.924027  2587 scheduler.cpp:177] Version: 0.29.0
Subscribed with ID '81fe5703-ccae-4c6e-8e39-a246109d812e-0001'
Submitted task 'auth_test' to agent '9edb64fe-5b97-43d3-81fe-81f0cdcea0b4-S0'
Received status update TASK_RUNNING for task 'auth_test'
  source: SOURCE_EXECUTOR


Thanks,

Tim Anderegg

Re: Review Request 47499: Make Mesos site responsive.

[Tim Anderegg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47499/#review133678
---



LGTM. We might want to consider causing the menu to split into 2 columns on 
mobile devices to maximize vertical space, but that's probably a separate 
commit.

- Tim Anderegg


On May 18, 2016, 12:24 a.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47499/
> ---
> 
> (Updated May 18, 2016, 12:24 a.m.)
> 
> 
> Review request for mesos, Tim Anderegg and Vinod Kone.
> 
> 
> Bugs: MESOS-5402
> https://issues.apache.org/jira/browse/MESOS-5402
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch wrap lines on small screens,
> so the page is more friendly to view on
> mobile.
> 
> 
> Diffs
> -
> 
>   site/source/assets/css/main.css 73ca8946091a638a359b1d769961879a283fa099 
>   site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 
> 
> Diff: https://reviews.apache.org/r/47499/diff/
> 
> 
> Testing
> ---
> 
> Manually checked some random pages in different sizes.
> 
> * PC
> ![PC](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/pT87vto4CHMMaG2/old_pc.png)
> ![PC](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/idXPLIM8t0LxRWA/new_pc.png)
> * iPad
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/Wt3g8bknstahXSC/old_iPad_landscape.png)
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/TBTjlj1xT3YFrOf/new_iPad_landscape.png)
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/sMct2b54lfCzrAu/old_iPad.png)
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/qp2hj1UCNOfGLIX/new_iPad.png)
> * iPhone
> ![iPhone](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/mCTMOx8FLFxANeo/old_iPhone.png)
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/5hlKDsOKqdJaztw/new_iPhone.png)
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 47510: Adjusted style to make website mobile friendly.

[Tim Anderegg]

> On May 18, 2016, 6:05 p.m., Vinod Kone wrote:
> > site/source/layouts/layout.erb, lines 66-83
> > <https://reviews.apache.org/r/47510/diff/1/?file=1386346#file1386346line66>
> >
> > what does this do?
> > 
> > also, can you attach before and after screen shots?

@vinodkone That section collapes the menu for mobile devices, which addresses 
the comment I left on the other patch.  Without it, the menu takes up a good 
portion of the screen until the user scrolls down, with this the menu is hidden 
unless the user hits the new menu button.  The new menu button is only 
displayed on mobile.


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47510/#review133774
---


On May 18, 2016, 6:04 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47510/
> ---
> 
> (Updated May 18, 2016, 6:04 p.m.)
> 
> 
> Review request for mesos, Freddy Ayuso-Henson, Tomasz Janiszewski, Tim 
> Anderegg, and Vinod Kone.
> 
> 
> Bugs: MESOS-3690
> https://issues.apache.org/jira/browse/MESOS-3690
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adjusted style to make website mobile friendly.
> 
> 
> Diffs
> -
> 
>   site/source/assets/css/main.css 73ca8946091a638a359b1d769961879a283fa099 
>   site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 
>   site/source/layouts/layout.erb 2bf6967faad45644647b732be0fa3c410b9951c5 
> 
> Diff: https://reviews.apache.org/r/47510/diff/
> 
> 
> Testing
> ---
> 
> # Note
> @vinodkone, this should credited to @fayusohenson and @janisz when submit.
> I pick the necessary changes for mobile friendly from 
> https://github.com/apache/mesos/pull/75 .
> 
> And record some simple videos under mobile, tablet and pc to show this patch.
> 
> ![home_mobile.gif](https://issues.apache.org/jira/secure/attachment/12804724/home_mobile.gif)
> ![home_tablet.gif](https://issues.apache.org/jira/secure/attachment/12804726/home_tablet.gif)
> ![home_pc.gif](https://issues.apache.org/jira/secure/attachment/12804725/home_pc.gif)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Review Request 46469: Added support for credentials to mesos-execute.

[Tim Anderegg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46469/
---

Review request for mesos.


Bugs: MESOS-3402
https://issues.apache.org/jira/browse/MESOS-3402


Repository: mesos


Description
---

Added support for credentials to mesos-execute.


Diffs
-

  src/cli/execute.cpp 087a73143d739f41638b8335c7e24dfcd14bc7fb 

Diff: https://reviews.apache.org/r/46469/diff/


Testing
---

$ ./mesos-execute --master=127.0.0.1:5050 --name=auth_test --command="while 
true; do echo 'Hello'; sleep 2; done"
I0420 21:55:11.347501  2751 scheduler.cpp:177] Version: 0.29.0
Received an ERROR event: Received unexpected '401 Unauthorized' () for SUBSCRIBE

$ ./mesos-execute --master=127.0.0.1:5050 --name=auth_test --command="while 
true; do echo 'Hello'; sleep 2; done" --principal=principal --secret=secret
I0420 21:54:02.924027  2587 scheduler.cpp:177] Version: 0.29.0
Subscribed with ID '81fe5703-ccae-4c6e-8e39-a246109d812e-0001'
Submitted task 'auth_test' to agent '9edb64fe-5b97-43d3-81fe-81f0cdcea0b4-S0'
Received status update TASK_RUNNING for task 'auth_test'
  source: SOURCE_EXECUTOR


Thanks,

Tim Anderegg

Review Request 52064: Support for multiple versions of docs.

[Tim Anderegg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-3011
https://issues.apache.org/jira/browse/MESOS-3011


Repository: mesos


Description
---

Support for multiple versions of docs.


Diffs
-

  site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
  site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
  site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b 
  site/build.sh 11f15e15621c4d3db1472e88911787b9b3100f97 
  site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 
  site/data/releases.yml 1e9bb8555d266658baaf37c4b608eebeb0d14da8 
  site/source/assets/js/versions.js PRE-CREATION 
  site/source/layouts/basic.erb 7464e40b619e883daad93c72c3fbdbfbdda8f152 
  site/source/layouts/documentation.erb 
a91f916a5fb7348b2702c272e7a2059bdf628c66 
  site/source/layouts/gettingstarted.erb PRE-CREATION 

Diff: https://reviews.apache.org/r/52064/diff/


Testing
---

Testing was done manually to verify that the documentation was built for each 
version of Mesos that is supported (some older versions do not have compatible 
documentation).


Thanks,

Tim Anderegg

Re: Review Request 52064: Support for multiple versions of docs.

[Tim Anderegg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/
---

(Updated Sept. 19, 2016, 8:43 p.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-3011
https://issues.apache.org/jira/browse/MESOS-3011


Repository: mesos


Description (updated)
---

Support for multiple versions of docs.  The approach I took was to use the 
"git" ruby library to iterate over each tagged version of Mesos, and generate 
the documentation.  This uses the "releases.yml" file to determine which 
versions should build documentation.  The same is done for images, since they 
may change between versions.  A select box was added to the website's 
breadcrumbs bar that allows the user to easily switch between documentation 
versions.  If a page is reached that doesn't exist in an older version of the 
documentation, the user is notified and redirect to the main page for that 
version.


Diffs
-

  site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
  site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
  site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b 
  site/build.sh 11f15e15621c4d3db1472e88911787b9b3100f97 
  site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 
  site/data/releases.yml 1e9bb8555d266658baaf37c4b608eebeb0d14da8 
  site/source/assets/js/versions.js PRE-CREATION 
  site/source/layouts/basic.erb 7464e40b619e883daad93c72c3fbdbfbdda8f152 
  site/source/layouts/documentation.erb 
a91f916a5fb7348b2702c272e7a2059bdf628c66 
  site/source/layouts/gettingstarted.erb PRE-CREATION 

Diff: https://reviews.apache.org/r/52064/diff/


Testing
---

Testing was done manually to verify that the documentation was built for each 
version of Mesos that is supported (some older versions do not have compatible 
documentation).


Thanks,

Tim Anderegg

Re: Review Request 52064: Support for multiple versions of docs.

[Tim Anderegg]

> On Sept. 28, 2016, 3:20 a.m., haosdent huang wrote:
> > Get this error during build.
> > 
> > ```
> > git  version   2>&1:sh: git: command not found
> > /mesos/site/Rakefile:4:in `'
> > (See full trace by running task with --trace)
> > rake aborted!
> > git  version   2>&1:sh: git: command not found
> > /mesos/site/Rakefile:4:in `'
> > (See full trace by running task with --trace)
> > ```
> 
> haosdent huang wrote:
> Need to update the Dockerfile to fix this problem.
> 
> ```
> diff --git a/site/Dockerfile b/site/Dockerfile
> index 8ba0be0..835e7df 100644
> --- a/site/Dockerfile
> +++ b/site/Dockerfile
> @@ -3,7 +3,7 @@ MAINTAINER "d...@mesos.apache.org"
> 
>  LABEL Description="This image is used for generating Mesos web site from 
> local sources and serving it on port 4567 (livereload on port 35729)."
> 
> -RUN yum install -y gcc-c++ make ruby ruby-devel rake doxygen 
> java-1.7.0-openjdk-devel
> +RUN yum install -y gcc-c++ git make ruby ruby-devel rake doxygen 
> java-1.7.0-openjdk-devel
>  RUN gem install bundler
> 
>  ENV LANG en_US.UTF-8
> ```

Good catch, I didn't use Docker for building so I already had git installed, 
will fix.


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/#review150673
---


On Sept. 19, 2016, 8:43 p.m., Tim Anderegg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52064/
> ---
> 
> (Updated Sept. 19, 2016, 8:43 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3011
> https://issues.apache.org/jira/browse/MESOS-3011
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support for multiple versions of docs.  The approach I took was to use the 
> "git" ruby library to iterate over each tagged version of Mesos, and generate 
> the documentation.  This uses the "releases.yml" file to determine which 
> versions should build documentation.  The same is done for images, since they 
> may change between versions.  A select box was added to the website's 
> breadcrumbs bar that allows the user to easily switch between documentation 
> versions.  If a page is reached that doesn't exist in an older version of the 
> documentation, the user is notified and redirect to the main page for that 
> version.
> 
> 
> Diffs
> -
> 
>   site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
>   site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
>   site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b 
>   site/build.sh 11f15e15621c4d3db1472e88911787b9b3100f97 
>   site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 
>   site/data/releases.yml 1e9bb8555d266658baaf37c4b608eebeb0d14da8 
>   site/source/assets/js/versions.js PRE-CREATION 
>   site/source/layouts/basic.erb 7464e40b619e883daad93c72c3fbdbfbdda8f152 
>   site/source/layouts/documentation.erb 
> a91f916a5fb7348b2702c272e7a2059bdf628c66 
>   site/source/layouts/gettingstarted.erb PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52064/diff/
> 
> 
> Testing
> ---
> 
> Testing was done manually to verify that the documentation was built for each 
> version of Mesos that is supported (some older versions do not have 
> compatible documentation).
> 
> 
> Thanks,
> 
> Tim Anderegg
> 
>

Re: Review Request 52064: Support for multiple versions of docs.

[Tim Anderegg]

> On Sept. 28, 2016, 3:55 a.m., haosdent huang wrote:
> > site/Rakefile, lines 67-71
> > <https://reviews.apache.org/r/52064/diff/1/?file=1503005#file1503005line67>
> >
> > How about we only continue when tags in `["0.26.0", "0.26.."]`?

This list of versions that don't have documentation in their repos shouldn't 
ever change.  If we filtered affirmatively by the versions that do have 
documentation, it would have to be updated each time a new version is added.  
So the current approach here seems easier to maintain, but I'm certainly open 
to suggestion!


> On Sept. 28, 2016, 3:55 a.m., haosdent huang wrote:
> > site/build.sh, line 24
> > <https://reviews.apache.org/r/52064/diff/1/?file=1503006#file1503006line24>
> >
> > I think we no need to change this file, right?

Not sure why this is showing up in the diff, will attempt to remove it.


> On Sept. 28, 2016, 3:55 a.m., haosdent huang wrote:
> > site/source/layouts/basic.erb, line 79
> > <https://reviews.apache.org/r/52064/diff/1/?file=1503010#file1503010line79>
> >
> > We need to make sure the style of verson selection here to match the 
> > breadcrumb above.
> > 
> > ```
> > 
> > 
> > ```
> > 
> > Another options are
> > 
> > * we put it in the left panel. Like what tensorflow document do. 
> > https://www.tensorflow.org/versions/r0.10/get_started/index.html
> > * we list all available version in a separate page. Like what spark 
> > document do. http://spark.apache.org/documentation.html

I originally had the version in the left panel, but it seemed a bit awkwardly 
placed there, and it seemed to me putting it in the breadcrumbs was more 
natural (in Tensorflow's it makes sense, as the left panel is a navigation 
menu).  I think it's best to have the version dropdown accessible on each page 
rather than a separate page, as that is more convenient for users.  I'll try 
cleaning up the style to match and we can see how that looks.


> On Sept. 28, 2016, 3:55 a.m., haosdent huang wrote:
> > site/source/layouts/documentation.erb, lines 15-19
> > <https://reviews.apache.org/r/52064/diff/1/?file=1503011#file1503011line15>
> >
> > Any reason that we add a back button instead of using the back button 
> > of browser?

This was because I often ran into the case that, when switching doc versions, I 
hit the browser's back button which returned me to the last version I was on 
instead of the new version.  The "back" link is there to quickly return to the 
main documentation page for whatever version the user is currently viewing, and 
to discourage the use of the browser back button in this case.  I could update 
the text to "Return to Documentation Home" or something along those lines, or I 
could just remove it as this is probably an edge case anyways.


- Tim


-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/#review150674
---


On Sept. 19, 2016, 8:43 p.m., Tim Anderegg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52064/
> ---
> 
> (Updated Sept. 19, 2016, 8:43 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3011
> https://issues.apache.org/jira/browse/MESOS-3011
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support for multiple versions of docs.  The approach I took was to use the 
> "git" ruby library to iterate over each tagged version of Mesos, and generate 
> the documentation.  This uses the "releases.yml" file to determine which 
> versions should build documentation.  The same is done for images, since they 
> may change between versions.  A select box was added to the website's 
> breadcrumbs bar that allows the user to easily switch between documentation 
> versions.  If a page is reached that doesn't exist in an older version of the 
> documentation, the user is notified and redirect to the main page for that 
> version.
> 
> 
> Diffs
> -
> 
>   site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
>   site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
>   site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b 
>   site/build.sh 11f15e15621c4d3db1472e88911787b9b3100f97 
>   site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 
>   site/data/releases.yml 1e9bb8555d266658baaf37c4b608ee

Re: Review Request 52064: Support for multiple versions of docs.

[Tim Anderegg]

> On Sept. 28, 2016, 3:55 a.m., haosdent huang wrote:
> > site/source/layouts/basic.erb, line 79
> > <https://reviews.apache.org/r/52064/diff/1/?file=1503010#file1503010line79>
> >
> > We need to make sure the style of verson selection here to match the 
> > breadcrumb above.
> > 
> > ```
> > 
> > 
> > ```
> > 
> > Another options are
> > 
> > * we put it in the left panel. Like what tensorflow document do. 
> > https://www.tensorflow.org/versions/r0.10/get_started/index.html
> > * we list all available version in a separate page. Like what spark 
> > document do. http://spark.apache.org/documentation.html
> 
> Tim Anderegg wrote:
> I originally had the version in the left panel, but it seemed a bit 
> awkwardly placed there, and it seemed to me putting it in the breadcrumbs was 
> more natural (in Tensorflow's it makes sense, as the left panel is a 
> navigation menu).  I think it's best to have the version dropdown accessible 
> on each page rather than a separate page, as that is more convenient for 
> users.  I'll try cleaning up the style to match and we can see how that looks.

I updated the style here to match the navigration pane better, I think this is 
the best approach but let me know what you think.


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/#review150674
---


On Dec. 12, 2016, 10:03 p.m., Tim Anderegg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52064/
> ---
> 
> (Updated Dec. 12, 2016, 10:03 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Bugs: MESOS-3011
> https://issues.apache.org/jira/browse/MESOS-3011
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support for multiple versions of docs.
> 
> 
> Diffs
> -
> 
>   site/Dockerfile 8ba0be0c28e924f7a2b89e6e5a3237deb3751a41 
>   site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
>   site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
>   site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b 
>   site/build.sh 11f15e15621c4d3db1472e88911787b9b3100f97 
>   site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 
>   site/data/releases.yml 755300aa83a1017362129bad256381d10c815609 
>   site/source/assets/css/main.css 83596ddbd833e36b60bdbbd487ebd464b3874119 
>   site/source/assets/js/versions.js PRE-CREATION 
>   site/source/layouts/basic.erb 7464e40b619e883daad93c72c3fbdbfbdda8f152 
>   site/source/layouts/documentation.erb 
> a91f916a5fb7348b2702c272e7a2059bdf628c66 
>   site/source/layouts/gettingstarted.erb PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52064/diff/
> 
> 
> Testing
> ---
> 
> Testing was done manually to verify that the documentation was built for each 
> version of Mesos that is supported (some older versions do not have 
> compatible documentation).
> 
> 
> Thanks,
> 
> Tim Anderegg
> 
>

Re: Review Request 52064: Support for multiple versions of docs.

[Tim Anderegg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/
---

(Updated Dec. 12, 2016, 10:03 p.m.)


Review request for mesos, haosdent huang and Vinod Kone.


Changes
---

Addressed issues raised below, sorry about the delay on resolving them!  Life 
has been getting in the way recently :)


Bugs: MESOS-3011
https://issues.apache.org/jira/browse/MESOS-3011


Repository: mesos


Description (updated)
---

Support for multiple versions of docs.


Diffs (updated)
-

  site/Dockerfile 8ba0be0c28e924f7a2b89e6e5a3237deb3751a41 
  site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
  site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
  site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b 
  site/build.sh 11f15e15621c4d3db1472e88911787b9b3100f97 
  site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 
  site/data/releases.yml 755300aa83a1017362129bad256381d10c815609 
  site/source/assets/css/main.css 83596ddbd833e36b60bdbbd487ebd464b3874119 
  site/source/assets/js/versions.js PRE-CREATION 
  site/source/layouts/basic.erb 7464e40b619e883daad93c72c3fbdbfbdda8f152 
  site/source/layouts/documentation.erb 
a91f916a5fb7348b2702c272e7a2059bdf628c66 
  site/source/layouts/gettingstarted.erb PRE-CREATION 

Diff: https://reviews.apache.org/r/52064/diff/


Testing
---

Testing was done manually to verify that the documentation was built for each 
version of Mesos that is supported (some older versions do not have compatible 
documentation).


Thanks,

Tim Anderegg

Re: Review Request 52064: Support for multiple versions of docs.

[Tim Anderegg]

> On May 9, 2017, 4:30 p.m., haosdent huang wrote:
> > Hi, @tim Thanks a lot for your update. I am still reading you patch and 
> > have not finished. Could return my comments if it works at my side. Thanks 
> > a lot for your contributions.

Thanks @haosdent, please let me know if you have any questions or need 
clarification on anything!


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/#review174335
---


On May 5, 2017, 9:23 p.m., Tim Anderegg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52064/
> ---
> 
> (Updated May 5, 2017, 9:23 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Bugs: MESOS-3011
> https://issues.apache.org/jira/browse/MESOS-3011
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support for multiple versions of docs.
> 
> 
> Diffs
> -
> 
>   site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
>   site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
>   site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b 
>   site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 
>   site/data/releases.yml 8bdc3ff11a821f5e1be04ac871c05b16403a82ac 
>   site/source/assets/js/versions.js PRE-CREATION 
>   site/source/layouts/basic.erb 3bf1f55d7d8feafd3caaa7902755404f7e45bae6 
> 
> 
> Diff: https://reviews.apache.org/r/52064/diff/5/
> 
> 
> Testing
> ---
> 
> Testing was done manually to verify that the documentation was built for each 
> version of Mesos that is supported (some older versions do not have 
> compatible documentation).
> 
> 
> Thanks,
> 
> Tim Anderegg
> 
>

Re: Review Request 52064: Support for multiple versions of docs.

[Tim Anderegg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/
---

(Updated May 5, 2017, 9:16 p.m.)


Review request for mesos, haosdent huang and Vinod Kone.


Changes
---

OK, I believe I have addressed all issues here, I also simplified the code a 
bit to use releases.yml as the source of versions to generate docs for, rather 
than the git tags themselves, and made the "docs:" key optional in that file.  
It only needs to be present if the given version should not have documentation 
generated for it, in which case it is set as "docs: false".  This also removes 
the need for the version check within the Rakefile itself.  Please let me know 
if any additional changes are needed.


Bugs: MESOS-3011
https://issues.apache.org/jira/browse/MESOS-3011


Repository: mesos


Description
---

Support for multiple versions of docs.


Diffs (updated)
-

  site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
  site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
  site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b 
  site/build.sh 11f15e15621c4d3db1472e88911787b9b3100f97 
  site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 
  site/data/releases.yml 8bdc3ff11a821f5e1be04ac871c05b16403a82ac 
  site/source/assets/js/versions.js PRE-CREATION 
  site/source/layouts/basic.erb 3bf1f55d7d8feafd3caaa7902755404f7e45bae6 
  site/source/layouts/documentation.erb 
a91f916a5fb7348b2702c272e7a2059bdf628c66 


Diff: https://reviews.apache.org/r/52064/diff/3/

Changes: https://reviews.apache.org/r/52064/diff/2-3/


Testing
---

Testing was done manually to verify that the documentation was built for each 
version of Mesos that is supported (some older versions do not have compatible 
documentation).


Thanks,

Tim Anderegg

Re: Review Request 52064: Support for multiple versions of docs.

[Tim Anderegg]

> On Dec. 23, 2016, 5:38 p.m., haosdent huang wrote:
> > site/Rakefile
> > Lines 122 (patched)
> > <https://reviews.apache.org/r/52064/diff/2/?file=1582226#file1582226line154>
> >
> > Replace all `\/latest\/` looks a bit dangerous. Do you have an example 
> > for this?
> 
> Tim Anderegg wrote:
> I ran the code across the documentation from a number of versions, and 
> determined that the only place the \/latest\/ string occurred was in URL's 
> that should be replaced, e.g. here: 
> https://raw.githubusercontent.com/apache/mesos/0.22.1/docs/home.md

Well, you were right :)  There were a few edge cases where this was too gready, 
so I updated the regex to be more restrictive.


> On Dec. 23, 2016, 5:38 p.m., haosdent huang wrote:
> > site/data/releases.yml
> > Lines 108 (patched)
> > <https://reviews.apache.org/r/52064/diff/2/?file=1582229#file1582229line108>
> >
> > I think we only need to keep the version `>=0.26.0`. This reduce the 
> > website generation time as well.
> 
> Tim Anderegg wrote:
> I'm happy to remove the older versions if desired.

I went with >=0.22.1, since that is the oldest tag on the apache/mesos github 
repo.  If we should just go with 0.26.0, I can do that instead.


> On Dec. 23, 2016, 5:38 p.m., haosdent huang wrote:
> > site/source/assets/css/main.css
> > Lines 39-41 (patched)
> > <https://reviews.apache.org/r/52064/diff/2/?file=1582230#file1582230line39>
> >
> > Could not find the differece for this css change. Is it necessary?
> 
> Tim Anderegg wrote:
> This was to better space the  tag used to select the proper 
> version that is part of the breadcrumb.  Without it, the alignement is off.

Actually, you were right this was not needed, sorry!


> On Dec. 23, 2016, 5:38 p.m., haosdent huang wrote:
> > site/source/layouts/gettingstarted.erb
> > Lines 1 (patched)
> > <https://reviews.apache.org/r/52064/diff/2/?file=1582234#file1582234line1>
> >
> > This layout file is unused, right?
> 
> Tim Anderegg wrote:
> It is unused in recent versions, but was used in older versions.  Since 
> the most recent "layouts" folder is used for rendering all versions of the 
> documentation after the generation process, it must contain all past layouts 
> or else the renderer will produce an error.

Now that we are only doing versions >= 0.22.1, this is no longer needed.


- Tim


-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/#review160091
---


On May 5, 2017, 9:16 p.m., Tim Anderegg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52064/
> ---
> 
> (Updated May 5, 2017, 9:16 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Bugs: MESOS-3011
> https://issues.apache.org/jira/browse/MESOS-3011
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support for multiple versions of docs.
> 
> 
> Diffs
> -
> 
>   site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
>   site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
>   site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b 
>   site/build.sh 11f15e15621c4d3db1472e88911787b9b3100f97 
>   site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 
>   site/data/releases.yml 8bdc3ff11a821f5e1be04ac871c05b16403a82ac 
>   site/source/assets/js/versions.js PRE-CREATION 
>   site/source/layouts/basic.erb 3bf1f55d7d8feafd3caaa7902755404f7e45bae6 
>   site/source/layouts/documentation.erb 
> a91f916a5fb7348b2702c272e7a2059bdf628c66 
> 
> 
> Diff: https://reviews.apache.org/r/52064/diff/3/
> 
> 
> Testing
> ---
> 
> Testing was done manually to verify that the documentation was built for each 
> version of Mesos that is supported (some older versions do not have 
> compatible documentation).
> 
> 
> Thanks,
> 
> Tim Anderegg
> 
>

Re: Review Request 52064: Support for multiple versions of docs.

[Tim Anderegg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/
---

(Updated May 5, 2017, 9:23 p.m.)


Review request for mesos, haosdent huang and Vinod Kone.


Changes
---

Removed file that only had whitespace changes.


Bugs: MESOS-3011
https://issues.apache.org/jira/browse/MESOS-3011


Repository: mesos


Description
---

Support for multiple versions of docs.


Diffs (updated)
-

  site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
  site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
  site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b 
  site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 
  site/data/releases.yml 8bdc3ff11a821f5e1be04ac871c05b16403a82ac 
  site/source/assets/js/versions.js PRE-CREATION 
  site/source/layouts/basic.erb 3bf1f55d7d8feafd3caaa7902755404f7e45bae6 


Diff: https://reviews.apache.org/r/52064/diff/5/

Changes: https://reviews.apache.org/r/52064/diff/4-5/


Testing
---

Testing was done manually to verify that the documentation was built for each 
version of Mesos that is supported (some older versions do not have compatible 
documentation).


Thanks,

Tim Anderegg

Re: Review Request 52064: Support for multiple versions of docs.

[Tim Anderegg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/
---

(Updated May 5, 2017, 9:20 p.m.)


Review request for mesos, haosdent huang and Vinod Kone.


Changes
---

Got rid of build.sh phantom change for real this time.


Bugs: MESOS-3011
https://issues.apache.org/jira/browse/MESOS-3011


Repository: mesos


Description
---

Support for multiple versions of docs.


Diffs (updated)
-

  site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
  site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
  site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b 
  site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 
  site/data/releases.yml 8bdc3ff11a821f5e1be04ac871c05b16403a82ac 
  site/source/assets/js/versions.js PRE-CREATION 
  site/source/layouts/basic.erb 3bf1f55d7d8feafd3caaa7902755404f7e45bae6 
  site/source/layouts/documentation.erb 
a91f916a5fb7348b2702c272e7a2059bdf628c66 


Diff: https://reviews.apache.org/r/52064/diff/4/

Changes: https://reviews.apache.org/r/52064/diff/3-4/


Testing
---

Testing was done manually to verify that the documentation was built for each 
version of Mesos that is supported (some older versions do not have compatible 
documentation).


Thanks,

Tim Anderegg

Re: Review Request 52064: Support for multiple versions of docs.

[Tim Anderegg]

> On Dec. 23, 2016, 5:38 p.m., haosdent huang wrote:
> >

Sorry for the long delay on this, I've finally carved up some time to try and 
close this out.  I've left some comments below, and am working on addressing 
the issues, I will update the review tomorrow with the final result, hopefully 
addressing all issues raised.  Thansk!


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/#review160091
---


On May 4, 2017, 9:26 p.m., Tim Anderegg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52064/
> ---
> 
> (Updated May 4, 2017, 9:26 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Bugs: MESOS-3011
> https://issues.apache.org/jira/browse/MESOS-3011
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support for multiple versions of docs.
> 
> 
> Diffs
> -
> 
>   site/Dockerfile 8ba0be0c28e924f7a2b89e6e5a3237deb3751a41 
>   site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
>   site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
>   site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b 
>   site/build.sh 11f15e15621c4d3db1472e88911787b9b3100f97 
>   site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 
>   site/data/releases.yml 755300aa83a1017362129bad256381d10c815609 
>   site/source/assets/css/main.css 83596ddbd833e36b60bdbbd487ebd464b3874119 
>   site/source/assets/js/versions.js PRE-CREATION 
>   site/source/layouts/basic.erb 7464e40b619e883daad93c72c3fbdbfbdda8f152 
>   site/source/layouts/documentation.erb 
> a91f916a5fb7348b2702c272e7a2059bdf628c66 
>   site/source/layouts/gettingstarted.erb PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/52064/diff/2/
> 
> 
> Testing
> ---
> 
> Testing was done manually to verify that the documentation was built for each 
> version of Mesos that is supported (some older versions do not have 
> compatible documentation).
> 
> 
> Thanks,
> 
> Tim Anderegg
> 
>

Re: Review Request 52064: Support for multiple versions of docs.

[Tim Anderegg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/
---

(Updated May 4, 2017, 9:26 p.m.)


Review request for mesos, haosdent huang and Vinod Kone.


Bugs: MESOS-3011
https://issues.apache.org/jira/browse/MESOS-3011


Repository: mesos


Description
---

Support for multiple versions of docs.


Diffs
-

  site/Dockerfile 8ba0be0c28e924f7a2b89e6e5a3237deb3751a41 
  site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
  site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
  site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b 
  site/build.sh 11f15e15621c4d3db1472e88911787b9b3100f97 
  site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 
  site/data/releases.yml 755300aa83a1017362129bad256381d10c815609 
  site/source/assets/css/main.css 83596ddbd833e36b60bdbbd487ebd464b3874119 
  site/source/assets/js/versions.js PRE-CREATION 
  site/source/layouts/basic.erb 7464e40b619e883daad93c72c3fbdbfbdda8f152 
  site/source/layouts/documentation.erb 
a91f916a5fb7348b2702c272e7a2059bdf628c66 
  site/source/layouts/gettingstarted.erb PRE-CREATION 


Diff: https://reviews.apache.org/r/52064/diff/2/


Testing
---

Testing was done manually to verify that the documentation was built for each 
version of Mesos that is supported (some older versions do not have compatible 
documentation).


Thanks,

Tim Anderegg

Re: Review Request 52064: Support for multiple versions of docs.

[Tim Anderegg]

> On May 9, 2017, 4:30 p.m., haosdent huang wrote:
> > Hi, @tim Thanks a lot for your update. I am still reading you patch and 
> > have not finished. Could return my comments if it works at my side. Thanks 
> > a lot for your contributions.
> 
> Tim Anderegg wrote:
> Thanks @haosdent, please let me know if you have any questions or need 
> clarification on anything!
> 
> Vinod Kone wrote:
> Any further updates on this? @haosdent can you commit this now?

@haosdent @vinodkone This probably at least needs a rebase, but functionally 
speaking everything should be in working order.  I'll be at the hackathon at 
MesosCon tomorrow, if folks want to work on closing this out!


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/#review174335
-------


On May 5, 2017, 9:23 p.m., Tim Anderegg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52064/
> ---
> 
> (Updated May 5, 2017, 9:23 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Bugs: MESOS-3011
> https://issues.apache.org/jira/browse/MESOS-3011
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support for multiple versions of docs.
> 
> 
> Diffs
> -
> 
>   site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 
>   site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf 
>   site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b 
>   site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 
>   site/data/releases.yml 8bdc3ff11a821f5e1be04ac871c05b16403a82ac 
>   site/source/assets/js/versions.js PRE-CREATION 
>   site/source/layouts/basic.erb 3bf1f55d7d8feafd3caaa7902755404f7e45bae6 
> 
> 
> Diff: https://reviews.apache.org/r/52064/diff/5/
> 
> 
> Testing
> ---
> 
> Testing was done manually to verify that the documentation was built for each 
> version of Mesos that is supported (some older versions do not have 
> compatible documentation).
> 
> 
> Thanks,
> 
> Tim Anderegg
> 
>

Re: Review Request 52064: Support for multiple versions of docs.

[Tim Anderegg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/
---

(Updated Feb. 9, 2018, 1:46 a.m.)


Review request for mesos, haosdent huang and Vinod Kone.


Changes
---

Rebased against latest


Bugs: MESOS-3011
https://issues.apache.org/jira/browse/MESOS-3011


Repository: mesos


Description
---

Support for multiple versions of docs.


Diffs (updated)
-

  site/Gemfile 877fe914a9787c140848fdf9958571fec5fa58ff 
  site/Gemfile.lock 909f3f3badeaa47c80929e243ce36307766edee4 
  site/Rakefile 31ef6ffe225ce7ddc573054058af1070b9e96b09 
  site/config.rb 04bc7aa1e0ac61ce5d89fd53d32f265532996913 
  site/data/releases.yml e3edc308a5429585b3fc3f05564d695ba3217035 
  site/source/assets/js/versions.js PRE-CREATION 
  site/source/layouts/basic.erb 8a07488940f3793d6fdd291dbe896e098f321c96 


Diff: https://reviews.apache.org/r/52064/diff/6/

Changes: https://reviews.apache.org/r/52064/diff/5-6/


Testing
---

Testing was done manually to verify that the documentation was built for each 
version of Mesos that is supported (some older versions do not have compatible 
documentation).


Thanks,

Tim Anderegg

Re: Review Request 52064: Support for multiple versions of docs.

[Tim Anderegg]

> On Feb. 9, 2018, 6:02 p.m., Benjamin Bannier wrote:
> > I am wondering whether it wouldn't be simpler to have the site setup just 
> > generate output for the currently checked-out version and dump that into 
> > some version-specific output folder. We could then have some CI setup 
> > execute this for the different tags or branches we care about. This 
> > wouldn't only simplify the site setup, but probably also deal better with 
> > e.g., changed requirements to the base system (e.g., needed to build 
> > binaries generating the endpoint documentation) which are currently not 
> > managed in the rake file.
> > 
> > One difficulty with that approach would be to determine under what branch 
> > we are actually working on. My guess is that we wouldn't want to update to 
> > documentation of 1.3.0 until we have tagged a 1.3.0 version, so we'd likely 
> > build documentation for the n-latest tags. The `HEAD` of `master` is more 
> > tricky as it would change more frequently and not directly have a release 
> > tag as parent (these live on release branches) making it harder to work 
> > with say `git-describe`. Maybe we could parse this from source, e.g., 
> > `MESOS_VERSION` in `include/mesos/version.hpp`.
> > 
> > The other difficulty might be that we might move a lot of site-generation 
> > setup out of the repo into e.g., Jenkins config. There are probably ways to 
> > work around that, but I haven't thought that through.

I'm not familiar with how Jenkins is configured and used here, but your 
approach could be simpler depending on how complex the CI build setup is.  This 
patch would remain mostly the same, except lines 68-89 of the Rakefile could be 
removed and the git dependency would no longer be necessary.  The version could 
then be fed in by Jenkins, which would probably be easier/simpler than trying 
to programmatically determine the version.  Right now "master" just translates 
to "latest" in the patch as-is.

I saw putting everything in the Rakefile as the most straightforward approach, 
since it allows the correct versions to generate docs for to be determined 
programmatically, avoiding the difficulty you mentioned above. However, it does 
require generating all documentation for all versions on each build, and 
significant changes to the build process or documentation process down the road 
might make it difficult to maintain a backwards-compatible approach (e.g. I 
currently disable doc generation for the oldest dozen tags or so which don't 
have the same documentation setup, or any documentation at all).


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/#review197173
---


On Feb. 9, 2018, 1:46 a.m., Tim Anderegg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52064/
> ---
> 
> (Updated Feb. 9, 2018, 1:46 a.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Bugs: MESOS-3011
> https://issues.apache.org/jira/browse/MESOS-3011
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support for multiple versions of docs.
> 
> 
> Diffs
> -
> 
>   site/Gemfile 877fe914a9787c140848fdf9958571fec5fa58ff 
>   site/Gemfile.lock 909f3f3badeaa47c80929e243ce36307766edee4 
>   site/Rakefile 31ef6ffe225ce7ddc573054058af1070b9e96b09 
>   site/config.rb 04bc7aa1e0ac61ce5d89fd53d32f265532996913 
>   site/data/releases.yml e3edc308a5429585b3fc3f05564d695ba3217035 
>   site/source/assets/js/versions.js PRE-CREATION 
>   site/source/layouts/basic.erb 8a07488940f3793d6fdd291dbe896e098f321c96 
> 
> 
> Diff: https://reviews.apache.org/r/52064/diff/6/
> 
> 
> Testing
> ---
> 
> Testing was done manually to verify that the documentation was built for each 
> version of Mesos that is supported (some older versions do not have 
> compatible documentation).
> 
> 
> Thanks,
> 
> Tim Anderegg
> 
>

Re: Review Request 52064: Support for multiple versions of docs.

[Tim Anderegg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/
---

(Updated Feb. 13, 2018, 3:44 p.m.)


Review request for mesos, haosdent huang and Vinod Kone.


Changes
---

Rebased and added more detailed description with screenshots.


Bugs: MESOS-3011
https://issues.apache.org/jira/browse/MESOS-3011


Repository: mesos


Description (updated)
---

This patch updates the website build process to allow for documentation to be 
generated for all versions of Mesos, based on the existing Git tags.  
Additionally, the website is updated with a dropdown list of the available 
versions of documentation.  If a user changes versions and the old version does 
not have the current page, a notice will be displayed and the user redirected 
to the home page for the desired version.

This is a temporary measure to "catchup" the documentation for the website by 
generating docs for all previous versions.  Going forward, as each new version 
of Mesos is released the documentation will be generated for that version only.

![Dropdown list of versions.](https://i.imgur.com/xvukEBGl.png)
Screenshot of the dropdown list of versions.

![404 Message](https://i.imgur.com/kqXNsxvl.png)
Screenshot of the message displayed if a page does not exist for the selected 
version.


Diffs (updated)
-

  site/Gemfile 877fe914a9787c140848fdf9958571fec5fa58ff 
  site/Gemfile.lock 909f3f3badeaa47c80929e243ce36307766edee4 
  site/Rakefile 31ef6ffe225ce7ddc573054058af1070b9e96b09 
  site/config.rb 04bc7aa1e0ac61ce5d89fd53d32f265532996913 
  site/data/releases.yml 56fd0fc7f5e34873c9b088778d77f9a6718a5933 
  site/source/assets/js/versions.js PRE-CREATION 
  site/source/layouts/basic.erb 8a07488940f3793d6fdd291dbe896e098f321c96 


Diff: https://reviews.apache.org/r/52064/diff/7/

Changes: https://reviews.apache.org/r/52064/diff/6-7/


Testing
---

Testing was done manually to verify that the documentation was built for each 
version of Mesos that is supported (some older versions do not have compatible 
documentation).


Thanks,

Tim Anderegg

Re: Review Request 52064: Support for multiple versions of docs.

[Tim Anderegg]

any copies of the Mesos code 
would persist (one for each tagged version), which would be GB's in size.

Thanks!  I should be able to find time to do this over the next week or so.

Tim


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/#review198236
---


On Feb. 13, 2018, 3:44 p.m., Tim Anderegg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52064/
> ---
> 
> (Updated Feb. 13, 2018, 3:44 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Bugs: MESOS-3011
> https://issues.apache.org/jira/browse/MESOS-3011
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch updates the website build process to allow for documentation to be 
> generated for all versions of Mesos, based on the existing Git tags.  
> Additionally, the website is updated with a dropdown list of the available 
> versions of documentation.  If a user changes versions and the old version 
> does not have the current page, a notice will be displayed and the user 
> redirected to the home page for the desired version.
> 
> This is a temporary measure to "catchup" the documentation for the website by 
> generating docs for all previous versions.  Going forward, as each new 
> version of Mesos is released the documentation will be generated for that 
> version only.
> 
> ![Dropdown list of versions.](https://i.imgur.com/xvukEBGl.png)
> Screenshot of the dropdown list of versions.
> 
> ![404 Message](https://i.imgur.com/kqXNsxvl.png)
> Screenshot of the message displayed if a page does not exist for the selected 
> version.
> 
> 
> Diffs
> -
> 
>   site/Gemfile 877fe914a9787c140848fdf9958571fec5fa58ff 
>   site/Gemfile.lock 909f3f3badeaa47c80929e243ce36307766edee4 
>   site/Rakefile 31ef6ffe225ce7ddc573054058af1070b9e96b09 
>   site/config.rb 04bc7aa1e0ac61ce5d89fd53d32f265532996913 
>   site/data/releases.yml 56fd0fc7f5e34873c9b088778d77f9a6718a5933 
>   site/source/assets/js/versions.js PRE-CREATION 
>   site/source/layouts/basic.erb 8a07488940f3793d6fdd291dbe896e098f321c96 
> 
> 
> Diff: https://reviews.apache.org/r/52064/diff/7/
> 
> 
> Testing
> ---
> 
> Testing was done manually to verify that the documentation was built for each 
> version of Mesos that is supported (some older versions do not have 
> compatible documentation).
> 
> 
> Thanks,
> 
> Tim Anderegg
> 
>