[GitHub] spark pull request #17169: [SPARK-19714][ML] Bucketizer.handleInvalid docs i...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17169 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #17169: [SPARK-19714][ML] Bucketizer.handleInvalid docs i...
Github user wojtek-szymanski commented on a diff in the pull request:
https://github.com/apache/spark/pull/17169#discussion_r104534910
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala
---
@@ -78,16 +78,19 @@ final class Bucketizer @Since("1.4.0") (@Since("1.4.0")
override val uid: String
def setOutputCol(value: String): this.type = set(outputCol, value)
/**
- * Param for how to handle invalid entries. Options are 'skip' (filter
out rows with
- * invalid values), 'error' (throw an error), or 'keep' (keep invalid
values in a special
- * additional bucket).
+ * Param for how to handle invalid entries containing either NaN or null
values.
--- End diff --
You are right. I will update docs with null values support once #17123 gets
merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #17169: [SPARK-19714][ML] Bucketizer.handleInvalid docs i...
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/17169#discussion_r104421310
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala
---
@@ -78,16 +78,19 @@ final class Bucketizer @Since("1.4.0") (@Since("1.4.0")
override val uid: String
def setOutputCol(value: String): this.type = set(outputCol, value)
/**
- * Param for how to handle invalid entries. Options are 'skip' (filter
out rows with
- * invalid values), 'error' (throw an error), or 'keep' (keep invalid
values in a special
- * additional bucket).
+ * Param for how to handle invalid entries containing either NaN or null
values.
--- End diff --
I guess once #17123 maybe merged it will hold true
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #17169: [SPARK-19714][ML] Bucketizer.handleInvalid docs i...
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/17169#discussion_r104385944
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala
---
@@ -78,16 +78,19 @@ final class Bucketizer @Since("1.4.0") (@Since("1.4.0")
override val uid: String
def setOutputCol(value: String): this.type = set(outputCol, value)
/**
- * Param for how to handle invalid entries. Options are 'skip' (filter
out rows with
- * invalid values), 'error' (throw an error), or 'keep' (keep invalid
values in a special
- * additional bucket).
+ * Param for how to handle invalid entries containing either NaN or null
values.
--- End diff --
This is actually not true currently - `null` is not handled as an invalid
value - see https://issues.apache.org/jira/browse/SPARK-19781
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
