Re: [Ring] Android Call StatusBar Exception/MultiDex

[Nathan Royce]

Re-sending since I neglected to Reply-To-All...
I pulled the latest commit (81cb605e6c72c9947826ad489898a4deb0abe1b6)
which also included the previous fix for Android 4.4 and can confirm I
don't have issue sending/receiving calls, so it can be pushed to the
Play Store.

On Fri, May 4, 2018 at 4:38 PM, Pierre Duchemin
 wrote:
> Thank you Nathan for this report.
>
> This issue is quite common on Android.
> It's caused by the library that convert vector pictures to raster in order to 
> keep compatibility with api < 21.
>
> However, vectors brings lots of improvements so I'd rather find a vector that 
> don't make the lib crash instead of using a png like you did.
>
> Here is a patch for this issue:
> https://gerrit-ring.savoirfairelinux.com/#/c/9374/
> The vector drawable is taken from http://materialdesignicons.com/ and look 
> like the old one.
>
> Since the emulator is crashing on call and our oldest phones are out of 
> order, I was not able to test it.
> Can you tell me if it helps?

Re: [Ring] Android Call StatusBar Exception/MultiDex

[Nathan Royce]

Nope, still no go.
I even went to that icon site and took a very simplistic one, but alas
that failed as well:
http://schemas.android.com/apk/res/android;
android:height="24dp"
android:width="24dp"
android:viewportWidth="24"
android:viewportHeight="24">



I'm sure you could test it on your side without an old phone by just
making a temporary notification message display on loading and using a
virtual kitkat device.

On Fri, May 4, 2018 at 4:38 PM, Pierre Duchemin
 wrote:
> Thank you Nathan for this report.
>
> This issue is quite common on Android.
> It's caused by the library that convert vector pictures to raster in order to 
> keep compatibility with api < 21.
>
> However, vectors brings lots of improvements so I'd rather find a vector that 
> don't make the lib crash instead of using a png like you did.
>
> Here is a patch for this issue:
> https://gerrit-ring.savoirfairelinux.com/#/c/9374/
> The vector drawable is taken from http://materialdesignicons.com/ and look 
> like the old one.
>
> Since the emulator is crashing on call and our oldest phones are out of 
> order, I was not able to test it.
> Can you tell me if it helps?

Re: [Ring] Android Call StatusBar Exception/MultiDex

[Pierre Duchemin]

Thank you Nathan for this report.

This issue is quite common on Android.
It's caused by the library that convert vector pictures to raster in order to 
keep compatibility with api < 21.

However, vectors brings lots of improvements so I'd rather find a vector that 
don't make the lib crash instead of using a png like you did.

Here is a patch for this issue:
https://gerrit-ring.savoirfairelinux.com/#/c/9374/
The vector drawable is taken from http://materialdesignicons.com/ and look like 
the old one.

Since the emulator is crashing on call and our oldest phones are out of order, 
I was not able to test it.
Can you tell me if it helps?

- Message original -
De: "Nathan Royce" <nroycea+...@gmail.com>
À: "ring" <ring@gnu.org>
Envoyé: Jeudi 3 Mai 2018 19:56:04
Objet: [Ring] Android Call StatusBar Exception/MultiDex

I think I narrowed down the problem to the vectors...
https://github.com/wordpress-mobile/WordPress-Android/issues/4968#issuecomment-26631

In NotificationServiceImpl.java - showCallNotification(), I had
changed "ic_call_end_white" in addAction to "ring_logo_24dp.png" for
everything (strictly for testing) and ring did NOT crash when
sending/receiving calls.

[Ring] Android Call StatusBar Exception/MultiDex

[Nathan Royce]

Looks like the reply I made to my other thread actually needs to be a
new different thread.
*
05-03 15:27:06.947 1029-1198/? D/WifiNative-wlan0: doString: SIGNAL_POLL
05-03 15:27:07.007 1215-1215/? E/StatusBar: couldn't inflate view for
notification cx.ring/0xf83e638

android.content.res.Resources$NotFoundException: File
res/drawable/ic_call_end_white.xml from drawable resource ID
#0x7f08006f
at
android.content.res.Resources.loadDrawable(Resources.java:2136)
at
android.content.res.Resources.getDrawable(Resources.java:715)
at
android.widget.TextView.setCompoundDrawablesRelativeWithIntrinsicBounds(TextView.java:2377)
at
android.widget.RemoteViews$TextViewDrawableAction.apply(RemoteViews.java:1417)
at
android.widget.RemoteViews.performApply(RemoteViews.java:2458)
at
android.widget.RemoteViews.apply(RemoteViews.java:2417)
at
android.widget.RemoteViews$ViewGroupAction.apply(RemoteViews.java:1345)
at
android.widget.RemoteViews.performApply(RemoteViews.java:2458)
at
android.widget.RemoteViews.apply(RemoteViews.java:2417)
at
com.android.systemui.statusbar.BaseStatusBar.inflateViews(BaseStatusBar.java:732)
at
com.android.systemui.statusbar.BaseStatusBar.createNotificationViews(BaseStatusBar.java:938)
at
com.android.systemui.statusbar.phone.PhoneStatusBar.addNotification(PhoneStatusBar.java:1307)
at
com.android.systemui.statusbar.CommandQueue$H.handleMessage(CommandQueue.java:326)
at
android.os.Handler.dispatchMessage(Handler.java:102)
at
android.os.Looper.loop(Looper.java:136)
at
android.app.ActivityThread.main(ActivityThread.java:5103)
at
java.lang.reflect.Method.invokeNative(Native Method)
at
java.lang.reflect.Method.invoke(Method.java:515)
at
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:790)
at
com.android.internal.os.ZygoteInit.main(ZygoteInit.java:606)
at
dalvik.system.NativeStart.main(Native Method)
 Caused by:
org.xmlpull.v1.XmlPullParserException: Binary XML file line #1:
invalid drawable tag vector
at
android.graphics.drawable.Drawable.createFromXmlInner(Drawable.java:933)
at
android.graphics.drawable.Drawable.createFromXml(Drawable.java:877)
at
android.content.res.Resources.loadDrawable(Resources.java:2132)
at
android.content.res.Resources.getDrawable(Resources.java:715)
at
android.widget.TextView.setCompoundDrawablesRelativeWithIntrinsicBounds(TextView.java:2377)
at
android.widget.RemoteViews$TextViewDrawableAction.apply(RemoteViews.java:1417)
at
android.widget.RemoteViews.performApply(RemoteViews.java:2458)
at
android.widget.RemoteViews.apply(RemoteViews.java:2417)
at
android.widget.RemoteViews$ViewGroupAction.apply(RemoteViews.java:1345)
at
android.widget.RemoteViews.performApply(RemoteViews.java:2458)
at
android.widget.RemoteViews.apply(RemoteViews.java:2417)
at
com.android.systemui.statusbar.BaseStatusBar.inflateViews(BaseStatusBar.java:732)
at
com.android.systemui.statusbar.BaseStatusBar.createNotificationViews(BaseStatusBar.java:938)
at
com.android.systemui.statusbar.phone.PhoneStatusBar.addNotification(PhoneStatusBar.java:1307)
at
com.android.systemui.statusbar.CommandQueue$H.handleMessage(CommandQueue.java:326)
at
android.os.Handler.dispatchMessage(Handler.java:102)