[Citadel Development] Citadel commit log: revision 6948

[matt]

r6948 | matt | 2009-01-13 02:47:46 -0500 (Tue, 13 Jan 2009) | 5 lines
Changed paths:
   M /trunk/webcit/auth.c
   M /trunk/webcit/messages.c
   M /trunk/webcit/serv_func.c
   M /trunk/webcit/static/summaryview.js
   M /trunk/webcit/static/t/iconbar.html
   M /trunk/webcit/static/t/login.html
   M /trunk/webcit/static/t/roombanner.html
   M /trunk/webcit/static/wclib.js
   M /trunk/webcit/static/webcit.css

* fix issues with room list in firefox 2 (didn't detect console.log properly, 
again)
* New JS func: WCLog
* some HTML validation fixes (remove align="center",  -> )
* known issue: FF2 won't hide handle overflow text in table cells. I do have 
some idea of how to work around

[Citadel Development] (no subject)

[matt]

Also, there is now a javascript library (CtdlDragDrop) for drag-drop stuff
that does things in a much more kosher way. Some time in the future I'll
modify notes view to use it.

[Citadel Development] (no subject)

[matt]

Thats another round. I'll install FF2 later on and check it out, admittedly I
haven't gone back far with regards to versions of the three main 'good
browsers' (FF, Safari and Opera), and Exploder is fairly consistent across
each version :(

Did someone attempt to activate i18n for datepicker as well? In 

[Citadel Development] Citadel commit log: revision 6947

[matt]

r6947 | matt | 2009-01-12 23:23:43 -0500 (Mon, 12 Jan 2009) | 6 lines
Changed paths:
   M /trunk/webcit/messages.c
   M /trunk/webcit/roomops.c
   M /trunk/webcit/static/ctdldragdrop.js
   M /trunk/webcit/static/summaryview.js
   M /trunk/webcit/static/wclib.js

* move output_headers to the top of readloop, before the big switch, so wprintf 
outputs within  instead of above  (fixes issue where buttons blew 
up huge in notesview)
* Only create CtdlDragDrop in summaryview, restores notes functionality for now
* Check to see if iconbar wholist exists before calling Ajax.Updater->fixes 
error on logon screen
* Fix double id definition for search form
* Restore date format to -mm-dd i.e pre r6912

[Citadel Development] (no subject)

[IGnatius T Foobar]

 >Do you see a request for /json_roomflr in the webcit console? Which browser
 >& version are you using?  

I don't see that request.  Firefox 2.0.0.11 on Linux.

 >Regarding your first list of regressions - are you sure iconbar had a
 >background? looking at the CSS on uncensored, its just white

Upon closer examination, I see the differences, and you're correct, the
background itself is white.  The difference is that in the pre-merge version,
the "switch to room list" and "customize this menu" links are the same
powder-blue color as the buttons, and the space below the iconbar (if there
is any) is the same turquoise color as the main background of the page.

Obviously these are not huge issues.

One more thing to be noted, although I don't think this particular merge
caused it: I no longer see the option to log in using OpenID.  This may have
disappeared when the login screen was templated.

[Citadel Development] (no subject)

[matt]

Do you see a request for /json_roomflr in the webcit console? Which browser
& version are you using?  

Disappearing room type images is probably a browser issue - CSS
list-style-image is now used to show them, so the browser has to load each as
they appear. A preloader will solve that.  

Noted issue with notes and calendar. 

Regarding your first list of regressions - are you sure iconbar had a
background? looking at the CSS on uncensored, its just white

[Citadel Development] Re: Citadel commit log: revision 6945

[IGnatius T Foobar]

Wow, that's a lot of fixes in one shot.  Thanks for responding so quickly! 
 
   
 A couple of things I noticed after this last update:  
   
 * "switch to room list" sometimes doesn't work.  I'm still trying to 
figure out a set of reproducible steps and will post them if I find them.  
   
 * When the iconbar room list appears, some of the icons are replaced by 
small circles, at least initially.  
   
 * When in the "Notes" view, the iconbar buttons are each an entire 
screenful tall.  Also, attempting to drag and drop a note is impossible, 
because the mouse-up event is lost for some reason -- so the note gets 
stuck to the mouse pointer and won't let go.  
   
 * Editing a calendar event -- the changes in r6637 appear to have 
regressed.  I had changed it to use the ISO international date format 
(-mm-dd) because it's the only format that won't confuse anyone.  (For 
example, if I create a new calendar event today, it will appear as 
12/01/2009, which in the US means December 1, not January 12.)  
   
 More as I find them.  By the way, I hope I'm not coming off as annoyed or 
anything -- I appreciate all of the work that's going in here.  But the 
regressions must of course be fixed.  
  

[Citadel Development] Citadel commit log: revision 6946

[dothebart]

r6946 | dothebart | 2009-01-12 18:31:20 -0500 (Mon, 12 Jan 2009) | 2 lines
Changed paths:
   M /trunk/webcit/setup.c

+ let the admin select the locales to preset / not set at install time; unset 
LANG in the no-preset case.

[Citadel Development] Citadel commit log: revision 6945

[matt]

r6945 | matt | 2009-01-12 18:15:26 -0500 (Mon, 12 Jan 2009) | 8 lines
Changed paths:
   M /trunk/webcit/iconbar.c
   M /trunk/webcit/messages.c
   M /trunk/webcit/static/summaryview.js
   M /trunk/webcit/static/t/iconbar.html
   M /trunk/webcit/static/wclib.js
   M /trunk/webcit/static/webcit.css

*fix numerous regressions that I let slip:
* 'customize this' now below 'log off' in iconbar
* fix embedded wholist in iconbar appearing if not enabled
* make drag and drop menu translucent, with no list padding
* enable chat button again
* no link colors for 'customize this'
* try to properly detect the presence/lack of Firebug/Safari/IE8 developer 
console (console.log). If you see any console.log missing errors and don't have 
Firebug installed, please tell me

[Citadel Development] Citadel commit log: revision 6943

[ajc]

r6943 | ajc | 2009-01-12 16:47:52 -0500 (Mon, 12 Jan 2009) | 1 line
Changed paths:
   M /trunk/webcit/webcit.c

* Properly handle '551 too many users' error in WebCit.  This resolves bug 420.

[Citadel Development] Citadel commit log: revision 6942

[dothebart]

r6942 | dothebart | 2009-01-12 15:14:46 -0500 (Mon, 12 Jan 2009) | 3 lines
Changed paths:
   M /trunk/webcit/messages.c
   M /trunk/webcit/msg_renderers.c
   M /trunk/webcit/roomops.c
   M /trunk/webcit/subst.c
   M /trunk/webcit/subst.h
   M /trunk/webcit/webcit.h

+ add =() subtemplates for params
* fix some warnings and non-C90 cleanness.

[Citadel Development] Citadel commit log: revision 6940

[ajc]

r6940 | ajc | 2009-01-12 13:03:14 -0500 (Mon, 12 Jan 2009) | 1 line
Changed paths:
   M /trunk/webcit/static/webcit.css

* webcit.css: returned tabcontent_submit width back to 96% as was originally 
done in r6522; this repairs the bottom of tabbed dialogs and makes them line up 
with the rest of the box instead of appearing as a short bottom tab

[Citadel Development] Re: r6936/new summary view changes

[IGnatius T Foobar]

   
 More:  
   
 * Tabbed dialogs such as the event editor and site-wide configuration now 
show the div that's common to all tabs (such as the Save/Cancel buttons) 
as an odd looking bottom tab instead of spanning the entire width of the 
dialog.  
   
 * The "Chat" function is gone.  Pushing the button has no effect.  
   
 * On the "Advanced" menu screen, the rounded corner which should appear 
at the bottom left of the "Basic Commands" box now appears aligned with 
the third column of options.  
  

[Citadel Development] Re: r6936/new summary view changes

[IGnatius T Foobar]

Ok, here are some problems I see so far:  
   
 * Iconbar - the background is gone  
   
 * Iconbar - "customize this menu" appears above the last button instead 
of below it, and the font is too big (did the css for it disappear?)  
   
 * When I click on "Mail" the message "Loading messages from server, 
please wait" appears, followed by a Javascript dialog reading "TypeError: 
console.log is not a function"  
   
 * After clicking through that dialog, the mail summary appears, but the 
"Loading messages" throbber continues to appear below it.  
   
 * When drag-and-drop is performed, the dragged div is not translucent  
   
 * The "switch to room list" is not a link, it's just text.  I can't 
switch to the room list.  
   
 * The little wholist embedded into the iconbar appeared, even though I 
had the preference set to "Yes" instead of "Yes with users list."  I fixed 
this recently, so it's probably a regression. 
 I then attempted to set it to "No", which worked fine, but then when I 
set it back to "Yes" it failed to reappear.  
  

[Citadel Development] Re: r6936/new summary view changes

[IGnatius T Foobar]

I like the safe mode idea.  What is its behavior?  Does it go to the old 
webcit semantics or does it actually implement a non-ajax view?  
  

[Citadel Development] r6936/new summary view changes

[matt]

.. And there we go..

There are still some cosmetic patch ups needed, but I'd like to extinguish
any possible bugs before I continue. 

If you are on a slower machine, or using Internet exploder, go into
advanced->prefs and change to 'safe mode' to improve responsiveness with
large (several thousand) sets of messages

[Citadel Development] Citadel commit log: revision 6939

[matt]

r6939 | matt | 2009-01-12 07:32:43 -0500 (Mon, 12 Jan 2009) | 2 lines
Changed paths:
   M /trunk/webcit/auth.c
   M /trunk/webcit/context_loop.c
   M /trunk/webcit/iconbar.c
   M /trunk/webcit/messages.c
   M /trunk/webcit/msg_renderers.c
   M /trunk/webcit/roomops.c
   M /trunk/webcit/static/dragdrop.js
   M /trunk/webcit/static/iconbaricns.css
   A /trunk/webcit/static/summaryview.js (from 
/branches/webcit-newsummaryview/static/summaryview.js:6938)
   M /trunk/webcit/static/t/box_preferences.html
   M /trunk/webcit/static/t/head.html
   M /trunk/webcit/static/t/iconbar.html
   M /trunk/webcit/static/t/load_attachments.html
   M /trunk/webcit/static/t/login.html
   A /trunk/webcit/static/t/mailsummary_json.html (from 
/branches/webcit-newsummaryview/static/t/mailsummary_json.html:6938)
   A /trunk/webcit/static/t/mailsummary_json_section.html (from 
/branches/webcit-newsummaryview/static/t/mailsummary_json_section.html:6938)
   M /trunk/webcit/static/t/msg_listview.html
   M /trunk/webcit/static/t/richedit.html
   M /trunk/webcit/static/t/roombanner.html
   M /trunk/webcit/static/t/section_attach_select.html
   M /trunk/webcit/static/t/section_mailsummary.html
   A /trunk/webcit/static/t/subject_aiderestart.html (from 
/trunk/webcit/static/t/subject_aiderestart.html:6814)
   A /trunk/webcit/static/t/subject_floorconfig.html (from 
/trunk/webcit/static/t/subject_floorconfig.html:6814)
   A /trunk/webcit/static/t/subject_inet_aliases.html (from 
/trunk/webcit/static/t/subject_inet_aliases.html:6814)
   A /trunk/webcit/static/t/subject_pushmail.html (from 
/trunk/webcit/static/t/subject_pushmail.html:6814)
   A /trunk/webcit/static/t/subject_tuning.html (from 
/trunk/webcit/static/t/subject_tuning.html:6814)
   M /trunk/webcit/static/t/summary_header.html
   M /trunk/webcit/static/wclib.js
   M /trunk/webcit/static/webcit.css
   M /trunk/webcit/subst.c
   M /trunk/webcit/subst.h
   M /trunk/webcit/webcit.c
   M /trunk/webcit/webcit.h

Merge new summary view branches changes into trunk

[Citadel Development] Citadel commit log: revision 6938

[matt]

r6938 | matt | 2009-01-12 05:08:09 -0500 (Mon, 12 Jan 2009) | 3 lines
Changed paths:
   M /branches/webcit-newsummaryview/calendar.c
   M /branches/webcit-newsummaryview/downloads.c
   M /branches/webcit-newsummaryview/fmt_date.c
   M /branches/webcit-newsummaryview/gettext.c
   A /branches/webcit-newsummaryview/paramhandling.h (from 
/trunk/webcit/paramhandling.h:6936)
   M /branches/webcit-newsummaryview/preferences.c
   M /branches/webcit-newsummaryview/preferences.h
   M /branches/webcit-newsummaryview/serv_func.c
   M /branches/webcit-newsummaryview/subst.c
   M /branches/webcit-newsummaryview/subst.h
   M /branches/webcit-newsummaryview/useredit.c
   M /branches/webcit-newsummaryview/webcit.h
   M /branches/webcit-newsummaryview/webserver.c

and more.. add stuff which hasn't been updated since r6919

[Citadel Development] Citadel commit log: revision 6937

[matt]

r6937 | matt | 2009-01-12 04:30:17 -0500 (Mon, 12 Jan 2009) | 2 lines
Changed paths:
   M /branches/webcit-newsummaryview/messages.c
   M /branches/webcit-newsummaryview/webcit.c

Some merges I have missed..

[Citadel Development] Citadel commit log: revision 6936

[matt]

r6936 | matt | 2009-01-12 04:21:37 -0500 (Mon, 12 Jan 2009) | 8 lines
Changed paths:
   M /branches/webcit-newsummaryview/WISHLIST
   M /branches/webcit-newsummaryview/messages.c
   M /branches/webcit-newsummaryview/msg_renderers.c
   M /branches/webcit-newsummaryview/roomops.c
   M /branches/webcit-newsummaryview/static/iconbaricns.css
   M /branches/webcit-newsummaryview/static/summaryview.js
   M /branches/webcit-newsummaryview/static/t/iconbar.html
   M /branches/webcit-newsummaryview/static/t/mailsummary_json.html
   M /branches/webcit-newsummaryview/static/t/roombanner.html
   M /branches/webcit-newsummaryview/static/webcit.css
   M /branches/webcit-newsummaryview/webcit.h

+ 'Safe mode' in summary view implemented
* Search within summary view now ajax'ed
* Fix the conditionals I added in msg_renderers.c so 'safe mode' works
* Place a few readloop variables into wcsession to aide above, I really should 
make that a struct though
* Place logoff button below roomlist in iconbar so it stays there
* mailsummary_json now has a few variables embedded