Re: [ros-dev] [ros-diffs] [tfaber] 64974: [CRT] - Add frame pointer omission information to assembly string functions to fix debugging annoyances. Reviews appreciated

2014-10-25 Thread Timo Kreuzer 

Am 25.10.2014 02:08, schrieb tfa...@svn.reactos.org:

Author: tfaber
Date: Sat Oct 25 00:08:23 2014
New Revision: 64974

URL: http://svn.reactos.org/svn/reactos?rev=64974view=rev
Log:
[CRT]
- Add frame pointer omission information to assembly string functions to fix 
debugging annoyances. Reviews appreciated



Modified: trunk/reactos/lib/sdk/crt/string/i386/tcsnlen.inc
URL: 
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/string/i386/tcsnlen.inc?rev=64974r1=64973r2=64974view=diff
==
--- trunk/reactos/lib/sdk/crt/string/i386/tcsnlen.inc   [iso-8859-1] (original)
+++ trunk/reactos/lib/sdk/crt/string/i386/tcsnlen.inc   [iso-8859-1] Sat Oct 25 
00:08:23 2014
@@ -5,7 +5,8 @@
  PUBLIC _tcsnlen
  .code
  
-_tcsnlen:

+FUNC _tcsnlen
+FPO 0, 1, 1, 1, 0, FRAME_FPO

This one has 2 parameters



___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] [ros-diffs] [akhaldi] 64994: [ADVAPI32] * Update ImpersonateNamedPipeClient(). CORE-8540

2014-10-25 Thread Ged Murphy 
Eeww, these are a bit ugly :(


On 25/10/2014 19:30, akha...@svn.reactos.org akha...@svn.reactos.org
wrote:

Author: akhaldi
Date: Sat Oct 25 18:30:05 2014
New Revision: 64994

URL: http://svn.reactos.org/svn/reactos?rev=64994view=rev
Log:
[ADVAPI32]
* Update ImpersonateNamedPipeClient().
CORE-8540

Modified:
trunk/reactos/dll/win32/advapi32/wine/security.c

Modified: trunk/reactos/dll/win32/advapi32/wine/security.c
URL: 
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/advapi32/wine/s
ecurity.c?rev=64994r1=64993r2=64994view=diff
==

--- trunk/reactos/dll/win32/advapi32/wine/security.c   [iso-8859-1]
(original)
+++ trunk/reactos/dll/win32/advapi32/wine/security.c   [iso-8859-1] Sat Oct
25 18:30:05 2014
@@ -954,37 +954,14 @@
 return TRUE;
 }
 
-/**
- * ImpersonateNamedPipeClient EXPORTED
- *
- * @implemented
- */
-BOOL
-WINAPI
-ImpersonateNamedPipeClient(HANDLE hNamedPipe)
-{
-IO_STATUS_BLOCK StatusBlock;
-NTSTATUS Status;
-
-TRACE(ImpersonateNamedPipeClient() called\n);
-
-Status = NtFsControlFile(hNamedPipe,
- NULL,
- NULL,
- NULL,
- StatusBlock,
- FSCTL_PIPE_IMPERSONATE,
- NULL,
- 0,
- NULL,
- 0);
-if (!NT_SUCCESS(Status))
-{
-SetLastError(RtlNtStatusToDosError(Status));
-return FALSE;
-}
-
-return TRUE;
+BOOL WINAPI ImpersonateNamedPipeClient( HANDLE hNamedPipe )
+{
+IO_STATUS_BLOCK io_block;
+
+TRACE((%p)\n, hNamedPipe);
+
+return set_ntstatus( NtFsControlFile(hNamedPipe, NULL, NULL, NULL,
+ io_block, FSCTL_PIPE_IMPERSONATE, NULL, 0,
NULL, 0) );
 }
 
 /*





___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] [ros-diffs] [akhaldi] 64994: [ADVAPI32] * Update ImpersonateNamedPipeClient(). CORE-8540

2014-10-25 Thread Pierre Schweitzer 
And it changes behavior of the functions.

I'd rather trust a !NT_SUCESS(Status)) than a status. This means these
functions with Wine code would fail on an informational status (whereas
they didn't before). Is it intentional? Do we have tests to assess such
behavior?

It's a bit a shame to replace well written ReactOS to Wine code with
broken style :-(.

On 25/10/2014 22:10, Ged Murphy wrote:
 Eeww, these are a bit ugly :(
 
 
 On 25/10/2014 19:30, akha...@svn.reactos.org akha...@svn.reactos.org
 wrote:
 
 Author: akhaldi
 Date: Sat Oct 25 18:30:05 2014
 New Revision: 64994

 URL: http://svn.reactos.org/svn/reactos?rev=64994view=rev
 Log:
 [ADVAPI32]
 * Update ImpersonateNamedPipeClient().
 CORE-8540

 Modified:
trunk/reactos/dll/win32/advapi32/wine/security.c

 Modified: trunk/reactos/dll/win32/advapi32/wine/security.c
 URL: 
 http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/advapi32/wine/s
 ecurity.c?rev=64994r1=64993r2=64994view=diff
 ==
 
 --- trunk/reactos/dll/win32/advapi32/wine/security.c [iso-8859-1]
 (original)
 +++ trunk/reactos/dll/win32/advapi32/wine/security.c [iso-8859-1] Sat Oct
 25 18:30:05 2014
 @@ -954,37 +954,14 @@
 return TRUE;
 }

 -/**
 - * ImpersonateNamedPipeClient   EXPORTED
 - *
 - * @implemented
 - */
 -BOOL
 -WINAPI
 -ImpersonateNamedPipeClient(HANDLE hNamedPipe)
 -{
 -IO_STATUS_BLOCK StatusBlock;
 -NTSTATUS Status;
 -
 -TRACE(ImpersonateNamedPipeClient() called\n);
 -
 -Status = NtFsControlFile(hNamedPipe,
 - NULL,
 - NULL,
 - NULL,
 - StatusBlock,
 - FSCTL_PIPE_IMPERSONATE,
 - NULL,
 - 0,
 - NULL,
 - 0);
 -if (!NT_SUCCESS(Status))
 -{
 -SetLastError(RtlNtStatusToDosError(Status));
 -return FALSE;
 -}
 -
 -return TRUE;
 +BOOL WINAPI ImpersonateNamedPipeClient( HANDLE hNamedPipe )
 +{
 +IO_STATUS_BLOCK io_block;
 +
 +TRACE((%p)\n, hNamedPipe);
 +
 +return set_ntstatus( NtFsControlFile(hNamedPipe, NULL, NULL, NULL,
 + io_block, FSCTL_PIPE_IMPERSONATE, NULL, 0,
 NULL, 0) );
 }

 /*


 
 
 
 ___
 Ros-dev mailing list
 Ros-dev@reactos.org
 http://www.reactos.org/mailman/listinfo/ros-dev
 


-- 
Pierre Schweitzer pierre at reactos.org
System  Network Administrator
Senior Kernel Developer
ReactOS Deutschland e.V.



smime.p7s
Description: S/MIME Cryptographic Signature
___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev