Re: [ros-dev] [ros-diffs] [pschweitzer] 66101: [CDMAKE] It's totally pointless to nullify after calloc

2015-01-28 Thread Pierre Schweitzer
It wasn't intended.
Then, if you want to rethink the usage of calloc and/or redundant code,
feel free.

On 29/01/2015 00:03, Timo Kreuzer wrote:
 
 This code change doesn't help to make the code more readable.
 
 
 Am 28.01.2015 um 21:41 schrieb pschweit...@svn.reactos.org:
 Author: pschweitzer
 Date: Wed Jan 28 20:41:23 2015
 New Revision: 66101

 URL: http://svn.reactos.org/svn/reactos?rev=66101view=rev
 Log:
 [CDMAKE]
 It's totally pointless to nullify after calloc

 Modified:
  trunk/reactos/tools/cdmake/dirhash.c

 Modified: trunk/reactos/tools/cdmake/dirhash.c
 URL:
 http://svn.reactos.org/svn/reactos/trunk/reactos/tools/cdmake/dirhash.c?rev=66101r1=66100r2=66101view=diff

 ==

 --- trunk/reactos/tools/cdmake/dirhash.c[iso-8859-1] (original)
 +++ trunk/reactos/tools/cdmake/dirhash.c[iso-8859-1] Wed Jan 28
 20:41:23 2015
 @@ -137,8 +137,6 @@
   free(parentcase);
 de = calloc(1, sizeof(*de));
 -de-head = NULL;
 -de-child = NULL;
   de-parent = parent_de;
   de-normalized_name = strdup(targetnorm);
   de-case_name = strdup(chop_filename(casename));



 
 
 
 
 ___
 Ros-dev mailing list
 Ros-dev@reactos.org
 http://www.reactos.org/mailman/listinfo/ros-dev
 


-- 
Pierre Schweitzer pierre at reactos.org
System  Network Administrator
Senior Kernel Developer
ReactOS Deutschland e.V.



smime.p7s
Description: S/MIME Cryptographic Signature
___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] [ros-diffs] [pschweitzer] 66101: [CDMAKE] It's totally pointless to nullify after calloc

2015-01-28 Thread Timo Kreuzer


This code change doesn't help to make the code more readable.


Am 28.01.2015 um 21:41 schrieb pschweit...@svn.reactos.org:

Author: pschweitzer
Date: Wed Jan 28 20:41:23 2015
New Revision: 66101

URL: http://svn.reactos.org/svn/reactos?rev=66101view=rev
Log:
[CDMAKE]
It's totally pointless to nullify after calloc

Modified:
 trunk/reactos/tools/cdmake/dirhash.c

Modified: trunk/reactos/tools/cdmake/dirhash.c
URL: 
http://svn.reactos.org/svn/reactos/trunk/reactos/tools/cdmake/dirhash.c?rev=66101r1=66100r2=66101view=diff
==
--- trunk/reactos/tools/cdmake/dirhash.c[iso-8859-1] (original)
+++ trunk/reactos/tools/cdmake/dirhash.c[iso-8859-1] Wed Jan 28 
20:41:23 2015
@@ -137,8 +137,6 @@
  free(parentcase);
  
  de = calloc(1, sizeof(*de));

-de-head = NULL;
-de-child = NULL;
  de-parent = parent_de;
  de-normalized_name = strdup(targetnorm);
  de-case_name = strdup(chop_filename(casename));








smime.p7s
Description: S/MIME Cryptographic Signature
___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev