Re: [ros-dev] ReactOS versioning
what about using this? internally maybe its necesary to move kernel goal to Windows 7 or even 8.1, but this way it would be much harder to get ReactOS stable at last. On Tue, Mar 10, 2015 at 2:27 PM, David Quintana (gigaherz) < gigah...@gmail.com> wrote: > SxS doesn't require links, it makes use of them to reduce the actual disk > usage. The conversation was about how many people "hate" the WinSxS folder > because when you look at the properties in explorer it shows a very large > number of GB, but fail to realize this number is not accurate due to the > large number of DLLs that are shared with System32. If we can't make use of > hardlinks, we can just copy the actual files. The HDD space used will grow, > but it's not like if our installation is 15gb... ;P > > On 10 March 2015 at 13:41, Pierre Schweitzer wrote: > >> I'm not sure you realize what you're praising. >> >> Links & junctions are not supported on FAT, they require NTFS. >> >> On 03/10/2015 12:37 PM, Huw Campbell wrote: >> > SxS uses hard links, not symlinks. >> > Seems like the way to go too, as we're already hitting the boundary >> with common controls and it's how windows does version compatibly. >> > Huw >> > >> > -Original Message- >> > From: "Ged Murphy" >> > Sent: 10/03/2015 10:27 PM >> > To: "'ReactOS Development List'" >> > Subject: Re: [ros-dev] ReactOS versioning >> > >> > It might also be useful to employ some form of heuristics as UAC does. >> Things like file name detection, string table detection, marked processes >> via user defined requests or a hash database, etc. Perhaps even scanning >> the imports (although this is harder to manage due to people using >> GetProcAddress to detect OS version) >> > >> > >> > -Original Message- >> > From: Ros-dev [mailto:ros-dev-boun...@reactos.org] On Behalf Of Timo >> Kreuzer >> > Sent: 07 March 2015 12:44 >> > To: ReactOS Development List >> > Subject: [ros-dev] ReactOS versioning >> > >> > >> > 1. We need a method to specify which application should be run in which >> environment. We should probably use the same mechanism that is used on >> Windows. Compatibility information is stored in a registry key >> HKCU\Software\Microsodt\Windows NT\CurrentVersion\AppCompatFlags\... The >> trick is to make this easy / transparent for the user. A right-click -> >> properties -> compatibility approach should for now probably be the easiest >> thing, >> > >> > >> > >> > ___ >> > Ros-dev mailing list >> > Ros-dev@reactos.org >> > http://www.reactos.org/mailman/listinfo/ros-dev >> > >> > >> > >> > ___ >> > Ros-dev mailing list >> > Ros-dev@reactos.org >> > http://www.reactos.org/mailman/listinfo/ros-dev >> > >> >> >> -- >> Pierre Schweitzer >> System & Network Administrator >> Senior Kernel Developer >> ReactOS Deutschland e.V. >> >> >> ___ >> Ros-dev mailing list >> Ros-dev@reactos.org >> http://www.reactos.org/mailman/listinfo/ros-dev >> > > > ___ > Ros-dev mailing list > Ros-dev@reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Re: [ros-dev] ReactOS versioning
SxS doesn't require links, it makes use of them to reduce the actual disk usage. The conversation was about how many people "hate" the WinSxS folder because when you look at the properties in explorer it shows a very large number of GB, but fail to realize this number is not accurate due to the large number of DLLs that are shared with System32. If we can't make use of hardlinks, we can just copy the actual files. The HDD space used will grow, but it's not like if our installation is 15gb... ;P On 10 March 2015 at 13:41, Pierre Schweitzer wrote: > I'm not sure you realize what you're praising. > > Links & junctions are not supported on FAT, they require NTFS. > > On 03/10/2015 12:37 PM, Huw Campbell wrote: > > SxS uses hard links, not symlinks. > > Seems like the way to go too, as we're already hitting the boundary with > common controls and it's how windows does version compatibly. > > Huw > > > > -Original Message- > > From: "Ged Murphy" > > Sent: 10/03/2015 10:27 PM > > To: "'ReactOS Development List'" > > Subject: Re: [ros-dev] ReactOS versioning > > > > It might also be useful to employ some form of heuristics as UAC does. > Things like file name detection, string table detection, marked processes > via user defined requests or a hash database, etc. Perhaps even scanning > the imports (although this is harder to manage due to people using > GetProcAddress to detect OS version) > > > > > > -Original Message- > > From: Ros-dev [mailto:ros-dev-boun...@reactos.org] On Behalf Of Timo > Kreuzer > > Sent: 07 March 2015 12:44 > > To: ReactOS Development List > > Subject: [ros-dev] ReactOS versioning > > > > > > 1. We need a method to specify which application should be run in which > environment. We should probably use the same mechanism that is used on > Windows. Compatibility information is stored in a registry key > HKCU\Software\Microsodt\Windows NT\CurrentVersion\AppCompatFlags\... The > trick is to make this easy / transparent for the user. A right-click -> > properties -> compatibility approach should for now probably be the easiest > thing, > > > > > > > > ___ > > Ros-dev mailing list > > Ros-dev@reactos.org > > http://www.reactos.org/mailman/listinfo/ros-dev > > > > > > > > ___ > > Ros-dev mailing list > > Ros-dev@reactos.org > > http://www.reactos.org/mailman/listinfo/ros-dev > > > > > -- > Pierre Schweitzer > System & Network Administrator > Senior Kernel Developer > ReactOS Deutschland e.V. > > > ___ > Ros-dev mailing list > Ros-dev@reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Re: [ros-dev] ReactOS versioning
I'm not sure you realize what you're praising. Links & junctions are not supported on FAT, they require NTFS. On 03/10/2015 12:37 PM, Huw Campbell wrote: > SxS uses hard links, not symlinks. > Seems like the way to go too, as we're already hitting the boundary with > common controls and it's how windows does version compatibly. > Huw > > -Original Message- > From: "Ged Murphy" > Sent: 10/03/2015 10:27 PM > To: "'ReactOS Development List'" > Subject: Re: [ros-dev] ReactOS versioning > > It might also be useful to employ some form of heuristics as UAC does. Things > like file name detection, string table detection, marked processes via user > defined requests or a hash database, etc. Perhaps even scanning the imports > (although this is harder to manage due to people using GetProcAddress to > detect OS version) > > > -Original Message- > From: Ros-dev [mailto:ros-dev-boun...@reactos.org] On Behalf Of Timo Kreuzer > Sent: 07 March 2015 12:44 > To: ReactOS Development List > Subject: [ros-dev] ReactOS versioning > > > 1. We need a method to specify which application should be run in which > environment. We should probably use the same mechanism that is used on > Windows. Compatibility information is stored in a registry key > HKCU\Software\Microsodt\Windows NT\CurrentVersion\AppCompatFlags\... The > trick is to make this easy / transparent for the user. A right-click -> > properties -> compatibility approach should for now probably be the easiest > thing, > > > > ___ > Ros-dev mailing list > Ros-dev@reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > > > > ___ > Ros-dev mailing list > Ros-dev@reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > -- Pierre Schweitzer System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V. smime.p7s Description: S/MIME Cryptographic Signature ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Re: [ros-dev] ReactOS versioning
SxS uses hard links, not symlinks. Seems like the way to go too, as we're already hitting the boundary with common controls and it's how windows does version compatibly. Huw -Original Message- From: "Ged Murphy" Sent: 10/03/2015 10:27 PM To: "'ReactOS Development List'" Subject: Re: [ros-dev] ReactOS versioning It might also be useful to employ some form of heuristics as UAC does. Things like file name detection, string table detection, marked processes via user defined requests or a hash database, etc. Perhaps even scanning the imports (although this is harder to manage due to people using GetProcAddress to detect OS version) -Original Message- From: Ros-dev [mailto:ros-dev-boun...@reactos.org] On Behalf Of Timo Kreuzer Sent: 07 March 2015 12:44 To: ReactOS Development List Subject: [ros-dev] ReactOS versioning 1. We need a method to specify which application should be run in which environment. We should probably use the same mechanism that is used on Windows. Compatibility information is stored in a registry key HKCU\Software\Microsodt\Windows NT\CurrentVersion\AppCompatFlags\... The trick is to make this easy / transparent for the user. A right-click -> properties -> compatibility approach should for now probably be the easiest thing, ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Re: [ros-dev] ReactOS versioning
It might also be useful to employ some form of heuristics as UAC does. Things like file name detection, string table detection, marked processes via user defined requests or a hash database, etc. Perhaps even scanning the imports (although this is harder to manage due to people using GetProcAddress to detect OS version) -Original Message- From: Ros-dev [mailto:ros-dev-boun...@reactos.org] On Behalf Of Timo Kreuzer Sent: 07 March 2015 12:44 To: ReactOS Development List Subject: [ros-dev] ReactOS versioning 1. We need a method to specify which application should be run in which environment. We should probably use the same mechanism that is used on Windows. Compatibility information is stored in a registry key HKCU\Software\Microsodt\Windows NT\CurrentVersion\AppCompatFlags\... The trick is to make this easy / transparent for the user. A right-click -> properties -> compatibility approach should for now probably be the easiest thing, ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Re: [ros-dev] [ros-diffs] [akhaldi] 66660: [ADVAPI32_WINETEST] Sync with Wine Staging 1.7.37. CORE-9246
On 2015-03-10 12:02, Amine Khaldi wrote: >> Why are we getting format warnings? Is __WINESRC__ not set correctly? > Hmm, it didn't help. Ah, PROCESS_ALL_ACCESS is the problem. We have access right constants defined with -L suffix. So yeah I think -Wno-format is the right solution for now. ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Re: [ros-dev] [ros-diffs] [akhaldi] 66660: [ADVAPI32_WINETEST] Sync with Wine Staging 1.7.37. CORE-9246
> Why are we getting format warnings? Is __WINESRC__ not set correctly? Hmm, it didn't help. ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Re: [ros-dev] [ros-diffs] [akhaldi] 66660: [ADVAPI32_WINETEST] Sync with Wine Staging 1.7.37. CORE-9246
On 2015-03-10 11:10, akha...@svn.reactos.org wrote: > +if(NOT MSVC) > +add_target_compile_flags(advapi32_winetest "-Wno-format") > +endif() Why are we getting format warnings? Is __WINESRC__ not set correctly? ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Re: [ros-dev] [ros-diffs] [akhaldi] 66658: [NTDLL_WINETEST] Sync with Wine Staging 1.7.37. CORE-9246
Hello Amine,
Although I agreed to sync our stuff with wine staging, I am not sure it
is a good idea to use their tests. My understanding is that patches
present in the wine staging tree implement missing features but did not
yet pass the wine quality requirement. Although it might be worth it for
modules, I'm not sure this is a good idea to include tests which were
not proven as good enough.
Simply put: I don't want to chase unexisting bugs just because we're
using a flaky test suite.
Regards
Jérôme
Le 10/03/2015 11:10, akha...@svn.reactos.org a écrit :
Author: akhaldi
Date: Tue Mar 10 10:10:04 2015
New Revision: 66658
URL: http://svn.reactos.org/svn/reactos?rev=66658&view=rev
Log:
[NTDLL_WINETEST] Sync with Wine Staging 1.7.37. CORE-9246
Modified:
trunk/rostests/winetests/ntdll/directory.c
trunk/rostests/winetests/ntdll/exception.c
trunk/rostests/winetests/ntdll/file.c
trunk/rostests/winetests/ntdll/info.c
trunk/rostests/winetests/ntdll/om.c
trunk/rostests/winetests/ntdll/reg.c
trunk/rostests/winetests/ntdll/rtl.c
trunk/rostests/winetests/ntdll/string.c
Modified: trunk/rostests/winetests/ntdll/directory.c
URL:
http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/ntdll/directory.c?rev=66658&r1=66657&r2=66658&view=diff
==
--- trunk/rostests/winetests/ntdll/directory.c [iso-8859-1] (original)
+++ trunk/rostests/winetests/ntdll/directory.c [iso-8859-1] Tue Mar 10
10:10:04 2015
@@ -51,7 +51,6 @@
/* The attribute sets to test */
static struct testfile_s {
-BOOL todo;/* set if it doesn't work on wine yet */
BOOL attr_done; /* set if attributes were tested for this file
already */
const DWORD attr; /* desired attribute */
const char *name; /* filename to use */
@@ -60,13 +59,13 @@
int nfound; /* How many were found (expect 1) */
WCHAR nameW[20]; /* unicode version of name (filled in later) */
} testfiles[] = {
-{ 0, 0, FILE_ATTRIBUTE_NORMAL,"n.tmp", NULL, "normal" },
-{ 1, 0, FILE_ATTRIBUTE_HIDDEN,"h.tmp", NULL, "hidden" },
-{ 1, 0, FILE_ATTRIBUTE_SYSTEM,"s.tmp", NULL, "system" },
-{ 0, 0, FILE_ATTRIBUTE_DIRECTORY, "d.tmp", NULL, "directory" },
-{ 0, 0, FILE_ATTRIBUTE_DIRECTORY, ".", NULL, ". directory" },
-{ 0, 0, FILE_ATTRIBUTE_DIRECTORY, "..",NULL, ".. directory" },
-{ 0, 0, 0, NULL }
+{ 0, FILE_ATTRIBUTE_NORMAL,"n.tmp", NULL, "normal" },
+{ 0, FILE_ATTRIBUTE_HIDDEN,"h.tmp", NULL, "hidden" },
+{ 0, FILE_ATTRIBUTE_SYSTEM,"s.tmp", NULL, "system" },
+{ 0, FILE_ATTRIBUTE_DIRECTORY, "d.tmp", NULL, "directory" },
+{ 0, FILE_ATTRIBUTE_DIRECTORY, ".", NULL, ". directory" },
+{ 0, FILE_ATTRIBUTE_DIRECTORY, "..",NULL, ".. directory" },
+{ 0, 0, NULL }
};
static const int max_test_dir_size = 20; /* size of above plus some for ..
etc */
@@ -147,12 +146,7 @@
if (namelen != len || memcmp(nameW, testfiles[i].nameW,
len*sizeof(WCHAR)))
continue;
if (!testfiles[i].attr_done) {
-if (testfiles[i].todo) {
-todo_wine
-ok (attrib == (testfiles[i].attr & attribmask), "file %s: expected
%s (%x), got %x (is your linux new enough?)\n", testfiles[i].name,
testfiles[i].description, testfiles[i].attr, attrib);
-} else {
-ok (attrib == (testfiles[i].attr & attribmask), "file %s: expected
%s (%x), got %x (is your linux new enough?)\n", testfiles[i].name,
testfiles[i].description, testfiles[i].attr, attrib);
-}
+ok (attrib == (testfiles[i].attr & attribmask), "file %s: expected %s
(%x), got %x (is your linux new enough?)\n", testfiles[i].name,
testfiles[i].description, testfiles[i].attr, attrib);
testfiles[i].attr_done = TRUE;
}
testfiles[i].nfound++;
Modified: trunk/rostests/winetests/ntdll/exception.c
URL:
http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/ntdll/exception.c?rev=66658&r1=66657&r2=66658&view=diff
==
--- trunk/rostests/winetests/ntdll/exception.c [iso-8859-1] (original)
+++ trunk/rostests/winetests/ntdll/exception.c [iso-8859-1] Tue Mar 10
10:10:04 2015
@@ -46,11 +46,14 @@
static PVOID (WINAPI *pRtlUnwind)(PVOID, PVOID, PEXCEPTION_RECORD, PVOID);
static PVOID (WINAPI *pRtlAddVectoredExceptionHandler)(ULONG first,
PVECTORED_EXCEPTION_HANDLER func);
static ULONG (WINAPI *pRtlRemoveVectoredExceptionHandler)(PVOID handler);
+static PVOID (WINAPI *pRtlAddVectoredContinueHandler)(ULONG first,
PVECTORED_EXCEPTION_HANDLER func);
+static ULONG (WINAPI *pRtlRemoveVectoredContinueHandler)(PVOID handler);
static NTSTATUS (WINAPI *pNtReadVirtualMemory)(HANDLE, const void*, void*,
SIZE_T, SIZE_T*);
Re: [ros-dev] [ros-diffs] [tkreuzer] 66636: [DDK/XDK] - Fix some prototypes in wdm.h (PMDLX -> PMDL) - Fix annotations for ExFreePool(WithTag)
On 2015-03-10 01:09, tkreu...@svn.reactos.org wrote: > --- trunk/reactos/include/xdk/exfuncs.h [iso-8859-1] (original) > +++ trunk/reactos/include/xdk/exfuncs.h [iso-8859-1] Tue Mar 10 > 00:09:20 2015 > @@ -606,14 +606,14 @@ > VOID > NTAPI > ExFreePool( > - _In_ __drv_freesMem(Mem) PVOID P); > + _Pre_not __drv_freesMem(Mem) PVOID P); > > _IRQL_requires_max_(DISPATCH_LEVEL) > NTKERNELAPI > VOID > NTAPI > ExFreePoolWithTag( > - _In_ __drv_freesMem(Mem) PVOID P, > + _Pre_not __drv_freesMem(Mem) PVOID P, >_In_ ULONG Tag); > > _IRQL_requires_max_(DISPATCH_LEVEL) Are these typos (missing "null_")? ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
