Re: [ros-dev] [ros-diffs] [hbelusca] 66903: [NTVDM] - Fix some english. - Validity checks for DosGetSftEntry returned pointer added. - Use unsigned indices for for-loops indices that are always positi
On 26.03.2015 18:56, Hermès BÉLUSCA - MAÏTO wrote: That's because I hesitate which DOS last error to return. I know that we have to specify one, but I need to recheck (and if Aleksander knows, he can fix that). H. Why don't you write so in the comment? Regards, Aleksey Bragin ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Re: [ros-dev] [ros-diffs] [hbelusca] 66903: [NTVDM] - Fix some english. - Validity checks for DosGetSftEntry returned pointer added. - Use unsigned indices for for-loops indices that are always positi
That's because I hesitate which DOS last error to return. I know that we have
to specify one, but I need to recheck (and if Aleksander knows, he can fix
that).
H.
-Message d'origine-
De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Pierre
Schweitzer
Envoyé : jeudi 26 mars 2015 16:21
À : ros-dev@reactos.org
Objet : Re: [ros-dev] [ros-diffs] [hbelusca] 66903: [NTVDM] - Fix some english.
- Validity checks for DosGetSftEntry returned pointer added. - Use unsigned
indices for for-loops indices that are always positive.
On 03/26/2015 03:52 PM, hbelu...@svn.reactos.org wrote:
> Modified: trunk/reactos/subsystems/mvdm/ntvdm/dos/dos32krnl/bios.c
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/mvdm/ntvdm
> /dos/dos32krnl/bios.c?rev=66903&r1=66902&r2=66903&view=diff
> ==
> --- trunk/reactos/subsystems/mvdm/ntvdm/dos/dos32krnl/bios.c [iso-8859-1]
> (original)
> +++ trunk/reactos/subsystems/mvdm/ntvdm/dos/dos32krnl/bios.c [iso-8859-1]
> Thu Mar 26 14:52:16 2015
> @@ -56,6 +56,13 @@
> BOOLEAN DosCheckInput(VOID)
> {
> PDOS_SFT_ENTRY SftEntry = DosGetSftEntry(DOS_INPUT_HANDLE);
> +
> +if (SftEntry == NULL)
> +{
> +/* Invalid handle */
> +DosLastError = ERROR_INVALID_HANDLE; // ERROR_FILE_NOT_FOUND
Hum... Why?
Is the error code wrong and should be ERROR_FILE_NOT_FOUND? And then, why
setting this other error code?
Or is the error code right, and then, what's the purpose of such comment?
Or do you have a doubt about the right error code to use? Be it one or the
other?
I come back to my eternal comment: don't comment for yourself. Comment for the
others, you're not alone here. So, make it explicit.
Cheers,
--
Pierre Schweitzer
System & Network Administrator
Senior Kernel Developer
ReactOS Deutschland e.V.
___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev
Re: [ros-dev] [ros-diffs] [hbelusca] 66903: [NTVDM] - Fix some english. - Validity checks for DosGetSftEntry returned pointer added. - Use unsigned indices for for-loops indices that are always positi
On 03/26/2015 03:52 PM, hbelu...@svn.reactos.org wrote:
> Modified: trunk/reactos/subsystems/mvdm/ntvdm/dos/dos32krnl/bios.c
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/mvdm/ntvdm/dos/dos32krnl/bios.c?rev=66903&r1=66902&r2=66903&view=diff
> ==
> --- trunk/reactos/subsystems/mvdm/ntvdm/dos/dos32krnl/bios.c [iso-8859-1]
> (original)
> +++ trunk/reactos/subsystems/mvdm/ntvdm/dos/dos32krnl/bios.c [iso-8859-1]
> Thu Mar 26 14:52:16 2015
> @@ -56,6 +56,13 @@
> BOOLEAN DosCheckInput(VOID)
> {
> PDOS_SFT_ENTRY SftEntry = DosGetSftEntry(DOS_INPUT_HANDLE);
> +
> +if (SftEntry == NULL)
> +{
> +/* Invalid handle */
> +DosLastError = ERROR_INVALID_HANDLE; // ERROR_FILE_NOT_FOUND
Hum... Why?
Is the error code wrong and should be ERROR_FILE_NOT_FOUND? And then,
why setting this other error code?
Or is the error code right, and then, what's the purpose of such comment?
Or do you have a doubt about the right error code to use? Be it one or
the other?
I come back to my eternal comment: don't comment for yourself. Comment
for the others, you're not alone here. So, make it explicit.
Cheers,
--
Pierre Schweitzer
System & Network Administrator
Senior Kernel Developer
ReactOS Deutschland e.V.
smime.p7s
Description: S/MIME Cryptographic Signature
___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev
Re: [ros-dev] Win2k3 end of life
-Message d'origine- De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Huw Campbell Envoyé : jeudi 26 mars 2015 12:33 À : ReactOS Development List Objet : [ros-dev] Win2k3 end of life > Hey, > Win2k3 is end of support in 6 months, which will mean that the symbol server will go down (as it has done for XP). > At the very least, we should scrape the symbol server so we can continue to check and debug. Anybody knows how to do that automatically? (of course there's still the possibility to download the (checked) symbols from Win2k3 SP2 from their symbols website, unless they want to also remove definitively the download). > Or move to NT6... It won't happen with magic (and within 6 months). Cheers, Hermès. ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Re: [ros-dev] Win2k3 end of life
http://en.wikipedia.org/wiki/Windows_Embedded_Industry Windows Embedded POSReady 2009 Based on Windows XP Service Pack 3, this version offers more features over Windows Embedded for Point of Service such as Full Localization and XPF Support if .NET Framework 3.5 or higher is installed.[16] Windows Embedded POSReady 2009 was released on December 9, 2008 Extended support ends on April 9, 2019 http://www.zdnet.com/article/registry-hack-enables-continued-updates-for-windows-xp/ A single registry setting makes Windows Update think your XP system is Windows XP POSReady, which will receive updates for another five years. 26.03.2015, 15:24, "Aleksey Bragin" :Hey,what about Windows XP "POS Ready"? It's still supported, and I suppose symbols should still be available?Regards,Aleksey BraginOn 26.03.2015 14:33, Huw Campbell wrote: Hey, Win2k3 is end of support in 6 months, which will mean that the symbol server will go down (as it has done for XP). At the very least, we should scrape the symbol server so we can continue to check and debug. Or move to NT6...___Ros-dev mailing listRos-dev@reactos.orghttp://www.reactos.org/mailman/listinfo/ros-dev -- Best regards, ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Re: [ros-dev] Win2k3 end of life
Hey, what about Windows XP "POS Ready"? It's still supported, and I suppose symbols should still be available? Regards, Aleksey Bragin On 26.03.2015 14:33, Huw Campbell wrote: Hey, Win2k3 is end of support in 6 months, which will mean that the symbol server will go down (as it has done for XP). At the very least, we should scrape the symbol server so we can continue to check and debug. Or move to NT6... ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
[ros-dev] Win2k3 end of life
Hey, Win2k3 is end of support in 6 months, which will mean that the symbol server will go down (as it has done for XP). At the very least, we should scrape the symbol server so we can continue to check and debug. Or move to NT6... ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
[ros-dev] Status Meeting (March 2015)
Hello, Let me invite you to the monthly status meeting taking place today 26th of March, 19:00 UTC, as always. IRC service will only be started shortly before the meeting. Your participation passwords and server address will be emailed to you shortly before the meeting starts, and they are going to be different once again as they are not stored in any database. Hopefully it's not much of inconvenience. If someone still is not getting passwords sent before a meeting - please email Pierre before the meeting started to get one. Please send agenda proposals to me before the meeting, so that we can start with a proposed agenda. And join Mumble! Regards, Aleksey Bragin ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Re: [ros-dev] [ros-diffs] [tkreuzer] 66893: [WIN32K] Rewrite brush code in C++
Timo and C++?? Hell must be a bit chilly today :) -Original Message- From: Ros-diffs [mailto:ros-diffs-boun...@reactos.org] On Behalf Of tkreu...@svn.reactos.org Sent: 25 March 2015 22:38 To: ros-di...@reactos.org Subject: [ros-diffs] [tkreuzer] 66893: [WIN32K] Rewrite brush code in C++ Author: tkreuzer Date: Wed Mar 25 22:38:20 2015 New Revision: 66893 URL: http://svn.reactos.org/svn/reactos?rev=66893&view=rev Log: [WIN32K] Rewrite brush code in C++ ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
