date:20150331

Re: [ros-dev] [ros-diffs] [tkreuzer] 65893: [GDI32] Import metafile code from wine. The wine code is unmodified (please keep it that way) and used through a wrapper function dispatcher and some helper

2015-03-31 Thread David Quintana (gigaherz)

Whoops I replied and THEN read the last line above... Nevermind this email.

On 1 April 2015 at 00:29, David Quintana (gigaherz)  wrote:
> Maybe we should send those fixes to wine-staging instead of actual wine?
>
> On 31 March 2015 at 22:39, Timo Kreuzer  wrote:
>> Am 31.03.2015 um 21:11 schrieb Thomas Faber:
>>>
>>> Hey Timo,
>>>
>>> I was just about to sync enhmetafile.c with Wine and found that your
>>> original import had the following diff:
>>> --- win32ss/gdi/gdi32/wine/enhmetafile.c(revision 67001)
>>> +++ win32ss/gdi/gdi32/wine/enhmetafile.c(working copy)
>>> @@ -546,8 +546,6 @@
>>> if (!SetWorldTransform(hdc, &final_trans))
>>>   {
>>> -__debugbreak();
>>> -SetWorldTransform(hdc, &final_trans);
>>
>> This was testing code, it should go.
>>
>>>   ERR("World transform failed!\n");
>>>   }
>>>   }
>>> @@ -1232,12 +1230,10 @@
>>>   case EMR_EXTSELECTCLIPRGN:
>>> {
>>> const EMREXTSELECTCLIPRGN *lpRgn = (const EMREXTSELECTCLIPRGN
>>> *)mr;
>>> -   const RGNDATA *pRgnData = (const RGNDATA *)lpRgn->RgnData;
>>> -   DWORD dwSize = sizeof(RGNDATAHEADER) + pRgnData->rdh.nCount *
>>> sizeof(RECT);
>>
>> This fix is important. ExtCreateRegion with size == 0 fails, if it is
>> properly implemented. I (or rather Amine) already sent a patch to wine. But
>> they first wanted a test that proves that this is correct, so I wrote them a
>> test, then they asked for this and that and I stopped caring. See
>> https://www.winehq.org/pipermail/wine-cvs/2014-November/103770.html and
>> https://www.winehq.org/pipermail/wine-patches/2014-November/135315.html
>> Amine might know if the actual fixes to this file and ExtCreateRegion have
>> been sent to wine as well.
>> We should just pass them to wine-staging.
>>
>>
>>
>>> HRGN hRgn = 0;
>>> if (mr->nSize >= sizeof(*lpRgn) + sizeof(RGNDATAHEADER))
>>> -hRgn = ExtCreateRegion( &info->init_transform, dwSize,
>>> pRgnData );
>>> +hRgn = ExtCreateRegion( &info->init_transform, 0, (const
>>> RGNDATA *)lpRgn->RgnData );
>>> ExtSelectClipRgn(hdc, hRgn, (INT)(lpRgn->iMode));
>>> /* ExtSelectClipRgn created a copy of the region */
>>>
>>> (this is the reverse diff, i.e. the one that would get it back in sync
>>>   with Wine)
>>>
>>> My guess is I should just remove this difference and get it completely
>>> synced (i.e. apply the above patch)? What do you think?
>>>
>>>
>>> On 2014-12-29 15:25, tkreu...@svn.reactos.org wrote:

 Author: tkreuzer
 Date: Mon Dec 29 14:25:30 2014
 New Revision: 65893

 URL: http://svn.reactos.org/svn/reactos?rev=65893&view=rev
 Log:
 [GDI32]
 Import metafile code from wine. The wine code is unmodified (please keep
 it that way) and used through a wrapper function dispatcher and some
 helpers. Fixes 1931 wine tests.

 Added:
  trunk/reactos/win32ss/gdi/gdi32/include/wine/   (with props)
  trunk/reactos/win32ss/gdi/gdi32/include/wine/gdi_driver.h   (with
 props)
  trunk/reactos/win32ss/gdi/gdi32/wine/   (with props)
  trunk/reactos/win32ss/gdi/gdi32/wine/CMakeLists.txt   (with props)
  trunk/reactos/win32ss/gdi/gdi32/wine/enhmetafile.c   (with props)
  trunk/reactos/win32ss/gdi/gdi32/wine/enhmfdrv/   (with props)
  trunk/reactos/win32ss/gdi/gdi32/wine/enhmfdrv/bitblt.c   (with
 props)
  trunk/reactos/win32ss/gdi/gdi32/wine/enhmfdrv/dc.c   (with props)
  trunk/reactos/win32ss/gdi/gdi32/wine/enhmfdrv/enhmetafiledrv.h
 (with props)
  trunk/reactos/win32ss/gdi/gdi32/wine/enhmfdrv/graphics.c   (with
 props)
  trunk/reactos/win32ss/gdi/gdi32/wine/enhmfdrv/init.c   (with props)
  trunk/reactos/win32ss/gdi/gdi32/wine/enhmfdrv/objects.c   (with
 props)
  trunk/reactos/win32ss/gdi/gdi32/wine/gdi_private.h   (with props)
  trunk/reactos/win32ss/gdi/gdi32/wine/metafile.c   (with props)
  trunk/reactos/win32ss/gdi/gdi32/wine/mfdrv/   (with props)
  trunk/reactos/win32ss/gdi/gdi32/wine/mfdrv/bitblt.c   (with props)
  trunk/reactos/win32ss/gdi/gdi32/wine/mfdrv/dc.c   (with props)
  trunk/reactos/win32ss/gdi/gdi32/wine/mfdrv/graphics.c   (with props)
  trunk/reactos/win32ss/gdi/gdi32/wine/mfdrv/init.c   (with props)
  trunk/reactos/win32ss/gdi/gdi32/wine/mfdrv/metafiledrv.h   (with
 props)
  trunk/reactos/win32ss/gdi/gdi32/wine/mfdrv/objects.c   (with props)
  trunk/reactos/win32ss/gdi/gdi32/wine/mfdrv/text.c   (with props)
  trunk/reactos/win32ss/gdi/gdi32/wine/rosglue.c   (with props)
 Modified:
  trunk/reactos/win32ss/gdi/gdi32/CMakeLists.txt
  trunk/reactos/win32ss/gdi/gdi32/include/gdi32p.h
  trunk/reactos/win32ss/gdi/gdi32/misc/misc.c
  trunk/reactos/win32ss/gdi/gdi32/objects/arc.c
  trunk/reactos/win32ss/gdi/gdi32/objects/bitm

Re: [ros-dev] [ros-diffs] [tkreuzer] 65893: [GDI32] Import metafile code from wine. The wine code is unmodified (please keep it that way) and used through a wrapper function dispatcher and some helper

2015-03-31 Thread David Quintana (gigaherz)

Maybe we should send those fixes to wine-staging instead of actual wine?

On 31 March 2015 at 22:39, Timo Kreuzer  wrote:
> Am 31.03.2015 um 21:11 schrieb Thomas Faber:
>>
>> Hey Timo,
>>
>> I was just about to sync enhmetafile.c with Wine and found that your
>> original import had the following diff:
>> --- win32ss/gdi/gdi32/wine/enhmetafile.c(revision 67001)
>> +++ win32ss/gdi/gdi32/wine/enhmetafile.c(working copy)
>> @@ -546,8 +546,6 @@
>> if (!SetWorldTransform(hdc, &final_trans))
>>   {
>> -__debugbreak();
>> -SetWorldTransform(hdc, &final_trans);
>
> This was testing code, it should go.
>
>>   ERR("World transform failed!\n");
>>   }
>>   }
>> @@ -1232,12 +1230,10 @@
>>   case EMR_EXTSELECTCLIPRGN:
>> {
>> const EMREXTSELECTCLIPRGN *lpRgn = (const EMREXTSELECTCLIPRGN
>> *)mr;
>> -   const RGNDATA *pRgnData = (const RGNDATA *)lpRgn->RgnData;
>> -   DWORD dwSize = sizeof(RGNDATAHEADER) + pRgnData->rdh.nCount *
>> sizeof(RECT);
>
> This fix is important. ExtCreateRegion with size == 0 fails, if it is
> properly implemented. I (or rather Amine) already sent a patch to wine. But
> they first wanted a test that proves that this is correct, so I wrote them a
> test, then they asked for this and that and I stopped caring. See
> https://www.winehq.org/pipermail/wine-cvs/2014-November/103770.html and
> https://www.winehq.org/pipermail/wine-patches/2014-November/135315.html
> Amine might know if the actual fixes to this file and ExtCreateRegion have
> been sent to wine as well.
> We should just pass them to wine-staging.
>
>
>
>> HRGN hRgn = 0;
>> if (mr->nSize >= sizeof(*lpRgn) + sizeof(RGNDATAHEADER))
>> -hRgn = ExtCreateRegion( &info->init_transform, dwSize,
>> pRgnData );
>> +hRgn = ExtCreateRegion( &info->init_transform, 0, (const
>> RGNDATA *)lpRgn->RgnData );
>> ExtSelectClipRgn(hdc, hRgn, (INT)(lpRgn->iMode));
>> /* ExtSelectClipRgn created a copy of the region */
>>
>> (this is the reverse diff, i.e. the one that would get it back in sync
>>   with Wine)
>>
>> My guess is I should just remove this difference and get it completely
>> synced (i.e. apply the above patch)? What do you think?
>>
>>
>> On 2014-12-29 15:25, tkreu...@svn.reactos.org wrote:
>>>
>>> Author: tkreuzer
>>> Date: Mon Dec 29 14:25:30 2014
>>> New Revision: 65893
>>>
>>> URL: http://svn.reactos.org/svn/reactos?rev=65893&view=rev
>>> Log:
>>> [GDI32]
>>> Import metafile code from wine. The wine code is unmodified (please keep
>>> it that way) and used through a wrapper function dispatcher and some
>>> helpers. Fixes 1931 wine tests.
>>>
>>> Added:
>>>  trunk/reactos/win32ss/gdi/gdi32/include/wine/   (with props)
>>>  trunk/reactos/win32ss/gdi/gdi32/include/wine/gdi_driver.h   (with
>>> props)
>>>  trunk/reactos/win32ss/gdi/gdi32/wine/   (with props)
>>>  trunk/reactos/win32ss/gdi/gdi32/wine/CMakeLists.txt   (with props)
>>>  trunk/reactos/win32ss/gdi/gdi32/wine/enhmetafile.c   (with props)
>>>  trunk/reactos/win32ss/gdi/gdi32/wine/enhmfdrv/   (with props)
>>>  trunk/reactos/win32ss/gdi/gdi32/wine/enhmfdrv/bitblt.c   (with
>>> props)
>>>  trunk/reactos/win32ss/gdi/gdi32/wine/enhmfdrv/dc.c   (with props)
>>>  trunk/reactos/win32ss/gdi/gdi32/wine/enhmfdrv/enhmetafiledrv.h
>>> (with props)
>>>  trunk/reactos/win32ss/gdi/gdi32/wine/enhmfdrv/graphics.c   (with
>>> props)
>>>  trunk/reactos/win32ss/gdi/gdi32/wine/enhmfdrv/init.c   (with props)
>>>  trunk/reactos/win32ss/gdi/gdi32/wine/enhmfdrv/objects.c   (with
>>> props)
>>>  trunk/reactos/win32ss/gdi/gdi32/wine/gdi_private.h   (with props)
>>>  trunk/reactos/win32ss/gdi/gdi32/wine/metafile.c   (with props)
>>>  trunk/reactos/win32ss/gdi/gdi32/wine/mfdrv/   (with props)
>>>  trunk/reactos/win32ss/gdi/gdi32/wine/mfdrv/bitblt.c   (with props)
>>>  trunk/reactos/win32ss/gdi/gdi32/wine/mfdrv/dc.c   (with props)
>>>  trunk/reactos/win32ss/gdi/gdi32/wine/mfdrv/graphics.c   (with props)
>>>  trunk/reactos/win32ss/gdi/gdi32/wine/mfdrv/init.c   (with props)
>>>  trunk/reactos/win32ss/gdi/gdi32/wine/mfdrv/metafiledrv.h   (with
>>> props)
>>>  trunk/reactos/win32ss/gdi/gdi32/wine/mfdrv/objects.c   (with props)
>>>  trunk/reactos/win32ss/gdi/gdi32/wine/mfdrv/text.c   (with props)
>>>  trunk/reactos/win32ss/gdi/gdi32/wine/rosglue.c   (with props)
>>> Modified:
>>>  trunk/reactos/win32ss/gdi/gdi32/CMakeLists.txt
>>>  trunk/reactos/win32ss/gdi/gdi32/include/gdi32p.h
>>>  trunk/reactos/win32ss/gdi/gdi32/misc/misc.c
>>>  trunk/reactos/win32ss/gdi/gdi32/objects/arc.c
>>>  trunk/reactos/win32ss/gdi/gdi32/objects/bitmap.c
>>>  trunk/reactos/win32ss/gdi/gdi32/objects/coord.c
>>>  trunk/reactos/win32ss/gdi/gdi32/objects/dc.c
>>>  trunk/reactos/win32ss/gdi/gdi32/objects/enhmfile.c
>>>  trunk/reactos/win32ss/gdi/gdi32/objects/gdiobj.c
>>>  trun

Re: [ros-dev] [ros-diffs] [tkreuzer] 65893: [GDI32] Import metafile code from wine. The wine code is unmodified (please keep it that way) and used through a wrapper function dispatcher and some helper

2015-03-31 Thread Timo Kreuzer


Am 31.03.2015 um 21:11 schrieb Thomas Faber:

Hey Timo,

I was just about to sync enhmetafile.c with Wine and found that your
original import had the following diff:
--- win32ss/gdi/gdi32/wine/enhmetafile.c(revision 67001)
+++ win32ss/gdi/gdi32/wine/enhmetafile.c(working copy)
@@ -546,8 +546,6 @@
  
  if (!SetWorldTransform(hdc, &final_trans))

  {
-__debugbreak();
-SetWorldTransform(hdc, &final_trans);

This was testing code, it should go.


  ERR("World transform failed!\n");
  }
  }
@@ -1232,12 +1230,10 @@
  case EMR_EXTSELECTCLIPRGN:
{
const EMREXTSELECTCLIPRGN *lpRgn = (const EMREXTSELECTCLIPRGN *)mr;
-   const RGNDATA *pRgnData = (const RGNDATA *)lpRgn->RgnData;
-   DWORD dwSize = sizeof(RGNDATAHEADER) + pRgnData->rdh.nCount * 
sizeof(RECT);
This fix is important. ExtCreateRegion with size == 0 fails, if it is 
properly implemented. I (or rather Amine) already sent a patch to wine. 
But they first wanted a test that proves that this is correct, so I 
wrote them a test, then they asked for this and that and I stopped 
caring. See 
https://www.winehq.org/pipermail/wine-cvs/2014-November/103770.html and

https://www.winehq.org/pipermail/wine-patches/2014-November/135315.html
Amine might know if the actual fixes to this file and ExtCreateRegion 
have been sent to wine as well.

We should just pass them to wine-staging.



HRGN hRgn = 0;
  
  if (mr->nSize >= sizeof(*lpRgn) + sizeof(RGNDATAHEADER))

-hRgn = ExtCreateRegion( &info->init_transform, dwSize, pRgnData );
+hRgn = ExtCreateRegion( &info->init_transform, 0, (const RGNDATA 
*)lpRgn->RgnData );
  
  	ExtSelectClipRgn(hdc, hRgn, (INT)(lpRgn->iMode));

/* ExtSelectClipRgn created a copy of the region */

(this is the reverse diff, i.e. the one that would get it back in sync
  with Wine)

My guess is I should just remove this difference and get it completely
synced (i.e. apply the above patch)? What do you think?


On 2014-12-29 15:25, tkreu...@svn.reactos.org wrote:

Author: tkreuzer
Date: Mon Dec 29 14:25:30 2014
New Revision: 65893

URL: http://svn.reactos.org/svn/reactos?rev=65893&view=rev
Log:
[GDI32]
Import metafile code from wine. The wine code is unmodified (please keep it 
that way) and used through a wrapper function dispatcher and some helpers. 
Fixes 1931 wine tests.

Added:
 trunk/reactos/win32ss/gdi/gdi32/include/wine/   (with props)
 trunk/reactos/win32ss/gdi/gdi32/include/wine/gdi_driver.h   (with props)
 trunk/reactos/win32ss/gdi/gdi32/wine/   (with props)
 trunk/reactos/win32ss/gdi/gdi32/wine/CMakeLists.txt   (with props)
 trunk/reactos/win32ss/gdi/gdi32/wine/enhmetafile.c   (with props)
 trunk/reactos/win32ss/gdi/gdi32/wine/enhmfdrv/   (with props)
 trunk/reactos/win32ss/gdi/gdi32/wine/enhmfdrv/bitblt.c   (with props)
 trunk/reactos/win32ss/gdi/gdi32/wine/enhmfdrv/dc.c   (with props)
 trunk/reactos/win32ss/gdi/gdi32/wine/enhmfdrv/enhmetafiledrv.h   (with 
props)
 trunk/reactos/win32ss/gdi/gdi32/wine/enhmfdrv/graphics.c   (with props)
 trunk/reactos/win32ss/gdi/gdi32/wine/enhmfdrv/init.c   (with props)
 trunk/reactos/win32ss/gdi/gdi32/wine/enhmfdrv/objects.c   (with props)
 trunk/reactos/win32ss/gdi/gdi32/wine/gdi_private.h   (with props)
 trunk/reactos/win32ss/gdi/gdi32/wine/metafile.c   (with props)
 trunk/reactos/win32ss/gdi/gdi32/wine/mfdrv/   (with props)
 trunk/reactos/win32ss/gdi/gdi32/wine/mfdrv/bitblt.c   (with props)
 trunk/reactos/win32ss/gdi/gdi32/wine/mfdrv/dc.c   (with props)
 trunk/reactos/win32ss/gdi/gdi32/wine/mfdrv/graphics.c   (with props)
 trunk/reactos/win32ss/gdi/gdi32/wine/mfdrv/init.c   (with props)
 trunk/reactos/win32ss/gdi/gdi32/wine/mfdrv/metafiledrv.h   (with props)
 trunk/reactos/win32ss/gdi/gdi32/wine/mfdrv/objects.c   (with props)
 trunk/reactos/win32ss/gdi/gdi32/wine/mfdrv/text.c   (with props)
 trunk/reactos/win32ss/gdi/gdi32/wine/rosglue.c   (with props)
Modified:
 trunk/reactos/win32ss/gdi/gdi32/CMakeLists.txt
 trunk/reactos/win32ss/gdi/gdi32/include/gdi32p.h
 trunk/reactos/win32ss/gdi/gdi32/misc/misc.c
 trunk/reactos/win32ss/gdi/gdi32/objects/arc.c
 trunk/reactos/win32ss/gdi/gdi32/objects/bitmap.c
 trunk/reactos/win32ss/gdi/gdi32/objects/coord.c
 trunk/reactos/win32ss/gdi/gdi32/objects/dc.c
 trunk/reactos/win32ss/gdi/gdi32/objects/enhmfile.c
 trunk/reactos/win32ss/gdi/gdi32/objects/gdiobj.c
 trunk/reactos/win32ss/gdi/gdi32/objects/metafile.c
 trunk/reactos/win32ss/gdi/gdi32/objects/painting.c
 trunk/reactos/win32ss/gdi/gdi32/objects/palette.c
 trunk/reactos/win32ss/gdi/gdi32/objects/path.c
 trunk/reactos/win32ss/gdi/gdi32/objects/region.c
 trunk/reactos/win32ss/gdi/gdi32/objects/text.c
 trunk/reactos/win32ss/include/ntgdihdl.h

[This mail would be too long, it was shortened to contain the URLs only.]

Modified: trunk/

Re: [ros-dev] [ros-diffs] [tkreuzer] 65893: [GDI32] Import metafile code from wine. The wine code is unmodified (please keep it that way) and used through a wrapper function dispatcher and some helper

2015-03-31 Thread Thomas Faber

Hey Timo,

I was just about to sync enhmetafile.c with Wine and found that your
original import had the following diff:
--- win32ss/gdi/gdi32/wine/enhmetafile.c(revision 67001)
+++ win32ss/gdi/gdi32/wine/enhmetafile.c(working copy)
@@ -546,8 +546,6 @@
 
 if (!SetWorldTransform(hdc, &final_trans))
 {
-__debugbreak();
-SetWorldTransform(hdc, &final_trans);
 ERR("World transform failed!\n");
 }
 }
@@ -1232,12 +1230,10 @@
 case EMR_EXTSELECTCLIPRGN:
   {
const EMREXTSELECTCLIPRGN *lpRgn = (const EMREXTSELECTCLIPRGN *)mr;
-   const RGNDATA *pRgnData = (const RGNDATA *)lpRgn->RgnData;
-   DWORD dwSize = sizeof(RGNDATAHEADER) + pRgnData->rdh.nCount * 
sizeof(RECT);
HRGN hRgn = 0;
 
 if (mr->nSize >= sizeof(*lpRgn) + sizeof(RGNDATAHEADER))
-hRgn = ExtCreateRegion( &info->init_transform, dwSize, pRgnData );
+hRgn = ExtCreateRegion( &info->init_transform, 0, (const RGNDATA 
*)lpRgn->RgnData );
 
ExtSelectClipRgn(hdc, hRgn, (INT)(lpRgn->iMode));
/* ExtSelectClipRgn created a copy of the region */

(this is the reverse diff, i.e. the one that would get it back in sync
 with Wine)

My guess is I should just remove this difference and get it completely
synced (i.e. apply the above patch)? What do you think?


On 2014-12-29 15:25, tkreu...@svn.reactos.org wrote:
> Author: tkreuzer
> Date: Mon Dec 29 14:25:30 2014
> New Revision: 65893
> 
> URL: http://svn.reactos.org/svn/reactos?rev=65893&view=rev
> Log:
> [GDI32]
> Import metafile code from wine. The wine code is unmodified (please keep it 
> that way) and used through a wrapper function dispatcher and some helpers. 
> Fixes 1931 wine tests.
> 
> Added:
> trunk/reactos/win32ss/gdi/gdi32/include/wine/   (with props)
> trunk/reactos/win32ss/gdi/gdi32/include/wine/gdi_driver.h   (with props)
> trunk/reactos/win32ss/gdi/gdi32/wine/   (with props)
> trunk/reactos/win32ss/gdi/gdi32/wine/CMakeLists.txt   (with props)
> trunk/reactos/win32ss/gdi/gdi32/wine/enhmetafile.c   (with props)
> trunk/reactos/win32ss/gdi/gdi32/wine/enhmfdrv/   (with props)
> trunk/reactos/win32ss/gdi/gdi32/wine/enhmfdrv/bitblt.c   (with props)
> trunk/reactos/win32ss/gdi/gdi32/wine/enhmfdrv/dc.c   (with props)
> trunk/reactos/win32ss/gdi/gdi32/wine/enhmfdrv/enhmetafiledrv.h   (with 
> props)
> trunk/reactos/win32ss/gdi/gdi32/wine/enhmfdrv/graphics.c   (with props)
> trunk/reactos/win32ss/gdi/gdi32/wine/enhmfdrv/init.c   (with props)
> trunk/reactos/win32ss/gdi/gdi32/wine/enhmfdrv/objects.c   (with props)
> trunk/reactos/win32ss/gdi/gdi32/wine/gdi_private.h   (with props)
> trunk/reactos/win32ss/gdi/gdi32/wine/metafile.c   (with props)
> trunk/reactos/win32ss/gdi/gdi32/wine/mfdrv/   (with props)
> trunk/reactos/win32ss/gdi/gdi32/wine/mfdrv/bitblt.c   (with props)
> trunk/reactos/win32ss/gdi/gdi32/wine/mfdrv/dc.c   (with props)
> trunk/reactos/win32ss/gdi/gdi32/wine/mfdrv/graphics.c   (with props)
> trunk/reactos/win32ss/gdi/gdi32/wine/mfdrv/init.c   (with props)
> trunk/reactos/win32ss/gdi/gdi32/wine/mfdrv/metafiledrv.h   (with props)
> trunk/reactos/win32ss/gdi/gdi32/wine/mfdrv/objects.c   (with props)
> trunk/reactos/win32ss/gdi/gdi32/wine/mfdrv/text.c   (with props)
> trunk/reactos/win32ss/gdi/gdi32/wine/rosglue.c   (with props)
> Modified:
> trunk/reactos/win32ss/gdi/gdi32/CMakeLists.txt
> trunk/reactos/win32ss/gdi/gdi32/include/gdi32p.h
> trunk/reactos/win32ss/gdi/gdi32/misc/misc.c
> trunk/reactos/win32ss/gdi/gdi32/objects/arc.c
> trunk/reactos/win32ss/gdi/gdi32/objects/bitmap.c
> trunk/reactos/win32ss/gdi/gdi32/objects/coord.c
> trunk/reactos/win32ss/gdi/gdi32/objects/dc.c
> trunk/reactos/win32ss/gdi/gdi32/objects/enhmfile.c
> trunk/reactos/win32ss/gdi/gdi32/objects/gdiobj.c
> trunk/reactos/win32ss/gdi/gdi32/objects/metafile.c
> trunk/reactos/win32ss/gdi/gdi32/objects/painting.c
> trunk/reactos/win32ss/gdi/gdi32/objects/palette.c
> trunk/reactos/win32ss/gdi/gdi32/objects/path.c
> trunk/reactos/win32ss/gdi/gdi32/objects/region.c
> trunk/reactos/win32ss/gdi/gdi32/objects/text.c
> trunk/reactos/win32ss/include/ntgdihdl.h
> 
> [This mail would be too long, it was shortened to contain the URLs only.]
> 
> Modified: trunk/reactos/win32ss/gdi/gdi32/CMakeLists.txt
> URL: 
> http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/gdi32/CMakeLists.txt?rev=65893&r1=65892&r2=65893&view=diff
> 
> Modified: trunk/reactos/win32ss/gdi/gdi32/include/gdi32p.h
> URL: 
> http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/gdi32/include/gdi32p.h?rev=65893&r1=65892&r2=65893&view=diff
> 
> Added: trunk/reactos/win32ss/gdi/gdi32/include/wine/gdi_driver.h
> URL: 
> http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/gdi32/include/wine/gdi_driver.h?rev=65893
> 
> Modified: trunk/reactos/win32ss/gdi/gdi32/misc/misc.c
>

Re: [ros-dev] [ros-diffs] [gadamopoulos] 66988: [EXPLORER] - Fix showing the website when Help is selected from the start menu.

2015-03-31 Thread Pierre Schweitzer

Just a side (minor) remark.

On 31/03/2015 00:28, gadamopou...@svn.reactos.org wrote:
> Modified: trunk/reactos/base/shell/explorer/explorer.rc
> URL: 
> http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/explorer/explorer.rc?rev=66988&r1=66987&r2=66988&view=diff
> ==
> --- trunk/reactos/base/shell/explorer/explorer.rc [iso-8859-1] (original)
> +++ trunk/reactos/base/shell/explorer/explorer.rc [iso-8859-1] Mon Mar 30 
> 22:28:08 2015
> @@ -28,7 +28,7 @@
>  STRINGTABLE
>  BEGIN
>  //IDS_HELP_COMMAND "helpctr.exe>-FromStartHelp"
> -IDS_HELP_COMMAND "https://www.reactos.org/";
> +IDS_HELP_COMMAND "http://www.reactos.org/";

This is to be reverted once ReactOS fully supports SSL.

-- 
Pierre Schweitzer 
System & Network Administrator
Senior Kernel Developer
ReactOS Deutschland e.V.



smime.p7s
Description: S/MIME Cryptographic Signature
___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] [ros-diffs] [tkreuzer] 65893: [GDI32] Import metafile code from wine. The wine code is unmodified (please keep it that way) and used through a wrapper function dispatcher and some helper

Re: [ros-dev] [ros-diffs] [tkreuzer] 65893: [GDI32] Import metafile code from wine. The wine code is unmodified (please keep it that way) and used through a wrapper function dispatcher and some helper

Re: [ros-dev] [ros-diffs] [tkreuzer] 65893: [GDI32] Import metafile code from wine. The wine code is unmodified (please keep it that way) and used through a wrapper function dispatcher and some helper

Re: [ros-dev] [ros-diffs] [tkreuzer] 65893: [GDI32] Import metafile code from wine. The wine code is unmodified (please keep it that way) and used through a wrapper function dispatcher and some helper

Re: [ros-dev] [ros-diffs] [gadamopoulos] 66988: [EXPLORER] - Fix showing the website when Help is selected from the start menu.

5 matches

Site Navigation

Mail list logo

Footer information