Re: [ros-dev] [ros-diffs] [spetreolle] 69186: [TRANSLATIONS] Translate remaining French strings in msgina.dll

2015-09-14 Thread Pierre Schweitzer 
"Voyez (avec) votre administrateur système" sounds too "spoken" French.

I'd really be in favour of something more... "written". Consultez,
contactez, whatever.

On 09/14/2015 12:43 PM, Hermès BÉLUSCA - MAÏTO wrote:
> Hi all !
> 
>  
> 
> De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Sylvain 
> Petreolle
> Envoyé : lundi 14 septembre 2015 11:36
> À : ReactOS Development List
> Objet : Re: [ros-dev] [ros-diffs] [spetreolle] 69186: [TRANSLATIONS] 
> Translate remaining French strings in msgina.dll
> 
>  
> 
>> +IDS_LOGONUSERDISABLED "Votre compte est désactivé. Voyez votre 
>> administrateur système."
> 
>> Consultez votre ?
> 
> In this case we should change the english line too, unless this is a false 
> friend :
> 
>> -IDS_LOGONUSERDISABLED "Your account has been disabled. Please see your 
>> system administrator."
> 
> Voyez avec votre administrateur système ?
> 
>  
> 
> I confirm what Pierre says, in proper french we say « Consultez votre 
> administrateur système » ; in english “please see” can be said. I would not 
> say it is a false friend, but better proper translation; indeed when you 
> translate from language X to language Y you are not obliged to do 
> word-by-word translation if you know that in language Y there is another way 
> to say the same thing (eg. If you see “when pigs will fly” you won’t 
> translate by “quand les cochons voleront” in French, but instead you’ll say 
> “quand les poules auront des dents”).
> 
>  
> 
> [...]
> 
>  
> 
> Kind regards, 
> 
>  
> 
> Sylvain Petreolle
> 
>  
> 
> Cheers,
> 
> Hermès
> 
>  
> 
> (and the obligatory :
> 
> “Sent by my spying MS Outlook” :P)
> 
>  
> 
>   _  
> 
> De : Pierre Schweitzer 
> À : ros-dev@reactos.org 
> Envoyé le : Vendredi 11 septembre 2015 22h05
> Objet : Re: [ros-dev] [ros-diffs] [spetreolle] 69186: [TRANSLATIONS] 
> Translate remaining French strings in msgina.dll
> 
>  
> 
>  
> 
> 
> Comments inline.
> 
> On 11/09/2015 21:30, spetreo...@svn.reactos.org wrote:
>> URL: 
>> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msgina/lang/fr-FR.rc?rev=69186
>>  
>> 
>>  =69185=69186=diff
>> ==
>>
>>
>> ___
>> Ros-dev mailing list
>> Ros-dev@reactos.org
>> http://www.reactos.org/mailman/listinfo/ros-dev


-- 
Pierre Schweitzer 
System & Network Administrator
Senior Kernel Developer
ReactOS Deutschland e.V.



smime.p7s
Description: S/MIME Cryptographic Signature
___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] [ros-diffs] [spetreolle] 69186: [TRANSLATIONS] Translate remaining French strings in msgina.dll

2015-09-14 Thread Hermès BÉLUSCA - MAÏTO 
"Veuillez contacter votre administrateur système."

H.

-Message d'origine-
De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Pierre
Schweitzer
Envoyé : lundi 14 septembre 2015 13:03
À : ros-dev@reactos.org
Objet : Re: [ros-dev] [ros-diffs] [spetreolle] 69186: [TRANSLATIONS]
Translate remaining French strings in msgina.dll

"Voyez (avec) votre administrateur système" sounds too "spoken" French.

I'd really be in favour of something more... "written". Consultez,
contactez, whatever.

On 09/14/2015 12:43 PM, Hermès BÉLUSCA - MAÏTO wrote:
> Hi all !
> 
>  
> 
> De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de 
> Sylvain Petreolle Envoyé : lundi 14 septembre 2015 11:36 À : ReactOS 
> Development List Objet : Re: [ros-dev] [ros-diffs] [spetreolle] 69186: 
> [TRANSLATIONS] Translate remaining French strings in msgina.dll
> 
>  
> 
>> +IDS_LOGONUSERDISABLED "Votre compte est désactivé. Voyez votre
administrateur système."
> 
>> Consultez votre ?
> 
> In this case we should change the english line too, unless this is a false
friend :
> 
>> -IDS_LOGONUSERDISABLED "Your account has been disabled. Please see
your system administrator."
> 
> Voyez avec votre administrateur système ?
> 
>  
> 
> I confirm what Pierre says, in proper french we say « Consultez votre
administrateur système » ; in english “please see” can be said. I would not
say it is a false friend, but better proper translation; indeed when you
translate from language X to language Y you are not obliged to do
word-by-word translation if you know that in language Y there is another way
to say the same thing (eg. If you see “when pigs will fly” you won’t
translate by “quand les cochons voleront” in French, but instead you’ll say
“quand les poules auront des dents”).
> 
>  
> 
> [...]
> 
>  
> 
> Kind regards,
> 
>  
> 
> Sylvain Petreolle
> 
>  
> 
> Cheers,
> 
> Hermès
> 
>  
> 
> (and the obligatory :
> 
> “Sent by my spying MS Outlook” :P)
> 
>  
> 
>   _
> 
> De : Pierre Schweitzer  À : ros-dev@reactos.org 
> Envoyé le : Vendredi 11 septembre 2015 22h05 Objet : Re: [ros-dev] 
> [ros-diffs] [spetreolle] 69186: [TRANSLATIONS] Translate remaining 
> French strings in msgina.dll
> 
>  
> 
>  
> 
> 
> Comments inline.
> 
> On 11/09/2015 21:30, spetreo...@svn.reactos.org wrote:
>> URL: 
>> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msgina/lan
>> g/fr-FR.rc?rev=69186 
>> > ng/fr-FR.rc?rev=69186=69185=69186=diff> 
>> =69185=69186=diff 
>> =
>> =
>>
>>
>> ___
>> Ros-dev mailing list
>> Ros-dev@reactos.org
>> http://www.reactos.org/mailman/listinfo/ros-dev


--
Pierre Schweitzer 
System & Network Administrator
Senior Kernel Developer
ReactOS Deutschland e.V.


___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] [ros-diffs] [spetreolle] 69186: [TRANSLATIONS] Translate remaining French strings in msgina.dll

2015-09-14 Thread Hermès BÉLUSCA - MAÏTO 
Hi all !

 

De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Sylvain 
Petreolle
Envoyé : lundi 14 septembre 2015 11:36
À : ReactOS Development List
Objet : Re: [ros-dev] [ros-diffs] [spetreolle] 69186: [TRANSLATIONS] Translate 
remaining French strings in msgina.dll

 

> +IDS_LOGONUSERDISABLED "Votre compte est désactivé. Voyez votre 
> administrateur système."

>Consultez votre ?

In this case we should change the english line too, unless this is a false 
friend :

> -IDS_LOGONUSERDISABLED "Your account has been disabled. Please see your 
> system administrator."

Voyez avec votre administrateur système ?

 

I confirm what Pierre says, in proper french we say « Consultez votre 
administrateur système » ; in english “please see” can be said. I would not say 
it is a false friend, but better proper translation; indeed when you translate 
from language X to language Y you are not obliged to do word-by-word 
translation if you know that in language Y there is another way to say the same 
thing (eg. If you see “when pigs will fly” you won’t translate by “quand les 
cochons voleront” in French, but instead you’ll say “quand les poules auront 
des dents”).

 

[...]

 

Kind regards, 

 

Sylvain Petreolle

 

Cheers,

Hermès

 

(and the obligatory :

“Sent by my spying MS Outlook” :P)

 

  _  

De : Pierre Schweitzer 
À : ros-dev@reactos.org 
Envoyé le : Vendredi 11 septembre 2015 22h05
Objet : Re: [ros-dev] [ros-diffs] [spetreolle] 69186: [TRANSLATIONS] Translate 
remaining French strings in msgina.dll

 

 


Comments inline.

On 11/09/2015 21:30, spetreo...@svn.reactos.org wrote:
> URL: 
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msgina/lang/fr-FR.rc?rev=69186
>  
> 
>  =69185=69186=diff
> ==
-- 
Pierre Schweitzer 
System & Network Administrator
Senior Kernel Developer
ReactOS Deutschland e.V.

___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev

___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] [ros-diffs] [pschweitzer] 69221: [MOUNTMGR] Implement the IOCTL IOCTL_MOUNTMGR_VOLUME_MOUNT_POINT_CREATED: - Implement WriteRemoteDatabaseEntry() - Implement MountMgrVolumeMountPointCrea

2015-09-14 Thread Pierre Schweitzer 
Refering to CVE-2015-1769/MS15-085?

On 14/09/2015 05:24, Alex Ionescu wrote:
> Lol, make sure not to implement the huge vulnerability Microsoft patched
> two months ago (win2k->xp-style database migration).
> 
> Best regards,
> Alex Ionescu
> 
> On Sun, Sep 13, 2015 at 6:52 PM,  wrote:
> 
>> Author: pschweitzer
>> Date: Sun Sep 13 22:52:07 2015
>> New Revision: 69221
>>
>> URL: http://svn.reactos.org/svn/reactos?rev=69221=rev
>> Log:
>> [MOUNTMGR]
>> Implement the IOCTL IOCTL_MOUNTMGR_VOLUME_MOUNT_POINT_CREATED:
>> - Implement WriteRemoteDatabaseEntry()
>> - Implement MountMgrVolumeMountPointCreated()
>>
>> Modified:
>> trunk/reactos/drivers/filters/mountmgr/database.c
>> trunk/reactos/drivers/filters/mountmgr/device.c
>> trunk/reactos/drivers/filters/mountmgr/mntmgr.h
>> trunk/reactos/drivers/filters/mountmgr/mountmgr.c
>>
>> Modified: trunk/reactos/drivers/filters/mountmgr/database.c
>> URL:
>> http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filters/mountmgr/database.c?rev=69221=69220=69221=diff
>>
>> ==
>> --- trunk/reactos/drivers/filters/mountmgr/database.c   [iso-8859-1]
>> (original)
>> +++ trunk/reactos/drivers/filters/mountmgr/database.c   [iso-8859-1] Sun
>> Sep 13 22:52:07 2015
>> @@ -192,6 +192,39 @@
>>  }
>>
>>  return Entry;
>> +}
>> +
>> +/*
>> + * @implemented
>> + */
>> +NTSTATUS
>> +WriteRemoteDatabaseEntry(IN HANDLE Database,
>> + IN LONG Offset,
>> + IN PDATABASE_ENTRY Entry)
>> +{
>> +NTSTATUS Status;
>> +LARGE_INTEGER ByteOffset;
>> +IO_STATUS_BLOCK IoStatusBlock;
>> +
>> +ByteOffset.QuadPart = Offset;
>> +Status = ZwWriteFile(Database,
>> + NULL,
>> + NULL,
>> + NULL,
>> + ,
>> + Entry,
>> + Entry->EntrySize,
>> + ,
>> + NULL);
>> +if (NT_SUCCESS(Status))
>> +{
>> +if (IoStatusBlock.Information < Entry->EntrySize)
>> +{
>> +Status = STATUS_INSUFFICIENT_RESOURCES;
>> +}
>> +}
>> +
>> +return Status;
>>  }
>>
>>  /*
>>
>> Modified: trunk/reactos/drivers/filters/mountmgr/device.c
>> URL:
>> http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filters/mountmgr/device.c?rev=69221=69220=69221=diff
>>
>> ==
>> --- trunk/reactos/drivers/filters/mountmgr/device.c [iso-8859-1]
>> (original)
>> +++ trunk/reactos/drivers/filters/mountmgr/device.c [iso-8859-1] Sun
>> Sep 13 22:52:07 2015
>> @@ -1688,15 +1688,242 @@
>>  return Status;
>>  }
>>
>> +/*
>> + * @implemented
>> + */
>>  NTSTATUS
>>  MountMgrVolumeMountPointCreated(IN PDEVICE_EXTENSION DeviceExtension,
>>  IN PIRP Irp,
>>  IN NTSTATUS LockStatus)
>>  {
>> -UNREFERENCED_PARAMETER(DeviceExtension);
>> -UNREFERENCED_PARAMETER(Irp);
>> -UNREFERENCED_PARAMETER(LockStatus);
>> -return STATUS_NOT_IMPLEMENTED;
>> +LONG Offset;
>> +BOOLEAN Found;
>> +NTSTATUS Status;
>> +HANDLE RemoteDatabase;
>> +PMOUNTDEV_UNIQUE_ID UniqueId;
>> +PDATABASE_ENTRY DatabaseEntry;
>> +PASSOCIATED_DEVICE_ENTRY AssociatedEntry;
>> +PDEVICE_INFORMATION DeviceInformation, TargetDeviceInformation;
>> +UNICODE_STRING LinkTarget, SourceDeviceName, SourceSymbolicName,
>> TargetVolumeName, VolumeName, DbName;
>> +
>> +/* Initialize string */
>> +LinkTarget.Length = 0;
>> +LinkTarget.MaximumLength = 0xC8;
>> +LinkTarget.Buffer = AllocatePool(LinkTarget.MaximumLength);
>> +if (LinkTarget.Buffer == NULL)
>> +{
>> +return STATUS_INSUFFICIENT_RESOURCES;
>> +}
>> +
>> +/* If the mount point was created, then, it changed!
>> + * Also use it to query some information
>> + */
>> +Status = MountMgrVolumeMountPointChanged(DeviceExtension, Irp,
>> LockStatus, , , );
>> +/* Pending means DB are under synchronization, bail out */
>> +if (Status == STATUS_PENDING)
>> +{
>> +FreePool(LinkTarget.Buffer);
>> +FreePool(SourceDeviceName.Buffer);
>> +FreePool(SourceSymbolicName.Buffer);
>> +return STATUS_PENDING;
>> +}
>> +else if (!NT_SUCCESS(Status))
>> +{
>> +FreePool(LinkTarget.Buffer);
>> +return Status;
>> +}
>> +
>> +/* Query the device information */
>> +Status = FindDeviceInfo(DeviceExtension, , FALSE,
>> );
>> +if (!NT_SUCCESS(Status))
>> +{
>> +/* If it failed, first try to get volume name */
>> +Status = QueryVolumeName(0, NULL, , ,
>> );
>> +if (!NT_SUCCESS(Status))
>> +{
>> +/* Then, try to read the symlink */
>> +Status =

Re: [ros-dev] [ros-diffs] [spetreolle] 69186: [TRANSLATIONS] Translate remaining French strings in msgina.dll

2015-09-14 Thread Sylvain Petreolle 
> French typography requires a space before and after ':'Agreed, but one 
> comment for all the broken space changes would have been enough. :)
> +    IDS_LOGONUSERDISABLED "Votre compte est désactivé. Voyez votre 
> administrateur système.">Consultez votre ?In this case we should change the 
> english line too, unless this is a false friend :> -    IDS_LOGONUSERDISABLED 
> "Your account has been disabled. Please see your system administrator."Voyez 
> avec votre administrateur système ?

>On 11/09/2015 21:30, spetreo...@svn.reactos.org wrote: 
These email address don't exist.


Kind regards, 

Sylvain Petreolle
  De : Pierre Schweitzer 
 À : ros-dev@reactos.org 
 Envoyé le : Vendredi 11 septembre 2015 22h05
 Objet : Re: [ros-dev] [ros-diffs] [spetreolle] 69186: [TRANSLATIONS] Translate 
remaining French strings in msgina.dll


   
Comments inline.

On 11/09/2015 21:30, spetreo...@svn.reactos.org wrote:
> URL: 
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msgina/lang/fr-FR.rc?rev=69186=69185=69186=diff
> ==
-- 
Pierre Schweitzer 
System & Network Administrator
Senior Kernel Developer
ReactOS Deutschland e.V.

___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev

  ___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] [ros-diffs] [pschweitzer] 69221: [MOUNTMGR] Implement the IOCTL IOCTL_MOUNTMGR_VOLUME_MOUNT_POINT_CREATED: - Implement WriteRemoteDatabaseEntry() - Implement MountMgrVolumeMountPointCrea

2015-09-14 Thread Ameer Ali 
u can implement thisit is wonderful

On Mon, Sep 14, 2015 at 8:54 AM, Alex Ionescu  wrote:

> Lol, make sure not to implement the huge vulnerability Microsoft patched
> two months ago (win2k->xp-style database migration).
>
> Best regards,
> Alex Ionescu
>
> On Sun, Sep 13, 2015 at 6:52 PM,  wrote:
>
>> Author: pschweitzer
>> Date: Sun Sep 13 22:52:07 2015
>> New Revision: 69221
>>
>> URL: http://svn.reactos.org/svn/reactos?rev=69221=rev
>> Log:
>> [MOUNTMGR]
>> Implement the IOCTL IOCTL_MOUNTMGR_VOLUME_MOUNT_POINT_CREATED:
>> - Implement WriteRemoteDatabaseEntry()
>> - Implement MountMgrVolumeMountPointCreated()
>>
>> Modified:
>> trunk/reactos/drivers/filters/mountmgr/database.c
>> trunk/reactos/drivers/filters/mountmgr/device.c
>> trunk/reactos/drivers/filters/mountmgr/mntmgr.h
>> trunk/reactos/drivers/filters/mountmgr/mountmgr.c
>>
>> Modified: trunk/reactos/drivers/filters/mountmgr/database.c
>> URL:
>> http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filters/mountmgr/database.c?rev=69221=69220=69221=diff
>>
>> ==
>> --- trunk/reactos/drivers/filters/mountmgr/database.c   [iso-8859-1]
>> (original)
>> +++ trunk/reactos/drivers/filters/mountmgr/database.c   [iso-8859-1] Sun
>> Sep 13 22:52:07 2015
>> @@ -192,6 +192,39 @@
>>  }
>>
>>  return Entry;
>> +}
>> +
>> +/*
>> + * @implemented
>> + */
>> +NTSTATUS
>> +WriteRemoteDatabaseEntry(IN HANDLE Database,
>> + IN LONG Offset,
>> + IN PDATABASE_ENTRY Entry)
>> +{
>> +NTSTATUS Status;
>> +LARGE_INTEGER ByteOffset;
>> +IO_STATUS_BLOCK IoStatusBlock;
>> +
>> +ByteOffset.QuadPart = Offset;
>> +Status = ZwWriteFile(Database,
>> + NULL,
>> + NULL,
>> + NULL,
>> + ,
>> + Entry,
>> + Entry->EntrySize,
>> + ,
>> + NULL);
>> +if (NT_SUCCESS(Status))
>> +{
>> +if (IoStatusBlock.Information < Entry->EntrySize)
>> +{
>> +Status = STATUS_INSUFFICIENT_RESOURCES;
>> +}
>> +}
>> +
>> +return Status;
>>  }
>>
>>  /*
>>
>> Modified: trunk/reactos/drivers/filters/mountmgr/device.c
>> URL:
>> http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filters/mountmgr/device.c?rev=69221=69220=69221=diff
>>
>> ==
>> --- trunk/reactos/drivers/filters/mountmgr/device.c [iso-8859-1]
>> (original)
>> +++ trunk/reactos/drivers/filters/mountmgr/device.c [iso-8859-1] Sun
>> Sep 13 22:52:07 2015
>> @@ -1688,15 +1688,242 @@
>>  return Status;
>>  }
>>
>> +/*
>> + * @implemented
>> + */
>>  NTSTATUS
>>  MountMgrVolumeMountPointCreated(IN PDEVICE_EXTENSION DeviceExtension,
>>  IN PIRP Irp,
>>  IN NTSTATUS LockStatus)
>>  {
>> -UNREFERENCED_PARAMETER(DeviceExtension);
>> -UNREFERENCED_PARAMETER(Irp);
>> -UNREFERENCED_PARAMETER(LockStatus);
>> -return STATUS_NOT_IMPLEMENTED;
>> +LONG Offset;
>> +BOOLEAN Found;
>> +NTSTATUS Status;
>> +HANDLE RemoteDatabase;
>> +PMOUNTDEV_UNIQUE_ID UniqueId;
>> +PDATABASE_ENTRY DatabaseEntry;
>> +PASSOCIATED_DEVICE_ENTRY AssociatedEntry;
>> +PDEVICE_INFORMATION DeviceInformation, TargetDeviceInformation;
>> +UNICODE_STRING LinkTarget, SourceDeviceName, SourceSymbolicName,
>> TargetVolumeName, VolumeName, DbName;
>> +
>> +/* Initialize string */
>> +LinkTarget.Length = 0;
>> +LinkTarget.MaximumLength = 0xC8;
>> +LinkTarget.Buffer = AllocatePool(LinkTarget.MaximumLength);
>> +if (LinkTarget.Buffer == NULL)
>> +{
>> +return STATUS_INSUFFICIENT_RESOURCES;
>> +}
>> +
>> +/* If the mount point was created, then, it changed!
>> + * Also use it to query some information
>> + */
>> +Status = MountMgrVolumeMountPointChanged(DeviceExtension, Irp,
>> LockStatus, , , );
>> +/* Pending means DB are under synchronization, bail out */
>> +if (Status == STATUS_PENDING)
>> +{
>> +FreePool(LinkTarget.Buffer);
>> +FreePool(SourceDeviceName.Buffer);
>> +FreePool(SourceSymbolicName.Buffer);
>> +return STATUS_PENDING;
>> +}
>> +else if (!NT_SUCCESS(Status))
>> +{
>> +FreePool(LinkTarget.Buffer);
>> +return Status;
>> +}
>> +
>> +/* Query the device information */
>> +Status = FindDeviceInfo(DeviceExtension, , FALSE,
>> );
>> +if (!NT_SUCCESS(Status))
>> +{
>> +/* If it failed, first try to get volume name */
>> +Status = QueryVolumeName(0, NULL, ,
>> , );
>> +if (!NT_SUCCESS(Status))
>> +{
>> +/* Then, try to read the symlink */
>>