Re: [ros-dev] [ros-diffs] [hbelusca] 70857: [USETUP]: In case chkdsk detects some disk errors, just display a warning message but allow the user to continue the installation.

2016-03-01 Thread Pierre Schweitzer
No?!
This is totally broken and is to be reverted.

If you detect errors, there are only 3 issues:
- Offer the user to attempt to repair errors
- Offer the user to format
- Exit (as it was done previously)

(If repairing fails, you fall into the two next cases).
You cannot ignore errors and let the use write on a borked file system.

Le 02/03/2016 01:51, hbelu...@svn.reactos.org a écrit :
> Author: hbelusca
> Date: Wed Mar  2 00:51:48 2016
> New Revision: 70857
> 
> URL: http://svn.reactos.org/svn/reactos?rev=70857=rev
> Log:
> [USETUP]: In case chkdsk detects some disk errors, just display a warning 
> message but allow the user to continue the installation.
> 
> Modified:
> trunk/reactos/base/setup/usetup/interface/usetup.c
> trunk/reactos/base/setup/usetup/lang/bg-BG.h
> trunk/reactos/base/setup/usetup/lang/bn-BD.h
> trunk/reactos/base/setup/usetup/lang/cs-CZ.h
> trunk/reactos/base/setup/usetup/lang/da-DK.h
> trunk/reactos/base/setup/usetup/lang/de-DE.h
> trunk/reactos/base/setup/usetup/lang/el-GR.h
> trunk/reactos/base/setup/usetup/lang/en-US.h
> trunk/reactos/base/setup/usetup/lang/es-ES.h
> trunk/reactos/base/setup/usetup/lang/et-EE.h
> trunk/reactos/base/setup/usetup/lang/fr-FR.h
> trunk/reactos/base/setup/usetup/lang/he-IL.h
> trunk/reactos/base/setup/usetup/lang/it-IT.h
> trunk/reactos/base/setup/usetup/lang/ja-JP.h
> trunk/reactos/base/setup/usetup/lang/lt-LT.h
> trunk/reactos/base/setup/usetup/lang/ms-MY.h
> trunk/reactos/base/setup/usetup/lang/nl-NL.h
> trunk/reactos/base/setup/usetup/lang/pl-PL.h
> trunk/reactos/base/setup/usetup/lang/pt-BR.h
> trunk/reactos/base/setup/usetup/lang/ro-RO.h
> trunk/reactos/base/setup/usetup/lang/ru-RU.h
> trunk/reactos/base/setup/usetup/lang/sk-SK.h
> trunk/reactos/base/setup/usetup/lang/sq-AL.h
> trunk/reactos/base/setup/usetup/lang/sv-SE.h
> trunk/reactos/base/setup/usetup/lang/tr-TR.h
> trunk/reactos/base/setup/usetup/lang/uk-UA.h
> trunk/reactos/base/setup/usetup/mui.h
> 
> Modified: trunk/reactos/base/setup/usetup/interface/usetup.c
> URL: 
> http://svn.reactos.org/svn/reactos/trunk/reactos/base/setup/usetup/interface/usetup.c?rev=70857=70856=70857=diff
> ==
> --- trunk/reactos/base/setup/usetup/interface/usetup.c[iso-8859-1] 
> (original)
> +++ trunk/reactos/base/setup/usetup/interface/usetup.c[iso-8859-1] 
> Wed Mar  2 00:51:48 2016
> @@ -3154,13 +3154,15 @@
>  if (!NT_SUCCESS(Status))
>  {
>  DPRINT("ChkdskPartition() failed with status 0x%08lx\n", Status);
> -sprintf(Buffer, "Setup failed to verify the selected 
> partition.\n"
> +// sprintf(Buffer, "Setup failed to verify the selected 
> partition.\n"
> +sprintf(Buffer, "ChkDsk detected some disk errors.\n"
>  "(Status 0x%08lx).\n", Status);
>  PopupError(Buffer,
> -   MUIGetString(STRING_REBOOTCOMPUTER),
> +   // MUIGetString(STRING_REBOOTCOMPUTER),
> +   MUIGetString(STRING_CONTINUE),
> Ir, POPUP_WAIT_ENTER);
>  
> -return QUIT_PAGE;
> +// return QUIT_PAGE;
>  }
>  
>  PartEntry->NeedsCheck = FALSE;
> 
> Modified: trunk/reactos/base/setup/usetup/lang/bg-BG.h
> URL: 
> http://svn.reactos.org/svn/reactos/trunk/reactos/base/setup/usetup/lang/bg-BG.h?rev=70857=70856=70857=diff
> ==
> --- trunk/reactos/base/setup/usetup/lang/bg-BG.h  [iso-8859-1] (original)
> +++ trunk/reactos/base/setup/usetup/lang/bg-BG.h  [iso-8859-1] Wed Mar  2 
> 00:51:48 2016
> @@ -1758,6 +1758,8 @@
>  "‘« £ ­¥ ­  ¥ ªâŽ‘ ¢êàåã ¤ï«"},
>  {STRING_CHECKINGPART,
>  "’¥ç¥ ¯à®¢¥àª  ­  ¨§¡à ­¨ï ¤ï«."},
> +{STRING_CONTINUE,
> +"ENTER = à®¤ê«¦ ¢ ­¥"},
>  {STRING_QUITCONTINUE,
>  "F3 = ˆ§å®¤  ENTER = à®¤ê«¦ ¢ ­¥"},
>  {STRING_REBOOTCOMPUTER,
> 
> Modified: trunk/reactos/base/setup/usetup/lang/bn-BD.h
> URL: 
> http://svn.reactos.org/svn/reactos/trunk/reactos/base/setup/usetup/lang/bn-BD.h?rev=70857=70856=70857=diff
> ==
> --- trunk/reactos/base/setup/usetup/lang/bn-BD.h  [iso-8859-1] (original)
> +++ trunk/reactos/base/setup/usetup/lang/bn-BD.h  [iso-8859-1] Wed Mar  2 
> 00:51:48 2016
> @@ -1743,6 +1743,8 @@
>  "Setup installs ReactOS onto Partition"},
>  {STRING_CHECKINGPART,
>  "Setup is now checking the selected partition."},
> +{STRING_CONTINUE,
> +"ENTER = Continue"},
>  {STRING_QUITCONTINUE,
>  "F3 = Quit  ENTER = Continue"},
>  {STRING_REBOOTCOMPUTER,
> 
> Modified: trunk/reactos/base/setup/usetup/lang/cs-CZ.h
> URL: 
> 

Re: [ros-dev] [GSOC] NTFS driver improvements

2016-03-01 Thread Amine Khaldi

Hi Pratik,

I am Pratik Singhal, a 3rd year undergraduate student studying 
Computer Science studying in BITS-Pilani, Goa Campus, India.
I want to pursue the project NTFS Driver Improvement project as a part 
of Google summer of code 2016.


Nice to meet you, and welcome to ReactOS!

We will have to figure out concrete goals of the project, full term 
and mid term deliverable and a plan for completion of project, if it 
is to be selected for Google summer of Code.


As per 
https://summerofcode.withgoogle.com/organizations/6324900541235200/ this 
is a recommended part of student proposals as it contributes to their 
quality and allows us to assess and evaluate better. Please consider 
figuring out this part.


The 'References' section of this GSoC idea 
(https://www.reactos.org/wiki/Google_Summer_of_Code_2016_Ideas#NTFS_driver_improvements) 
should give you pointers and help you learn and prepare for your 
proposal. Good luck!


Cheers,
Amine.

___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev


[ros-dev] [GSOC] NTFS driver improvements

2016-03-01 Thread Pratik Singhal
Hello all,
I am Pratik Singhal, a 3rd year undergraduate student studying Computer
Science studying in BITS-Pilani, Goa Campus, India.
I want to pursue the project NTFS Driver Improvement project as a part of
Google summer of code 2016.

I have previously participated in Google summer of Code 2015 for FreeBSD
operating system and have done some kernel hacking before.(
https://wiki.freebsd.org/SummerOfCode2015/CubieBoardSupport)
I have also made a mini operating system of my own.

I am sure, that the experience I gained while previously for FreeBSD  will
certainly help me in understanding the ReactOS code base quickly which will
be useful for the project.  I don't have any significant experience on
working with file systems before, but I am confident that with some
guidance from fellow developers  I will be able to learn new things which
will help in  completion of the project.  Also, I haven't had any access to
Windows source code , so that shouldn't be a problem.

We will have to figure out concrete goals of the project, full term and mid
term deliverable and a plan for completion of project, if it is to be
selected for Google summer of Code.

It'll be great if somebody, could mentor me for this project.

Thanks,
Pratik Singhal
___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev