Re: [ros-dev] [ros-diffs] [hbelusca] 70857: [USETUP]: In case chkdsk detects some disk errors, just display a warning message but allow the user to continue the installation.

2016-03-02 Thread Pierre Schweitzer 
Then fix FastFAT so that it updates statistics and don't put hazardous
hacks into Usetup.
Will be greatly appreciated :-).

As a side note, it seems that our vfatlib is already able to fix errors.
I believe it can already fix a wrong free clusters count.

It's actually funny it's raised as an error, IIRC, free clusters count
is not mandatory and cannot even be trusted by drivers.

Le 02/03/2016 10:14, Hermès BÉLUSCA - MAÏTO a écrit :
> Thanks Pierre for your ideas. I will modify the message box to try to 
> integrate those options.
> At the moment we are (in usetup) limited, so repairing the errors will be 
> done later. The rest can be implemented easily.
> The fact is that the only error that happens as soon as you write files using 
> ReactOS' fastfat driver is that fastfat doesn't update the "free cluster 
> number" field in the FSInfo sector of FAT32 disk.
> Because of that, each time you try to reinstall ReactOS without formatting on 
> such a partition, you get the checkdisk complaining that this number is wrong 
> & needs to be corrected, but then the VfatChkdsk returns a non-success error 
> that is interpreted by Usetup as a failure (and the error message appears, 
> forbidding the user to continue nevertheless to install ROS).
> 
> Cheers,
> Hermès
> 
> -Message d'origine-
> De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Pierre 
> Schweitzer
> Envoyé : mercredi 2 mars 2016 08:47
> À : ros-dev@reactos.org
> Objet : Re: [ros-dev] [ros-diffs] [hbelusca] 70857: [USETUP]: In case chkdsk 
> detects some disk errors, just display a warning message but allow the user 
> to continue the installation.
> 
> No?!
> This is totally broken and is to be reverted.
> 
> If you detect errors, there are only 3 issues:
> - Offer the user to attempt to repair errors
> - Offer the user to format
> - Exit (as it was done previously)
> 
> (If repairing fails, you fall into the two next cases).
> You cannot ignore errors and let the use write on a borked file system.
> 
> Le 02/03/2016 01:51, hbelu...@svn.reactos.org a écrit :
>> Author: hbelusca
>> Date: Wed Mar  2 00:51:48 2016
>> New Revision: 70857
>>
>> URL: http://svn.reactos.org/svn/reactos?rev=70857=rev
>> Log:
>> [USETUP]: In case chkdsk detects some disk errors, just display a warning 
>> message but allow the user to continue the installation.
>>
>> Modified:
>> trunk/reactos/base/setup/usetup/interface/usetup.c
>> trunk/reactos/base/setup/usetup/lang/bg-BG.h
>> trunk/reactos/base/setup/usetup/lang/bn-BD.h
>> trunk/reactos/base/setup/usetup/lang/cs-CZ.h
>> trunk/reactos/base/setup/usetup/lang/da-DK.h
>> trunk/reactos/base/setup/usetup/lang/de-DE.h
>> trunk/reactos/base/setup/usetup/lang/el-GR.h
>> trunk/reactos/base/setup/usetup/lang/en-US.h
>> trunk/reactos/base/setup/usetup/lang/es-ES.h
>> trunk/reactos/base/setup/usetup/lang/et-EE.h
>> trunk/reactos/base/setup/usetup/lang/fr-FR.h
>> trunk/reactos/base/setup/usetup/lang/he-IL.h
>> trunk/reactos/base/setup/usetup/lang/it-IT.h
>> trunk/reactos/base/setup/usetup/lang/ja-JP.h
>> trunk/reactos/base/setup/usetup/lang/lt-LT.h
>> trunk/reactos/base/setup/usetup/lang/ms-MY.h
>> trunk/reactos/base/setup/usetup/lang/nl-NL.h
>> trunk/reactos/base/setup/usetup/lang/pl-PL.h
>> trunk/reactos/base/setup/usetup/lang/pt-BR.h
>> trunk/reactos/base/setup/usetup/lang/ro-RO.h
>> trunk/reactos/base/setup/usetup/lang/ru-RU.h
>> trunk/reactos/base/setup/usetup/lang/sk-SK.h
>> trunk/reactos/base/setup/usetup/lang/sq-AL.h
>> trunk/reactos/base/setup/usetup/lang/sv-SE.h
>> trunk/reactos/base/setup/usetup/lang/tr-TR.h
>> trunk/reactos/base/setup/usetup/lang/uk-UA.h
>> trunk/reactos/base/setup/usetup/mui.h
>>
>> Modified: trunk/reactos/base/setup/usetup/interface/usetup.c
>> URL: 
>> http://svn.reactos.org/svn/reactos/trunk/reactos/base/setup/usetup/int
>> erface/usetup.c?rev=70857=70856=70857=diff
>> ==
>> --- trunk/reactos/base/setup/usetup/interface/usetup.c   [iso-8859-1] 
>> (original)
>> +++ trunk/reactos/base/setup/usetup/interface/usetup.c   [iso-8859-1] 
>> Wed Mar  2 00:51:48 2016
>> @@ -3154,13 +3154,15 @@
>>  if (!NT_SUCCESS(Status))
>>  {
>>  DPRINT("ChkdskPartition() failed with status 0x%08lx\n", 
>> Status);
>> -sprintf(Buffer, "Setup failed to verify the selected 
>> partition.\n"
>> +// sprintf(Buffer, "Setup failed to verify the selected 
>> partition.\n"
>> +sprintf(Buffer, "ChkDsk detected some disk errors.\n"
>>  "(Status 0x%08lx).\n", Status);
>>  PopupError(Buffer,
>> -   MUIGetString(STRING_REBOOTCOMPUTER),
>> +   // MUIGetString(STRING_REBOOTCOMPUTER),
>> +   MUIGetString(STRING_CONTINUE),
>> Ir, POPUP_WAIT_ENTER);
>>

Re: [ros-dev] GSOC 2016 - SSH Service Project

2016-03-02 Thread Oliver Schneider 
Perhaps have a look at 
which is Microsoft's effort at porting OpenSSH so that it can work with
PowerShell. (They are reusing what NoMachine had done before them.)

AFAIK they culled most of the OpenSSL functions in order to replace it
with Windows crypto, but since the argument of that being proprietary
would not hold in ReactOS, you could possibly use the ReactOS crypto
straight.

Otherwise, from what I know, you can re-enable the use of OpenSSL in it.

// Oliver

On 2016-03-02 17:18, Ged Murphy wrote:
> Why do we want an SSH server in the source?
> 
> If someone wants to run an SSH server, they can download and install one
> as they would do on Windows.
> 
>  
> 
>  
> 
> *From:*Ros-dev [mailto:ros-dev-boun...@reactos.org] *On Behalf Of
> *Zachary Gorden
> *Sent:* 02 March 2016 16:58
> *To:* ReactOS Development List 
> *Subject:* Re: [ros-dev] GSOC 2016 - SSH Service Project
> 
>  
> 
> Any SSH server developed for ReactOS would need to be written in C/C++
> and be compilable by both GCC and VC++. So while the expectation is that
> a developer would likely need to pull a SSH library from an existing
> source such as OpenSSH, the server itself will almost certainly need to
> be written from scratch if only because there does not exist as far as I
> am aware of a fully open source SSH server that runs natively on Windows
> without hauling around the likes of cygwin. Apache Mina is written in
> Java and therefore would be inappropriate as a starting base for the SSH
> server project.
> 
>  
> 
> On Wed, Mar 2, 2016 at 5:30 AM, Anchit Jain  > wrote:
> 
> Hello everyone,
> 
> I am Anchit Jain, Computer Science undergraduate from BITS PILANI,
> India. 
> I am interested in pursuing SSH Service project.
> 
>  
> 
> I have some experience in Socket Programming and Network Protocol
> development in C. Some of my work could be seen
> at https://github.com/anchitjain1234
> 
> .
> 
> In past, I have implemented some basic network services like TFTP
> protocol and some minor part of FTP client. 
> 
>  
> 
> Regarding the project :- Would this project require a new SSH Server
> to be written from scratch or to be build upon some existing
> codebase like Apache Mina etc.?
> 
>  
> 
> I would request potential mentors to guide me for the same.
> 
>  
> 
>  
> 
> Thanks,
> 
> Anchit Jain
> 
> 
> Image removed by sender.
> 
> 
> ___
> Ros-dev mailing list
> Ros-dev@reactos.org 
> http://www.reactos.org/mailman/listinfo/ros-dev
> 
>  
> 
> 
> 
> ___
> Ros-dev mailing list
> Ros-dev@reactos.org
> http://www.reactos.org/mailman/listinfo/ros-dev
> 

___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] GSOC 2016 - SSH Service Project

2016-03-02 Thread Denis Cardon 

Hi Zachary,

Le 02/03/2016 17:58, Zachary Gorden a écrit :

Any SSH server developed for ReactOS would need to be written in C/C++
and be compilable by both GCC and VC++. So while the expectation is that
a developer would likely need to pull a SSH library from an existing
source such as OpenSSH, the server itself will almost certainly need to
be written from scratch if only because there does not exist as far as I
am aware of a fully open source SSH server that runs natively on Windows
without hauling around the likes of cygwin. Apache Mina is written in
Java and therefore would be inappropriate as a starting base for the SSH
server project.


actually there is a project at microsoft for porting openssh on windows 
as a native process. I think it come from the NX/Nomachine code base:


https://github.com/PowerShell/Win32-OpenSSH

It does compile and install without cygwin are a prerequisite, however 
it is not yet production ready.


About the next post of Ged, there seems to be a plan for MS to add a ssh 
server in their distribution : 
https://blogs.msdn.microsoft.com/powershell/2015/06/03/looking-forward-microsoft-support-for-secure-shell-ssh/


Cheers,

Denis




On Wed, Mar 2, 2016 at 5:30 AM, Anchit Jain > wrote:

Hello everyone,
I am Anchit Jain, Computer Science undergraduate from BITS PILANI,
India.
I am interested in pursuing SSH Service project.

I have some experience in Socket Programming and Network Protocol
development in C. Some of my work could be seen at
https://github.com/anchitjain1234

.
In past, I have implemented some basic network services like TFTP
protocol and some minor part of FTP client.

Regarding the project :- Would this project require a new SSH Server
to be written from scratch or to be build upon some existing
codebase like Apache Mina etc.?

I would request potential mentors to guide me for the same.


Thanks,
Anchit Jain


___
Ros-dev mailing list
Ros-dev@reactos.org 
http://www.reactos.org/mailman/listinfo/ros-dev




___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev



--
Denis Cardon
Tranquil IT Systems
Les Espaces Jules Verne, bâtiment A
12 avenue Jules Verne
44230 Saint Sébastien sur Loire
tel : +33 (0) 2.40.97.57.55
http://www.tranquil-it-systems.fr


___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] GSOC 2016 - SSH Service Project

2016-03-02 Thread Ged Murphy 
Why do we want an SSH server in the source?

If someone wants to run an SSH server, they can download and install one as 
they would do on Windows.

 

 

From: Ros-dev [mailto:ros-dev-boun...@reactos.org] On Behalf Of Zachary Gorden
Sent: 02 March 2016 16:58
To: ReactOS Development List 
Subject: Re: [ros-dev] GSOC 2016 - SSH Service Project

 

Any SSH server developed for ReactOS would need to be written in C/C++ and be 
compilable by both GCC and VC++. So while the expectation is that a developer 
would likely need to pull a SSH library from an existing source such as 
OpenSSH, the server itself will almost certainly need to be written from 
scratch if only because there does not exist as far as I am aware of a fully 
open source SSH server that runs natively on Windows without hauling around the 
likes of cygwin. Apache Mina is written in Java and therefore would be 
inappropriate as a starting base for the SSH server project.

 

On Wed, Mar 2, 2016 at 5:30 AM, Anchit Jain  > wrote:

Hello everyone,

I am Anchit Jain, Computer Science undergraduate from BITS PILANI, India. 
I am interested in pursuing SSH Service project.

 

I have some experience in Socket Programming and Network Protocol development 
in C. Some of my work could be seen at  

 https://github.com/anchitjain1234.

In past, I have implemented some basic network services like TFTP protocol and 
some minor part of FTP client. 

 

Regarding the project :- Would this project require a new SSH Server to be 
written from scratch or to be build upon some existing codebase like Apache 
Mina etc.?

 

I would request potential mentors to guide me for the same.

 

 

Thanks,

Anchit Jain





___
Ros-dev mailing list
Ros-dev@reactos.org  
http://www.reactos.org/mailman/listinfo/ros-dev

 

___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev

[ros-dev] TR: [ros-diffs] [hbelusca] 70857: [USETUP]: In case chkdsk detects some disk errors, just display a warning message but allow the user to continue the installation.

2016-03-02 Thread Hermès BÉLUSCA - MAÏTO 
(Message resent because the other one was automatically rejected because it was 
too large).

-Message d'origine-
De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Hermès BÉLUSCA 
- MAÏTO
Envoyé : mercredi 2 mars 2016 10:14
À : 'ReactOS Development List'
Objet : Re: [ros-dev] [ros-diffs] [hbelusca] 70857: [USETUP]: In case chkdsk 
detects some disk errors, just display a warning message but allow the user to 
continue the installation.

Thanks Pierre for your ideas. I will modify the message box to try to integrate 
those options.
At the moment we are (in usetup) limited, so repairing the errors will be done 
later. The rest can be implemented easily.
The fact is that the only error that happens as soon as you write files using 
ReactOS' fastfat driver is that fastfat doesn't update the "free cluster 
number" field in the FSInfo sector of FAT32 disk.
Because of that, each time you try to reinstall ReactOS without formatting on 
such a partition, you get the checkdisk complaining that this number is wrong & 
needs to be corrected, but then the VfatChkdsk returns a non-success error that 
is interpreted by Usetup as a failure (and the error message appears, 
forbidding the user to continue nevertheless to install ROS).

Cheers,
Hermès

-Message d'origine-
De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Pierre 
Schweitzer Envoyé : mercredi 2 mars 2016 08:47 À : ros-dev@reactos.org Objet : 
Re: [ros-dev] [ros-diffs] [hbelusca] 70857: [USETUP]: In case chkdsk detects 
some disk errors, just display a warning message but allow the user to continue 
the installation.

No?!
This is totally broken and is to be reverted.

If you detect errors, there are only 3 issues:
- Offer the user to attempt to repair errors
- Offer the user to format
- Exit (as it was done previously)

(If repairing fails, you fall into the two next cases).
You cannot ignore errors and let the use write on a borked file system.


___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev

[ros-dev] GSOC 2016 - SSH Service Project

2016-03-02 Thread Anchit Jain 
Hello everyone,

I am Anchit Jain, Computer Science undergraduate from BITS PILANI, India.  
I am interested in pursuing SSH Service project.

  

I have some experience in Socket Programming and Network Protocol development
in C. Some of my work could be seen at [https://github.com/anchitjain1234](htt
ps://link.nylas.com/link/ezhvubksgc7dhi29sglp2mpvq/7af2e7b30ed04821b97b5daf768
9e7a5/0?redirect=https%3A%2F%2Fgithub.com%2Fanchitjain1234).

In past, I have implemented some basic network services like TFTP protocol and
some minor part of FTP client.

  

Regarding the project :- Would this project require a new SSH Server to be
written from scratch or to be build upon some existing codebase like Apache
Mina etc.?

  

I would request potential mentors to guide me for the same.

  

  

Thanks,

Anchit Jain  

  
![](https://link.nylas.com/open/ezhvubksgc7dhi29sglp2mpvq/b6c19abbf9d6411eb72c
8562b4b783ce)

___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] [ros-diffs] [hbelusca] 70857: [USETUP]: In case chkdsk detects some disk errors, just display a warning message but allow the user to continue the installation.

2016-03-02 Thread Hermès BÉLUSCA - MAÏTO 
Thanks Pierre for your ideas. I will modify the message box to try to integrate 
those options.
At the moment we are (in usetup) limited, so repairing the errors will be done 
later. The rest can be implemented easily.
The fact is that the only error that happens as soon as you write files using 
ReactOS' fastfat driver is that fastfat doesn't update the "free cluster 
number" field in the FSInfo sector of FAT32 disk.
Because of that, each time you try to reinstall ReactOS without formatting on 
such a partition, you get the checkdisk complaining that this number is wrong & 
needs to be corrected, but then the VfatChkdsk returns a non-success error that 
is interpreted by Usetup as a failure (and the error message appears, 
forbidding the user to continue nevertheless to install ROS).

Cheers,
Hermès

-Message d'origine-
De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Pierre 
Schweitzer
Envoyé : mercredi 2 mars 2016 08:47
À : ros-dev@reactos.org
Objet : Re: [ros-dev] [ros-diffs] [hbelusca] 70857: [USETUP]: In case chkdsk 
detects some disk errors, just display a warning message but allow the user to 
continue the installation.

No?!
This is totally broken and is to be reverted.

If you detect errors, there are only 3 issues:
- Offer the user to attempt to repair errors
- Offer the user to format
- Exit (as it was done previously)

(If repairing fails, you fall into the two next cases).
You cannot ignore errors and let the use write on a borked file system.

Le 02/03/2016 01:51, hbelu...@svn.reactos.org a écrit :
> Author: hbelusca
> Date: Wed Mar  2 00:51:48 2016
> New Revision: 70857
> 
> URL: http://svn.reactos.org/svn/reactos?rev=70857=rev
> Log:
> [USETUP]: In case chkdsk detects some disk errors, just display a warning 
> message but allow the user to continue the installation.
> 
> Modified:
> trunk/reactos/base/setup/usetup/interface/usetup.c
> trunk/reactos/base/setup/usetup/lang/bg-BG.h
> trunk/reactos/base/setup/usetup/lang/bn-BD.h
> trunk/reactos/base/setup/usetup/lang/cs-CZ.h
> trunk/reactos/base/setup/usetup/lang/da-DK.h
> trunk/reactos/base/setup/usetup/lang/de-DE.h
> trunk/reactos/base/setup/usetup/lang/el-GR.h
> trunk/reactos/base/setup/usetup/lang/en-US.h
> trunk/reactos/base/setup/usetup/lang/es-ES.h
> trunk/reactos/base/setup/usetup/lang/et-EE.h
> trunk/reactos/base/setup/usetup/lang/fr-FR.h
> trunk/reactos/base/setup/usetup/lang/he-IL.h
> trunk/reactos/base/setup/usetup/lang/it-IT.h
> trunk/reactos/base/setup/usetup/lang/ja-JP.h
> trunk/reactos/base/setup/usetup/lang/lt-LT.h
> trunk/reactos/base/setup/usetup/lang/ms-MY.h
> trunk/reactos/base/setup/usetup/lang/nl-NL.h
> trunk/reactos/base/setup/usetup/lang/pl-PL.h
> trunk/reactos/base/setup/usetup/lang/pt-BR.h
> trunk/reactos/base/setup/usetup/lang/ro-RO.h
> trunk/reactos/base/setup/usetup/lang/ru-RU.h
> trunk/reactos/base/setup/usetup/lang/sk-SK.h
> trunk/reactos/base/setup/usetup/lang/sq-AL.h
> trunk/reactos/base/setup/usetup/lang/sv-SE.h
> trunk/reactos/base/setup/usetup/lang/tr-TR.h
> trunk/reactos/base/setup/usetup/lang/uk-UA.h
> trunk/reactos/base/setup/usetup/mui.h
> 
> Modified: trunk/reactos/base/setup/usetup/interface/usetup.c
> URL: 
> http://svn.reactos.org/svn/reactos/trunk/reactos/base/setup/usetup/int
> erface/usetup.c?rev=70857=70856=70857=diff
> ==
> --- trunk/reactos/base/setup/usetup/interface/usetup.c[iso-8859-1] 
> (original)
> +++ trunk/reactos/base/setup/usetup/interface/usetup.c[iso-8859-1] 
> Wed Mar  2 00:51:48 2016
> @@ -3154,13 +3154,15 @@
>  if (!NT_SUCCESS(Status))
>  {
>  DPRINT("ChkdskPartition() failed with status 0x%08lx\n", Status);
> -sprintf(Buffer, "Setup failed to verify the selected 
> partition.\n"
> +// sprintf(Buffer, "Setup failed to verify the selected 
> partition.\n"
> +sprintf(Buffer, "ChkDsk detected some disk errors.\n"
>  "(Status 0x%08lx).\n", Status);
>  PopupError(Buffer,
> -   MUIGetString(STRING_REBOOTCOMPUTER),
> +   // MUIGetString(STRING_REBOOTCOMPUTER),
> +   MUIGetString(STRING_CONTINUE),
> Ir, POPUP_WAIT_ENTER);
>  
> -return QUIT_PAGE;
> +// return QUIT_PAGE;
>  }
>  
>  PartEntry->NeedsCheck = FALSE;
> 
> Modified: trunk/reactos/base/setup/usetup/lang/bg-BG.h
> URL: 
> http://svn.reactos.org/svn/reactos/trunk/reactos/base/setup/usetup/lan
> g/bg-BG.h?rev=70857=70856=70857=diff
> ==
> --- trunk/reactos/base/setup/usetup/lang/bg-BG.h  [iso-8859-1] (original)
> +++ trunk/reactos/base/setup/usetup/lang/bg-BG.h  [iso-8859-1] Wed Mar  2 
> 00:51:48 2016
> @@