Re: [Rosegarden-user] Loop Buttons on the Toolbars

2022-10-31 Thread Lorenzo Sutton

Hi Ted,

On 31/10/2022 01:02, Ted Felix wrote:
   Just pushed [833ea5f3] which adds loop buttons to all three major 
window transport toolbars: main, matrix, and notation.  They should 
behave exactly like the loop button on the transport.


Thanks! IMHO this is a really cool feature to have especially the fact 
that it's there also in matrix in notation, and makes the loop in 
Rosegarden much more 'sequencer idiomatic'!


There might be an issue: if you start with 'traditional' loop mode, 
select a range (that also turns looping on) and then select the advanced 
looping in preferences, turning looping on/off still only affects 
traditional looping behaviour while you can only turn the advanced 
looping on/off by right clicking on the top bar. Additionally once in 
advanced loop mode you can't deselect the traditional loop range any 
more with right click as this is now 'grabbed' by advanced loop.


Essentially the only way to get out of this situation is de-activating 
advanced loop mode in preferences and restarting rosegarden. Unless I'm 
missing something.


I understand that advanced vs. traditional lives in the preference, with 
the idea that a user might just set it up once and not change it so 
frequently. Personally I'd see use cases for both while working on the 
same piece (e.g. using traditional loop for small segments like a verse 
or chorus, an then the advanced for a whole - potentially in progress - 
song), so maybe this is more minor and can go in the future release.


Sorry for the terse feedback, I assume being a little redundant at this 
point is better than ambiguity :-)


Lorenzo



   This is likely the end of my changes before feature freeze on the 
9th.  Feel free to dig in and give it a good beating.


   Please test latest git.

Ted.


___
Rosegarden-user mailing list
Rosegarden-user@lists.sourceforge.net - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-user




___
Rosegarden-user mailing list
Rosegarden-user@lists.sourceforge.net - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-user


[Rosegarden-user] Loop Buttons on the Toolbars

2022-10-30 Thread Ted Felix
  Just pushed [833ea5f3] which adds loop buttons to all three major 
window transport toolbars: main, matrix, and notation.  They should 
behave exactly like the loop button on the transport.


  This is likely the end of my changes before feature freeze on the 
9th.  Feel free to dig in and give it a good beating.


  Please test latest git.

Ted.


___
Rosegarden-user mailing list
Rosegarden-user@lists.sourceforge.net - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-user