Re: [Rpm-maint] Planning for rpm 4.13.0 (-rc2)

2016-12-09 Thread Gleb Fotengauer-Malinovskiy 
On Fri, Dec 09, 2016 at 06:24:02PM +0200, Panu Matilainen wrote:
> On 10/17/2016 11:05 AM, Panu Matilainen wrote:
> > On 10/16/2016 10:15 AM, Dmitry V. Levin wrote:
> >> Hi,
> >>
> >> On Fri, Oct 14, 2016 at 04:33:00PM +0300, Panu Matilainen wrote:
> >>>
> >>> Hey folks,
> >>>
> >>> Time to get rpm 4.13.0 out of the door. But in order to do that, we'll
> >>> need to cut -rc2 first, there's just too much change to jump right into
> >>> final.
> >>>
> >>> The idea is to get -rc2 out next week (ie by Oct 21st at latest). If all
> >>> goes well we'll just rename that to -final in a few weeks time, if all
> >>> goes to hell we'll just have another -rc. Which I really, really dont
> >>> want to happen. So what I've planned for -rc2 is this rather
> >>> conservative cherry-picks from git master on top of the 4.13.x branch:
> >> [...]
> >>> Anyway, the list above is not set in stone, otherwise there'd be little
> >>> point in posting it here. If you think something absolutely critical is
> >>> missing from that list, or that something should not be there, now is
> >>> the time to speak up.
> >>
> >> Please include rpmdb.c fixes (commits 4c6e51e2 and e5d3b9f6), they are
> >> essential for apt-rpm.
> >
> > Request noted, but remember this is an ages old runtime bug, finally
> > fixed. Whether it gets fixed or not does not affect eg package or
> > API/ABI compatibility, so it can just as well be fixed in 4.13.1.
> >
> 
> So... in one of my weak moments I ended up letting these patches in 
> 4.13.0 against my own guidelines and here's my reward: commit 4c6e51e2 
> breaks cleaning up the locks on ctrl-c and so we have a wholly unwanted 
> and unnecessary regression in 4.13.0. Yeah it doesn't double free 
> because it doesn't free at all, at least in this case - yay.

Oh, I'm sorry.

I think, my commits both break cleanup of database locks. :(

> To reproduce, run 'rpm -qa' as root, hit ctrl-c and witness locks left 
> behind, eg:
> 
> [root@mangusti ~]# rpm -qa|grep anything
> ^C
> [root@mangusti ~]# rpm -q anything
> BDB2053 Freeing read locks for locker 0x34a: 9666/140299205872448
> BDB2053 Freeing read locks for locker 0x34b: 9666/140299205872448
> BDB2053 Freeing read locks for locker 0x34c: 9666/140299205872448
> package anything is not installed
> [root@mangusti ~]#
> 
>   - Panu -

-- 
glebfm
>From b360e928af5964aeb310ad95b6b505da902e539a Mon Sep 17 00:00:00 2001
From: Gleb Fotengauer-Malinovskiy 
Date: Fri, 9 Dec 2016 23:15:42 +
Subject: [PATCH 1/2] Fix one of regressions in cleanup of database locks

Commits 4c6e51e and e5d3b9f broke cleanup of locks in two different
ways.

In 4c6e51e rpmdbClose, rpmdbMatchIterator, and rpmdbIndexIterator
functions were changed to free object only if it is listed in
rpmdbRock, rpmmiRock, or in rpmdbRock, respectively.  As long as
rpmdbCheckTerminate removed objects from lists by itself, these
functions refused to free them.
---
 lib/rpmdb.c | 6 --
 1 file changed, 6 deletions(-)

diff --git a/lib/rpmdb.c b/lib/rpmdb.c
index 2dd3684..81115ff 100644
--- a/lib/rpmdb.c
+++ b/lib/rpmdb.c
@@ -334,20 +334,14 @@ int rpmdbCheckTerminate(int terminate)
 	rpmdbIndexIterator ii;
 
 	while ((mi = rpmmiRock) != NULL) {
-	rpmmiRock = mi->mi_next;
-	mi->mi_next = NULL;
 	rpmdbFreeIterator(mi);
 	}
 
 	while ((ii = rpmiiRock) != NULL) {
-	rpmiiRock = ii->ii_next;
-	ii->ii_next = NULL;
 	rpmdbIndexIteratorFree(ii);
 	}
 
 	while ((db = rpmdbRock) != NULL) {
-	rpmdbRock = db->db_next;
-	db->db_next = NULL;
 	(void) rpmdbClose(db);
 	}
 }
>From a05b935b6e86ae31a2d263779ce33ced0da6a3bf Mon Sep 17 00:00:00 2001
From: Gleb Fotengauer-Malinovskiy 
Date: Fri, 9 Dec 2016 23:17:01 +
Subject: [PATCH 2/2] Revert "rpmdb.c: (rpmdbCheckTerminate) return non-zero on
 subsequent runs"

Commits 4c6e51e and e5d3b9f broke cleanup of locks in two different
ways.

In e5d3b9f rpmdbCheckTerminate was changed to return non-zero,
but rpmdbCheckTerminate is called indirectly by itself
through rpmdbFreeIterator and rpmdbCheckSignals.  So, with that
change, rpm exits right after free of first rpmdbMatchIterator.

This reverts commit e5d3b9f682383ee026b5a86a47eb5f288bdf8991.
---
 lib/rpmdb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/rpmdb.c b/lib/rpmdb.c
index 81115ff..04cec51 100644
--- a/lib/rpmdb.c
+++ b/lib/rpmdb.c
@@ -315,7 +315,7 @@ int rpmdbCheckTerminate(int terminate)
 sigset_t newMask, oldMask;
 static int terminating = 0;
 
-if (terminating) return terminating;
+if (terminating) return 0;
 
 (void) sigfillset(&newMask);		/* block all signals */
 (void) sigprocmask(SIG_BLOCK, &newMask, &oldMask);
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] Planning for rpm 4.13.0 (-rc2)

2016-12-09 Thread Panu Matilainen 

On 10/17/2016 11:05 AM, Panu Matilainen wrote:

On 10/16/2016 10:15 AM, Dmitry V. Levin wrote:

Hi,

On Fri, Oct 14, 2016 at 04:33:00PM +0300, Panu Matilainen wrote:


Hey folks,

Time to get rpm 4.13.0 out of the door. But in order to do that, we'll
need to cut -rc2 first, there's just too much change to jump right into
final.

The idea is to get -rc2 out next week (ie by Oct 21st at latest). If all
goes well we'll just rename that to -final in a few weeks time, if all
goes to hell we'll just have another -rc. Which I really, really dont
want to happen. So what I've planned for -rc2 is this rather
conservative cherry-picks from git master on top of the 4.13.x branch:

[...]

Anyway, the list above is not set in stone, otherwise there'd be little
point in posting it here. If you think something absolutely critical is
missing from that list, or that something should not be there, now is
the time to speak up.


Please include rpmdb.c fixes (commits 4c6e51e2 and e5d3b9f6), they are
essential for apt-rpm.


Request noted, but remember this is an ages old runtime bug, finally
fixed. Whether it gets fixed or not does not affect eg package or
API/ABI compatibility, so it can just as well be fixed in 4.13.1.



So... in one of my weak moments I ended up letting these patches in 
4.13.0 against my own guidelines and here's my reward: commit 4c6e51e2 
breaks cleaning up the locks on ctrl-c and so we have a wholly unwanted 
and unnecessary regression in 4.13.0. Yeah it doesn't double free 
because it doesn't free at all, at least in this case - yay.


To reproduce, run 'rpm -qa' as root, hit ctrl-c and witness locks left 
behind, eg:


[root@mangusti ~]# rpm -qa|grep anything
^C
[root@mangusti ~]# rpm -q anything
BDB2053 Freeing read locks for locker 0x34a: 9666/140299205872448
BDB2053 Freeing read locks for locker 0x34b: 9666/140299205872448
BDB2053 Freeing read locks for locker 0x34c: 9666/140299205872448
package anything is not installed
[root@mangusti ~]#

- Panu -
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] When using %autopatch, create backup files with .~ suffix by def… (#109)

2016-12-09 Thread Igor Gnatenko 
@rpm-maint Please hate @jsilhan and @j-mracek for this

-- 
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/109#issuecomment-266035398___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] When using %autopatch, create backup files with .~ suffix by def… (#109)

2016-12-09 Thread ニール・ゴンパ 
For those looking from GitHub and the URL is being weirdly borked, here's the 
bug: https://bugs.mageia.org/show_bug.cgi?id=9832

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/109#issuecomment-266032964___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] When using %autopatch, create backup files with .~ suffix by def… (#109)

2016-12-09 Thread soig 
On 9 December 2016 at 15:41, Igor Gnatenko  wrote:

> @soig  Fully agree, saw same problem in Fedora
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> ,
> or mute the thread
> 
> .
>
​And here's a scary example where backup files made os-prober do stupid and
dangerous things:
https://bugs.mageia.org/show_bug.cgi?id=9832​


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/109#issuecomment-266029995___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] When using %autopatch, create backup files with .~ suffix by def… (#109)

2016-12-09 Thread ニール・ゴンパ 
@proyvind @soig @ignatenkobrain Maybe it'd be better if it was not on by 
default?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/109#issuecomment-266029530___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] When using %autopatch, create backup files with .~ suffix by def… (#109)

2016-12-09 Thread Igor Gnatenko 
@soig Fully agree, saw same problem in Fedora

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/109#issuecomment-266029269___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] When using %autopatch, create backup files with .~ suffix by def… (#109)

2016-12-09 Thread soig 
On 9 December 2016 at 04:03, proyvind  wrote:

> …ault
>
> The legacy mandriva %apply_patches macro by default generated backup
> files with unique suffixes by default, the suffix for patch0 being
> .0001~ etc.
>
> As for those of us still using gendiff, this is still convenient, while
> for those using a scm, the '~' at end of suffix will anyways be
> automatically ignored, so enabling it by default won't interfer.
>
> A -B argument passed to the %autopatch will disable this.
> --
> You can view, comment on, or merge this pull request online at:
>
>   https://github.com/rpm-software-management/rpm/pull/109
> Commit Summary
>
>- When using %autopatch, create backup files with .~ suffix by
>default
>
> File Changes
>
>- *M* macros.in
>
>(10)
>
> Patch Links:
>
>- https://github.com/rpm-software-management/rpm/pull/109.patch
>- https://github.com/rpm-software-management/rpm/pull/109.diff
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> , or mute the
> thread
> 
> .
>

​
Actually, in Mageia where we used extensively %apply_patches as the
mandriva legacy, we found out taht the backup behaviour not pleasant as
this makes several packages to silently package backup files
If one really wants backups, (s)he just has to use "%autosetup -S git" and
the like

​See eg: https://bugs.mageia.org/show_bug.cgi?id=15579

I remember having seen other strange and rare build issues due to backup
files, so please no, we don't want backup by default and since we've great
support for SCMs, there's no point in having such an option.
My 2 cents


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/109#issuecomment-266028997___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] When using %autopatch, create backup files with .~ suffix by def… (#109)

2016-12-09 Thread DNF Bot 
Can one of the admins verify this patch?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/109#issuecomment-266029013___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Metatags (#107)

2016-12-09 Thread ニール・ゴンパ 
I'm a bit confused. What exactly are MetaTags supposed to do? You mention 
comps, are these supposed to be more like [SUSE's 
patterns](https://build.opensuse.org/package/view_file/system:install:head/patterns-openSUSE/patterns-openSUSE.spec?expand=1)?

I can't quite tell what this is supposed to do...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/107#issuecomment-266012048___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] When using %autopatch, create backup files with .~ suffix by def… (#109)

2016-12-09 Thread ニール・ゴンパ 
Conan-Kudo approved this pull request.

Looks good to me.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/109#pullrequestreview-12224386___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

[Rpm-maint] [PATCH] Link testing/usr/bin to testing/bin.

2016-12-09 Thread Mark Wielaard 
Some tests running under fakechroot started failing because scripts tried
to execute /usr/bin/rm but inside the testing chroot /usr/bin and /bin
aren't linked. Just symlink testing/usr/bin to testing/bin to simulate
a unified /usr setup.

Signed-off-by: Mark Wielaard 
---
 tests/Makefile.am | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 7091220..8c036d6 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -104,6 +104,8 @@ testing$(bindir)/rpmbuild: ../rpmbuild
rm -rf testing
mkdir -p testing/$(bindir)
ln -s ./$(bindir) testing/bin
+   mkdir -p testing/usr
+   ln -s ../bin testing/usr/bin
(cd ${top_builddir} && \
  $(MAKE) DESTDIR=`pwd`/${subdir}/testing install)
cp -r ${srcdir}/data/ testing/
-- 
1.8.3.1

___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] Unable to build after Stop messing with CFLAGS from configure patch

2016-12-09 Thread Panu Matilainen 

On 12/09/2016 10:41 AM, Mark Wielaard wrote:

Hi,

commit bd3eb213 "Stop messing with CFLAGS from configure" renamed
rpm.am to rpm.am.in. rpm.am is included am into all Makefile.am files.
But rpm.am is now generated by configure. Which means it is generated
in the builddir so the includes should reference top_builddir instead of
top_srcdir now. But when running automake (or autoreconf) configure
doesn't even exist yet, so there is no rpm.am file yet and automake
will fail to generate proper Makefile.in files.

Could we instead do it like the attached by just defining the
AM_CFLAGS substitution inside the Makefile.am files themselves?

Thanks,


I thought I tested the "bootstrap" case but guess not :-/ I was really 
hoping to have a single place for setting that stuff in the makefiles 
but oh well...


Applied, thanks for the patch and sorry 'bout the breakage.

- Panu -

___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Build fixes related to (#108)

2016-12-09 Thread Mark Wielaard 
On Thu, Dec 08, 2016 at 11:57:50PM -0800, DNF Bot wrote:
> Can one of the admins verify this patch?

Could you please include the patch you want to see verified in
your message?

Thanks,

Mark
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

[Rpm-maint] Unable to build after Stop messing with CFLAGS from configure patch

2016-12-09 Thread Mark Wielaard 
Hi,

commit bd3eb213 "Stop messing with CFLAGS from configure" renamed
rpm.am to rpm.am.in. rpm.am is included am into all Makefile.am files.
But rpm.am is now generated by configure. Which means it is generated
in the builddir so the includes should reference top_builddir instead of
top_srcdir now. But when running automake (or autoreconf) configure
doesn't even exist yet, so there is no rpm.am file yet and automake
will fail to generate proper Makefile.in files.

Could we instead do it like the attached by just defining the
AM_CFLAGS substitution inside the Makefile.am files themselves?

Thanks,

Mark
>From 7a17a1eeb058cbafe59863ea40e8b0f697ca6bc8 Mon Sep 17 00:00:00 2001
From: Mark Wielaard 
Date: Fri, 9 Dec 2016 09:31:58 +0100
Subject: [PATCH] Define AM_CFLAGS inside the Makefile.am files themselves.

Trying to include AM_CFLAGS through a configure generated rpm.am file
doesn't really work because at the time automake runs configure doesn't
exist yet to process rpm.am.in. Just define the AM_CFLAGS substitution
inside the Makefile.am files themselves.

Rename rpm.am.in back to rpm.am.

Signed-off-by: Mark Wielaard 
---
 Makefile.am   | 1 +
 build/Makefile.am | 1 +
 configure.ac  | 2 +-
 fileattrs/Makefile.am | 1 +
 lib/Makefile.am   | 1 +
 plugins/Makefile.am   | 1 +
 python/Makefile.am| 1 +
 rpm.am.in => rpm.am   | 2 --
 rpmio/Makefile.am | 1 +
 scripts/Makefile.am   | 1 +
 sign/Makefile.am  | 1 +
 tests/Makefile.am | 1 +
 12 files changed, 11 insertions(+), 3 deletions(-)
 rename rpm.am.in => rpm.am (92%)

diff --git a/Makefile.am b/Makefile.am
index 47bb4bd..eef2376 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -5,6 +5,7 @@ ACLOCAL_AMFLAGS = -I m4
 DISTCHECK_CONFIGURE_FLAGS = --with-external-db
 
 include $(top_srcdir)/rpm.am
+AM_CFLAGS = @RPMCFLAGS@
 
 CLEANFILES =
 EXTRA_DIST = ChangeLog CREDITS INSTALL \
diff --git a/build/Makefile.am b/build/Makefile.am
index f0f55a9..2fa3c3d 100644
--- a/build/Makefile.am
+++ b/build/Makefile.am
@@ -1,6 +1,7 @@
 # Makefile for rpmbuild library.
 
 include $(top_srcdir)/rpm.am
+AM_CFLAGS = @RPMCFLAGS@
 
 AM_CPPFLAGS =  -I$(top_builddir) -I$(top_srcdir) -I$(top_builddir)/include/
 AM_CPPFLAGS += @WITH_BEECRYPT_INCLUDE@
diff --git a/configure.ac b/configure.ac
index e08096d..4f3be87 100644
--- a/configure.ac
+++ b/configure.ac
@@ -892,7 +892,7 @@ AC_PATH_PROG(AUTOM4TE,autom4te,:)
 
 AC_SUBST([dirstamp],[\${am__leading_dot}dirstamp])
 
-AC_CONFIG_FILES([Makefile rpm.am
+AC_CONFIG_FILES([Makefile
rpmio/Makefile lib/Makefile build/Makefile sign/Makefile
po/Makefile.in scripts/Makefile fileattrs/Makefile
misc/Makefile 
diff --git a/fileattrs/Makefile.am b/fileattrs/Makefile.am
index 9c55aa1..1895f44 100644
--- a/fileattrs/Makefile.am
+++ b/fileattrs/Makefile.am
@@ -1,6 +1,7 @@
 # Makefile for rpm file attributes
 
 include $(top_srcdir)/rpm.am
+AM_CFLAGS = @RPMCFLAGS@
 
 fattrsdir = $(rpmconfigdir)/fileattrs
 
diff --git a/lib/Makefile.am b/lib/Makefile.am
index 7fd6f94..c95d674 100644
--- a/lib/Makefile.am
+++ b/lib/Makefile.am
@@ -1,6 +1,7 @@
 # Makefile for rpm library.
 
 include $(top_srcdir)/rpm.am
+AM_CFLAGS = @RPMCFLAGS@
 
 AM_CPPFLAGS = -I$(top_builddir) -I$(top_srcdir) -I$(top_builddir)/include/
 AM_CPPFLAGS += @WITH_BEECRYPT_INCLUDE@
diff --git a/plugins/Makefile.am b/plugins/Makefile.am
index 5ddc174..98eb154 100644
--- a/plugins/Makefile.am
+++ b/plugins/Makefile.am
@@ -1,6 +1,7 @@
 # Makefile for rpm library.
 
 include $(top_srcdir)/rpm.am
+AM_CFLAGS = @RPMCFLAGS@
 
 AM_CPPFLAGS = -I$(top_builddir) -I$(top_srcdir) -I$(top_builddir)/include/
 AM_CPPFLAGS += -I$(top_srcdir)/misc
diff --git a/python/Makefile.am b/python/Makefile.am
index cae66f0..af8b089 100644
--- a/python/Makefile.am
+++ b/python/Makefile.am
@@ -1,6 +1,7 @@
 # Makefile for rpm library.
 
 include $(top_srcdir)/rpm.am
+AM_CFLAGS = @RPMCFLAGS@
 
 EXTRA_DIST = rpm/__init__.py rpm/transaction.py
 
diff --git a/rpm.am.in b/rpm.am
similarity index 92%
rename from rpm.am.in
rename to rpm.am
index c91bebf..1f43ad8 100644
--- a/rpm.am.in
+++ b/rpm.am
@@ -8,5 +8,3 @@ rpmconfigdir = $(prefix)/lib/rpm
 
 # Libtool version (current-revision-age) for all our libraries
 rpm_version_info = 7:0:0
-
-AM_CFLAGS = @RPMCFLAGS@
diff --git a/rpmio/Makefile.am b/rpmio/Makefile.am
index 68a8219..5ad4d68 100644
--- a/rpmio/Makefile.am
+++ b/rpmio/Makefile.am
@@ -1,6 +1,7 @@
 # Makefile for rpm library.
 
 include $(top_srcdir)/rpm.am
+AM_CFLAGS = @RPMCFLAGS@
 
 AM_CPPFLAGS = -I$(top_builddir) -I$(top_srcdir) -I$(top_builddir)/include/
 AM_CPPFLAGS += @WITH_NSS_INCLUDE@
diff --git a/scripts/Makefile.am b/scripts/Makefile.am
index f204c51..b1360e1 100644
--- a/scripts/Makefile.am
+++ b/scripts/Makefile.am
@@ -1,6 +1,7 @@
 # Makefile for rpm scripts.
 
 include $(top_srcdir)/rpm.am
+AM_CFLAGS = @RPMCFLAGS@
 
 CLEANFILES =
 
diff --git a/sign/Makefile.am b/sign/Makefile.am
index 86314ff..e612981 100644
--- a/sign/Makefile.am
+++ b/sign/Makefile.am
@@ -1,6

Re: [Rpm-maint] [rpm-software-management/rpm] Build fixes related to (#108)

2016-12-09 Thread Panu Matilainen 
Closed #108.

-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/108#event-888031777___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint