Re: [Rpm-maint] [rpm-software-management/rpm] Can't use `--define "_gpg_name Foo"` any more (#153)

2017-02-09 Thread Panu Matilainen
Yup, signing support was removed from librpmbuild between RHEL 6 and 7 as 
insecure, rpmbuild --sign option is only minimally supported through a popt 
alias which certainly wont handle this case.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/153#issuecomment-278878715___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Can't use `--define "_gpg_name Foo"` any more (#153)

2017-02-09 Thread James Sumners
Example project -- https://github.com/jsumners/staticdhcpd-rpm

When the build script in that project is run it looks for a sibling file 
`gpg-env`. If found, it sources the file and generates the build command like 
so:

```
rpmbuild --define "_topdir ${CWD}/rpmbuild" \
  --define "_signature ${signature}" \
  --define "_gpg_path ${gpg_path}" --define "_gpg_name ${gpg_name}" \
  --sign --ba rpmbuild/SPECS/${SPEC1}
```

This works just fine in a RHEL 6 environment. But if you do it in a RHEL 7 
environment it fails saying:

```
You must set "%_gpg_name" in your macro file
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/153___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] RFE: option for initial-only content in files (#152)

2017-02-09 Thread soig
On 9 February 2017 at 09:18, Panu Matilainen 
wrote:

> Originally filed in the old rpm.org Trac instance by ovasik for the
> use-case of files like /etc/passwd:
>
> Maybe useful only for combination with %config(noreplace), not sure at the
> moment. There are several files e.g. Fedora's /etc/passwd marked
> %config(noreplace) where it doesn't make sense to .rpmnew file. It is
> useless and could confuse users (and even cause troubles if used as
> replacement for /etc/passwd by unexperienced admin. Therefore I would like
> to not create .rpmnew file, to not replace old /etc/passwd file but to
> INSTALL /etc/passwd file when installing rpm's.
>
> There is afaik no option for this case available at the moment. When I
> mark the file %ghost, it will be not installed - as it will be not part of
> .rpm file - which is not good in this case. Deleting .rpmnew file in %post
> could make paranoic user scared - as rpm update reported .rpmnew file and
> file is missing. If you have other proposal, feel free to post it here.
>
> Could be useful for some catalog files - which have to be installed once,
> but there is no need to update them afterwards - even if the file content
> in new release changed. I do not expect wide usage, but it would be an
> option for such border cases.
>
> Original suggestion was on %config(nowarn), dmach suggested other, far
> better names:
>
>- installonly
>- noupdate
>- norpmnew
>
>
​The last one is not generic enough as one is used to either get a .rpmnew
or a .rpmsave​


>
>
> IMO the use-case is very real and worth implementing, it's just the minor
> details that need sorting out. Such as:
>
>- The name - %config(nowarn) is absolutely terrible, "noupdate" seems
>like a nice generic term that describes the functionality well. But other
>ideas welcome too, something that describes the class of such files (think
>of %config, %doc etc) would be fine too.
>- Should this be limited to %config files? My gut feeling says no -
>for example /etc/passwd is not a %config file in the usual sense, and I
>seem to have a dim recollection of various other use-cases for this that
>were not really config files.
>- This would seem to be in relatively close relation to %ghost,
>because after such a file becomes just like a %ghost, but it certainly is
>not a %ghost file since we need to carry it in payload. Is there something
>else in this direction?
>
> What else?
>


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/152#issuecomment-278742676___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add OpenSSL crypto backend (#129)

2017-02-09 Thread Panu Matilainen
pmatilai approved this pull request.

At this point, ACK for the whole lot.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/129#pullrequestreview-21020680___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add OpenSSL crypto backend (#129)

2017-02-09 Thread ニール・ゴンパ
Conan-Kudo approved this pull request.

The changes look good to me for Linux, and it properly fails to allow usage of 
OpenSSL backend from the configure step on macOS.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/129#pullrequestreview-21022178___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add OpenSSL crypto backend (#129)

2017-02-09 Thread Panu Matilainen
My plan was to let @ffesti conduct the actual merge ceremony, web buttons doing 
stuff to code make me nervous :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/129#issuecomment-278659644___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add OpenSSL crypto backend (#129)

2017-02-09 Thread ニール・ゴンパ
@sgallagher Before having @pmatilai merge it, can you squash your fixup commits 
into the non fixup ones? We don't have autosquashing for them here...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/129#issuecomment-278658202___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add OpenSSL crypto backend (#129)

2017-02-09 Thread Stephen Gallagher
Yeah, I'm going to squash them all down to a single commit. One moment.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/129#issuecomment-278658414___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add OpenSSL crypto backend (#129)

2017-02-09 Thread Panu Matilainen
Looks good to me, thanks.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/129#issuecomment-278657373___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] RFE: option for initial-only content in files (#152)

2017-02-09 Thread Panu Matilainen
Originally filed in the old rpm.org Trac instance by ovasik for the use-case of 
files like /etc/passwd:

> Maybe useful only for combination with %config(noreplace), not sure at the 
> moment. There are several files e.g. Fedora's /etc/passwd marked 
> %config(noreplace) where it doesn't make sense to .rpmnew file. It is useless 
> and could confuse users (and even cause troubles if used as replacement for 
> /etc/passwd by unexperienced admin. Therefore I would like to not create 
> .rpmnew file, to not replace old /etc/passwd file but to INSTALL /etc/passwd 
> file when installing rpm's.
>
> There is afaik no option for this case available at the moment. When I mark 
> the file %ghost, it will be not installed - as it will be not part of .rpm 
> file - which is not good in this case. Deleting .rpmnew file in %post could 
> make paranoic user scared - as rpm update reported .rpmnew file and file is 
> missing. If you have other proposal, feel free to post it here.
>
> Could be useful for some catalog files - which have to be installed once, but 
> there is no need to update them afterwards - even if the file content in new 
> release changed. I do not expect wide usage, but it would be an option for 
> such border cases. 

Original suggestion was on %config(nowarn), dmach suggested other, far better 
names:
- installonly
- noupdate
- norpmnew

IMO the use-case is very real and worth implementing, it's just the minor 
details that need sorting out. Such as:
- The name - %config(nowarn) is absolutely terrible, "noupdate" seems like a 
nice generic term that describes the functionality well. But other ideas 
welcome too, something that describes the class of such files (think of 
%config, %doc etc) would be fine too.
- Should this be limited to %config files? My gut feeling says no - for example 
/etc/passwd is not a %config file in the usual sense, and I seem to have a dim 
recollection of various other use-cases for this that were not really config 
files.
- This would seem to be in relatively close relation to %ghost, because after 
such a file becomes just like a %ghost, but it certainly is not a %ghost file 
since we need to carry it in payload. Is there something else in this direction?

What else?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/152___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add OpenSSL crypto backend (#129)

2017-02-09 Thread Stephen Gallagher
@pmatilai OK, I added some text to the INSTALL file. Please proofread it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/129#issuecomment-278648068___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add OpenSSL crypto backend (#129)

2017-02-09 Thread Stephen Gallagher
@sgallagher pushed 1 commit.

907a1a3  Add OpenSSL to INSTALL


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/129/files/992e94cbacdbafd4b42db24ba275f5bffc77b8f6..907a1a3cdfcd55a85506f0621738bcd82dcaaa9c
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint