Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)

[proyvind]

@proyvind pushed 1 commit.

d3c3dc0  fix license versioning


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/122/files/532a383a4bc19daee7ac96ce44947bfa12b0ad7c..d3c3dc0f5151a5680be6d1e810afc621e44358a7
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

[Rpm-maint] [rpm-software-management/rpm] Find lang.sh multi names (#235)

[proyvind]

You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/235

-- Commit Summary --

  * add support for passing multiple names to find-lang.sh to avoid having to 
run find-lang.sh for each name and append the file lists produced later
  * don't use undefined $NAME, but rather use array member of $NAMES

-- File Changes --

M scripts/find-lang.sh (19)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/235.patch
https://github.com/rpm-software-management/rpm/pull/235.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/235
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)

[proyvind]

@proyvind pushed 2 commits.

9bdd811  add support for %{shrink:}, derived from rpm5.org
532a383  use %{shrink:} to slim down %__spec_install_post to work with 
parallelize


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/122/files/b22db1d40a70c1d22b7c04b02289ec9aada224c2..532a383a4bc19daee7ac96ce44947bfa12b0ad7c
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)

[proyvind]

@proyvind pushed 2 commits.

b59efa4  notify about missing chrpath
b22db1d  fix proper stripping of .pc file name suffixes


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/122/files/cedff9ad30d0617db050a6afd8ed3c5349e04a5f..b22db1d40a70c1d22b7c04b02289ec9aada224c2
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

[Rpm-maint] [rpm-software-management/rpm] add support for %{shrink:}, derived from rpm5.org (#234)

[proyvind]

Shrinks body by removing all leading and trailing whitespaces and
reducing intermediate whitespaces to a single space character.
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/234

-- Commit Summary --

  * add support for %{shrink:}, derived from rpm5.org

-- File Changes --

M rpmio/macro.c (24)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/234.patch
https://github.com/rpm-software-management/rpm/pull/234.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/234
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)

[proyvind]

@proyvind pushed 1 commit.

cedff9a  add parallel brp-* script support using GNU parallel


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/122/files/ed06b4f286c24f6c1fc36e9e282a46807e27927a..cedff9ad30d0617db050a6afd8ed3c5349e04a5f
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

[Rpm-maint] [rpm-software-management/rpm] fix path to external beecrypt include dir (#233)

[proyvind]

beecrypt are storing headers under /usr/include/beecrypt by default (which is 
also where the configure.ac check looks for as well), but while passing 
internal beecrypt build to default header search path, it fails to do so for 
external beecrypt (ie. -I/usr/include/beecrypt).


You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/233

-- Commit Summary --

  * fix path to external beecrypt include dir

-- File Changes --

M configure.ac (1)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/233.patch
https://github.com/rpm-software-management/rpm/pull/233.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/233
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Use C.UTF-8 locale, if available (#227)

[ニール・ゴンパ]

Conan-Kudo requested changes on this pull request.



> @@ -1,7 +1,7 @@
 #! /bin/sh
 # mkinstalldirs --- make directory hierarchy
 
-scriptversion=2006-05-11.19
+scriptversion=2009-04-28.21; # UTC

Why are we updating this? There are no changes except of comments...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/227#pullrequestreview-43302666___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] WIP: Add brp helper scripts derived from spec-helper (#230)

[ニール・ゴンパ]

Closed #230.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/230#event-1118310087___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] WIP: Add brp helper scripts derived from spec-helper (#230)

[ニール・ゴンパ]

Closing for now, as #122 seems to be active again...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/230#issuecomment-307580448___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)

[ニール・ゴンパ]

Conan-Kudo requested changes on this pull request.

Some of these scripts don't fully clarify the intent of which license the code 
is actually under. This feels gross and I don't think it helps make the 
licensing of RPM as a whole easier to understand.

Either clarify the licensing of the scripts in question (GPLv2+ or what?) or 
remove the scripts.

> @@ -0,0 +1,25 @@
+#!/bin/sh
+#---
+# Origin   : Linux-Mandrake
+# Author   : Frederic Lepied
+# Created On   : Tue Nov  7 08:33:05 2000
+# Description  : Run ldconfig to create symlinks to libraries.
+#
+# Copyright (C) 2000 by Frederic Lepied 
+# Redistribution of this file is permitted under the terms of the GNU
+# Public License (GPL).

What does this mean? What version of the license?

> @@ -0,0 +1,42 @@
+#!/bin/sh
+#---
+# Origin   : Linux-Mandrake
+# Author   : Per Øyvind Karlsen 
+#  : Frederic Lepied 
+#  : (original implementation, Mon Nov 13 07:17:42 2000)
+# Created On   : Tue Sep 25 01:53:16 2012
+# Description  : Automatically relativize symlinks
+#
+# Copyright (C) 2012 by Per Øyvind Karlsen 
+# Redistribution of this file is permitted under the terms of the GNU
+# Public License (GPL).

Same as earlier.

> @@ -0,0 +1,25 @@
+#!/bin/sh
+#---
+# Origin   : Mandriva Linux
+# Author   : Per Øyvind Karlsen 
+# Created On   : Tue Dec 6 06:56:49 2011
+# Description  : Automatically remove /usr/share/dir if created during install
+#
+# Copyright (C) 2011 by Per Øyvind 
+# Redistribution of this file is permitted under the terms of the GNU
+# Public License (GPL).

Same as earlier.

> @@ -0,0 +1,24 @@
+#!/bin/sh
+#---
+# Origin   : Mandriva Linux
+# Author   : Per Øyvind Karlsen 
+# Created On   : Tue Dec 6 06:56:49 2011
+# Description  : Automatically remove undesired libtool .la library files
+#
+# Copyright (C) 2011 by Per Øyvind 
+# Redistribution of this file is permitted under the terms of the GNU
+# Public License (GPL).

Same as earlier.

> @@ -0,0 +1,58 @@
+#!/bin/sh
+#---
+# Origin   : Mandriva Linux
+# Author   : Per Øyvind Karlsen 
+# Created On   : Thu Feb 21 02:44:18 2013
+# Description  : Make sure to remove any standard library search paths from
+#  : rpath/runpath tags as they're not only redundant, but will
+#  : break overriding search paths.
+#  : Search paths of the tag that's not standard will be kept 
intact.
+#
+# Copyright (C) 2013 by Per Øyvind 
+# Redistribution of this file is permitted under the terms of the GNU
+# Public License (GPL).

Same as earlier.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/122#pullrequestreview-43302575___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)

[proyvind]

@proyvind pushed 1 commit.

41c7de8  finish WIP adding copyright notices to scripts


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/122/files/667aaf07d1cd3d0ab414fc05e742675a7f2df2b8..41c7de8c6dcc79a2951b4660abd8777fa97bee05
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Run binary package generation via thread pools (#226)

[Jeff Johnson]

You need to make sure that RPMTAG_BUILD{TIME,HOST} in both the *.src.rpm and 
the binary packages is identical. This was done originally with static 
variables, but can also be done by setting these variables in one place once, 
and then using the stored values where necessary.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/226#issuecomment-307575313___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Rpm query causes corruption in the file-backed mmaped bdb regions (#232)

[Jeff Johnson]

Note also that simply removing __db.00N files to "fix" problems can lead to 
other "corruption" problems, particularly when other accesses are running 
simultaneously.

The better fix for what you are calling "corruption" is to use "db_recover" 
with/without the -e option.

BDB has a notification facility that db_recover will use to signal other 
processes that the dbenv is being recreated. But (last I checked) rpm-4.x.y 
does not use/implement that facility. RPM5+BDB does implement the dbenv 
notification facility, automates recovery where needed on the next dbenv open, 
and also uses a full transactional ACID store with logs, rpm-4.x.y uses a CDB 
model which permits a single writer or multiple readers, with per-database 
(i.e. per-table) locking. The transactional model uses per-page locking, and 
logs all operations with a transactional commit/discard operation. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/232#issuecomment-307573757___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Rpm query causes corruption in the file-backed mmaped bdb regions (#232)

[Jeff Johnson]

The term "corruption" is highly unspecific: please avoid, and/or supply more 
specific details.

Yes, somewhat counter intuitively, the "read-only" operation of rpm -qa is 
writing to disk: at a minimum, shared read locks (and rpm-4.x.y also is trying 
to create an advisory file lock).

The mmap'ing to backing file store is necessary for the dbenv (which has locks 
and caches) to be shared between processes.

RPM itself has 2 "risky" implementations using BDB:
- fsync is disabled (for performance) by stubbing out a BDB vector.
- non-root access to databases (the more common DB term is "tables") without a 
dbenv (hence no shared locks).

Without fsync, there is no (strong) guarantee that multiple processes see the 
same data on the file system. In practice (on linux) this has not caused major 
problems: but that is NOT a claim that no problems exist.

Reading without taking out a shared read lock can segfault if/when a writer is 
updating an rpmdb. In practice, the exclusive file lock and the pattern of 
usage of RPM is such that an occasional segfault is tolerable. But its quite 
easy to demonstrate the problem by running many concurrent RPM queries and 
installs.

In practice, RPM creates an exclusive file lock that serializes writers (but 
readers mostly do not participate in the advisory locking scheme, at least last 
I checked).

If you are truly interested in stable/robust concurrent access to an rpmdb, 
then you MUST correct the above problems. Denying the creation of shared read 
locks, either through file system permissions (i.e. non-root) or sandboxing 
simply isn't going to provide stable/robust concurrent access to an rpmdb.

The better approach is to permit write access to the dbenv files (in the 
__db.00N files) either through file system permissions (like group writable 
0664, and possibly a setgid bit and ownership on the rpm executable), or by 
configuring your sandbox to permit writes to the dbenv files.

Treating the dbenv files as transient cache and moving them into a separate 
directory may help with sandbox rule generation as well.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/232#issuecomment-307572921___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint