Re: [Rpm-maint] [rpm-software-management/rpm] Fail to check signature (#270)

[Anselmo L. S. Melo]

@n3npq, thanks for your comments.

It's just to add more info:
A possible conflict between package generated by rpm5 x rpm4 was one of our 
first hypothesis, however the same issue happens with signed packages generated 
by rpm4 (for the yocto-2.3 based system):

```
bash-4.3# rpm5 -qp --yaml intel-aero-repo-1.4-r0.corei7_64.rpm | grep Rpmversion
  Rpmversion: 4.13.90
```


rpm 4 with the commit linked by @lucasdemarchi above fails with the the 
following error:
```
bash-4.3# rpm -qlp intel-aero-repo-1.4-r0.corei7_64.rpm 
error: intel-aero-repo-1.4-r0.corei7_64.rpm: signature region 62: tag number 
mismatch 8 ril 6 dl 4772 rdl 16

error: intel-aero-repo-1.4-r0.corei7_64.rpm: not an rpm package (or package 
manifest)
```

Both 
[intel-aero-repo](https://github.com/rpm-software-management/rpm/files/1166904/intel-aero-repo-1.4-r0.corei7_64.rpm.zip)
 package and the [public 
key](https://github.com/rpm-software-management/rpm/files/1166908/public-gpg-key.txt)
 are attached for reference.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/270#issuecomment-317133187___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] add acinclude.m4 (#271)

[ニール・ゴンパ]

Conan-Kudo approved this pull request.





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/271#pullrequestreview-51496403___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

[Rpm-maint] [rpm-software-management/rpm] add acinclude.m4 (#271)

[Igor Gnatenko]

Projects that use autoconf are expected to detect
build prerequisites and libraries.

This usually leads to a set of ad hoc de facto m4 macros
that deal with various details like API and path incompatibilities,
much of which is platform and os and distro dependent.

Various standard tools (like pkgconfig) to find these details
have been devised; meanwhile there is still a great deal of diversity,
particularly between platforms like linux and *BSD, that often
makes portability more difficult than it needs to be.

One useful approach -- particularly when maintaining
a project like RPM -- is RPM_CHECK_LIB that does all the usual
operations and permits a compact specification of 3rd party
library details.
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/271

-- Commit Summary --

  * add acinclude.m4

-- File Changes --

A m4/acinclude.m4 (537)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/271.patch
https://github.com/rpm-software-management/rpm/pull/271.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/271
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)

[Jun Aruga]

@ignatenkobrain congratulations. Where is the RPM's URL in 
https://semaphoreci.com ?

https://semaphoreci.com/rpm-software-management/rpm is 404 not found.

Does Semaphoreci have the configuration file such as `.travis.yml` or 
`.circleci/config.yml`?
I want to see the logic to test `rpm` on 4 containers (Fedora 24, 25, 26, 
rawhide).

Shall we change current `README` to `README.md` or something to see build 
status easily?
like a Cockpit https://github.com/cockpit-project/cockpit/blob/master/README.md


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261#issuecomment-317007720___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [PATCH] find-debuginfo.sh: Remove non-allocated NOBITS sections from minisymtab.

[Florian Festi]

Pushed.
On 07/19/2017 02:53 PM, Mark Wielaard wrote:
> In the minisymtab section (the .gnu_debugdata embedded ELF image) we
> do not need unallocated sections (except for the SYMTAB and STRTAB
> sections we are creating). We already remove PROGBITS and NOTES. Also
> remove NOBITS sections. They should not really take up much (any) space
> but they still add to the section tables. These sections might be created
> with the new --keep-section support (which puts the actual section in
> the main ELF binary, and a NOBITS variant in the .debug file).
> 
> Also binutils objcopy seems to sometimes add them anyway filled with
> zeros instead of marking them NOBITS.
> 
> Signed-off-by: Mark Wielaard 
> ---
>  scripts/find-debuginfo.sh | 8 ++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/find-debuginfo.sh b/scripts/find-debuginfo.sh
> index e19ce9b..2fa95e8 100755
> --- a/scripts/find-debuginfo.sh
> +++ b/scripts/find-debuginfo.sh
> @@ -247,12 +247,16 @@ add_minidebug()
>local mini_debuginfo=`mktemp`
>  
># In the minisymtab we don't need the .debug_ sections (already removed
> -  # by -S) but also not any other non-allocated PROGBITS or NOTE sections.
> +  # by -S) but also not other non-allocated PROGBITS, NOTE or NOBITS 
> sections.
># List and remove them explicitly. We do want to keep the allocated,
># symbol and NOBITS sections so cannot use --keep-only because that is
># too aggressive. Field $2 is the section name, $3 is the section type
># and $8 are the section flags.
> -  local remove_sections=`readelf -W -S "$debuginfo" | awk '{ if 
> (index($2,".debug_") != 1 && ($3 == "PROGBITS" || $3 == "NOTE") && 
> index($8,"A") == 0) printf "--remove-section "$2" " }'`
> +  local remove_sections=`readelf -W -S "$debuginfo" \
> + | awk '{ if (index($2,".debug_") != 1 \
> +  && ($3 == "PROGBITS" || $3 == "NOTE" || $3 == "NOBITS") \
> +  && index($8,"A") == 0) \
> +printf "--remove-section "$2" " }'`
>  
># Extract the dynamic symbols from the main binary, there is no need to 
> also have these
># in the normal symbol table
> 


-- 

Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Paul Argiry, Charles Cachera, Michael Cunningham,
Michael O'Neill
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [PATCH] replaceSigDigests is only used with IMAEVM.

[Florian Festi]

Pushed.

On 07/19/2017 03:33 PM, Mark Wielaard wrote:
> The replaceSigDigests function is only used in includeFileSignatures
> when WITH_IMAEVM is defined. If not warning is generated.
> 
> Signed-off-by: Mark Wielaard 
> ---
>  sign/rpmgensig.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sign/rpmgensig.c b/sign/rpmgensig.c
> index 0731363..d29c178 100644
> --- a/sign/rpmgensig.c
> +++ b/sign/rpmgensig.c
> @@ -469,6 +469,7 @@ static void unloadImmutableRegion(Header *hdrp, rpmTagVal 
> tag)
>  }
>  }
>  
> +#ifdef WITH_IMAEVM
>  static rpmRC replaceSigDigests(FD_t fd, const char *rpm, Header *sigp,
>  off_t sigStart, off_t sigTargetSize,
>  char *SHA256, char *SHA1, uint8_t *MD5)
> @@ -516,6 +517,7 @@ static rpmRC replaceSigDigests(FD_t fd, const char *rpm, 
> Header *sigp,
>  exit:
>  return rc;
>  }
> +#endif
>  
>  static rpmRC includeFileSignatures(FD_t fd, const char *rpm,
>  Header *sigp, Header *hdrp,
> 


-- 

Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Paul Argiry, Charles Cachera, Michael Cunningham,
Michael O'Neill
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [PATCH] config: Detect major/minor warnings and include the correct system header.

[Florian Festi]

Pushed.

On 07/21/2017 01:24 PM, Mark Wielaard wrote:
> Hi,
> 
> On Thu, 2017-07-20 at 17:06 +0300, Dmitry V. Levin wrote:
>> I'm not sure what sys/mkdev.h does, but glibc's sys/sysmacros.h certainly
>> undefines major, minor, and makedev prior to defining its own versions of
>> these macros.
>>
>> My guess is that these undefs are not needed.
> 
> You are right. This makes the patch simpler. Now we only need to fix the
> AC_HEADER_MAJOR check. Cleaned up patch attached. Retested on rhel7 and
> fedora26.
> 
> sys/mkdev.h is a solaris/bsd thing. I checked and they also undef the
> macros before (re)defining them. Although there they might not be
> defined in another header in the first place.
> 
> Thanks,
> 
> Mark
> 
> 
> 
> ___
> Rpm-maint mailing list
> Rpm-maint@lists.rpm.org
> http://lists.rpm.org/mailman/listinfo/rpm-maint
> 


-- 

Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Paul Argiry, Charles Cachera, Michael Cunningham,
Michael O'Neill
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)

[Igor Gnatenko]

(I hope)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261#issuecomment-316997466___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Add Travis CI testing environment. (#261)

[Igor Gnatenko]

So, now we have semaphoreci! Even it doesn't work on PRs (temporary).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/261#issuecomment-316997426___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] find-debuginfo.sh: Remove non-allocated NOBITS sections from minisymtab. (#267)

[Igor Gnatenko]

seems like @ffesti already merged this manually

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/267#issuecomment-316997135___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] find-debuginfo.sh: Remove non-allocated NOBITS sections from minisymtab. (#267)

[Igor Gnatenko]

Closed #267.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/267#event-1173846662___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] replaceSigDigests is only used with IMAEVM. (#268)

[ニール・ゴンパ]

Okay then...  

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/268#issuecomment-316977080___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] replaceSigDigests is only used with IMAEVM. (#268)

[Igor Gnatenko]

@Conan-Kudo no. It's static function in `.c` file.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/268#issuecomment-316976980___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] replaceSigDigests is only used with IMAEVM. (#268)

[ニール・ゴンパ]

Conan-Kudo approved this pull request.





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/268#pullrequestreview-51449448___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [PATCH] config: Detect major/minor warnings and include the correct system header.

[Mark Wielaard]

Hi,

On Thu, 2017-07-20 at 17:06 +0300, Dmitry V. Levin wrote:
> I'm not sure what sys/mkdev.h does, but glibc's sys/sysmacros.h certainly
> undefines major, minor, and makedev prior to defining its own versions of
> these macros.
> 
> My guess is that these undefs are not needed.

You are right. This makes the patch simpler. Now we only need to fix the
AC_HEADER_MAJOR check. Cleaned up patch attached. Retested on rhel7 and
fedora26.

sys/mkdev.h is a solaris/bsd thing. I checked and they also undef the
macros before (re)defining them. Although there they might not be
defined in another header in the first place.

Thanks,

Mark
From 77a745abd88f278b4c29aadefb2f6c5d47bde5e6 Mon Sep 17 00:00:00 2001
From: Mark Wielaard 
Date: Wed, 19 Jul 2017 14:43:28 +0200
Subject: [PATCH] config: Detect major/minor warnings and include the correct
 system header.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

glibc 2.25 introduced (really long and annoying) warnings for each use
of the major/minor macros from the wrong header:

lib/cpio.c: In function ‘rpmcpioHeaderWrite’:
lib/cpio.c:245:13: warning: In the GNU C Library, "major" is defined
 by . For historical compatibility, it is
 currently defined by  as well, but we plan to
 remove this soon. To use "major", include 
 directly. If you did not intend to use a system-defined macro
 "major", you should undefine it after including .
 dev = major(st->st_dev); SET_NUM_FIELD(hdr->devMajor, dev, field);
 ^~

Adjust the configure check to correctly detect the header to include
that doesn't produce those warning producing macros.

Tested against RHEL7 (glibc 2.17) and Fedora 26 (glibc 2.25).

Signed-off-by: Mark Wielaard 
---
 configure.ac | 8 
 1 file changed, 8 insertions(+)

diff --git a/configure.ac b/configure.ac
index cc657ec..017a908 100644
--- a/configure.ac
+++ b/configure.ac
@@ -561,7 +561,15 @@ AM_ICONV
 
 dnl Checks for header files we can live without.
 AC_HEADER_STDC
+dnl glibc and autoconf don't really play well together.
+dnl glibc will produce a warning when including the wrong header.
+dnl but still define major and minor. Causing us to include the header
+dnl that produces a giant warning for each major/minor use.
+dnl Use -Werror to work around that.
+old_CFLAGS=$CFLAGS
+CFLAGS="$CFLAGS -Werror"
 AC_HEADER_MAJOR
+CFLAGS=$old_CFLAGS
 AC_STRUCT_DIRENT_D_TYPE
 
 AC_CHECK_HEADERS(limits.h)
-- 
1.8.3.1

___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] replaceSigDigests is only used with IMAEVM. (#268)

[ニール・ゴンパ]

@ignatenkobrain Isn't this public API, though?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/268#issuecomment-316950916___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: Offer LMDB as an alternative engine to BDB for rpmdb (#128)

[Leonid Yuriev]

@Conan-Kudo, please take look to https://github.com/ReOpen/libmdbx/tree/devel 
and https://github.com/PositiveTechnologies/libfpta

-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/128#issuecomment-316928065___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint