Re: [Rpm-maint] [rpm-software-management/rpm] Add zstd compressed payload support to RPM (#295)

2017-07-30 Thread ニール・ゴンパ 
@Conan-Kudo pushed 1 commit.

f86b7c2  ci: Add libzstd-devel to CI Dockerfile


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/295/files/5678c29a524d842403b068aa040a9f8ade7d4789..f86b7c211b5588b69620aac43db5a7e0dd0e7f9a
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

[Rpm-maint] [rpm-software-management/rpm] Add zstd compressed payload support to RPM (#295)

2017-07-30 Thread ニール・ゴンパ 
This PR adds support for zstd compressed payloads for RPMs. This addresses the 
issues with duplicate m4 files with #283 and adds proper attribution.

Obsoletes #283 
Closes #256 
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/295

-- Commit Summary --

  * Add acinclude.m4 with RPM_CHECK_LIB m4 macro
  * Add zstd compressed payload support to RPM

-- File Changes --

A acinclude.m4 (537)
M build/pack.c (6)
M build/parsePrep.c (3)
M configure.ac (15)
M lib/rpmds.c (5)
M macros.in (1)
M rpmio/macro.c (3)
M rpmio/rpmfileutil.c (3)
M rpmio/rpmfileutil.h (3)
M rpmio/rpmio.c (251)
M scripts/rpm2cpio.sh (1)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/295.patch
https://github.com/rpm-software-management/rpm/pull/295.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/295
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Add LMDB backend for RPMDB to RPM (from @n3npq in #281) (#291)

2017-07-30 Thread Jeff Johnson 
@Conan-Kudo : if using RPM_CHECK_LIB w internal, its a bit trickier than just 
adding a checkout.
So you likely want to remove "internal" as the 1st thing to try in 
"[yes,internal:external:none]"

FYI, removing "none" as in (yes,external) will fail to configure if not found 
(i.e. mandatory)

And in all cases you can add --with-lmdb=internal, or --without-lmedb, or 
--with-lmdb=no etc etc etc.

IRPM_CHECK_LIB is mostly intuitive once you get the hang of what is what


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/291#issuecomment-318945518___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Add LMDB backend for RPMDB to RPM (from @n3npq in #281) (#291)

2017-07-30 Thread Jeff Johnson 
@ignatenkobrain : I don't send PR's because I don't have the 
time/energy/resources to wait months for review, updating the PR with zero 
feedback other than "Why don't you send PR's?". That's why.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/291#issuecomment-318943069___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Colorized rpmlog() output (#225)

2017-07-30 Thread ニール・ゴンパ 
Conan-Kudo approved this pull request.





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/225#pullrequestreview-53110650___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)

2017-07-30 Thread proyvind 
brp-clean-files is convenient as it'll simply make sure that files which surely 
has no place in builldroot are removed and accidental packaging of is prevented.

The script is extremely simple and the most trivial one in this PR, so I fail 
to see your concern about it might break something.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/122#issuecomment-318936377___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)

2017-07-30 Thread proyvind 
No idea what you mean by prefering users explicitly doing the right thing..
Trying to interpret it, it seems to contradict the purpose of these scripts in 
general, avoiding users having to explicitly take care of things that can be 
safely automized and handled automatically outside of spec files.
Requiring packagers to explictly do the right thing is not a good argument as 
you really wanna avoid the chance of human errors (which are the most common 
error of all) as much as possible.

brp-relink-symlinks was written long time ago and has been in production use 
since without any issues.

For "too magic", I'd rather think of it as doing it in the most 
reliable/correct fashion.

It would be far more constructive with comments about the scripts behaviour, 
purpose and how implemented rather than raising concerns based on false 
assumptions about the condition of.




-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/122#issuecomment-318936019___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)

2017-07-30 Thread proyvind 
For the package exceptions requiring the libtool .la files, you have a disabler 
macro.
That's the whole point of the disabler macros in general, while enabling the 
scripts are desired in most cases, thus enabled by default, there always might 
be exceptions where not desired and for those you can simply use the disablers.

And disabler macros are added for scripts for consistency (regardless of 
perceived usefulness of disabling any particular behaviour of individual 
scripts).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/122#issuecomment-318934817___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)

2017-07-30 Thread proyvind 
proyvind commented on this pull request.



> @@ -0,0 +1,17 @@
+#!/bin/sh
+# Fix .desktop files to be compliant with XDG specification

Why? .desktop files issuee corrected by this script is quite widespread and 
goes often unnoticed.

Trivial to automatically fix with script, tedious to manually pursue fixing...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/122#discussion_r130254470___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] add support for %{shrink:}, derived from rpm5.org (#234)

2017-07-30 Thread proyvind 
why remove attribution from commit message?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/234#issuecomment-318933780___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] digest_openssl: return failure if setting key failed (#293)

2017-07-30 Thread Florian Festi 
Merged #293.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/293#event-1184919353___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] fix couple of memory leaks in rpmbuild (#292)

2017-07-30 Thread Florian Festi 
Merged #292.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/292#event-1184918766___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Add LMDB backend for RPMDB to RPM (from @n3npq in #281) (#291)

2017-07-30 Thread ニール・ゴンパ 
@n3npq @hyc @ignatenkobrain This should be fully rebased now.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/291#issuecomment-318926969___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Add LMDB backend for RPMDB to RPM (from @n3npq in #281) (#291)

2017-07-30 Thread ニール・ゴンパ 
@Conan-Kudo pushed 1 commit.

c2cad9d  Remove MDB_FIXEDMAP flag to prevent portability issues


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/291/files/2864bc4a3cb8905abbed1e833e50e03a6aded5d3..c2cad9da9e06997a5083fbf0eb4ace1ae3f78e1f
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Macro arguments do not support quoting (#222)

2017-07-30 Thread Igor Gnatenko 
Closed #222.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/222#event-1184895706___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Macro arguments do not support quoting (#222)

2017-07-30 Thread Igor Gnatenko 
```
[brain@ignatenko-w541 kojilogs]$ ~/Projects/upstream/rpm/rpm --define "%foo() 
1:%1 2:%2" --eval "%foo %nil bar"
1:bar 2:%2
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/222#issuecomment-318926307___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Make the default DB backend macro configurable (#157)

2017-07-30 Thread Igor Gnatenko 
@ffesti should we close this issue?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/157#issuecomment-318926262___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Zstd compression support (from jbj) (#283)

2017-07-30 Thread Igor Gnatenko 
ignatenkobrain requested changes on this pull request.

and also, use --author when doing commit instead of stealing work done by 
others.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/283#pullrequestreview-53105075___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Zstd compression support (from jbj) (#283)

2017-07-30 Thread Igor Gnatenko 
ignatenkobrain commented on this pull request.



> +dnl ##  NAME:
+dnl ##AC_MSG_VERBOSE -- Display a message under --verbose
+dnl ##
+dnl ##  USAGE:
+dnl ##AC_MSG_VERBOSE()
+dnl ##
+
+AC_DEFUN([AC_MSG_VERBOSE], [
+if test ".$verbose" = .yes; then
+_AS_ECHO([$1])
+fi
+])
+
+dnl ##
+dnl ##  NAME:
+dnl ##RPM_CHECK_LIB -- Check for third-party libraries

and such things as well... personally I think we should just stick to pkgconfig 
and do not care about anything else. pkgconfig is standard de-facto.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/283#pullrequestreview-53105067___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Zstd compression support (from jbj) (#283)

2017-07-30 Thread Igor Gnatenko 
ignatenkobrain commented on this pull request.



> +
+dnl ##
+dnl ##  NAME:
+dnl ##AC_MSG_TITLE -- Display a configuration title
+dnl ##
+dnl ##  USAGE:
+dnl ##AC_MSG_TITLE(, )
+dnl ##
+
+AC_DEFUN([AC_MSG_TITLE],[
+_AS_ECHO([Configuring $1, Version $2])
+])
+
+dnl ##
+dnl ##  NAME:
+dnl ##AC_MSG_HEADER -- Display a configuration header

such things should go to autoconf (or autoconf-archive).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/283#pullrequestreview-53105045___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Zstd compression support (from jbj) (#283)

2017-07-30 Thread Igor Gnatenko 
ignatenkobrain commented on this pull request.



> @@ -0,0 +1,537 @@
+dnl ##
+dnl ##  acinclude.m4 -- manually provided local Autoconf macros
+dnl ##
+
+dnl ##
+dnl ##  NAME:
+dnl ##AC_MSG_TITLE -- Display a configuration title

such things should go to autoconf (or autoconf-archive).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/283#pullrequestreview-53105041___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Colorized rpmlog() output (#225)

2017-07-30 Thread Igor Gnatenko 
ignatenkobrain approved this pull request.





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/225#pullrequestreview-53104988___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] add support for %{shrink:}, derived from rpm5.org (#234)

2017-07-30 Thread Igor Gnatenko 
ignatenkobrain requested changes on this pull request.

@proyvind please remove `derived from rpm5.org` from commit message and rebase 
against current master.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/234#pullrequestreview-53104973___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Run binary package generation via thread pools (#226)

2017-07-30 Thread Igor Gnatenko 
@kanavin any news here?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/226#issuecomment-318925604___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] add RPM_CHECK_LIB m4 macro (from jbj) (#282)

2017-07-30 Thread Igor Gnatenko 
without real usage, just adding macro is useless. closing in favor of #283

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/282#issuecomment-318925523___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Add LMDB backend for RPMDB to RPM (from @n3npq in #281) (#291)

2017-07-30 Thread Jeff Johnson 
See also comments at issue #281 about removing MDB_FIXEDMAP. Just delete the 
line that looks like
`eflags |= MDB_FIXEDMAP`

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/291#issuecomment-318921238___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Add LMDB backend for RPMDB to RPM (from @n3npq in #281) (#291)

2017-07-30 Thread Igor Gnatenko 
@n3npq why don't you send Pull Requests on your own. finding this attachments 
and converting them to real commits is painful and doesn't lead anywhere...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/291#issuecomment-318921157___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

[Rpm-maint] [rpm-software-management/rpm] RFE: include only used debuginfo files even if _debuginfo_subpackages is disabled (#294)

2017-07-30 Thread Igor Gnatenko 
Currently, we just include everything under /usr/lib/debug to debuginfo package 
(even debug files for excluded binaries). When we use debuginfo subpackages, we 
strictly filter files out. We need to backport this functionality into 
one-big-debuginfo-style packages.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/294___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Adding an LMDB backend to RPM (#281)

2017-07-30 Thread hyc 
OK, best to turn it off. We were experimenting with it in OpenLDAP because we 
wanted to store pointer-based structures with live pointers and not need 
explicit serialization/deserialization. (I.e., all pointers in the struct just 
point to other parts of the mmap'd object.) It's a pretty specialized use case, 
and quite fragile in the face of growing map sizes.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/281#issuecomment-318916495___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Add LMDB backend for RPMDB to RPM (from @n3npq in #281) (#291)

2017-07-30 Thread Jeff Johnson 
BDB and LMDB have always had the ability to have mutable databases (actually 
tables) in a single file. So actually there is a "Packages" 
(sub-)database/table in data.mdb.

Since 2 of 3 backend now have sub-databases in a single file, its likely time 
to do the same with BDB. I've never bothered to do that because people are used 
to using "ls -al" to see the relative size of files: with sub-databases you 
need to run db_stat or mob_stat to see what is using space.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/291#issuecomment-318911138___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

[Rpm-maint] [rpm-software-management/rpm] digest_openssl: return failure if setting key failed (#293)

2017-07-30 Thread Igor Gnatenko 
```
digest_openssl.c:552:9: warning: Value stored to 'rc' is never read
rc = 0;
^~
```

Acked-by: Stephen Gallagher 
Signed-off-by: Igor Gnatenko 
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/293

-- Commit Summary --

  * digest_openssl: return failure if setting key failed

-- File Changes --

M rpmio/digest_openssl.c (1)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/293.patch
https://github.com/rpm-software-management/rpm/pull/293.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/293
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

[Rpm-maint] [rpm-software-management/rpm] fix couple of memory leaks in rpmbuild (#292)

2017-07-30 Thread Igor Gnatenko 
```
==9077== 336 (40 direct, 296 indirect) bytes in 1 blocks are definitely lost in 
loss record 32 of 37
==9077==at 0x4C31C15: realloc (vg_replace_malloc.c:785)
==9077==by 0x57575B7: rrealloc (rpmmalloc.c:65)
==9077==by 0x574FEE2: argvAdd (argv.c:138)
==9077==by 0x4E45C8E: addNewIDSymlink (files.c:1705)
==9077==by 0x4E4B946: generateBuildIDs (files.c:1969)
==9077==by 0x4E4B946: processPackageFiles (files.c:2542)
==9077==by 0x4E4B946: processBinaryFiles (files.c:3076)
==9077==by 0x4E44180: buildSpec (build.c:262)
==9077==by 0x402E6E: buildForTarget.constprop.1 (rpmbuild.c:517)
==9077==by 0x4030CA: build.constprop.0 (rpmbuild.c:550)
==9077==by 0x4020AA: main (rpmbuild.c:697)
==9077==
==9077== 487 (48 direct, 439 indirect) bytes in 1 blocks are definitely lost in 
loss record 33 of 37
==9077==at 0x4C31C15: realloc (vg_replace_malloc.c:785)
==9077==by 0x57575B7: rrealloc (rpmmalloc.c:65)
==9077==by 0x574FEE2: argvAdd (argv.c:138)
==9077==by 0x4E45C8E: addNewIDSymlink (files.c:1705)
==9077==by 0x4E4BB74: generateBuildIDs (files.c:2015)
==9077==by 0x4E4BB74: processPackageFiles (files.c:2542)
==9077==by 0x4E4BB74: processBinaryFiles (files.c:3076)
==9077==by 0x4E44180: buildSpec (build.c:262)
==9077==by 0x402E6E: buildForTarget.constprop.1 (rpmbuild.c:517)
==9077==by 0x4030CA: build.constprop.0 (rpmbuild.c:550)
==9077==by 0x4020AA: main (rpmbuild.c:697)
==9077==
==9077== 149,066 (144 direct, 148,922 indirect) bytes in 2 blocks are 
definitely lost in loss record 37 of 37
==9077==at 0x4C31A1E: calloc (vg_replace_malloc.c:711)
==9077==by 0x575757E: rcalloc (rpmmalloc.c:55)
==9077==by 0x509FCEE: initIter (rpmfi.c:1684)
==9077==by 0x4E4A611: filterDebuginfoPackage (files.c:2831)
==9077==by 0x4E4A611: processBinaryFiles (files.c:3080)
==9077==by 0x4E44180: buildSpec (build.c:262)
==9077==by 0x402E6E: buildForTarget.constprop.1 (rpmbuild.c:517)
==9077==by 0x4030CA: build.constprop.0 (rpmbuild.c:550)
==9077==by 0x4020AA: main (rpmbuild.c:697)
```

Signed-off-by: Igor Gnatenko 
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/292

-- Commit Summary --

  * fix couple of memory leaks in rpmbuild

-- File Changes --

M build/files.c (3)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/292.patch
https://github.com/rpm-software-management/rpm/pull/292.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/292
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Adding an LMDB backend to RPM (#281)

2017-07-30 Thread hyc 
Why are you using FIXEDMAP? That's going to lead to portability issues.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/281#issuecomment-318897281___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Add LMDB backend for RPMDB to RPM (from @n3npq in #281) (#291)

2017-07-30 Thread Robert Scheck 
Is it intended, that it's called `/data.mdb` rather `/Packages.mdb`?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/291#issuecomment-318894429___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint