[Rpm-maint] [rpm-software-management/rpm] Fix typos in sv.po (#576)

2018-10-18 Thread Johan Heikkilä

You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/576

-- Commit Summary --

  * Fix typos in sv.po

-- File Changes --

M po/sv.po (4)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/576.patch
https://github.com/rpm-software-management/rpm/pull/576.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/576
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Macros: Use full build template (#480)

2018-10-18 Thread Panu Matilainen
Finally got around to look at this a bit, it's a bit of a trip down the memory 
lane as I remember looking at the build template stuff in the macros file some 
15+ years ago and wondering why it was never finished :slightly_smiling_face: 

I suppose we do want this in some form at least, but escaping all the %'s kind 
of nullifies the potential benefit of being able to re-expand macros at 
build-time (vs spec parse time). I kinda doubt those weird%%names are that 
common that we couldn't break it, as long as there's an easy way to around it 
(escapes, quoting, whatever)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/480#issuecomment-430934713___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] RFE: make %{load: } work in %prep (#571)

2018-10-18 Thread Panu Matilainen
Actually rpm does perform further expansions at the time of build too for the 
various section templates, BUT the script itself from the spec is not 
re-expanded. PR #480 sort of does this, except that it escapes all percent 
signs automatically which in turn prevents actual macros from being expanded, 
which makes it all a bit moot. With a bit of modification to disable the 
escaping, #480 actually allows you do place %%{load:...} at the beginning of 
%prep and evaluated during build. Even then it's fairly non-obvious and klunky 
because the macro will not be evaluated in the context of the shell script it 
appears in, so eg relative paths wont work. So it becomes
```
%%{load:%{_builddir}/%{buildsubdir}/rpm/macros.fonts}
```

...and I'm not at all conviced that all this makes it somehow better and less 
hacky than using the shell.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/571#issuecomment-430931491___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] RFE: make %{load: } work in %prep (#571)

2018-10-18 Thread Panu Matilainen
@nim-nim , ah sorry I missed the link in initial description and somehow 
thought the "linked bit" meant something entirely different.

The issue here is not that %{load:..} does not work from %prep. It does, but at 
the time of *parse*, not build. And since the macros file in question is packed 
inside the source tarball, it's only available after unpacking - in other 
words, during build. If macros.fonts were a separate standalone %{SOURCE}, you 
could %{load:..} it from the spec.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/571#issuecomment-430918837___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint