Re: [Rpm-maint] [rpm-software-management/rpm] Dynamic Build Dependencies (#593)
@ffesti pushed 1 commit. a5707b3 Fix copy in paste error in d6c4fff2029d7996389d40047fb1893edcf7fdd5 -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/593/files/a1607e5d985d8be742d99e88d06d0a011938caab..a5707b3a2f863e5825e54351ad2c8b7a0d04ef5a ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Dynamic Build Dependencies (#593)
Fixed. Nice catch! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/593#issuecomment-436316583___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Rename parseBuildInstallClean() to something more generic (d6c4fff)
build/parseSpec.c:804 has a cut-and-paste error -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/commit/d6c4fff2029d7996389d40047fb1893edcf7fdd5#commitcomment-31194485___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Dynamic Build Dependencies (#593)
Thinking a bit more rpmbuild should probably continue building the srpm with the generated BuildRequires included (probably depending on command line options) even when failing the build of the binary packages due to missing BuildRequires. So build systems could setup the second attempt using the newly build srpm. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/593#issuecomment-436261484___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Dynamic Build Dependencies (#593)
ffesti commented on this pull request. > case PART_CLEAN: - parsePart = parseBuildInstallClean(spec, parsePart); + parsePart = parseSimpleScript(spec, "%clean", &(spec->clean)); Yeah, this is a separate patch already. Pushed to master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/593#discussion_r231105774___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Dynamic Build Dependencies (#593)
pmatilai commented on this pull request. > case PART_CLEAN: - parsePart = parseBuildInstallClean(spec, parsePart); + parsePart = parseSimpleScript(spec, "%clean", &(spec->clean)); The parseBuildInstallClean() -> parseSimpleScript() generalisation makes sense regardless of the rest of this, please split that part into a separate commit and push. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/593#pullrequestreview-171988236___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Dynamic Build Dependencies (#593)
Oh, rpmbuild also needs to grow a cli param to control the execution of the %generate_buildrequires section. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/593#issuecomment-436228752___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Dynamic Build Dependencies (#593)
As discussed in #104 this allows adding a %generate_buildrequires section to spec files. The sections stdout is read in as BuildRequires and are checked. If some are missing the build is aborted. This is still in a prove of concept state. The dependencies added to the SRPM for this features need to be thought through more thoroughly. Stopping the build for missing dependencies also deserves its own return code of rpmbuild. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/593 -- Commit Summary -- * BuildRequires POC * Rename parseBuildInstallClean() to something more generic * Dependencies for DynamicBuildRequires * Rename section to %generate_buildrequires -- File Changes -- M build/Makefile.am (2) M build/build.c (95) M build/pack.c (4) R build/parseSimpleScript.c (20) M build/parseSpec.c (12) M build/rpmbuild.h (1) M build/rpmbuild_internal.h (8) M rpmbuild.c (1) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/593.patch https://github.com/rpm-software-management/rpm/pull/593.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/593 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
