Re: [Rpm-maint] [rpm-software-management/rpm] Add --zlib-compress-debug-sections to find-debug-info.sh (#795)
> Note that eu-elfcompress does the same. Not that it really should matter
> which tool does it.
> Currently find-debuginfo.sh uses tools from both binutils and elfutils, it
> might be nice to only
> depend on one set of tools (my preference would obviously be to migrate
> everything to the
> elfutils toolset).
I have no preference at this point. AFAIU both tools use the same zlib library
to do the compression, so there's no benefit from choosing on or the other.
> There is also zlib-gnu, the older, pre-standard, compression. Dunno if we
> want to support that
> too.
I don't see that as useful now, but it's easy to add later if someone want this.
> I do think that this is a nice option to have in theory. But I haven't tried
> it myself yet
OK, good to hear.
>> https://github.com/rpm-software-management/rpm/pull/795.patch
>> https://github.com/rpm-software-management/rpm/pull/795.diff
>> - id="`readelf -Wn
>> "${RPM_BUILD_ROOT}/usr/lib/debug/.dwz/${dwz_multifile_name}" \ - 2>/dev/null
>> | sed -n 's/^ Build ID: \([0-9a-f]\+\)/\1/p'`"
> I am slightly surprised we don't seem to use the dwz build-id. Could you
> double check
> we don't actually need that id?
AFAIU, yes, we don't need it. I've split this part off into a separate pull
request: https://github.com/rpm-software-management/rpm/pull/825.
> Also, is there really no distro that is contemplating to use this?
>If not, then maybe it is better to not add the extra complexity till someone
>really wants it
Well, my intention is to propose this as patch for the rpm package in openSUSE
Tumbleweed, either as upstream backport, or as local patch. Obviously I'd
prefer a backport ;) .
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/795#issuecomment-524822852___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Remove unused variable id in find-debuginfo.sh (#825)
Merged #825 into master. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/825#event-2583287429___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Remove unused variable id in find-debuginfo.sh (#825)
Okay, thanks for the patch + review guys. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/825#issuecomment-524813925___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Remove unused variable id in find-debuginfo.sh (#825)
Hi, On Mon, Aug 26, 2019 at 02:44:22AM -0700, Tom de Vries wrote: > There's code setting variable id in scripts/find-debuginfo.sh, but there's no > subsequent use. The only use of $id in the script is in do_file, where it is > a local variable. > > The variable setting was introduced in commit 6b3b435fa "Add dwz debuginfo > compression support" in combination with a subsequent make_id_link using the > variable, but the make_id_link was removed in commit bbfe1f86b > "Add build-id links to rpm for all ELF files". > > Remove the unused variable. Thanks for looking through the history. This makes sense, the id variable should have been removed when the only usage of it for make_id_link was removed. Now it just does extra work for nothing. Cheers, Mark ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] rpm ignores architecture when creating self-erasures (#408)
This is fixed with commit 0fcf8c2b8692fbe06b0bb353247f9d70c91c14a1 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/408#issuecomment-524798212___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] rpm ignores architecture when creating self-erasures (#408)
Closed #408. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/408#event-2583153766___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Remove unused variable id in find-debuginfo.sh (#825)
Earlier submitted as part of https://github.com/rpm-software-management/rpm/pull/795 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/825#issuecomment-524796434___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Remove unused variable id in find-debuginfo.sh (#825)
There's code setting variable id in scripts/find-debuginfo.sh, but there's no subsequent use. The only use of $id in the script is in do_file, where it is a local variable. The variable setting was introduced in commit 6b3b435fa "Add dwz debuginfo compression support" in combination with a subsequent make_id_link using the variable, but the make_id_link was removed in commit bbfe1f86b "Add build-id links to rpm for all ELF files". Remove the unused variable. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/825 -- Commit Summary -- * Remove unused variable id in find-debuginfo.sh -- File Changes -- M scripts/find-debuginfo.sh (4) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/825.patch https://github.com/rpm-software-management/rpm/pull/825.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/825 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Make dependency generation test payload-compression agnostic (#824)
Non-gzip compression introduces extra dependencies to packages, force gzip compression on the dependency generation test to avoid basically false failures. This lets us run the test-suite with other compression methods as needed (but not changing any defaults here) Also document zstd compression in macros file. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/824 -- Commit Summary -- * Document zstd compression in main macros file * Make dependency generation test payload-compression agnostic -- File Changes -- M macros.in (1) M tests/rpmbuild.at (1) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/824.patch https://github.com/rpm-software-management/rpm/pull/824.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/824 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
