Re: [Rpm-maint] [rpm-software-management/rpm] Cleanup gpg-agent handling in test-suite (#1270)
Merged #1270 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1270#event-3445622887___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix data race in packageBinaries() function (#1264)
> Okay, the problem is fairly obvious, pkg being declared way outside the
> parallel block.
> But rather than sprinkling more OpenMP magic dust to solve it, can you verify
> that this (ie just declare the variable inside the parallel block) solves the
> problem?
>
> ```
> #pragma omp single
> for (int i = 0; i < npkgs; i++) {
> - pkg = tasks[i];
> + Package pkg = tasks[i];
I just checked and doing this also fixes the bug.
> #pragma omp task untied priority(i)
> {
> pkg->rc = packageBinary(spec, pkg, cookie, cheating, >filename);
> ```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1264#issuecomment-644201067___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Make the "rpmbuild debuginfo -g3 .debug_macro" test an expected fail … (#1267)
Would it be possible to backport this to the 4.16 branch? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1267#issuecomment-644187292___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Cleanup gpg-agent handling in test-suite (#1270)
Localize the setup/teardown to the only place needing it. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1270 -- Commit Summary -- * Merge obsoletion tests sharing built content to single group * Merge dependency tests sharing built material to common groups * Merge %config tests sharing built content into common groups * Merge %config symlink tests sharing built content into common groups * Merge config filetype change tests sharing built content into common groups * Merge file type replacement tests sharing built content into common groups * Merge spec conditional tests into one group * Eliminate redundant source file copying from build tests * Merge minimize_writes tests sharing built content into common groups * Merge --addsign tests into a a common group * Localize gpg-agent setup to --addsign tests -- File Changes -- M tests/Makefile.am (6) M tests/local.at (2) M tests/rpmbuild.at (123) M tests/rpmbuildid.at (72) M tests/rpmconfig.at (401) M tests/rpmconfig2.at (315) M tests/rpmconfig3.at (99) M tests/rpmdeps.at (378) M tests/rpmi.at (20) M tests/rpmreplace.at (79) M tests/rpmsigdig.at (72) M tests/rpmverify.at (72) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/1270.patch https://github.com/rpm-software-management/rpm/pull/1270.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1270 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Testsuite cleanup (#1269)
Wow! You now basically halved the time of the test suite takes. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1269#issuecomment-644031870___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Testsuite cleanup (#1269)
Merged #1269 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1269#event-3443606399___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Testsuite cleanup (#1269)
Just for the record, this cuts down the running time of `./rpmtest -j8` on my laptop from ~52s to ~40s. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1269#issuecomment-644027426___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix data race in packageBinaries() function (#1264)
Okay, the problem is fairly obvious, pkg being declared way outside the
parallel block.
But rather than sprinkling more OpenMP magic dust to solve it, can you verify
that this (ie just declare the variable inside the parallel block) solves the
problem?
``` #pragma omp parallel
#pragma omp single
for (int i = 0; i < npkgs; i++) {
- pkg = tasks[i];
+ Package pkg = tasks[i];
#pragma omp task untied priority(i)
{
pkg->rc = packageBinary(spec, pkg, cookie, cheating, >filename);
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1264#issuecomment-643998971___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Testsuite cleanup (#1269)
Merge tests to groups when they share built content to avoid redundant builds over and over again, eliminate redundant copies on build tests etc. Besides removing gobs of crud, makes it run faster too. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1269 -- Commit Summary -- * Merge obsoletion tests sharing built content to single group * Merge dependency tests sharing built material to common groups * Merge %config tests sharing built content into common groups * Merge %config symlink tests sharing built content into common groups * Merge config filetype change tests sharing built content into common groups * Merge file type replacement tests sharing built content into common groups * Merge spec conditional tests into one group * Eliminate redundant source file copying from build tests * Merge minimize_writes tests sharing built content into common groups -- File Changes -- M tests/local.at (2) M tests/rpmbuild.at (123) M tests/rpmbuildid.at (72) M tests/rpmconfig.at (401) M tests/rpmconfig2.at (315) M tests/rpmconfig3.at (99) M tests/rpmdeps.at (378) M tests/rpmi.at (20) M tests/rpmreplace.at (79) M tests/rpmverify.at (72) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/1269.patch https://github.com/rpm-software-management/rpm/pull/1269.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1269 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RPM fsverity support (#1203)
> RPM doesn't actually need the fsverity utility to be present, but it does > need libfsverity Yup, the library is what I meant by my comment, not the utility. Thanks for adding the check. I'll need to take closer look at the updated version but overall I think its in fair shape for this point, and the added tags totally reasonable. So I'm considering the tags reserved, and there are no competing tag additions at the moment, but if it makes you sleep better we can certainly merge the tag addition right away to cement the reservation. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1203#issuecomment-643925438___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
