Re: [Rpm-maint] [rpm-software-management/rpm] pythondistdeps: Switch to importlib.metadata (#1317)

2020-08-11 Thread torsava
> Any updates on the test suite investigation? Is there anything I can do to 
> help?

@s-t-e-v-e-n-k Apologies, I got buried under different priorities. I'll try to 
get this in a few days.

If you'd like to see on your own, the test suite for `pythondistdeps.py` is 
currently only in our Fedora repo here: 
https://src.fedoraproject.org/rpms/python-rpm-generators/blob/master/f/tests 
(file `test_scripts_pythondistdeps.py` and folder 
`data/scripts_pythondistdeps`).

Apologies for the location, the test suite was rejected here in the RPM repo 
for complexity. A new upstream repo for Python RPM scripts is planned (but that 
hasn't been created yet), so I'll be adding it there when possible.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1317#issuecomment-672061507___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Missing concise descriptions for rpm header tags (#1319)

2020-08-11 Thread Bernhard Schuster
anyone :question: 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1319#issuecomment-671953452___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] debugedit: Fix missing relocation of .debug_types section. (#1323)

2020-08-11 Thread Mark Wielaard
On Sat, Aug 08, 2020 at 07:04:03AM +0200, Jan Kratochvil wrote:
> On Fri, 07 Aug 2020 13:55:35 +0200, Mark Wielaard wrote:
> > But I pulled
> > that branch and reviewed the actual commits (1d080e02 and c804a960).
> 
> git clone -b types g...@github.com:jankratochvil/rpm.git rpm-types
> 
> commit 8b5bbcc6d586be50b6a251256c39c3b0332b1f2b
> debugedit: Fix missing relocation of .debug_types section.
> commit 1d080e02409d181169d3aec2a19192418f253fd3
> [NFC] debugedit: Move code from edit_dwarf2() to edit_info().
> 
> 
> > It would be better to have a separate RPM_DEBUGEDIT_TYPES_SETUP that
> > does that and leave RPM_DEBUGEDIT_SETUP as is. Otherwise we change the
> > existing tests too.
> 
> done as: RPM_DEBUGEDIT_SETUP([-fdebug-types-section])

Nice. Using $1 is better than what I suggested.

Commits look good. Should go into the main branch IMHO.

Thanks,

Mark
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] rpmplugin.h

2020-08-11 Thread Iosif Menshikov
Greetings!

My question is about Plugin API, more precisely, about rpmplugin.h header. Even 
it is widely used in your own plugins, it is not included in package after 
installation. Are there any reasons to keep this header uninstalled? I know, 
that plugins' documentation labeled "DRAFT", but it seems like plugins work 
pretty well.

Thanks and Regards,
Iosif
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Can not parse CHANGELOGTEXT from the specfile (#1301)

2020-08-11 Thread Florian Festi
Closed #1301 via #1328.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1301#event-3641565661___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Fix changelog trimming to work relative to newest existing entry (#1301) (#1328)

2020-08-11 Thread Florian Festi
Merged #1328 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1328#event-3641565651___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint