Re: [Rpm-maint] [rpm-software-management/rpm] Add proper quotation support to %files (PR #2206)
@pmatilai commented on this pull request.
> t = NULL;
+ end = s + strlen(s) - 1;
+
+ /* Syntax checks */
+ if (quotes == 1) {
+ rpmlog(RPMLOG_ERR, _("Missing quote: %s\n"), s);
I was about to say this should report a line number, but the existing error
message doesn't have that either and the needed context is missing multiple
layers of calls above, so lets not go there now. This series is long enough as
it is :laughing:
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2206#pullrequestreview-1129379847
You are receiving this because you are subscribed to this thread.
Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add manual page for File Mode (PR #2215)
On a more general note: "file mode" makes me think of something in the %files list / chmod. This is only "mode" in the rpmio API, on the macro side it's just known as payload compression, so maybe call the file "payload", with the only subsection (for now) being this, ie the compression? :thinking: -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2215#issuecomment-1266470463 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Make API docs part of the reference manual (Issue #2216)
This looks like one for @ffesti -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2216#issuecomment-1266463704 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Make API docs part of the reference manual (Issue #2216)
The API docs should be made part of the reference manual, appendix or something. The need for this is made rather painfully obvious by #2215. This may be more of a website thing than rpm codebase, but filing here as the docs layout does reflect the reference manual too and I've blissfully forgotten the details. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2216 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add manual page for File Mode (PR #2215)
@pmatilai commented on this pull request.
> +### Example Modes
+
+These are some example mode strings suitable for the payload:
+
+| Mode | Description |
+|---|---|
+|`w9.gzdio`| gzip level 9, RPM payload's default |
+|`w9.bzdio`| bzip2 level 9, bzip2's default|
+|`w6.xzdio`| xz level 6, xz's default |
+|`w7T16.xzdio` | xz level 7 using 16 threads |
+|`w7T0.xzdio` | xz level 7 using `%{getncpus}` threads|
+|`w7T.xzdio` | xz level 7 using `%{getncpus}` threads|
+|`w6.lzdio`| lzma-alone level 6, lzma's default|
+|`w3.zstdio` | zstd level 3, zstd's default |
+|`w19T8.zstdio`| zstd level 19 using 8 threads |
+|`w7T0.zstdio` | zstd level 7 using `%{getncpus}` threads |
Replace %{getncpus} references with broad stroke "auto detected", see above.
I'd add a variant without the explicit compression level, eg 'w.xzdio', because
that's legit too (IIRC) and just means "use whatever the default".
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2215#pullrequestreview-1129355322
You are receiving this because you are subscribed to this thread.
Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add manual page for File Mode (PR #2215)
@pmatilai commented on this pull request. > + +``` +[flags]. +``` + +The `mode` parameter is mandatory and contains a sequence of letters as +described in `fopen(3)`. For payload configuration, only `w` is allowed. + +The `type` parameter is also mandatory and specifies the compression type +(*compressor*) to be used. Currently, the following compressors are supported: + +| Type | Description | +|---|---| +|`gzdio` | gzip ([flags](#gzip-flags)) | +|`bzdio` | bzip2 ([flags](#bzip2-flags)) | +|`xzdio` | lzma ([flags](#xz-lzma-flags))| ...especially as the examples below talk about "xz" -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2215#discussion_r986472566 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add manual page for File Mode (PR #2215)
@pmatilai commented on this pull request.
> +
+These can include a compression level (from 0 to 9) and `T` followed by the
+number of threads to be used during compression, where `T0` (or just `T`) means
+that the optimal number of threads should automatically be chosen based on the
+`%{getncpus}` macro.
+
+ LZMA (Alone) Flags
+
+These can include a compression level (from 0 to 9).
+
+ ZSTD Flags
+
+These can include a compression level (see `-#` in `zstd(1)` for the supported
+values), `T` followed by the number of threads to be used during compression,
+where `T0` means that the optimal number of threads should automatically be
+chosen based on the `%{getncpus}` macro, and `L` followed by a window size that
Ditto here, just say number of threads should be automatically detected, but
don't mention how exactly.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2215#pullrequestreview-1129350780
You are receiving this because you are subscribed to this thread.
Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add manual page for File Mode (PR #2215)
@pmatilai commented on this pull request.
> +
+These can include a compression level (from 0 to 9) and a strategy (e.g. `h`
+for Huffman-only compression). See the description of `gzopen()` in
+`/usr/include/zlib.h` for more details.
+
+ BZIP2 Flags
+
+These can include a compression level (from 1 to 9) and `s` (enables "small
+mode").
+
+ XZ (LZMA) Flags
+
+These can include a compression level (from 0 to 9) and `T` followed by the
+number of threads to be used during compression, where `T0` (or just `T`) means
+that the optimal number of threads should automatically be chosen based on the
+`%{getncpus}` macro.
Too much detail. Just state that plain T/T0 means autodetect.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2215#pullrequestreview-1129350168
You are receiving this because you are subscribed to this thread.
Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add manual page for File Mode (PR #2215)
@pmatilai commented on this pull request. > @@ -0,0 +1,95 @@ +--- +layout: default +title: rpm.org - File Mode +--- +# File Mode + +RPM supports a variety of compression methods through external libraries for +its internal I/O operations. For ease of use, the [RPMIO +API](https://ftp.osuosl.org/pub/rpm/api/4.17.0/group__rpmio.html) offers This points out two things (neither of which is the fault of this PR): - I forgot to upload 4.18 API docs - the API docs need to go into the docs directory too so we link between API and other docs without this kind of thing (that is now outdated from the go, and will require cumbersome constant updating). -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2215#pullrequestreview-1129348380 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add manual page for File Mode (PR #2215)
@pmatilai commented on this pull request. > + +``` +[flags]. +``` + +The `mode` parameter is mandatory and contains a sequence of letters as +described in `fopen(3)`. For payload configuration, only `w` is allowed. + +The `type` parameter is also mandatory and specifies the compression type +(*compressor*) to be used. Currently, the following compressors are supported: + +| Type | Description | +|---|---| +|`gzdio` | gzip ([flags](#gzip-flags)) | +|`bzdio` | bzip2 ([flags](#bzip2-flags)) | +|`xzdio` | lzma ([flags](#xz-lzma-flags))| Just call it XZ in the description too, the real state of affairs here is just too confusing for the uninitiated :smile: -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2215#pullrequestreview-1129345687 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Translations update from Fedora Weblate (PR #2167)
@weblate pushed 6 commits. 7b0b4706f7fa43d50f74b95cbae2af127e0dbdd8 Translated using Weblate (German) 61038b0f11c9f6d9d6a0e2a7b772ad99340bff8c Translated using Weblate (Russian) 2bd5c3456fd9d2b1c3698ae4eea2b5835693ee46 Translated using Weblate (Russian) 4478b8053b0e25ee3a2224c67a285eaee49dd917 Translated using Weblate (Russian) 8abc5d0e9aef96567b6584b557431aca97b9af0f Translated using Weblate (Chinese (Simplified) (zh_CN)) 85bcaf9dce57014bc9d61af833243000bbcedc07 Translated using Weblate (Chinese (Simplified) (zh_CN)) -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2167/files/15d2e80b35d58b1e84b24db14753a7bf3d823272..85bcaf9dce57014bc9d61af833243000bbcedc07 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add manual page for File Mode (PR #2215)
Also note the text doesn't mention the capital/non-capital letter distinction mentioned in https://github.com/rpm-software-management/rpm/pull/1507#issuecomment-1018529205, see my comments in that thread for the context. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2215#issuecomment-1265688073 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add manual page for File Mode (PR #2215)
I'm not entirely convinced that adding a note about macro configuration to the RPM format page makes sense, though, as it's more of a user-facing thing than it is an internal implementation matter... but it's the only place in the docs that we dedicate to the Payload right now, so I can't think of anything better. Ideas welcome. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2215#issuecomment-1265683076 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Add manual page for File Mode (PR #2215)
Fixes: #1895 You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/2215 -- Commit Summary -- * Add manual page for File Mode -- File Changes -- A docs/manual/file_mode.md (95) M docs/manual/format.md (5) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/2215.patch https://github.com/rpm-software-management/rpm/pull/2215.diff -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2215 You are receiving this because you are subscribed to this thread. Message ID:___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] How can I find details on the binary representation of the RPM DB? (Discussion #2211)
> The details of the database format are OFF-LIMITS TO EXTERNAL USERS! > > Sqlite is but one of the possible database formats. If you want to access the > rpm database, you do so through the librpm API. Just because one should not access the rpmdb without going through librpm does not mean that one might not be curious about the actual rpmdb format. I know I am! -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/discussions/2211#discussioncomment-3788032 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] RPM 4.18.0: Build errors
On Mon, 3 Oct 2022 15:35:24 +0300
Panu Matilainen wrote:
> On 9/21/22 19:48, Scott Andrews wrote:
> > %prep
> > %setup -q -n %{name}-%{version}-release
> > sed 's:/bin/sh:/usr/bin/sh:' -i macros.in
> > sh autogen.sh --noconfigure
> >
> > %build
> > _options=( --prefix=/usr
> > --program-prefix=
> > --sysconfdir=/etc
> > --sharedstatedir=/var/lib
> > --localstatedir=/var
> > --with-crypto=libgcrypt
> > --with-gnu-ld
> > --with-archive
> > --with-cap
> > --with-acl
> > --without-selinux
> > --enable-zstd
> > --enable-sqlite
> > --enable-python
> > --disable-openmp
> > --disable-dependency-tracking
> > --disable-silent-rules
> > --disable-nls
> > --disable-rpath)
> > ./configure ${_options[@]}
> > %{make_build}
> >
> > make[3]: Entering directory
> > '/home/rpi/BUILD/rpm-4.18.0-release/docs/man' no -s -t man
> > fr/rpm.8.md -o fr/rpm.8 make[3]: no: No such file or directory
> > make[3]: *** [Makefile:883: fr/rpm.8] Error 127
> > make[3]: Leaving directory
> > '/home/rpi/BUILD/rpm-4.18.0-release/docs/man' make[3]: *** Waiting
> > for unfinished jobs make[3]: Entering directory
> > '/home/rpi/BUILD/rpm-4.18.0-release/docs/man' no -s -t man
> > ja/rpm.8.md -o ja/rpm.8 make[3]: no: No such file or directory
> > make[3]: *** [Makefile:883: ja/rpm.8] Error 127
> > make[3]: Leaving directory
> > '/home/rpi/BUILD/rpm-4.18.0-release/docs/man' make[3]: Entering
> > directory '/home/rpi/BUILD/rpm-4.18.0-release/docs/man' no -s -t man
> > ja/rpm2cpio.8.md -o ja/rpm2cpio.8 make[3]: no: No such file or
> > directory make[3]: *** [Makefile:883: ja/rpm2cpio.8] Error 127
> > make[3]: Leaving directory
> > '/home/rpi/BUILD/rpm-4.18.0-release/docs/man' make[3]: Entering
> > directory '/home/rpi/BUILD/rpm-4.18.0-release/docs/man' no -s -t man
> > ja/rpmbuild.8.md -o ja/rpmbuild.8 make[3]: no: No such file or
> > directory
>
> These are attempts to run 'pandoc' but it's not present, which is
> where the "no" comes from. But pandoc isn't needed building rpm from
> the source tarballs, the manual pages are shipped in the tarball.
> Unless of course the .md files have been touched.
>
> Here's what those timestamps look on my system after unpacking the
> 4.18.0 tarball:
>
> -rw-r--r--. 1 pmatilai pmatilai 34668 Jun 28 10:16 docs/man/fr/rpm.8
> -rw-r--r--. 1 pmatilai pmatilai 30566 Apr 7 14:13
> docs/man/fr/rpm.8.md -rw-r--r--. 1 pmatilai pmatilai 1270 Jun 28
> 10:16 docs/man/ja/rpm2cpio.8 -rw-r--r--. 1 pmatilai pmatilai658
> Apr 7 14:13 docs/man/ja/rpm2cpio.8.md
> -rw-r--r--. 1 pmatilai pmatilai 72339 Jun 28 10:16 docs/man/ja/rpm.8
> -rw-r--r--. 1 pmatilai pmatilai 34450 Apr 7 14:13
> docs/man/ja/rpm.8.md
>
> Also, the beta1 tarball had a bug wrt this, might want to
> double-check that.
>
> - Panu -
>
I cloned the rpm repository and then created a archive of the 4.18.0 tag
When extracting the archive all the timestamps are dated as follows:
./fr:
total 40K
drwxr-xr-x 2 scott scott 4.0K Oct 3 09:55 .
drwxr-xr-x 8 scott scott 4.0K Oct 3 09:55 ..
-rw-r--r-- 1 scott scott 30K Sep 20 08:07 rpm.8.md
./ja:
total 64K
drwxr-xr-x 2 scott scott 4.0K Oct 3 09:55 .
drwxr-xr-x 8 scott scott 4.0K Oct 3 09:55 ..
-rw-r--r-- 1 scott scott 658 Sep 20 08:07 rpm2cpio.8.md
-rw-r--r-- 1 scott scott 34K Sep 20 08:07 rpm.8.md
-rw-r--r-- 1 scott scott 8.5K Sep 20 08:07 rpmbuild.8.md
-rw-r--r-- 1 scott scott 1.6K Sep 20 08:07 rpmgraph.8.md
This if from the tarball on rpm.org:
./fr:
total 76K
drwxr-xr-x 2 scott scott 4.0K Oct 3 10:02 .
drwxr-xr-x 8 scott scott 4.0K Oct 3 10:02 ..
-rw-r--r-- 1 scott scott 34K Jun 28 03:16 rpm.8
-rw-r--r-- 1 scott scott 30K Apr 7 07:13 rpm.8.md
./ja:
total 164K
drwxr-xr-x 2 scott scott 4.0K Oct 3 10:02 .
drwxr-xr-x 8 scott scott 4.0K Oct 3 10:02 ..
-rw-r--r-- 1 scott scott 1.3K Jun 28 03:16 rpm2cpio.8
-rw-r--r-- 1 scott scott 658 Apr 7 07:13 rpm2cpio.8.md
-rw-r--r-- 1 scott scott 71K Jun 28 03:16 rpm.8
-rw-r--r-- 1 scott scott 34K Apr 7 07:13 rpm.8.md
-rw-r--r-- 1 scott scott 18K Jun 28 03:16 rpmbuild.8
-rw-r--r-- 1 scott scott 8.5K Apr 7 07:13 rpmbuild.8.md
-rw-r--r-- 1 scott scott 3.7K Jun 28 03:16 rpmgraph.8
-rw-r--r-- 1 scott scott 1.6K Apr 7 07:13 rpmgraph.8.md
I am on an ARM platform and pandoc is not available
Is there a fix for building from the git version?
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] RPM 4.18.0: Build errors
On 9/21/22 19:48, Scott Andrews wrote:
%prep
%setup -q -n %{name}-%{version}-release
sed 's:/bin/sh:/usr/bin/sh:' -i macros.in
sh autogen.sh --noconfigure
%build
_options=( --prefix=/usr
--program-prefix=
--sysconfdir=/etc
--sharedstatedir=/var/lib
--localstatedir=/var
--with-crypto=libgcrypt
--with-gnu-ld
--with-archive
--with-cap
--with-acl
--without-selinux
--enable-zstd
--enable-sqlite
--enable-python
--disable-openmp
--disable-dependency-tracking
--disable-silent-rules
--disable-nls
--disable-rpath)
./configure ${_options[@]}
%{make_build}
make[3]: Entering directory
'/home/rpi/BUILD/rpm-4.18.0-release/docs/man' no -s -t man fr/rpm.8.md
-o fr/rpm.8 make[3]: no: No such file or directory
make[3]: *** [Makefile:883: fr/rpm.8] Error 127
make[3]: Leaving directory '/home/rpi/BUILD/rpm-4.18.0-release/docs/man'
make[3]: *** Waiting for unfinished jobs
make[3]: Entering directory
'/home/rpi/BUILD/rpm-4.18.0-release/docs/man' no -s -t man ja/rpm.8.md
-o ja/rpm.8 make[3]: no: No such file or directory
make[3]: *** [Makefile:883: ja/rpm.8] Error 127
make[3]: Leaving directory '/home/rpi/BUILD/rpm-4.18.0-release/docs/man'
make[3]: Entering directory
'/home/rpi/BUILD/rpm-4.18.0-release/docs/man' no -s -t man
ja/rpm2cpio.8.md -o ja/rpm2cpio.8 make[3]: no: No such file or directory
make[3]: *** [Makefile:883: ja/rpm2cpio.8] Error 127
make[3]: Leaving directory '/home/rpi/BUILD/rpm-4.18.0-release/docs/man'
make[3]: Entering directory
'/home/rpi/BUILD/rpm-4.18.0-release/docs/man' no -s -t man
ja/rpmbuild.8.md -o ja/rpmbuild.8 make[3]: no: No such file or directory
These are attempts to run 'pandoc' but it's not present, which is where
the "no" comes from. But pandoc isn't needed building rpm from the
source tarballs, the manual pages are shipped in the tarball. Unless of
course the .md files have been touched.
Here's what those timestamps look on my system after unpacking the
4.18.0 tarball:
-rw-r--r--. 1 pmatilai pmatilai 34668 Jun 28 10:16 docs/man/fr/rpm.8
-rw-r--r--. 1 pmatilai pmatilai 30566 Apr 7 14:13 docs/man/fr/rpm.8.md
-rw-r--r--. 1 pmatilai pmatilai 1270 Jun 28 10:16 docs/man/ja/rpm2cpio.8
-rw-r--r--. 1 pmatilai pmatilai658 Apr 7 14:13
docs/man/ja/rpm2cpio.8.md
-rw-r--r--. 1 pmatilai pmatilai 72339 Jun 28 10:16 docs/man/ja/rpm.8
-rw-r--r--. 1 pmatilai pmatilai 34450 Apr 7 14:13 docs/man/ja/rpm.8.md
Also, the beta1 tarball had a bug wrt this, might want to double-check that.
- Panu -
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix typo in macros manual (PR #2214)
Merged #2214 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2214#event-7506339119 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix typo in macros manual (PR #2214)
Thanks for spotting + the patch! -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2214#issuecomment-1265305674 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
