[Rpm-maint] [rpm-software-management/rpm] Fix spelling and grammar in conditionalbuilds.md (PR #3064)
You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/3064 -- Commit Summary -- * Fix spelling and grammar in conditionalbuilds.md -- File Changes -- M docs/manual/conditionalbuilds.md (4) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/3064.patch https://github.com/rpm-software-management/rpm/pull/3064.diff -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3064 You are receiving this because you are subscribed to this thread. Message ID: rpm-software-management/rpm/pull/3...@github.com ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] SPECPARTS dir in %_builddir/%buildsubdir is leaking to setuptools package discovery (Issue #2532)
Could the default be `SPECPARTS-%{name}` instead of `%{name}-SPECPARTS`, so that `$RPM_BUILD_DIR/%{name}*` doesn't change meaning? -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2532#issuecomment-1705676298 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [PATCH] Fix array bounds check of decoding[] in base64_decode_value.
On 25/05/16 14:32 +0200, Mark Wielaard wrote: This issue was reported against the libb64 public domain code from which rpmio/base64.c was derived. https://sourceforge.net/p/libb64/bugs/2/ The char signedness issue was already solved differently in our code, but the array bounds check was missing in rpmio/base64.c. N.B. the >= change was just merged here: https://github.com/rpm-software-management/rpm/pull/68/files The value_in < 43 check isn't strictly needed for RPM, because the code was changed to use unsigned char (unlike upstream libb64 which uses char), and so if value_in is less than 43 it will wrap to a positive value greater than 212, which will fail the sizeof(decoding)/sizeof(int) check. Fixed suggested by Jakub Wilk and Jonathan Wakely. Signed-off-by: Mark Wielaard <m...@redhat.com> --- rpmio/base64.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/rpmio/base64.c b/rpmio/base64.c index 60e67d4..a3767ca 100644 --- a/rpmio/base64.c +++ b/rpmio/base64.c @@ -103,8 +103,9 @@ char *rpmBase64Encode(const void *data, size_t len, int linelen) static int base64_decode_value(unsigned char value_in) { static const int decoding[] = {62,-1,-1,-1,63,52,53,54,55,56,57,58,59,60,61,-1,-1,-1,-2,-1,-1,-1,0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,-1,-1,-1,-1,-1,-1,26,27,28,29,30,31,32,33,34,35,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50,51}; + if (value_in < 43) return -1; value_in -= 43; - if (value_in > sizeof(decoding)/sizeof(int)) + if (value_in >= sizeof(decoding)/sizeof(int)) return -1; return decoding[value_in]; } -- 2.5.5 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Fix off-by-one error (#68)
There's an off-by-one error in base64_decode_value which results in undefined behaviour: void* out; size_t len; rpmBase64Decode("\x7b", , ); You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/68 -- Commit Summary -- * Fix off-by-one error -- File Changes -- M rpmio/base64.c (2) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/68.patch https://github.com/rpm-software-management/rpm/pull/68.diff --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/68 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint