Re: [Rpm-maint] [rpm-software-management/rpm] Moving unnecessary notice about empty rpm packages to debug message. (#615)
I think that the patch fixes an ERROR in user interface of rpm utility. When a user asks for a list of package's files he wants to get exactly the list of files, doesn't he? And if there's no files in the package then he wants to get an empty output, doesn't he? Why instead of empty output he gets a text message (according to user's locale)? I think it looks unpredictable and non intuitive. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/615#issuecomment-449499880___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Moving unnecessary notice about empty rpm packages to debug message. (#615)
> You can use rpm -q --qf='%{FILENAMES:arraysize}\n' to get the number of files.
Ok. And what about getting a list of included files? Do you have a dirty trick
for that? And why we can't just trust `rpm -ql` to do this simple task?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/615#issuecomment-449464112___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Moving unnecessary notice about empty rpm packages to debug message. (#615)
> changing them _will_ break some scripts that expect them there No, you can't even rely on this behavior in scripts, because this message (contains no files) is locale-dependent. You can't use it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/615#issuecomment-449462630___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Moving unnecessary notice about empty rpm packages to debug message. (#615)
> Isn't that what the `--quiet` switch is for...? No, definitely no. Because --quiet switch suppresses all output, so the output of rpm -ql of a normal package with a set of files included in will be also empty. Example: $ rpm -ql bzip2-devel-1.0.6-28.fc29.x86_64 | wc -l 6 $ rpm -ql --quiet bzip2-devel-1.0.6-28.fc29.x86_64 | wc -l 0 So you can't use --quiet switch to get number of package's files in a shell script. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/615#issuecomment-449210038___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Moving unnecessary notice about empty rpm packages to debug message. (#615)
This notice makes a problem when you want to process an output of rpm -ql of an empty rpm package in a shell script. Example: $ rpm -ql gpg-pubkey-f2ee9d55-560cfc0a (contains no files) $ rpm -ql gpg-pubkey-f2ee9d55-560cfc0a | wc -l 1 --- But the package is empty! You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/615 -- Commit Summary -- * Moving unnecessary notice about empty rpm packages to debug message. -- File Changes -- M lib/query.c (2) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/615.patch https://github.com/rpm-software-management/rpm/pull/615.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/615 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
