[Rpm-maint] [rpm-software-management/rpm] 4.19.1.1: source and patrches listed in NoSoure: ans NoPatch: are not removed when is used --rmsource (Issue #3037)

2024-04-15 Thread Tomasz Kłoczko
Yeah .. looks like that remove files listed in NoSource: NoPatch: is not 
performed when --rmsource is used.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/3037
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] 4.19.1.1: `rpmbuild --undefine foo` is not working (Discussion #2939)

2024-02-28 Thread Tomasz Kłoczko
> No, it doesn't.

Can you show your executios of commands executions which I've provided?
Did you try to reproduce what I've done? 樂 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/discussions/2939#discussioncomment-8618693
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] 4.19.1.1: `rpmbuild --undefine foo` is not working (Discussion #2939)

2024-02-28 Thread Tomasz Kłoczko
> No, read what I wrote more carefully. Neither --define or --undefine can 
> affect a macro _defined inside a spec_.
> Both can affect the parse, and cause things to be defined or undefined, but 
> only wrt macros that are defined before the macro is parsed.

Please have look ONE MORE time on specs example which disproves what you just 
wrote.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/discussions/2939#discussioncomment-8617999
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] 4.19.1.1: `rpmbuild --undefine foo` is not working (Discussion #2939)

2024-02-28 Thread Tomasz Kłoczko
> --define and --undefine execute long before the spec is parsed, so while they 
> can affect the way a spec is parsed, neither can affect a macro defined 
> inside a spec.

Please have look one more time on my examples.
`--define` IS working and at the same time `--undefine` IS NOT working so it 
cannot be matter of when something is parsed.


-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/discussions/2939#discussioncomment-8617632
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] 4.19.1.1: `rpmbuild --undefine foo` is not qorking (Issue #2923)

2024-02-21 Thread Tomasz Kłoczko
I know that this option is not mentioned anywhere in documentation however IMO 
it should be present to be able not only define from command line macro using 
`--define foo` but as well undefine it if it is present in global or spec 
macros.
So this is I've decided to raise this not as RFE but issue ticket.

More interesting is that on use `rpmbuild --undefine foo` rpmbuild do not fails 
with message informing that it is is unsupported option.
I'm not 100% how `--undefine` option is recognised but looks like some parts or 
rpm command line parsing are involved.
I made two test specs to expose that

test-define.spec

```spec
Summary:test --define
Name:   test-define
Version:1
License:foo
Release:2%{?dist}

%description
Test --define.

%prep

%if 0%{?test}
echo "test defined"
%endif

%check
echo "%{name} package has no test suite"

%files
```



test-undefine.spec

```spec
%define test1

Summary:test --undefine
Name:   test-undefine
Version:1
License:foo
Release:2%{?dist}

%description
Test --undefine.

%prep

%if 0%{?test}
echo "test defined"
%endif

%check
echo "%{name} package has no test suite"

%files
```


And here are results:
```console
[tkloczko@pers-jacek SPECS]$ rpmbuild -bp test-define.spec
warning: source_date_epoch_from_changelog set but %changelog is missing
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.ySytzr
+ umask 022
+ cd /home/tkloczko/rpmbuild/BUILD
+ RPM_EC=0
++ jobs -p
+ exit 0

RPM build warnings:
source_date_epoch_from_changelog set but %changelog is missing
[tkloczko@pers-jacek SPECS]$ rpmbuild -bp test-define.spec --define "test 1"
warning: source_date_epoch_from_changelog set but %changelog is missing
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.PANGwI
+ umask 022
+ cd /home/tkloczko/rpmbuild/BUILD
+ echo 'test defined'
test defined
+ RPM_EC=0
++ jobs -p
+ exit 0

RPM build warnings:
source_date_epoch_from_changelog set but %changelog is missing
```
So it works as expected.
And here is `--undefine` test
```console
[tkloczko@pers-jacek SPECS]$ rpmbuild -bp test-undefine.spec
warning: source_date_epoch_from_changelog set but %changelog is missing
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.GM3NF2
+ umask 022
+ cd /home/tkloczko/rpmbuild/BUILD
+ echo 'test defined'
test defined
+ RPM_EC=0
++ jobs -p
+ exit 0

RPM build warnings:
source_date_epoch_from_changelog set but %changelog is missing
[tkloczko@pers-jacek SPECS]$ rpmbuild -bp test-undefine.spec --undefine test
warning: source_date_epoch_from_changelog set but %changelog is missing
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.2kdiZT
+ umask 022
+ cd /home/tkloczko/rpmbuild/BUILD
+ echo 'test defined'
test defined
+ RPM_EC=0
++ jobs -p
+ exit 0

RPM build warnings:
source_date_epoch_from_changelog set but %changelog is missing
```
So `--undefine` as cmd param is recognised however second case is not handled 
as expected.
I'm almost sure that fixing that could be one one or two code change .. however 
cannot locate that.
May I ask for help? 樂 


-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2923
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] `update-po` target fails (needs submodule update) (Issue #2899)

2024-02-20 Thread Tomasz Kłoczko
> Oh, and just to clarify, in the case of 4.19.1.1, we did _not_ intend to 
> update the translations in that release at all, which is why this issue 
> wasn't caught yet.

Just FTR: updating translations should be be part of the (pre)release process.
Email addresses taken from each .po files should be used to spread 
notifications "I'm going to release new version of software X in next N days. 
Please update translations". This shuld be predeceased by `make -C po 
update-po` and commit to the all .po files.

As long as translations are kept in separated repo it makes that harder to sync 
and to keep track of all changes between version (because tag repo A do not 
causes that such tag is propagated across submodule).


-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2899#issuecomment-195454
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] 4.19.1.1: `update-po` target fails (Issue #2899)

2024-02-12 Thread Tomasz Kłoczko
Looks like po/POTFILES.in is not up-to-date and translators as well are not 
aware that some updates needs to be added  
```console
[tkloczko@pers-jacek x86_64-redhat-linux-gnu]$ make update-pot -C po
make: Entering directory 
'/home/tkloczko/rpmbuild/BUILD/rpm-4.19.1.1/x86_64-redhat-linux-gnu/po'
cd /home/tkloczko/rpmbuild/BUILD/rpm-4.19.1.1/x86_64-redhat-linux-gnu && make  
-f CMakeFiles/Makefile2 po/CMakeFiles/update-pot.dir/rule
make[1]: Entering directory 
'/home/tkloczko/rpmbuild/BUILD/rpm-4.19.1.1/x86_64-redhat-linux-gnu'
/usr/bin/cmake -S/home/tkloczko/rpmbuild/BUILD/rpm-4.19.1.1 
-B/home/tkloczko/rpmbuild/BUILD/rpm-4.19.1.1/x86_64-redhat-linux-gnu 
--check-build-system CMakeFiles/Makefile.cmake 0
/usr/bin/cmake -E cmake_progress_start 
/home/tkloczko/rpmbuild/BUILD/rpm-4.19.1.1/x86_64-redhat-linux-gnu/CMakeFiles 1
make  -f CMakeFiles/Makefile2 po/CMakeFiles/update-pot.dir/all
make[2]: Entering directory 
'/home/tkloczko/rpmbuild/BUILD/rpm-4.19.1.1/x86_64-redhat-linux-gnu'
make  -f po/CMakeFiles/update-pot.dir/build.make 
po/CMakeFiles/update-pot.dir/depend
make[3]: Entering directory 
'/home/tkloczko/rpmbuild/BUILD/rpm-4.19.1.1/x86_64-redhat-linux-gnu'
cd /home/tkloczko/rpmbuild/BUILD/rpm-4.19.1.1/x86_64-redhat-linux-gnu && 
/usr/bin/cmake -E cmake_depends "Unix Makefiles" 
/home/tkloczko/rpmbuild/BUILD/rpm-4.19.1.1 
/home/tkloczko/rpmbuild/BUILD/rpm-4.19.1.1/po 
/home/tkloczko/rpmbuild/BUILD/rpm-4.19.1.1/x86_64-redhat-linux-gnu 
/home/tkloczko/rpmbuild/BUILD/rpm-4.19.1.1/x86_64-redhat-linux-gnu/po 
/home/tkloczko/rpmbuild/BUILD/rpm-4.19.1.1/x86_64-redhat-linux-gnu/po/CMakeFiles/update-pot.dir/DependInfo.cmake
 "--color="
make[3]: Leaving directory 
'/home/tkloczko/rpmbuild/BUILD/rpm-4.19.1.1/x86_64-redhat-linux-gnu'
make  -f po/CMakeFiles/update-pot.dir/build.make 
po/CMakeFiles/update-pot.dir/build
make[3]: Entering directory 
'/home/tkloczko/rpmbuild/BUILD/rpm-4.19.1.1/x86_64-redhat-linux-gnu'
[100%] Updating translation source
cd /home/tkloczko/rpmbuild/BUILD/rpm-4.19.1.1 && /usr/bin/xgettext 
--package-name=rpm --package-version=4.19.1.1 
--output=/home/tkloczko/rpmbuild/BUILD/rpm-4.19.1.1/po/rpm.pot --language=C 
--no-location --keyword=_ --keyword=N_ 
--files-from=/home/tkloczko/rpmbuild/BUILD/rpm-4.19.1.1/po/POTFILES.in
/usr/bin/xgettext: error while opening "cliutils.c" for reading: No such file 
or directory
make[3]: *** [po/CMakeFiles/update-pot.dir/build.make:74: 
po/CMakeFiles/update-pot] Error 1
```
IMO It would be hoof to add excutinh that target at least in dist tar ball 
process formation and/or in CI.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2899
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Introduce an rpm-controlled per-build directory (PR #2885)

2024-02-06 Thread Tomasz Kłoczko
> @kloczek , this is not about SPECPARTS although if you _look_ at the PR, 
> that's one of the issues that gets solved by this. See #2532 for the 
> background.

On first look it looks like it is `setuptools` issue. .. like in other python 
modules cases (which I've mention here).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2885#issuecomment-1929048282
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Introduce an rpm-controlled per-build directory (PR #2885)

2024-02-05 Thread Tomasz Kłoczko
Just found in inbox that another maintainer sorted out issue related to create 
directory in python module source tree 
https://github.com/PyGithub/PyGithub/pull/2894. As you see fixing that it is 
not rocket science ..

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2885#issuecomment-1927414807
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Introduce an rpm-controlled per-build directory (PR #2885)

2024-02-05 Thread Tomasz Kłoczko
Just made grep across all Fedora spec files
```console
[tkloczko@pers-jacek SPECS.fedora]$ grep SPECPARTS  *
python-bidict.spec:# SPECPARTS dir in %%_builddir/%%buildsubdir is leaking to 
setuptools package
python-bidict.spec:rm -rf SPECPARTS
python-cairocffi.spec:- Drop rmdir SPECPARTS
python-chaospy.spec:rm -rf SPECPARTS
python-linkify-it-py.spec:- Stop removing the SPECPARTS directory, it doesn't 
exist
python-linkify-it-py.spec:- Remove empty SPECPARTS directory that breaks build
python-mechanize.spec:rm -rf SPECPARTS
python-neo.spec:# remove rpm's SPECPARTS file
python-neo.spec:rm -rf SPECPARTS
python-nihtest.spec:# Work around issue with package discovery due to SPECPARTS 
dir
python-nose2.spec:rm -rf SPECPARTS
python-numpoly.spec:rm -rf SPECPARTS
python-quantities.spec:# Work around confusion with SPECPARTS directory looking 
like a package to
python-quantities.spec:rm -rf SPECPARTS
python-uc-micro-py.spec:rm -rf SPECPARTS
qcad.spec:rm -rf ../*-SPECPARTS
rpm.spec:- Use mkdir -p for creating SPECPARTS dir
traceroute.spec:%make_build CFLAGS="$RPM_OPT_FLAGS" LDFLAGS="$RPM_LD_FLAGS" 
SKIPDIRS="${RPM_SPECPARTS_DIR##*/}"
```
Few of those cases already have been sorted out by source tree maintainers.

Another question is .. is it really worth to keep SPECPARTS extension in rpm? 樂 
So far not been able to find even SINGLE case of use that.
IMO that whole SPECPARTS created so far more issues (and by this wasted more 
man/hours) than saved any time on packaging.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2885#issuecomment-1927384811
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Introduce an rpm-controlled per-build directory (PR #2885)

2024-02-05 Thread Tomasz Kłoczko
> Do I understand correctly that the `BUILDROOT` dir was replaced by 
> `%{_builddir}/%{_target_cpu}-%{_target_os}-root`? The `%{_builddir}` is the 
> right move IMHO, but what is the advantage of 
> `%{_target_cpu}-%{_target_os}-root` over `BUILDROOT`, especially when e.g. 
> `SPECPARTS` stays the same.

I'm using below patch
```patch
--- a/tests/rpmspec.at
+++ b/tests/rpmspec.at
@@ -333,8 +333,8 @@
   exit $STATUS
 fi
 cd 'hello-1.0'
-rm -rf '/build/BUILD/hello-1.0-SPECPARTS'
-/usr/bin/mkdir -p '/build/BUILD/hello-1.0-SPECPARTS'
+rm -rf '/build/BUILD/hello-1.0/SPECPARTS'
+/usr/bin/mkdir -p '/build/BUILD/hello-1.0/SPECPARTS'
 /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
 echo "Patch #0 (hello-1.0-modernize.patch):"
 /usr/bin/patch --no-backup-if-mismatch -f -p1 -b --suffix .modernize --fuzz=0 
< /build/SOURCES/hello-1.0-modernize.patch
--- a/macros.in
+++ b/macros.in
@@ -271,7 +271,7 @@
 %buildroot %{_buildrootdir}/%{NAME}-%{VERSION}-%{RELEASE}.%{_arch}

 #  Path for spec file snippets generated during build
-%specpartsdir %{_builddir}/%{buildsubdir}-SPECPARTS
+%specpartsdir %{_builddir}/%{buildsubdir}/SPECPARTS

 #  Directory where temporaray files can be created.
 %_tmppath  %{_var}/tmp
--- a/build/build.c
+++ b/build/build.c
@@ -195,14 +195,8 @@
fprintf(fp, "cd '%s'\n", buildSubdir);

 if (what == RPMBUILD_RMBUILD) {
-   if (rpmMacroIsDefined(spec->macros, "specpartsdir")) {
-   char * buf = rpmExpand("%{specpartsdir}", NULL);
-   fprintf(fp, "rm -rf '%s'\n", buf);
-   free(buf);
-   }
if (buildSubdir[0] != '\0')
-   fprintf(fp, "rm -rf '%s' '%s.gemspec'\n",
-   buildSubdir, buildSubdir);
+   fprintf(fp, "rm -rf '%s'\n", buildSubdir);
 } else if (sb != NULL)
fprintf(fp, "%s", sb);

```
After that I've tested that whit almost 5k of my src.rpm and found that only 
few packages are failing because of that change.
All those packages are python modules and fail s result of MISSING parts in 
pyprojects toml.

Because SPECPARTS **exposed those issue** IMO instead evacuating that directory 
outside source tree it should be INTENTIONALLY put in that location.

In meantime for all those cases I've opened issue tickets and ~half already 
have been sorted out.

Example fail on building `uc-micro-py` python module:
```console
+ /usr/bin/python3 -sBm build -w --no-isolation
* Getting build dependencies for wheel...
No `packages` or `py_modules` configuration, performing automatic discovery.
`flat-layout` detected -- analysing .
discovered packages -- ['uc_micro', 'SPECPARTS ', 'uc_micro.categories', 
'uc_micro.properties', 'uc_micro.categories.Cc', 'uc_micro.categories.Cf', 
'uc_micro.categories.P', 'uc_micro.categories.Z', 'uc_micro.properties.Any']
Traceback (most recent call last):
  File 
"/usr/lib/python3.8/site-packages/pyproject_hooks/_in_process/_in_process.py", 
line 353, in 
main()
  File 
"/usr/lib/python3.8/site-packages/pyproject_hooks/_in_process/_in_process.py", 
line 335, in main
json_out['return_val'] = hook(**hook_input['kwargs'])
  File 
"/usr/lib/python3.8/site-packages/pyproject_hooks/_in_process/_in_process.py", 
line 118, in get_requires_for_build_wheel
return hook(config_settings)
  File "/usr/lib/python3.8/site-packages/setuptools/build_meta.py", line 325, 
in get_requires_for_build_wheel
return self._get_build_requires(config_settings, requirements=['wheel'])
  File "/usr/lib/python3.8/site-packages/setuptools/build_meta.py", line 295, 
in _get_build_requires
self.run_setup()
  File "/usr/lib/python3.8/site-packages/setuptools/build_meta.py", line 311, 
in run_setup
exec(code, locals())
  File "", line 1, in 
  File "/usr/lib/python3.8/site-packages/setuptools/__init__.py", line 103, in 
setup
return distutils.core.setup(**attrs)
  File "/usr/lib/python3.8/site-packages/setuptools/_distutils/core.py", line 
159, in setup
dist.parse_config_files()
  File "/usr/lib/python3.8/site-packages/setuptools/dist.py", line 627, in 
parse_config_files
pyprojecttoml.apply_configuration(self, filename, ignore_option_errors)
  File "/usr/lib/python3.8/site-packages/setuptools/config/pyprojecttoml.py", 
line 66, in apply_configuration
config = read_configuration(filepath, True, ignore_option_errors, dist)
  File "/usr/lib/python3.8/site-packages/setuptools/config/pyprojecttoml.py", 
line 131, in read_configuration
return expand_configuration(asdict, root_dir, ignore_option_errors, dist)
  File "/usr/lib/python3.8/site-packages/setuptools/config/pyprojecttoml.py", 
line 156, in expand_configuration
return _ConfigExpander(config, root_dir, ignore_option_errors, 
dist).expand()
  File "/usr/lib/python3.8/site-packages/setuptools/config/pyprojecttoml.py", 
line 204, in expand
self._expand_all_dynamic(dist, package_dir)
  File "/usr/lib/python3.8/site-packages/setuptools/config/pyprojecttoml.py", 
line 249, in _expand_all_dynamic

Re: [Rpm-maint] [rpm-software-management/rpm] Allow to specify a default for bcond features in a macro file (PR #2405)

2024-01-31 Thread Tomasz Kłoczko
This PR is wrong and is not solving th issue.
It is the problem that macros used with `%bcond_with foo`/`%bcond_without foo` 
like `%{?with_foo}` and `%{?without_foo}` are using presence or not that macro.
If you will look closer on macros file
```spec
# Internally, the `--with foo` option defines the macro `_with_foo` and the
# `--without foo` option defines the macro `_without_foo`.
# Based on those and a default (used when neither is given), bcond macros
# define the macro `with_foo`, which should later be checked:

%bcond()%[ (%2)\
? "%{expand:%%{!?_without_%{1}:%%global with_%{1} 1}}"\
: "%{expand:%%{?_with_%{1}:%%global with_%{1} 1}}"\
]
%bcond_with()   %bcond %{1} 0
%bcond_without()%bcond %{1} 1

# Shorthands for %{defined with_...}:
%with() %{expand:%%{?with_%{1}:1}%%{!?with_%{1}:0}}
%without()  %{expand:%%{?with_%{1}:0}%%{!?with_%{1}:1}}
```
you can find that it is used only presence of `%{with_foo}` or not.
This is why I have issue with disable globally %check using %bcond 
https://github.com/rpm-software-management/rpm/discussions/2870
Please test you PR with test spec and test units which I've added in this 
discussion and you will find that you PR is not working as expected/

IMO better would be leave %bcond as it is ad define possibility to use 
something new.


-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2405#issuecomment-1919030097
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] 4.19.1: bug in `%___build_pre_env` definition (Issue #2863)

2024-01-21 Thread Tomasz Kłoczko
https://github.com/rpm-software-management/rpm/blob/b2e8a2bed582a9ccc70fbbf3c8586bdd712ea4d1/macros.in#L762-L766

Issue is that `%{?build_ldflags}` it is no value of the macro but it provides 
information is macro defined or not.

When I've added in some cyrus-sasl.spec file "%global build_ldflags 
%{?build_ldflags} -Wl,--enable-new-dtags` rpmbuild failed with
```console
error: /home/tkloczko/rpmbuild/SPECS/build/cyrus-sasl.spec: line 209: Too many 
levels of recursion in macro expansion. It is likely caused by recursive macro 
declaration.
 63<
(%build_ldflags)
 62<
  (%build_ldflags)
 61<
(%build_ldflags)
 60<
  (%build_ldflags)
 59<
(%build_ldflags)
 58<
  (%build_ldflags)
 57<
(%build_ldflags)
 56<
  (%build_ldflags)
 55<
(%build_ldflags)
 54<
  (%build_ldflags)
 53<
(%build_ldflags)
 52<
  (%build_ldflags)
 51<
(%build_ldflags)
 50<
  (%build_ldflags)
 49<
(%build_ldflags)
 48<
  (%build_ldflags)
 47<
(%build_ldflags)
 46<
  (%build_ldflags)
 45<
(%build_ldflags)
 44<
  (%build_ldflags)
 43<
(%build_ldflags)
 42<
  (%build_ldflags)
 41<
(%build_ldflags)
 40<
  (%build_ldflags)
 39<
(%build_ldflags)
 38<
  (%build_ldflags)
 37<
(%build_ldflags)
 36<  
(%build_ldflags)
 35<
(%build_ldflags)
 34<  
(%build_ldflags)
 33<
(%build_ldflags)
 32<  
(%build_ldflags)
 31<
(%build_ldflags)
 30<  
(%build_ldflags)
 29<(%build_ldflags)
 28<  (%build_ldflags)
 27<(%build_ldflags)
 26<  (%build_ldflags)
 25<(%build_ldflags)
 24<  (%build_ldflags)
 23<  

Re: [Rpm-maint] [rpm-software-management/rpm] move custom definition of the %__spec_check_pre from spec file to global macros causes not the same result (Issue #2862)

2024-01-21 Thread Tomasz Kłoczko
Sorry Actual behaviour is different.
When I've executed above commands I've already had changed `%__spec_check_pre` 
in /usr/lib/rpm/redhat/macros.


Result with defined %bcond_with

```spec
%bcond_with check

Summary:bcond test
Name:   test
Version:1
Release:1
License:foo

%description
bcond test.

%prep

# Add handle --{with|without} check
%define __spec_check_pre \
%{!?with_check:echo "%%check disabled."; exit 0} \
%{___build_pre}

%check
echo "%{name} package test suite"
exit 1

%files
```

```console
[tkloczko@pers-jacek SPECS]$ rpmbuild -bi test.spec
warning: source_date_epoch_from_changelog set but %changelog is missing
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.4hXN9D
+ umask 022
+ cd /home/tkloczko/rpmbuild/BUILD
+ RPM_EC=0
++ jobs -p
+ exit 0
Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.XMbSqT
%check disabled.
Processing files: test-1-1.x86_64
Checking for unpackaged file(s): /usr/lib/rpm/check-files 
/home/tkloczko/rpmbuild/BUILDROOT/test-1-1.x86_64
```


Which is as expected


Result with defined %bcondout_with

```spec
%bcond_without  check

Summary:bcond test
Name:   test
Version:1
Release:1
License:foo

%description
bcond test.

%prep

# Add handle --{with|without} check
%define __spec_check_pre \
%{!?with_check:echo "%%check disabled."; exit 0} \
%{___build_pre}

%check
echo "%{name} package test suite"
exit 1

%files
```

```console
[tkloczko@pers-jacek SPECS]$ rpmbuild -bi test.spec
warning: source_date_epoch_from_changelog set but %changelog is missing
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.wJqF1l
+ umask 022
+ cd /home/tkloczko/rpmbuild/BUILD
+ RPM_EC=0
++ jobs -p
+ exit 0
Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.pKu6HS
+ umask 022
+ cd /home/tkloczko/rpmbuild/BUILD
+ echo 'test package test suite'
test package test suite
+ exit 1
error: Bad exit status from /var/tmp/rpm-tmp.pKu6HS (%check)
```


Which is as expected as well.


Result without defined bcond

```spec
Summary:bcond test
Name:   test
Version:1
Release:1
License:foo

%description
bcond test.

%prep

# Add handle --{with|without} check
%define __spec_check_pre \
%{!?with_check:echo "%%check disabled."; exit 0} \
%{___build_pre}

%check
echo "%{name} package test suite"
exit 1

%files
```

```console
[tkloczko@pers-jacek SPECS]$ rpmbuild -bi test.spec
warning: source_date_epoch_from_changelog set but %changelog is missing
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.KZbK71
+ umask 022
+ cd /home/tkloczko/rpmbuild/BUILD
+ RPM_EC=0
++ jobs -p
+ exit 0
Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.6PTPuy
%check disabled.
Processing files: test-1-1.x86_64
Checking for unpackaged file(s): /usr/lib/rpm/check-files 
/home/tkloczko/rpmbuild/BUILDROOT/test-1-1.x86_64
```


Incorrect result because without define `%bcond_{with|without} check` such 
solution should not be disabling %check.

In other words it is not issue with %__spec_check_pre redefinition but above 
approach with globally redefines %__spec_check_pre does not work as expected 
(which is not rpm issue).

Q: how to modify above to have expected behaviour? 樂 


-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2862#issuecomment-1902614727
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] move custom definition of the %__spec_check_pre from spec file to global macros causes not the same result (Issue #2862)

2024-01-21 Thread Tomasz Kłoczko
**Describe the bug**
in 
https://github.com/rpm-software-management/rpm/issues/316#issuecomment-1900766922
 I wrote that I'm using +years solution which allows me to disable %check 
execution by use `%bcond_with check`.
What I'm using is not exactly what I've proposed in next comment.
What I'm using is purely spec files solution by add in spec file
```spec
%bcond_with check
.
.
%check
%{!?with_check:echo "%%check disabled."; exit 0}

```


What wrote in the in #316 was based on below test case:

```spec
Summary:bcond check test
Name:   test
Version:1
Release:1
License:foo

%description
bcond test.

%prep

%define__spec_check_pre \
   %{!?with_check:echo "%%check disabled."; exit 0} \
   %{___build_pre}

%check
echo "%{name} package test suite"

%files
```

```console
[tkloczko@pers-jacek SPECS]$ rpmbuild -bi test.spec
warning: source_date_epoch_from_changelog set but %changelog is missing
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.lNjy8k
+ umask 022
+ cd /home/tkloczko/rpmbuild/BUILD
+ RPM_EC=0
++ jobs -p
+ exit 0
Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.mQr3fh
%check disabled.
Processing files: test-1-1.x86_64
Checking for unpackaged file(s): /usr/lib/rpm/check-files 
/home/tkloczko/rpmbuild/BUILDROOT/test-1-1.x86_64
```


However when I've moved `%__spec_check_pre` definition to macros.check  file
```spec
# Add handle --{with|without} check
%__spec_check_pre \
%{!?with_check:echo "%%check disabled."; exit 0} \
%{___build_pre}
```
and started testing spec file like below
```spec
Summary:bcond check test
Name:   test
Version:1
Release:1
License:foo

%description
bcond test.

%prep

%check
echo "%{name} package test suite"

%files
```
Result is not the same:
```console
[tkloczko@pers-jacek SPECS]$ rpmbuild -bi test.spec --macros 
/usr/lib/rpm/macros:/usr/lib/rpm/redhat/macros:macros.check
warning: source_date_epoch_from_changelog set but %changelog is missing
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.bnQsY0
+ umask 022
+ cd /home/tkloczko/rpmbuild/BUILD
+ RPM_EC=0
++ jobs -p
+ exit 0
Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.JZfaOi
+ umask 022
+ cd /home/tkloczko/rpmbuild/BUILD
+ echo 'test package test suite'
test package test suite
+ RPM_EC=0
++ jobs -p
+ exit 0
Processing files: test-1-1.x86_64
Checking for unpackaged file(s): /usr/lib/rpm/check-files 
/home/tkloczko/rpmbuild/BUILDROOT/test-1-1.%{_arch}
```
Looks like it is not possible to evaluate in bcond macros from global macros or 
that evaluation needs to be added differently.

Q: what I'm doing incorrectly and/or how to eval `%with_chec` from global 
macros? 樂 


-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2862
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] RFE: add way to set macro for --nocheck in rpmbuild (#316)

2024-01-19 Thread Tomasz Kłoczko
> ```spec
> # Add handle --{with|without} check
> %__spec_check_pre \
> %{!?with_check:echo "%%check disabled."; exit 0} \
> %{___build_pre}
> ```

Actually this is not all. It needs to be added default value of the 
%with_check. So wole solution has two additional lines.
```spec
# Add handle --{with|without} check
%with_check   1
%__spec_check_pre \
%{!?with_check:echo "%%check disabled."; exit 0} \
%{___build_pre}
```


-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/316#issuecomment-1900926087
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] RFE: add way to set macro for --nocheck in rpmbuild (#316)

2024-01-19 Thread Tomasz Kłoczko
> we can use : rpmbuild --without check

This can be added very easy by place in global macros single line modification
```spec
# Add handle --{with|without} check
%__spec_check_pre \
%{!?with_check:echo "%%check disabled."; exit 0} \
%{___build_pre}
```
Than you can place in spec file:
```spec
%bcond_with   check
```
to disable %check.
I'm using that hack +3 years.

Do you want this as PR? 樂 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/316#issuecomment-1900766922
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] RFE: Deduplicate data among binary packages produced by the same source package in the rpmdb (Issue #2827)

2023-12-30 Thread Tomasz Kłoczko
Wate of time.
Deduplication it is something which should be done on fs layer.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2827#issuecomment-1872599981
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] 4.19.1: broken `update-pot` target (Issue #2817)

2023-12-19 Thread Tomasz Kłoczko
> Well yes, it's not something you're expected to run on a release tarball. So 
> this is really going in circles, again.

MANY projects have not updated .po files (look on 
https://github.com/mesonbuild/meson/issues/11338)


-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2817#issuecomment-1862366164
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] 4.19.1: broken `update-pot` target (Issue #2817)

2023-12-18 Thread Tomasz Kłoczko
> (..) and for Fedora multiple times by different people and doesn't exhibit 
> any such errors.

Because Fedora build procedure has no `update-pot` target execution.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2817#issuecomment-1860964179
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] 4.19.1: broken `update-pot` target (Issue #2817)

2023-12-17 Thread Tomasz Kłoczko
> I'm just making the changes where they are now. I can certainly see moving 
> the CMake code out and file list out.

It is not possible to tag repo ans subrepo.
At the moment in https://github.com/rpm-software-management/rpm-l10n there is 
no any tags.


-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2817#issuecomment-1859353187
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] 4.19.1: broken `update-pot` target (Issue #2817)

2023-12-16 Thread Tomasz Kłoczko
IMO all those changes should be part of rpm repo.
In this repo should be time to time (at least week before release) updated 
po/rpm.pot file and that .pot files should be registered on one of the i18n 
translation infras. Than time to time available updates should be pooled.
Really .. please have a look how it is organized by other projects because 
nothing needs to be kept in separated git repo. 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2817#issuecomment-1858986555
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] 4.19.1: broken `update-pot` target (Issue #2817)

2023-12-15 Thread Tomasz Kłoczko
> Why on earth are you specifically running 'update-pot' on a released rpm 
> tarball in the first place?

Because .pot file used during build is ALWAYS not-up-to-date. `update-pot` 
removes many translated entries which are no longer used (-> installed .mo 
files are shorter).
As you see in this case what is in .po files bases on not updated files list 
from which phrases to translate should be taken.
Because .po files updates are not pushed translators are updating outdated list 
of phrases to translate.

> And, if you expect somebody to look at this, supply the entire reproducer. 
> Ie, all the cmake commands on a pristine source tarball.

In first line of the provided output is ONE command which needs to be executed. 
It does not need anything build env specific biits.
Please at least try to reproduce that by execute that command in your build env.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2817#issuecomment-1858098757
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] 4.19.1: broken `update-pot` target (Issue #2817)

2023-12-14 Thread Tomasz Kłoczko
BTW: is it possible to change dist tar ball compression from .bz2 to .xz 樂 
(xz produces shorter tar balls on archives with text files)
```console
[tkloczko@pers-jacek SOURCES]$ ls -l rpm-4.19.1.tar.xz rpm-4.19.1.tar.bz2
-rw-rw-r-- 1 tkloczko tkloczko 5940447 Dec 14 19:37 rpm-4.19.1.tar.bz2
-rw-rw-r-- 1 tkloczko tkloczko 5449032 Dec 14 19:37 rpm-4.19.1.tar.xz
```


-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2817#issuecomment-1856482908
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] 4.19.1: broken `update-pot` target (Issue #2817)

2023-12-14 Thread Tomasz Kłoczko
It would be good to add checking that target to release procedure
```console
+ /usr/bin/cmake --build x86_64-redhat-linux-gnu -j48 --verbose --target 
update-pot
Change Dir: '/home/tkloczko/rpmbuild/BUILD/rpm-4.19.1/x86_64-redhat-linux-gnu'

Run Build Command(s): /usr/bin/cmake -E env VERBOSE=1 /usr/bin/gmake -f 
Makefile -j48 update-pot
/usr/bin/cmake -S/home/tkloczko/rpmbuild/BUILD/rpm-4.19.1 
-B/home/tkloczko/rpmbuild/BUILD/rpm-4.19.1/x86_64-redhat-linux-gnu 
--check-build-system CMakeFiles/Makefile.cmake 0
/usr/bin/gmake  -f CMakeFiles/Makefile2 update-pot
gmake[1]: Entering directory 
'/home/tkloczko/rpmbuild/BUILD/rpm-4.19.1/x86_64-redhat-linux-gnu'
/usr/bin/cmake -S/home/tkloczko/rpmbuild/BUILD/rpm-4.19.1 
-B/home/tkloczko/rpmbuild/BUILD/rpm-4.19.1/x86_64-redhat-linux-gnu 
--check-build-system CMakeFiles/Makefile.cmake 0
/usr/bin/cmake -E cmake_progress_start 
/home/tkloczko/rpmbuild/BUILD/rpm-4.19.1/x86_64-redhat-linux-gnu/CMakeFiles 1
/usr/bin/gmake  -f CMakeFiles/Makefile2 po/CMakeFiles/update-pot.dir/all
gmake[2]: Entering directory 
'/home/tkloczko/rpmbuild/BUILD/rpm-4.19.1/x86_64-redhat-linux-gnu'
/usr/bin/gmake  -f po/CMakeFiles/update-pot.dir/build.make 
po/CMakeFiles/update-pot.dir/depend
gmake[3]: Entering directory 
'/home/tkloczko/rpmbuild/BUILD/rpm-4.19.1/x86_64-redhat-linux-gnu'
cd /home/tkloczko/rpmbuild/BUILD/rpm-4.19.1/x86_64-redhat-linux-gnu && 
/usr/bin/cmake -E cmake_depends "Unix Makefiles" 
/home/tkloczko/rpmbuild/BUILD/rpm-4.19.1 
/home/tkloczko/rpmbuild/BUILD/rpm-4.19.1/po 
/home/tkloczko/rpmbuild/BUILD/rpm-4.19.1/x86_64-redhat-linux-gnu 
/home/tkloczko/rpmbuild/BUILD/rpm-4.19.1/x86_64-redhat-linux-gnu/po 
/home/tkloczko/rpmbuild/BUILD/rpm-4.19.1/x86_64-redhat-linux-gnu/po/CMakeFiles/update-pot.dir/DependInfo.cmake
 "--color="
gmake[3]: Leaving directory 
'/home/tkloczko/rpmbuild/BUILD/rpm-4.19.1/x86_64-redhat-linux-gnu'
/usr/bin/gmake  -f po/CMakeFiles/update-pot.dir/build.make 
po/CMakeFiles/update-pot.dir/build
gmake[3]: Entering directory 
'/home/tkloczko/rpmbuild/BUILD/rpm-4.19.1/x86_64-redhat-linux-gnu'
[100%] Updating translation source
cd /home/tkloczko/rpmbuild/BUILD/rpm-4.19.1 && /usr/bin/xgettext 
--package-name=rpm --package-version=4.19.1 
--output=/home/tkloczko/rpmbuild/BUILD/rpm-4.19.1/po/rpm.pot --language=C 
--no-location --keyword=_ --keyword=N_ 
--files-from=/home/tkloczko/rpmbuild/BUILD/rpm-4.19.1/po/POTFILES.in
/usr/bin/xgettext: error while opening "cliutils.c" for reading: No such file 
or directory
gmake[3]: *** [po/CMakeFiles/update-pot.dir/build.make:74: 
po/CMakeFiles/update-pot] Error 1
gmake[3]: Leaving directory 
'/home/tkloczko/rpmbuild/BUILD/rpm-4.19.1/x86_64-redhat-linux-gnu'
gmake[2]: *** [CMakeFiles/Makefile2:1114: po/CMakeFiles/update-pot.dir/all] 
Error 2
gmake[2]: Leaving directory 
'/home/tkloczko/rpmbuild/BUILD/rpm-4.19.1/x86_64-redhat-linux-gnu'
gmake[1]: *** [CMakeFiles/Makefile2:1121: po/CMakeFiles/update-pot.dir/rule] 
Error 2
gmake[1]: Leaving directory 
'/home/tkloczko/rpmbuild/BUILD/rpm-4.19.1/x86_64-redhat-linux-gnu'
```


-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2817
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] https://ftp.rpm.org/releases/ reports ERR_CERT_COMMON_NAME_INVALID (Issue #2792)

2023-11-28 Thread Tomasz Kłoczko
On requests is reported NET::ERR_CERT_COMMON_NAME_INVALID
```console
NET::ERR_CERT_COMMON_NAME_INVALID
Subject: *.osuosl.org

Issuer: InCommon RSA Server CA

Expires on: 14 Aug 2024

Current date: 28 Nov 2023

PEM encoded chain:
-BEGIN CERTIFICATE-
MIIGqDCCBZCgAwIBAgIRALyLan5HduQddO9zEyf77aswDQYJKoZIhvcNAQELBQAw
djELMAkGA1UEBhMCVVMxCzAJBgNVBAgTAk1JMRIwEAYDVQQHEwlBbm4gQXJib3Ix
EjAQBgNVBAoTCUludGVybmV0MjERMA8GA1UECxMISW5Db21tb24xHzAdBgNVBAMT
FkluQ29tbW9uIFJTQSBTZXJ2ZXIgQ0EwHhcNMjMwNzE0MDAwMDAwWhcNMjQwODEz
MjM1OTU5WjBXMQswCQYDVQQGEwJVUzEPMA0GA1UECBMGT3JlZ29uMSAwHgYDVQQK
ExdPcmVnb24gU3RhdGUgVW5pdmVyc2l0eTEVMBMGA1UEAwwMKi5vc3Vvc2wub3Jn
MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAxE+tTnRB+rTTpSf5SfzE
z+HpeQI3QBhwUB3BYcmc167o7VwSeiPSrCp34u4S/a+GS9+jI1Y4Jy3Ox4dYgcXh
GJyyMZq1oqTBbkcBGfSOAZmRltIdUqilos5AFtXGzC/S0OD6DODiSxG0RawZdkWB
eMihztuPOPgXpu9qlxZ3LBxDPFOqCVnwodNDSWtfon5Z1TgmbrQWcLDMeGXFB5vI
UlWS9Pc5rp+BFKk3mHrL9CKsUCk/1ptklQJCnlFiyO/Ghgp0Xih+EgYrA3DdPeIh
XnPYQw/Ua5vAwFRulYpwUcv/5gLlcg1KBVf8tREYSzxoiiWQJa1TC52W3rPwP1pd
8QIDAQABo4IDTjCCA0owHwYDVR0jBBgwFoAUHgWjd49sluJbh0umtIascQAM5zgw
HQYDVR0OBBYEFIm9f5UX1CeHc2FOSfjAVC4m5oWwMA4GA1UdDwEB/wQEAwIFoDAM
BgNVHRMBAf8EAjAAMB0GA1UdJQQWMBQGCCsGAQUFBwMBBggrBgEFBQcDAjBnBgNV
HSAEYDBeMFIGDCsGAQQBriMBBAMBATBCMEAGCCsGAQUFBwIBFjRodHRwczovL3d3
dy5pbmNvbW1vbi5vcmcvY2VydC9yZXBvc2l0b3J5L2Nwc19zc2wucGRmMAgGBmeB
DAECAjBEBgNVHR8EPTA7MDmgN6A1hjNodHRwOi8vY3JsLmluY29tbW9uLXJzYS5v
cmcvSW5Db21tb25SU0FTZXJ2ZXJDQS5jcmwwdQYIKwYBBQUHAQEEaTBnMD4GCCsG
AQUFBzAChjJodHRwOi8vY3J0LnVzZXJ0cnVzdC5jb20vSW5Db21tb25SU0FTZXJ2
ZXJDQV8yLmNydDAlBggrBgEFBQcwAYYZaHR0cDovL29jc3AudXNlcnRydXN0LmNv
bTCCAX4GCisGAQQB1nkCBAIEggFuBIIBagFoAHcAdv+IPwq2+5VRwmHM9Ye6NLSk
zbsp3GhCCp/mZ0xaOnQAAAGJUb8w/wAABAMASDBGAiEAy9/JKdOm2leouMJ2fxx3
X4BL04Ufru3ckww809nB6FUCIQD5hpNiiUi0qrV8LmVFBSBELgw6AcnhsTDpoDXs
OTyJHwB2ANq2v2s/tbYin5vCu1xr6HCRcWy7UYSFNL2kPTBI1/urAAABiVG/MVAA
AAQDAEcwRQIgIuHidNv3xe9CXZCjMHcgXbJ7v3lt3wjoSCvbWQon7soCIQCXlCiw
ROLZj3rjmgYYi4zgo/rVU7ZFC+XUn6LcQqCLrAB1AO7N0GTV2xrOxVy3nbTNE6Iy
h0Z8vOzew1FIWUZxH7WbAAABiVG/MSkAAAQDAEYwRAIge7uLhEJ4n+BLh6+ulquU
uxCSMqpOpzXxLvIRO/saIWkCICAi/cShxKXPvSw5TDPE4YbywIrwn76XwtoBaGPJ
o8/OMCMGA1UdEQQcMBqCDCoub3N1b3NsLm9yZ4IKb3N1b3NsLm9yZzANBgkqhkiG
9w0BAQsFAAOCAQEAYkzWrVp8vbGejyLCYnnT4lyDFBpiWoWgmngxldtrkV0ccfsk
C1dqj/3QBMcNp5A/PNmXyoRSkIWEBuFbTCnQvdUzysvnLB5CYJIrQ8Fj/NI0Bh2Q
Xbk+Tg395RKFyCefXg4MxRhqW/LfwV1cUibC1ZQz7f/heBjyJ/+nJvpEnEu0eLrJ
vrrl0NMvV/lV1H6lIo804WlONjtQBxhP+yU5i7yfuKDoy3wOr1nvu0Ehoh52dioF
titSUyWpPnWDCB5y7jEW01mBc2VhS3wW+2ptEqmVKR0VvgCoGjliWhFhSaTkBqhx
yZeJh5K7pzRTVAWFbk1XhShHClniy//Meotyfw==
-END CERTIFICATE-
-BEGIN CERTIFICATE-
MIIF+TCCA+GgAwIBAgIQRyDQ+oVGGn4XoWQCkYRjdDANBgkqhkiG9w0BAQwFADCB
iDELMAkGA1UEBhMCVVMxEzARBgNVBAgTCk5ldyBKZXJzZXkxFDASBgNVBAcTC0pl
cnNleSBDaXR5MR4wHAYDVQQKExVUaGUgVVNFUlRSVVNUIE5ldHdvcmsxLjAsBgNV
BAMTJVVTRVJUcnVzdCBSU0EgQ2VydGlmaWNhdGlvbiBBdXRob3JpdHkwHhcNMTQx
MDA2MDAwMDAwWhcNMjQxMDA1MjM1OTU5WjB2MQswCQYDVQQGEwJVUzELMAkGA1UE
CBMCTUkxEjAQBgNVBAcTCUFubiBBcmJvcjESMBAGA1UEChMJSW50ZXJuZXQyMREw
DwYDVQQLEwhJbkNvbW1vbjEfMB0GA1UEAxMWSW5Db21tb24gUlNBIFNlcnZlciBD
QTCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAJwb8bsvf2MYFVFRVA+e
xU5NEFj6MJsXKZDmMwysE1N8VJG06thum4ltuzM+j9INpun5uukNDBqeso7JcC7v
HgV9lestjaKpTbOc5/MZNrun8XzmCB5hJ0R6lvSoNNviQsil2zfVtefkQnI/tBPP
iwckRR6MkYNGuQmm/BijBgLsNI0yZpUn6uGX6Ns1oytW61fo8BBZ321wDGZq0GTl
qKOYMa0dYtX6kuOaQ80tNfvZnjNbRX3EhigsZhLI2w8ZMA0/6fDqSl5AB8f2IHpT
eIFken5FahZv9JNYyWL7KSd9oX8hzudPR9aKVuDjZvjs3YncJowZaDuNi+L7RyML
fzcCAwEAAaOCAW4wggFqMB8GA1UdIwQYMBaAFFN5v1qqK0rPVIDh2JvAnfKyA2bL
MB0GA1UdDgQWBBQeBaN3j2yW4luHS6a0hqxxAAznODAOBgNVHQ8BAf8EBAMCAYYw
EgYDVR0TAQH/BAgwBgEB/wIBADAdBgNVHSUEFjAUBggrBgEFBQcDAQYIKwYBBQUH
AwIwGwYDVR0gBBQwEjAGBgRVHSAAMAgGBmeBDAECAjBQBgNVHR8ESTBHMEWgQ6BB
hj9odHRwOi8vY3JsLnVzZXJ0cnVzdC5jb20vVVNFUlRydXN0UlNBQ2VydGlmaWNh
dGlvbkF1dGhvcml0eS5jcmwwdgYIKwYBBQUHAQEEajBoMD8GCCsGAQUFBzAChjNo
dHRwOi8vY3J0LnVzZXJ0cnVzdC5jb20vVVNFUlRydXN0UlNBQWRkVHJ1c3RDQS5j
cnQwJQYIKwYBBQUHMAGGGWh0dHA6Ly9vY3NwLnVzZXJ0cnVzdC5jb20wDQYJKoZI
hvcNAQEMBQADggIBAC0RBjjW29dYaK+qOGcXjeIT16MUJNkGE+vrkS/fT2ctyNMU
11ZlUp5uH5gIjppIG8GLWZqjV5vbhvhZQPwZsHURKsISNrqOcooGTie3jVgU0W+0
+Wj8mN2knCVANt69F2YrA394gbGAdJ5fOrQmL2pIhDY0jqco74fzYefbZ/VS29fR
5jBxu4uj1P+5ZImem4Gbj1e4ZEzVBhmO55GFfBjRidj26h1oFBHZ7heDH1Bjzw72
hipu47Gkyfr2NEx3KoCGMLCj3Btx7ASn5Ji8FoU+hCazwOU1VX55mKPU1I2250Lo
RCASN18JyfsD5PVldJbtyrmz9gn/TKbRXTr80U2q5JhyvjhLf4lOJo/UzL5WCXED
Smyj4jWG3R7Z8TED9xNNCxGBMXnMete+3PvzdhssvbORDwBZByogQ9xL2LUZFI/i
eoQp0UM/L8zfP527vWjEzuDN5xwxMnhi+vCToh7J159o5ah29mP+aJnvujbXEnGa
nrNxHzu+AGOePV8hwrGGG7hOIcPDQwkuYwzN/xT29iLp/cqf9ZhEtkGcQcIImH3b
oJ8ifsCnSbu0GB9L06Yqh7lcyvKDTEADslIaeSEINxhO2Y1fmcYFX/Fqrrp1WnhH
OjplXuXE0OPa0utaKC25Aplgom88L2Z8mEWcyfoB7zKOfD759AN7JKZWCYwk
-END CERTIFICATE-
-BEGIN CERTIFICATE-
MIIF3jCCA8agAwIBAgIQAf1tMPyjylGoG7xkDjUDLTANBgkqhkiG9w0BAQwFADCB
iDELMAkGA1UEBhMCVVMxEzARBgNVBAgTCk5ldyBKZXJzZXkxFDASBgNVBAcTC0pl
cnNleSBDaXR5MR4wHAYDVQQKExVUaGUgVVNFUlRSVVNUIE5ldHdvcmsxLjAsBgNV

Re: [Rpm-maint] [rpm-software-management/rpm] debuginfo packages lack licenses (Issue #2778)

2023-11-22 Thread Tomasz Kłoczko
License details are in Licence: field.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2778#issuecomment-1822460400
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] 4.18.99: broken off-source-tree install target (Issue #2650)

2023-09-11 Thread Tomasz Kłoczko
Do you have any suggestion why in my case cmake is not installing pytom module 
in `%{python3_sitearch}`? 樂 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2650#issuecomment-1713690481
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] 4.18.99: `rpmbuild -bp` no longer allows unpack source tree by %prep execution without checking dependencies (Issue #2652)

2023-09-08 Thread Tomasz Kłoczko
IMO it would be good to add line about that on 
https://rpm.org/wiki/Releases/4.19.0

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2652#issuecomment-1711936588
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] 4.18.99: `rpmbuild -bp` no longer allows unpack source tree by %prep execution without checking dependencies (Issue #2652)

2023-09-08 Thread Tomasz Kłoczko
As long as %build was not executed and there is no such things lik 
`PrepRequires:` IMO it was not the bug .
`BuildRequires:` literally says that it  defines **build** dependencies
Good that `--nodeps` still is working  

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2652#issuecomment-1711935795
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] 4.18.99: `rpmbuild -bp` no longer allows unpack source tree by %prep execution without checking dependencies (Issue #2652)

2023-09-08 Thread Tomasz Kłoczko
I don;t see anything about that on https://rpm.org/wiki/Releases/4.19.0 so it 
must be some side effects recent changes.
console
[tkloczko@pers-jacek SPECS]$ rpmbuild -bp python-fastavro.spec
error: Failed build dependencies:
python3dist(cython) is needed by python-fastavro-1.8.3-2.fc35.x86_64
python3dist(installer) is needed by python-fastavro-1.8.3-2.fc35.x86_64
python3dist(lz4) is needed by python-fastavro-1.8.3-2.fc35.x86_64
python3dist(pandas) is needed by python-fastavro-1.8.3-2.fc35.x86_64
python3dist(python-snappy) is needed by 
python-fastavro-1.8.3-2.fc35.x86_64
python3dist(sphinx-rtd-theme) is needed by 
python-fastavro-1.8.3-2.fc35.x86_64
python3dist(zstandard) is needed by python-fastavro-1.8.3-2.fc35.x86_64



-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2652
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] fix install rpmrc, platform and macros files with off-source-tree build (PR #2651)

2023-09-08 Thread Tomasz Kłoczko
> $ cmake -B build -C rpm

So in above you are NOT passim -S and -B and looks like you are running cmake 
from outside root source tree..
Please try `cmake -B build -S . -C rpm`. (IIRC -C it is only cache dir so it 
should not matter)

> $ cmake --build build/
> $ cmake --install build/

Here you need to pass DESTDIR as well. Please try `DESTDIR=/tmp/rpm.test cmake 
--install build`


-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2651#issuecomment-1711749474
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] fix install rpmrc, platform and macros files with off-source-tree build (PR #2651)

2023-09-08 Thread Tomasz Kłoczko
> > So as you see I'm passing -S and -B paths explicit ..
> 
> Yes, that's what fails, see my comment above.

ItWorks™️  in my case. Not only in case of rpm but 
```console
[tkloczko@pers-jacek SPECS]$ grep -l %cmake *spec |wc -l
553
```
packages.
May I have look on your command with output? 樂 


-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2651#issuecomment-1711670132
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] fix install rpmrc, platform and macros files with off-source-tree build (PR #2651)

2023-09-08 Thread Tomasz Kłoczko
In my case cmake source definition of rpm macros looks like below:
```spec
#
# Macros for cmake
#
%_cmake_skip_rpath  -D CMAKE_SKIP_RPATH=ON
%__cmake/usr/bin/cmake
%__ctest/usr/bin/ctest
%_vpath_srcdir  .

# - Set default compile flags
# - CMAKE_*_FLAGS_RELEASE are added *after* the *FLAGS environment variables
# and default to -O3 -DNDEBUG.  Strip the -O3 so we can override with *FLAGS
# - Turn on verbose makefiles so we can see and verify compile flags
# - Set default install prefixes and library install directories
# - Turn on shared libraries by default
%cmake %{set_build_flags} \
%__cmake \\\
-B %{_vpath_builddir} \\\
-D BUILD_SHARED_LIBS=ON \\\
-D CMAKE_AR="$AR" \\\
-D CMAKE_BUILD_TYPE=RelWithDebInfo \\\
-D CMAKE_C_FLAGS_RELEASE="-DNDEBUG" \\\
-D CMAKE_CXX_FLAGS_RELEASE="-DNDEBUG" \\\
-D CMAKE_Fortran_FLAGS_RELEASE="-DNDEBUG" \\\
-D CMAKE_INSTALL_PREFIX=%{_prefix} \\\
-D CMAKE_NM="$NM" \\\
-D CMAKE_RANLIB="$RANLIB" \\\
-D CMAKE_VERBOSE_MAKEFILE=ON \\\
-D INCLUDE_INSTALL_DIR=%{_includedir} \\\
-D LIB_INSTALL_DIR=%{_libdir} \\\
%if "%{?_lib}" == "lib64" \
-D LIB_SUFFIX=64 \\\
%endif \
-D SHARE_INSTALL_PREFIX=%{_datadir} \\\
-D SYSCONF_INSTALL_DIR=%{_sysconfdir} \\\
-S %{_vpath_srcdir}

%cmake_build \
%__cmake --build %{_vpath_builddir} %{?_smp_mflags} --verbose

%cmake_install \
DESTDIR=%{buildroot} %__cmake --install %{_vpath_builddir}

%ctest  %__ctest --test-dir %{_vpath_builddir} --output-on-failure 
--force-new-ctest-process %{?_smp_mflags} \\\
```
So as you se I'm passing -S and -B paths explicit ..

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2651#issuecomment-1711566891
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] fix install rpmrc, platform and macros files with off-source-tree build (PR #2651)

2023-09-08 Thread Tomasz Kłoczko
Nevertheless if both params of the install() are specified with 
{CMAKE_SOURCE_DIR} and ${CMAKE_BINARY_DIR} like it is in proposed patch it will 
be working in both cases  

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2651#issuecomment-1711515266
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] fix install rpmrc, platform and macros files with off-source-tree build (PR #2651)

2023-09-08 Thread Tomasz Kłoczko
> > No, no .. this is not the case. In Fedora rpm.spec %cmake macro is not used 
> > so this is why it was not exposed. 
> > https://src.fedoraproject.org/rpms/rpm/blob/rawhide/f/rpm.spec#_360
> 
> I don't see how that contradicts what I said above.

You wrote that it must be related to Fedora %cmake macro definition.
In this case %cmake macro is not used so it cannot be related to Fedora %cmacro 
 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2651#issuecomment-1711512019
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] fix install rpmrc, platform and macros files with off-source-tree build (PR #2651)

2023-09-08 Thread Tomasz Kłoczko
> This seems more like some kind of misconfiguration related to the `%cmake` 
> macro shipped in Fedora

No, no .. this is not the case.
In Fedora rpm.spec %cmake macro is not used so this is why it was not exposed.
https://src.fedoraproject.org/rpms/rpm/blob/rawhide/f/rpm.spec#_360

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2651#issuecomment-1711507304
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] 4.18.99: no test suite?樂 (Issue #2648)

2023-09-08 Thread Tomasz Kłoczko
Still execution of that test suite script IMO should be done over ctest.
This would allow easier migration to execute units over ctest.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2648#issuecomment-1711463478
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] 4.18.99: no test suite?樂 (Issue #2648)

2023-09-08 Thread Tomasz Kłoczko
Because ctest is standard cmake tool and it is supported directly by cmake 
files allowing OOTB for example parallelisation of ctest units execution (it 
allows as well exclude some exact units paralel execution 
https://www.scivision.dev/cmake-resource-lock-ctest/ .. .if it was the cause of 
not choosing ctest).
Why to maintain own test suite framework? 樂 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2648#issuecomment-1711411289
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] 4.18.99: broken off-source-tree install target (Issue #2650)

2023-09-08 Thread Tomasz Kłoczko
In python/CMakeLists.txt is:
```cmake
install(TARGETS _rpm
DESTINATION ${Python3_SITEARCH}/rpm)
install(FILES rpm/transaction.py rpm/__init__.py
DESTINATION ${Python3_SITEARCH}/rpm)

set(egginfo 
${PROJECT_NAME}-${PROJECT_VERSION}-py${Python3_VERSION_MAJOR}.${Python3_VERSION_MINOR}.egg-info)
configure_file(rpm.egg-info.in ${egginfo} @ONLY)
install(FILES ${CMAKE_CURRENT_BINARY_DIR}/${egginfo}
DESTINATION ${Python3_SITEARCH})
```
Looksl like this cmake variable is defined  in rpm tree樂 
```console
[tkloczko@pers-jacek rpm-4.18.99]$ grep -r Python3_SITEARCH
python/CMakeLists.txt:  DESTINATION ${Python3_SITEARCH}/rpm)
python/CMakeLists.txt:  DESTINATION ${Python3_SITEARCH}/rpm)
python/CMakeLists.txt:  DESTINATION ${Python3_SITEARCH})
```
```console
[tkloczko@pers-jacek rpm-4.18.99]$ grep -r Python3_SITEARCH /usr
grep: /usr/libexec/utempter: Permission denied
grep: /usr/share/polkit-1/rules.d: Permission denied
/usr/share/cmake/Modules/FindPython3.cmake:``Python3_SITEARCH``
grep: /usr/sbin/unix_update: Permission denied
```
In that files is:
```cmake 
``Python3_SITEARCH``
  Third-party platform dependent installation directory.

  Information returned by ``sysconfig.get_path('platlib')``.
```
However ..
```console
[tkloczko@pers-jacek rpm-4.18.99]$ python3 -m sysconfig | grep platlib
platlib = "/usr/lib64/python3.8/site-packages"
```
comments? 樂 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2650#issuecomment-1711404469
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] 4.18.99: broken off-source-tree install target (Issue #2650)

2023-09-08 Thread Tomasz Kłoczko
Looks like python module wrong directory may be related to the fact that I'm 
using %cmake macro which in my case looks like below
```spec
%cmake %{set_build_flags} \
%__cmake \\\
-B %{_vpath_builddir} \\\
-D BUILD_SHARED_LIBS=ON \\\
-D CMAKE_AR="$AR" \\\
-D CMAKE_BUILD_TYPE=RelWithDebInfo \\\
-D CMAKE_C_FLAGS_RELEASE="-DNDEBUG" \\\
-D CMAKE_CXX_FLAGS_RELEASE="-DNDEBUG" \\\
-D CMAKE_Fortran_FLAGS_RELEASE="-DNDEBUG" \\\
-D CMAKE_INSTALL_PREFIX=%{_prefix} \\\
-D CMAKE_NM="$NM" \\\
-D CMAKE_RANLIB="$RANLIB" \\\
-D CMAKE_VERBOSE_MAKEFILE=ON \\\
-D INCLUDE_INSTALL_DIR=%{_includedir} \\\
-D LIB_INSTALL_DIR=%{_libdir} \\\
%if "%{?_lib}" == "lib64" \
-D LIB_SUFFIX=64 \\\
%endif \
-D SHARE_INSTALL_PREFIX=%{_datadir} \\\
-D SYSCONF_INSTALL_DIR=%{_sysconfdir} \\\
-S %{_vpath_srcdir}
```



-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2650#issuecomment-1711391974
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] fix install rpmrc, platform and macros files with off-source-tree build (PR #2651)

2023-09-08 Thread Tomasz Kłoczko
> CMake sets the current working directory to the respective build directory 
> automatically

Yes default directory is current directory however I see why it was working in 
case fedora build
```spec
%build
%set_build_flags

mkdir _build
cd _build
cmake \
  -DCMAKE_INSTALL_PREFIX=%{_usr} \
  -DCMAKE_INSTALL_SHAREDSTATEDIR:PATH=%{_var}/lib \
  %{?with_bdb_ro:-DENABLE_BDB_RO=ON} \
  %{!?with_ndb:-DENABLE_NDB=OFF} \
  %{!?with_sqlite:-DENABLE_SQLITE=OFF} \
  %{!?with_plugins:-DENABLE_PLUGINS=OFF} \
  %{?with_fsverity:-DWITH_FSVERITY=ON} \
  %{?with_libimaevm:-DWITH_IMAEVM=ON} \
  %{!?with_libarchive:-DWITH_ARCHIVE=OFF} \
  %{!?with_check:-DENABLE_TESTSUITE=OFF} \
  %{!?with_sequoia:-DWITH_INTERNAL_OPENPGP=ON} \
  %{!?with_sequoia:-DWITH_OPENSSL=ON } \
  -DRPM_VENDOR=redhat \
  ..
```
So in this case current direcrtry is changed before cmake execution and indeed 
CMAKE_BINARY_DIR"." however CMAKE_SOURCE_DIR="..".

I'm using %cmake macro so it uses `-B ` and  ${CMAKE_BINARY_DIR} is 
no longer current direcrory.

With my patch it will be working in both cases.

It is clearly possible to see that those three files are generated and land in 
${CMAKE_BINARY_DIR}.
```console
[tkloczko@pers-jacek rpm-4.18.99]$ ls -la x86_64-redhat-linux-gnu/
total 984
drwxr-xr-x 1 tkloczko tkloczko   828 Sep  8 09:23 .
drwxr-xr-x 1 tkloczko tkloczko   966 Sep  8 09:23 ..
-rw-r--r-- 1 tkloczko tkloczko 53053 Sep  8 09:23 CMakeCache.txt
-rw-r--r-- 1 tkloczko tkloczko 15038 Sep  8 09:23 CMakeDoxyfile.in
-rw-r--r-- 1 tkloczko tkloczko 20955 Sep  8 09:23 CMakeDoxygenDefaults.cmake
drwxr-xr-x 1 tkloczko tkloczko   914 Sep  8 09:23 CMakeFiles
-rw-r--r-- 1 tkloczko tkloczko 39153 Sep  8 09:23 Makefile
drwxr-xr-x 1 tkloczko tkloczko18 Sep  8 09:23 Testing
drwxr-xr-x 1 tkloczko tkloczko   178 Sep  8 09:23 build
-rw-r--r-- 1 tkloczko tkloczko 26756 Sep  8 09:23 cmake_install.cmake
-rw-r--r-- 1 tkloczko tkloczko  3147 Sep  8 09:23 config.h
drwxr-xr-x 1 tkloczko tkloczko   142 Sep  8 09:23 docs
-rwxr-xr-x 1 tkloczko tkloczko 49160 Sep  8 09:23 elfdeps
drwxr-xr-x 1 tkloczko tkloczko74 Sep  8 09:23 fileattrs
drwxr-xr-x 1 tkloczko tkloczko 6 Sep  8 09:23 include
-rw-r--r-- 1 tkloczko tkloczko  6151 Sep  8 09:23 install_manifest.txt
drwxr-xr-x 1 tkloczko tkloczko   164 Sep  8 09:23 lib
-rw-r--r-- 1 tkloczko tkloczko 45607 Sep  8 09:23 macros<<<=== HERE
drwxr-xr-x 1 tkloczko tkloczko74 Sep  8 09:23 misc
-rw-r--r-- 1 tkloczko tkloczko  2948 Sep  8 09:23 platform<<<=== HERE
drwxr-xr-x 1 tkloczko tkloczko   278 Sep  8 09:23 plugins
drwxr-xr-x 1 tkloczko tkloczko  1040 Sep  8 09:23 po
drwxr-xr-x 1 tkloczko tkloczko   140 Sep  8 09:23 python
-rwxr-xr-x 1 tkloczko tkloczko 59704 Sep  8 09:23 rpm
-rw-r--r-- 1 tkloczko tkloczko  3681 Sep  8 09:23 rpm-config-version.cmake
-rw-r--r-- 1 tkloczko tkloczko  1329 Sep  8 09:23 rpm-config.cmake
-rw-r--r-- 1 tkloczko tkloczko  4374 Sep  8 09:23 rpm-targets.cmake
-rw-r--r-- 1 tkloczko tkloczko   284 Sep  8 09:23 rpm.pc
-rwxr-xr-x 1 tkloczko tkloczko 55864 Sep  8 09:23 rpm2archive
-rwxr-xr-x 1 tkloczko tkloczko 43384 Sep  8 09:23 rpm2cpio
-rwxr-xr-x 1 tkloczko tkloczko 80584 Sep  8 09:23 rpmbuild
-rwxr-xr-x 1 tkloczko tkloczko 49336 Sep  8 09:23 rpmdb
-rwxr-xr-x 1 tkloczko tkloczko 41048 Sep  8 09:23 rpmdeps
-rwxr-xr-x 1 tkloczko tkloczko 47976 Sep  8 09:23 rpmgraph
drwxr-xr-x 1 tkloczko tkloczko   160 Sep  8 09:23 rpmio
-rwxr-xr-x 1 tkloczko tkloczko 42616 Sep  8 09:23 rpmkeys
-rwxr-xr-x 1 tkloczko tkloczko 32608 Sep  8 09:23 rpmlua
-rw-r--r-- 1 tkloczko tkloczko 11817 Sep  8 09:23 rpmpopt-4.18.99
lrwxrwxrwx 1 tkloczko tkloczko 3 Sep  8 09:23 rpmquery -> rpm
-rw-r--r-- 1 tkloczko tkloczko 18607 Sep  8 09:23 rpmrc <<<=== HERE
-rwxr-xr-x 1 tkloczko tkloczko 51784 Sep  8 09:23 rpmsign
-rwxr-xr-x 1 tkloczko tkloczko 38200 Sep  8 09:23 rpmsort
-rwxr-xr-x 1 tkloczko tkloczko 50448 Sep  8 09:23 rpmspec
-rwxr-xr-x 1 tkloczko tkloczko 40968 Sep  8 09:23 rpmuncompress
lrwxrwxrwx 1 tkloczko tkloczko 3 Sep  8 09:23 rpmverify -> rpm
drwxr-xr-x 1 tkloczko tkloczko74 Sep  8 09:23 scripts
drwxr-xr-x 1 tkloczko tkloczko   172 Sep  8 09:23 sign
drwxr-xr-x 1 tkloczko tkloczko74 Sep  8 09:23 tests
```


-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2651#issuecomment-1711374792
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] 4.18.99: broken off-source-tree install target (Issue #2650)

2023-09-08 Thread Tomasz Kłoczko
After install 4.18.99 and rebuild looks globs are working (so indeed globs re 
related to %arch).
However looks like python module installation hack still is needed .. so still 
something is wrong 樂
```console
RPM build errors:
File not found: 
/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.x86_64/usr/lib64/python3.8/site-packages/rpm
File not found: 
/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.x86_64/usr/lib64/python3.8/site-packages/rpm-*.*-info
```
```console
[tkloczko@pers-jacek SPECS]$ ls 
/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.x86_64/usr/lib/python3.8/site-packages/rpm*
 -l
-rw-r--r-- 1 tkloczko tkloczko 262 Sep  8 09:23 
/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.x86_64/usr/lib/python3.8/site-packages/rpm-4.18.99-py3.8.egg-info

/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.x86_64/usr/lib/python3.8/site-packages/rpm:
total 168
-rw-r--r-- 1 tkloczko tkloczko   3070 Sep  4 10:19 __init__.py
-rwxr-xr-x 1 tkloczko tkloczko 157512 Sep  8 09:23 _rpm.so
-rw-r--r-- 1 tkloczko tkloczko   6226 Sep  4 10:19 transaction.py
```


-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2650#issuecomment-1711360674
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] 4.18.99: no test suite?樂 (Issue #2648)

2023-09-08 Thread Tomasz Kłoczko
> We don't support ctest. The test suite is run with `make check`, see the 
> [README](https://github.com/rpm-software-management/rpm/blob/master/tests/README.md).

(just humble question)
OK but why? 樂 



-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2648#issuecomment-1711335321
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] 4.18.99: rpmbuild no longer recognises shell globs in %files?樂 (Issue #2649)

2023-09-08 Thread Tomasz Kłoczko
OK so it may mean that my patch fixes only install target in case of use 
off-source-tree build and because python module was installed in wrong location 
(on building rpm 4.17.0) stil something else around.

Other thing is  that even with broken %_arch "%{_arch}" string was used in path 
name and it did not affected collection %files and forming binary rpm packages.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2649#issuecomment-1711323487
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] 4.18.99: broken off-source-tree install target (Issue #2650)

2023-09-08 Thread Tomasz Kłoczko
On building 4.18.99 using rpm 4.17.0 I found that it is yet another issue which 
is somehow related to %_arch.

On building python module lands in /usr/lib/python* instead in 
/usr/lib64/python*
Initially I've added hack in %install
```spec
%__mv %{buildroot}{%{_prefix}/lib/python*,%{_libdir}}
```



-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2650#issuecomment-1711293523
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] 4.18.99: rpmbuild no longer recognises shell globs in %files?樂 (Issue #2649)

2023-09-08 Thread Tomasz Kłoczko
I've deleted all %_arch comments and opened separated ticket to keep those two 
thing separated.

I don't thing that shell globs are somehow related to %_arch issue when it is 
used off-source-tree build.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2649#issuecomment-1711289564
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] 4.18.99: rpmbuild no longer recognises shell globs in %files?樂 (Issue #2649)

2023-09-08 Thread Tomasz Kłoczko
This issue may be related to 
https://github.com/rpm-software-management/rpm/issues/1749

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2649#issuecomment-1711263408
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] paths[with spaces and square brackets] cannot be listed in %files (#1749)

2023-09-08 Thread Tomasz Kłoczko
Quite possible that this PR broke shell globs in %files
https://github.com/rpm-software-management/rpm/issues/2649

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1749#issuecomment-1711262879
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] fix install rpmrc, platform and macros files with off-source-tree build (PR #2651)

2023-09-08 Thread Tomasz Kłoczko
Files like rpmrc, platform and macros are not in source tree and they are 
generated to ${CMAKE_BINARY_DIR} in cace of off-source tree build.

Close #2650
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/2651

-- Commit Summary --

  * fix install rpmrc, platform and macros files with off-source-tree build

-- File Changes --

M CMakeLists.txt (4)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/2651.patch
https://github.com/rpm-software-management/rpm/pull/2651.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2651
You are receiving this because you are subscribed to this thread.

Message ID: rpm-software-management/rpm/pull/2...@github.com
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] 4.18.99: broken off-source-tree install target (Issue #2650)

2023-09-08 Thread Tomasz Kłoczko
>From https://github.com/rpm-software-management/rpm/issues/2649
I just realised that %_arch macro is not defined as well and I see in %install
```console
Executing(%install): /bin/sh -e /var/tmp/rpm-tmp.TkXan3
+ umask 022
+ cd /home/tkloczko/rpmbuild/BUILD
+ '[' '/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.%{_arch}' '!=' / ']'
+ rm -rf '/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.%{_arch}'
++ dirname '/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.%{_arch}'
+ /usr/bin/mkdir -p /home/tkloczko/rpmbuild/BUILDROOT
+ /usr/bin/mkdir '/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.%{_arch}'
+ ASMFLAGS='-O2 -g -grecord-gcc-switches -pipe -Wall -Werror=format-security 
-Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS 
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong 
-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fno-omit-frame-pointer 
-mno-omit-leaf-frame-pointer -m64 -mtune=generic -fasynchronous-unwind-tables 
-fstack-clash-protection -fcf-protection -fdata-sections -ffunction-sections'
+ CFLAGS='-O2 -g -grecord-gcc-switches -pipe -Wall -Werror=format-security 
-Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS 
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong 
-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fno-omit-frame-pointer 
-mno-omit-leaf-frame-pointer -m64 -mtune=generic -fasynchronous-unwind-tables 
-fstack-clash-protection -fcf-protection -fdata-sections -ffunction-sections'
+ CXXFLAGS='-O2 -g -grecord-gcc-switches -pipe -Wall -Werror=format-security 
-Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS 
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong 
-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fno-omit-frame-pointer 
-mno-omit-leaf-frame-pointer -m64 -mtune=generic -fasynchronous-unwind-tables 
-fstack-clash-protection -fcf-protection -fdata-sections -ffunction-sections'
+ FFLAGS='-O2 -g -grecord-gcc-switches -pipe -Wall -Werror=format-security 
-Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS 
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong 
-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fno-omit-frame-pointer 
-mno-omit-leaf-frame-pointer -m64 -mtune=generic -fasynchronous-unwind-tables 
-fstack-clash-protection -fcf-protection -fdata-sections -ffunction-sections 
-I/usr/lib/gfortran/modules'
+ FCFLAGS='-O2 -g -grecord-gcc-switches -pipe -Wall -Werror=format-security 
-Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS 
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong 
-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fno-omit-frame-pointer 
-mno-omit-leaf-frame-pointer -m64 -mtune=generic -fasynchronous-unwind-tables 
-fstack-clash-protection -fcf-protection -fdata-sections -ffunction-sections 
-I/usr/lib/gfortran/modules'
+ LDFLAGS='-Wl,--gc-sections -Wl,--as-needed -Wl,-z,now 
-specs=/usr/lib/rpm/redhat/redhat-hardened-ld -Wl,--build-id=sha1'
+ RUSTFLAGS='-C codegen-units=1 -C debuginfo=2 -C opt-level=2 -C 
link-arg=-fdata-sections -C link-arg=-ffunction-sections -C 
link-arg=-Wl,--as-needed -C link-arg=-Wl,-z,now -C link-arg=-Wl,-z,relro 
--cap-lints=warn'
+ VALAFLAGS=-g
+ CC=/usr/bin/gcc
+ CXX=/usr/bin/g++
+ FC=/usr/bin/gfortran
+ AR=/usr/bin/gcc-ar
+ NM=/usr/bin/gcc-nm
+ RANLIB=/usr/bin/gcc-ranlib
+ export ASMFLAGS CFLAGS CXXFLAGS FFLAGS FCFLAGS LDFLAGS VALAFLAGS CC CXX FC AR 
NM RANLIB RUSTFLAGS VALAFLAGS
+ cd rpm-4.18.99
+ DESTDIR='/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.%{_arch}'
+ /usr/bin/cmake --install x86_64-redhat-linux
-- Install configuration: "RelWithDebInfo"
-- Installing: 
/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.%{_arch}/usr/share/man/man1/gendiff.1

[..]

-- Set runtime path of 
"/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.%{_arch}/usr/lib/rpm/rpmuncompress"
 to ""
grep: rpmrc: No such file or directory
sed: can't read rpmrc: No such file or directory
cat: platform: No such file or directory
cat: macros: No such file or directory
-- Installing: 
/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.%{_arch}/usr/lib/rpm/macros
-- Installing: 
/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.%{_arch}/usr/lib/rpm/rpmrc
-- Installing: 
/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.%{_arch}/usr/lib/rpm/rpmpopt-4.18.99
-- Installing: 
/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.%{_arch}/usr/lib64/pkgconfig/rpm.pc
-- Installing: 
/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.%{_arch}/usr/lib/rpm/lua
-- Installing: 
/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.%{_arch}/usr/lib/rpm/macros.d
-- Installing: 
/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.%{_arch}/usr/lib64/cmake/rpm/rpm-config.cmake
-- Installing: 
/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.%{_arch}/usr/lib64/cmake/rpm/rpm-config-version.cmake
-- Installing: 

Re: [Rpm-maint] [rpm-software-management/rpm] 4.18.99: rpmbuild no longer recognises shell globs in %files?樂 (Issue #2649)

2023-09-08 Thread Tomasz Kłoczko
Files rpmrc, platform and macros are mot in source tree and they are generated 
to `${CMAKE_BINARY_DIR}` in cace of off-source tree build.
Here is the patch which fixes this issue
```patch
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -162,7 +162,9 @@
install(CODE "execute_process(COMMAND
${CMAKE_COMMAND} -E env pkglibdir=${RPM_CONFIGDIR}
${CMAKE_SOURCE_DIR}/installplatform
-   rpmrc platform macros
+   ${CMAKE_BINARY_DIR}/rpmrc
+   ${CMAKE_BINARY_DIR}/platform
+   ${CMAKE_BINARY_DIR}/macros
${RPMCANONVENDOR} ${RPMCANONOS} ${RPMCANONGNU})"
)
 endfunction()
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2649#issuecomment-1711212728
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] 4.18.99: rpmbuild no longer recognises shell globs in %files?樂 (Issue #2649)

2023-09-08 Thread Tomasz Kłoczko
I just realised that %_arch macro is not defined as well and I see in %install
```console
Executing(%install): /bin/sh -e /var/tmp/rpm-tmp.TkXan3
+ umask 022
+ cd /home/tkloczko/rpmbuild/BUILD
+ '[' '/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.%{_arch}' '!=' / ']'
+ rm -rf '/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.%{_arch}'
++ dirname '/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.%{_arch}'
+ /usr/bin/mkdir -p /home/tkloczko/rpmbuild/BUILDROOT
+ /usr/bin/mkdir '/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.%{_arch}'
+ ASMFLAGS='-O2 -g -grecord-gcc-switches -pipe -Wall -Werror=format-security 
-Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS 
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong 
-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fno-omit-frame-pointer 
-mno-omit-leaf-frame-pointer -m64 -mtune=generic -fasynchronous-unwind-tables 
-fstack-clash-protection -fcf-protection -fdata-sections -ffunction-sections'
+ CFLAGS='-O2 -g -grecord-gcc-switches -pipe -Wall -Werror=format-security 
-Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS 
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong 
-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fno-omit-frame-pointer 
-mno-omit-leaf-frame-pointer -m64 -mtune=generic -fasynchronous-unwind-tables 
-fstack-clash-protection -fcf-protection -fdata-sections -ffunction-sections'
+ CXXFLAGS='-O2 -g -grecord-gcc-switches -pipe -Wall -Werror=format-security 
-Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS 
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong 
-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fno-omit-frame-pointer 
-mno-omit-leaf-frame-pointer -m64 -mtune=generic -fasynchronous-unwind-tables 
-fstack-clash-protection -fcf-protection -fdata-sections -ffunction-sections'
+ FFLAGS='-O2 -g -grecord-gcc-switches -pipe -Wall -Werror=format-security 
-Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS 
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong 
-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fno-omit-frame-pointer 
-mno-omit-leaf-frame-pointer -m64 -mtune=generic -fasynchronous-unwind-tables 
-fstack-clash-protection -fcf-protection -fdata-sections -ffunction-sections 
-I/usr/lib/gfortran/modules'
+ FCFLAGS='-O2 -g -grecord-gcc-switches -pipe -Wall -Werror=format-security 
-Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS 
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong 
-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fno-omit-frame-pointer 
-mno-omit-leaf-frame-pointer -m64 -mtune=generic -fasynchronous-unwind-tables 
-fstack-clash-protection -fcf-protection -fdata-sections -ffunction-sections 
-I/usr/lib/gfortran/modules'
+ LDFLAGS='-Wl,--gc-sections -Wl,--as-needed -Wl,-z,now 
-specs=/usr/lib/rpm/redhat/redhat-hardened-ld -Wl,--build-id=sha1'
+ RUSTFLAGS='-C codegen-units=1 -C debuginfo=2 -C opt-level=2 -C 
link-arg=-fdata-sections -C link-arg=-ffunction-sections -C 
link-arg=-Wl,--as-needed -C link-arg=-Wl,-z,now -C link-arg=-Wl,-z,relro 
--cap-lints=warn'
+ VALAFLAGS=-g
+ CC=/usr/bin/gcc
+ CXX=/usr/bin/g++
+ FC=/usr/bin/gfortran
+ AR=/usr/bin/gcc-ar
+ NM=/usr/bin/gcc-nm
+ RANLIB=/usr/bin/gcc-ranlib
+ export ASMFLAGS CFLAGS CXXFLAGS FFLAGS FCFLAGS LDFLAGS VALAFLAGS CC CXX FC AR 
NM RANLIB RUSTFLAGS VALAFLAGS
+ cd rpm-4.18.99
+ DESTDIR='/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.%{_arch}'
+ /usr/bin/cmake --install x86_64-redhat-linux
-- Install configuration: "RelWithDebInfo"
-- Installing: 
/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.%{_arch}/usr/share/man/man1/gendiff.1

[..]

-- Set runtime path of 
"/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.%{_arch}/usr/lib/rpm/rpmuncompress"
 to ""
grep: rpmrc: No such file or directory
sed: can't read rpmrc: No such file or directory
cat: platform: No such file or directory
cat: macros: No such file or directory
-- Installing: 
/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.%{_arch}/usr/lib/rpm/macros
-- Installing: 
/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.%{_arch}/usr/lib/rpm/rpmrc
-- Installing: 
/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.%{_arch}/usr/lib/rpm/rpmpopt-4.18.99
-- Installing: 
/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.%{_arch}/usr/lib64/pkgconfig/rpm.pc
-- Installing: 
/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.%{_arch}/usr/lib/rpm/lua
-- Installing: 
/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.%{_arch}/usr/lib/rpm/macros.d
-- Installing: 
/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.%{_arch}/usr/lib64/cmake/rpm/rpm-config.cmake
-- Installing: 
/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.%{_arch}/usr/lib64/cmake/rpm/rpm-config-version.cmake
-- Installing: 
/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.%{_arch}/usr/lib64/cmake/rpm/rpm-targets.cmake
-- 

[Rpm-maint] [rpm-software-management/rpm] 4.18.99: rpmbuild no longer recognises shell globs in %files?樂 (Issue #2649)

2023-09-08 Thread Tomasz Kłoczko
After build first time rpm 4.18.99 I've tested building it with itself and I 
found new rpm no longer accepts shell globs in %files
RPM build errors:
File not found: 
/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.%{_arch}/usr/lib/rpm/*.{req,prov}
File not found: 
/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.%{_arch}/usr/lib/rpm/*.{provides,requires}
```
and
```console
[tkloczko@pers-jacek rpm-4.18.99]$ ls 
/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.%{_arch}/usr/lib/rpm/*.{req,prov}
 
/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.%{_arch}/usr/lib/rpm/*{provides,requires}*
 -1
/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.%{_arch}/usr/lib/rpm/find-provides
/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.%{_arch}/usr/lib/rpm/find-requires
/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.%{_arch}/usr/lib/rpm/fontconfig.prov
/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.%{_arch}/usr/lib/rpm/rpm_macros_provides.sh
/home/tkloczko/rpmbuild/BUILDROOT/rpm-4.18.99-2.fc35.%{_arch}/usr/lib/rpm/script.req
```
Bug or fracture? 樂 


-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2649
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] 4.18.99: no test suite?樂 (Issue #2648)

2023-09-07 Thread Tomasz Kłoczko
Just started refreshing my rpm package with rpm to latest version and found 
that despite run cmake with `ENABLE_TESTSUITE=ON` ctest is not able to run any 
test units
```console
+ cd rpm-4.18.99
+ /usr/bin/ctest --test-dir x86_64-redhat-linux-gnu --output-on-failure 
--force-new-ctest-process -j48 /usr/bin/chmod -R a+rwX .
Internal ctest changing into directory: 
/home/tkloczko/rpmbuild/BUILD/rpm-4.18.99/x86_64-redhat-linux-gnu
Test project /home/tkloczko/rpmbuild/BUILD/rpm-4.18.99/x86_64-redhat-linux-gnu
No tests were found!!!
```


-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2648
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] RFE: more finegrained BuildRequires (Issue #2631)

2023-08-26 Thread Tomasz Kłoczko
Introduction of `CheckRequires` which will be working as same as 
`BuildRequires` but skipped when executed with `--no-check` would be useful.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2631#issuecomment-1694277030
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Make %optflags empty on noarch target (PR #2615)

2023-08-15 Thread Tomasz Kłoczko
I want only point that %optflags could be used in %check.
I don not remember even one case when such change would be necessary.
 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2615#issuecomment-1678625213
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] RFE: allow overriding buildtime and hostname via environment variable (Issue #2603)

2023-08-04 Thread Tomasz Kłoczko
You can do that by `rpmbuild --define "%_buildhost " ` 
or you can put permanentny line in ~/.rpmmacros like "%_buildhost ".

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2603#issuecomment-1665426860
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] RFE: read sources checksums from the SPEC file and verify them (#463)

2023-07-14 Thread Tomasz Kłoczko
> This is an orthogonal discussion. you can have multiple variants in both 
> suggestions of mine (also in the fragmet suffix)

Maybe you din't notice but I've proposed not one but two variants.
Main point which I've added is to use pk11 like csum format. From that point of 
view everything from my point of view is secondary.


-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/463#issuecomment-1635723341
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] RFE: read sources checksums from the SPEC file and verify them (#463)

2023-07-14 Thread Tomasz Kłoczko
> I think that makes it really tricky with ordering (is it applying to the next 
> source or the previous one? and what if there are conditionals around source 
> lines?). imho really not very intuitive as it is very context dependent.

Currentpy you can use:
```spec
Source: file1
Source: file2
.
.
```
and rpm automatically numbers those Source internally.
So in above scenario ..
```spec
Source: file1
Source: file2
SourceCSum: sha256://
SourceCSum: sha256://
```
Would be instantly equivalent of:
```spec
Source0: file1
Source1: file2
SourceCSum0: sha256://
SourceCSum1: sha256://
```
Using `://` could allow as well use for example something 
like `github://verified` which could retrieve verified sign out of 
released/tagged Source: (and Patch:) archives (patches generated out of 
commits) as well.
https://docs.github.com/en/authentication/troubleshooting-commit-signature-verification/checking-your-commit-and-tag-signature-verification-status


-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/463#issuecomment-1635700929
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] RFE: read sources checksums from the SPEC file and verify them (#463)

2023-07-14 Thread Tomasz Kłoczko
I would like to see something more like pk11 format
```spec
SourceCSum: sha256://
```
Which would allow use different checksums algorithms.
Or as second argument of the `Source:`
```spec
Source:  sha256://
```


-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/463#issuecomment-1635653447
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] [RFE] Add option to %files to ignore listed files (suggest: -i) (Issue #2555)

2023-06-27 Thread Tomasz Kłoczko
During almost +20 years of using rpm I've never had such needs.
`%exclude` so far was enough.

-1

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2555#issuecomment-1609161572
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] `rpm -qa` output in json (Discussion #2547)

2023-06-19 Thread Tomasz Kłoczko
Someone have been trying to construct rpm query format string to produce for 
example `rpm -qa` packages names and versions as json? 樂 


-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/discussions/2547
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add RPM_LD_FLAGS to build environment (PR #2481)

2023-06-08 Thread Tomasz Kłoczko
> @kloczek if you don't know then perhaps you should find out before making 
> such statements.

As I wrote %set_build_flags is using $CFLAGS, $CXXFLAGS, $LDFLAGS, $NM, $CC, 
$CXX and so on because those env variables comes with meson, GNU, autotools, 
cmake and even plain make.
If some project is using `$RPM_`prefixed variables it is VERY rpm specific and 
should be fixed.

As same adding not `$RPM_`prefixed env variable to the generated script in 
%__prep_{build,install} does not make to much sense (especially in case 
building noarch packages) because tooling macros are using %set_build_flags.

All that makes only build logs longer .. only this and nothing more.
All above logic do not depend on my knowledge (I have nothing to do with the 
subject).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2481#issuecomment-1582341050
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add RPM_LD_FLAGS to build environment (PR #2481)

2023-06-07 Thread Tomasz Kłoczko
To be honest I have no idea why rpm source tree still cares about $RPM_*FLAGS 
env variables.
%configiure, %cmake and %meson are using %set_build_flags and that macro has 
nothing to do with $RPM_*_FLAGS.
If it something still uses $RPM_*FLAGS it is still some rare uncleaned case.


-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2481#issuecomment-1581184693
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Move dbus announce plugin config in /usr/share (PR #2530)

2023-06-02 Thread Tomasz Kłoczko
Hmm .. why this PR is not using paths provides by `dbus-1.pc`? 樂


-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2530#issuecomment-1573756570
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] 4.18.90: build fails with `-D WITH_INTERNAL_OPENPGP=ON -D WITH_OPENSSL=ON` (Issue #2507)

2023-05-25 Thread Tomasz Kłoczko
> Look, there simply are no references to those symbols in the entire source 
> tree. Take a pristine copy of the source and see for yourself. I don't know 
> what you're building, but those error messages can not come from building the 
> pristine 4.19 alpha tarball or git master.

Are you sure?
console
[tkloczko@pers-jacek rpm-4.18.90]$ grep -r pgpPrtPkts
include/rpm/rpmpgp.h:int pgpPrtPkts(const uint8_t *pkts, size_t pktlen, pgpDig 
dig, int printing);
rpmio/rpmkeyring.c: pgpPrtPkts(key->pkt, key->pktlen, sig, _print_pkts);
rpmio/rpmkeyring.c:rc = pgpPrtPkts(key->pkt, key->pktlen, dig, _print_pkts);
rpmio/rpmpgp_sequoia.c:W(int, pgpPrtPkts,
ChangeLog:- pgpPrtPkts() is basically just a wrapper to pgpPrtParams()
ChangeLog:Clean up pgpPrtPkts() and friends a bit
ChangeLog:- Since the only entry to these is pgpPrtPkts() and that ensures
ChangeLog:Added sanity checks on pgpPrtPkts() entry
ChangeLog:  early on in pgpPrtPkts() and doesn't change, and the rsa/dsa
ChangeLog:  pgpPrtPkts() to validate & figure it out and check its return 
code instead,
ChangeLog:- The error message is not very helpful but if pgpPrtPkts() fails
ChangeLog:Oops, rpmPubkeyDig() should return NULL if pgpPrtPkts() fails
ChangeLog:Actually handle headerGet() / pgpPrtPkts() failure on signature 
verify
ChangeLog:- additionally verify pgpPrtPkts() return code
```
Tar ball taken from http://ftp.rpm.org/releases/testing/rpm-4.18.90.tar.bz2


-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2507#issuecomment-1563231113
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] 4.18.90: build fails with `-D WITH_INTERNAL_OPENPGP=ON -D WITH_OPENSSL=ON` (Issue #2507)

2023-05-25 Thread Tomasz Kłoczko
I'm not using ccache.

Build env is performed inside LXC zone which has been created out of only 
BuldRequires.
The same effect I have outside LXC zone.
Did you check 'cmake -L" output to check what exactly have been set by cmake? 樂 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2507#issuecomment-1562856447
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] 4.18.90: build fails with `-D WITH_INTERNAL_OPENPGP=ON -D WITH_OPENSSL=ON` (Issue #2507)

2023-05-24 Thread Tomasz Kłoczko
> As per INSTALL:
> 
> ```
> wget http://ftp.rpm.org/releases/testing/rpm-4.18.90.tar.bz2
> tar xf rpm-4.18.90.tar.bz2
> cd rpm-4.18.90
> mkdir _build
> cd _build/
> cmake -D WITH_INTERNAL_OPENPGP=ON -D WITH_OPENSSL=ON ..
> make
> ```

Please have a look one more time on the ticket description.
Exactly those two params I've been using and with those two build fails.
Did you try to reproduce this issue? 樂 


-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2507#issuecomment-1561861855
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] 4.18.90: build fails with `-D WITH_INTERNAL_OPENPGP=ON -D WITH_OPENSSL=ON` (Issue #2507)

2023-05-22 Thread Tomasz Kłoczko
God to know that issue of tagging/versioning in in WIP state  
Thx  

What about how to build 4.18.90 with openssl? 樂 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2507#issuecomment-1557550368
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] 4.18.90: build fails with `-D WITH_INTERNAL_OPENPGP=ON -D WITH_OPENSSL=ON` (Issue #2507)

2023-05-22 Thread Tomasz Kłoczko
> The openssl backend builds just fine. Like @ffesti said, you have some cruft 
> in your source and/or build tree that's causing the failure.

Moment so what kind of cmake params I need to pass to 4.18.90 to build with 
openssl? 樂 

BTW looks like currently is used kind of messy versioning/tagging.
On http://ftp.rpm.org/releases/testing/ latest (test) release is 4.18.90 and 
there is no such tab in git repo and latest one is `rpm-4.19.0-alpha`.
If that is wat was used to generate rpm-4.18.90.tar.bz2 it should eb used 
`rpm-4.18.90`.
If you want to use alpha/beta/rc convention IMO you should consider use Gnome 
convention like `rpm-4.19.0.alpha` -> `rpm-4.19.0.beat` -> `rpm-4.19.0.rc` -> 
`rpm-4.19.0.0` (https://discourse.gnome.org/t/new-gnome-versioning-scheme/4235)
As well IMO it would be good to drop `rpm-` prefix in git tags to be able 
directly use autogenerated from git tag tar ball as input source resource.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2507#issuecomment-1557167391
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] 4.18.90: build fails with `-D WITH_INTERNAL_OPENPGP=ON -D WITH_OPENSSL=ON` (Issue #2507)

2023-05-15 Thread Tomasz Kłoczko
OK .. so it some unfinished wotk on that transition.
Thanks for clarification  

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2507#issuecomment-1548093170
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] 4.18.90: build fails with `-D WITH_INTERNAL_OPENPGP=ON -D WITH_OPENSSL=ON` (Issue #2507)

2023-05-15 Thread Tomasz Kłoczko
Moment so intention is to abandon handle by rpm handle PGP signatures using 
openssl routines? 樂 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2507#issuecomment-1548003186
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] 4.18.90: build fails with `-D WITH_INTERNAL_OPENPGP=ON -D WITH_OPENSSL=ON` (Issue #2507)

2023-05-11 Thread Tomasz Kłoczko
Looks like some library (probably `gpgme`) dependency checking is missing when 
source tree is configured with `-D WITH_INTERNAL_OPENPGP=ON -D WITH_OPENSSL=ON`.
I see only openssl detection in
https://github.com/rpm-software-management/rpm/blob/93ee7d9c6164467608094a7e0652a0e3d84a6715/rpmio/CMakeLists.txt#L14C1-L17

Result is that librpmio is underlinked:
```console
[ 37%] Linking C executable rpm
/usr/bin/cmake -E cmake_link_script CMakeFiles/rpm.dir/link.txt --verbose=1
/usr/bin/gcc -O2 -g -grecord-gcc-switches -pipe -Wall -Werror=format-security 
-Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS 
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong 
-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fno-omit-frame-pointer 
-mno-omit-leaf-frame-pointer -m64 -mtune=generic -fasynchronous-unwind-tables 
-fstack-clash-protection -fcf-protection -fdata-sections -ffunction-sections 
-DNDEBUG -Wl,--gc-sections -Wl,--as-needed -Wl,-z,now 
-specs=/usr/lib/rpm/redhat/redhat-hardened-ld -Wl,--build-id=sha1 
CMakeFiles/rpm.dir/rpm.c.o CMakeFiles/rpm.dir/cliutils.c.o -o rpm  
-Wl,-rpath,/home/tkloczko/rpmbuild/BUILD/rpm-4.18.90/x86_64-redhat-linux-gnu/lib:/home/tkloczko/rpmbuild/BUILD/rpm-4.18.90/x86_64-redhat-linux-gnu/rpmio:
 lib/librpm.so.10.0.0 rpmio/librpmio.so.10.0.0 /usr/lib64/libpopt.so
/usr/bin/ld: rpmio/librpmio.so.10.0.0: undefined reference to `pgpPrtPkts'
/usr/bin/ld: rpmio/librpmio.so.10.0.0: undefined reference to `pgpNewDig'
/usr/bin/ld: rpmio/librpmio.so.10.0.0: undefined reference to `pgpDigGetParams'
/usr/bin/ld: rpmio/librpmio.so.10.0.0: undefined reference to `pgpFreeDig'
collect2: error: ld returned 1 exit status
```


-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2507
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] %autosetup -a1 -a2 failed to extract all tarball (Issue #2495)

2023-04-26 Thread Tomasz Kłoczko
Nevertheless it is possible to hadle such cases by:
```spec
%setup -q -a1 -a2
%autopatch
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2495#issuecomment-1523607579
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] %autosetup -a1 -a2 failed to extract all tarball (Issue #2495)

2023-04-23 Thread Tomasz Kłoczko
Known issue https://github.com/rpm-software-management/rpm/issues/1204

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2495#issuecomment-1519134758
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Q: is it possible to define dependencies generators in spec file? (Discussion #2485)

2023-04-19 Thread Tomasz Kłoczko
That is OK (do I was not wrong) .. what do you think about create RFE? 樂 

IMO especially such dependecy generator for `provides` would be usefull. IMO it 
would be godd to be able define different dependencies generators per 
sunbpackage so this is why I've been thinking about something like `%define  
___{provides,requires}`.


-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/discussions/2485#discussioncomment-5659107
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Q: is it possible to define dependencies generators in spec file? (Discussion #2485)

2023-04-14 Thread Tomasz Kłoczko
According to 
https://rpm-software-management.github.io/rpm/manual/dependency_generators.html 
it is possible to define in .ttr files dependencies generators.
That works.

As long as .attr files defines macros I've been thinking that this will mean 
that such macros meybe is possible to define directly in spec file like
```spec
%define  ___requires   %()
%define  ___provides   %()
```
and looks like such macro is not used.

Typical use case is for example API version of just build foo-devel package as:
```spec
Provides: foo()
```
or for example package with X server provides ABI imterface
```spec
Provides: xserver-abi() = 
```
which is now defined manually for example in X server spec file by
```
%define ansic_major 0
%define ansic_minor 4
%define videodrv_major  25
%define videodrv_minor  2
%define xinput_major24
%define xinput_minor4
%define extension_major 10
%define extension_minor 0

Provides:   xserver-abi(ansic-%{ansic_major})   = %{ansic_minor}
Provides:   xserver-abi(extension-%{extension_major})   = 
%{extension_minor}
Provides:   xserver-abi(videodrv-%{videodrv_major}) = 
%{videodrv_minor}
Provides:   xserver-abi(xinput-%{xinput_major}) = 
%{xinput_minor}
```
And theoretically this could be generated by parse content of the files 
installed in buildroot 
```spec
%define __xorg-x11-server-Xorg_provides   %()
```
If such ABI version will change it will be necessary to update that manually 
but first someone will need to notie that all X server modules needs to be 
rebuilded because ABI has changed and now it fails on X Server start and rpm 
was not able to raise automatically broken dependencies.
Use cases for scenario simillar to above is much more.

Currently to have something like that it is neccessary to have inatall in 
`%_fileattrsdir` some `foo.attr` file and IMO it would be way better to have 
possiblity to define for exact in exact package spec file `%___provides` 
and other.

Issue is that as long as such macro is uaees and place where iit is defined are 
located in two places (.attr and spec file) it is nothing more than just asking 
for troubles. Other thinng is that as long as it is only dependecy henerator 
used only in one place (fro ecample provides generator) it would be good to 
have possibility to define that straight is spec file.

..or maybe it is possible to define something like that straight is spec? 樂



-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/discussions/2485
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] 4.17.0: autoconf 2.71 warnings (#1785)

2021-09-24 Thread Tomasz Kłoczko
Those warnings can be fixed and using older version of autoconf still will be 
fine.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1785#issuecomment-926497383___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] 4.17.0: autoconf 2.71 warnings (#1785)

2021-09-23 Thread Tomasz Kłoczko
Look slike rpm still is mot fully cleaned for autoconf 2.71
```console
+ autoreconf -fiv
autoreconf: export WARNINGS=
autoreconf: Entering directory '.'
autoreconf: running: autopoint --force
Copying file m4/codeset.m4
Copying file m4/fcntl-o.m4
Copying file m4/glibc2.m4
Copying file m4/glibc21.m4
Copying file m4/intdiv0.m4
Copying file m4/intl.m4
Copying file m4/intldir.m4
Copying file m4/intmax.m4
Copying file m4/inttypes-pri.m4
Copying file m4/inttypes_h.m4
Copying file m4/lcmessage.m4
Copying file m4/lock.m4
Copying file m4/longlong.m4
Copying file m4/printf-posix.m4
Copying file m4/size_max.m4
Copying file m4/stdint_h.m4
Copying file m4/threadlib.m4
Copying file m4/uintmax_t.m4
Copying file m4/visibility.m4
Copying file m4/wchar_t.m4
Copying file m4/wint_t.m4
Copying file m4/xsize.m4
Copying file po/Makevars.template
autoreconf: running: aclocal --force -I m4
autoreconf: configure.ac: tracing
autoreconf: running: libtoolize --copy --force
libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, 'build-aux'.
libtoolize: copying file 'build-aux/ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
libtoolize: copying file 'm4/libtool.m4'
libtoolize: copying file 'm4/ltoptions.m4'
libtoolize: copying file 'm4/ltsugar.m4'
libtoolize: copying file 'm4/ltversion.m4'
libtoolize: copying file 'm4/lt~obsolete.m4'
autoreconf: configure.ac: not using Intltool
autoreconf: configure.ac: not using Gtkdoc
autoreconf: running: aclocal --force -I m4
autoreconf: running: /usr/bin/autoconf --force
configure.ac:29: warning: The macro `AC_PROG_LIBTOOL' is obsolete.
configure.ac:29: You should run autoupdate.
m4/libtool.m4:99: AC_PROG_LIBTOOL is expanded from...
configure.ac:29: the top level
configure.ac:32: warning: The macro `AC_PROG_CC_C99' is obsolete.
configure.ac:32: You should run autoupdate.
./lib/autoconf/c.m4:1659: AC_PROG_CC_C99 is expanded from...
configure.ac:32: the top level
configure.ac:62: warning: The macro `AM_PROG_LIBTOOL' is obsolete.
configure.ac:62: You should run autoupdate.
m4/libtool.m4:100: AM_PROG_LIBTOOL is expanded from...
configure.ac:62: the top level
configure.ac:265: warning: The macro `AC_HELP_STRING' is obsolete.
configure.ac:265: You should run autoupdate.
./lib/autoconf/general.m4:204: AC_HELP_STRING is expanded from...
./lib/autoconf/general.m4:1553: AC_ARG_WITH is expanded from...
configure.ac:265: the top level
configure.ac:518: warning: The macro `AC_HEADER_STDC' is obsolete.
configure.ac:518: You should run autoupdate.
./lib/autoconf/headers.m4:704: AC_HEADER_STDC is expanded from...
configure.ac:518: the top level
autoreconf: running: /usr/bin/autoheader --force
autoreconf: running: automake --add-missing --copy --force-missing
configure.ac:15: installing 'build-aux/compile'
configure.ac:9: installing 'build-aux/missing'
Makefile.am: installing 'build-aux/depcomp'
autoreconf: Leaving directory '.'
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1785___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Clarify %check script use-case by executing it before %install (#1618)

2021-04-07 Thread Tomasz Kłoczko
Just please "If it ain't broke, don't fix it".

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1618#issuecomment-814813292___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Clarify %check script use-case by executing it before %install (#1618)

2021-04-07 Thread Tomasz Kłoczko
It doent matter what is using and how.
Changing order of the `check` and `%insytall` does not fixes or improves 
anything and may cause **only** problems.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1618#issuecomment-814810509___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Clarify %check script use-case by executing it before %install (#1618)

2021-04-07 Thread Tomasz Kłoczko
At the moment fedora `%pytes` ant `%ox` are udsing paths in %{builroot} and in 
many cases there is no other way to perform `%check` than using `%{builroot}` 
tree

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1618#issuecomment-814782686___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] 4.15.1: problem with rpm and --root option (#1372)

2020-10-14 Thread Tomasz Kłoczko
I'm still struglling with access to the database of the LXC zone using --dbpath 
or --root.

You wrote that you been able to use rpm on such cases with --dbpath.
Could you please c some example how you ar doing that?


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1372#issuecomment-708340656___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] 4.16.0: issue with %clean after finish building package (#1382)

2020-10-05 Thread Tomasz Kłoczko
.. because test suite not always will be executed by rpmbuild.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1382#issuecomment-703470941___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] 4.16.0: issue with %clean after finish building package (#1382)

2020-10-05 Thread Tomasz Kłoczko
As I wrote chmod at the end shout not harm any test units.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1382#issuecomment-703473925___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] 4.16.0: issue with %clean after finish building package (#1382)

2020-10-05 Thread Tomasz Kłoczko
IMO better woud be just do that chmod as last unit of the test suite.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1382#issuecomment-703469613___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] 4.16.0: issue with %clean after finish building package (#1382)

2020-10-04 Thread Tomasz Kłoczko
Looks like something has changed in test suite and after suzessfull build 
package standard %clean section cannot remove build tree:
```
Executing(--clean): /bin/sh -e /var/tmp/rpm-tmp.4Q0rn7
+ umask 022
+ cd /home/tkloczko/rpmbuild/BUILD
+ rm -rf rpm-4.16.0
rm: cannot remove 'rpm-4.16.0/tests/testing/usr/bin/bin': Permission denied
rm: cannot remove 'rpm-4.16.0/tests/testing/usr/bin/gendiff': Permission denied
rm: cannot remove 'rpm-4.16.0/tests/testing/usr/bin/rpm': Permission denied
rm: cannot remove 'rpm-4.16.0/tests/testing/usr/bin/rpm2cpio': Permission denied
rm: cannot remove 'rpm-4.16.0/tests/testing/usr/bin/rpmbuild': Permission denied
rm: cannot remove 'rpm-4.16.0/tests/testing/usr/bin/rpmdb': Permission denied
rm: cannot remove 'rpm-4.16.0/tests/testing/usr/bin/rpmkeys': Permission denied
rm: cannot remove 'rpm-4.16.0/tests/testing/usr/bin/rpmsign': Permission denied
rm: cannot remove 'rpm-4.16.0/tests/testing/usr/bin/rpmspec': Permission denied
rm: cannot remove 'rpm-4.16.0/tests/testing/usr/bin/rpm2archive': Permission 
denied
rm: cannot remove 'rpm-4.16.0/tests/testing/usr/bin/rpmgraph': Permission denied
rm: cannot remove 'rpm-4.16.0/tests/testing/usr/bin/rpmquery': Permission denied
rm: cannot remove 'rpm-4.16.0/tests/testing/usr/bin/rpmverify': Permission 
denied
rm: cannot remove 'rpm-4.16.0/tests/testing/usr/bin/gzip': Permission denied
rm: cannot remove 'rpm-4.16.0/tests/testing/usr/bin/cat': Permission denied
rm: cannot remove 'rpm-4.16.0/tests/testing/usr/bin/patch': Permission denied
rm: cannot remove 'rpm-4.16.0/tests/testing/usr/bin/tar': Permission denied
rm: cannot remove 'rpm-4.16.0/tests/testing/usr/bin/sh': Permission denied
rm: cannot remove 'rpm-4.16.0/tests/testing/usr/bin/ln': Permission denied
rm: cannot remove 'rpm-4.16.0/tests/testing/usr/bin/chmod': Permission denied
rm: cannot remove 'rpm-4.16.0/tests/testing/usr/bin/rm': Permission denied
rm: cannot remove 'rpm-4.16.0/tests/testing/usr/bin/mkdir': Permission denied
rm: cannot remove 'rpm-4.16.0/tests/testing/usr/bin/uname': Permission denied
rm: cannot remove 'rpm-4.16.0/tests/testing/usr/bin/grep': Permission denied
rm: cannot remove 'rpm-4.16.0/tests/testing/usr/bin/sed': Permission denied
rm: cannot remove 'rpm-4.16.0/tests/testing/usr/bin/find': Permission denied
rm: cannot remove 'rpm-4.16.0/tests/testing/usr/bin/file': Permission denied
rm: cannot remove 'rpm-4.16.0/tests/testing/usr/bin/ionice': Permission denied
rm: cannot remove 'rpm-4.16.0/tests/testing/usr/bin/mktemp': Permission denied
rm: cannot remove 'rpm-4.16.0/tests/testing/usr/bin/nice': Permission denied
rm: cannot remove 'rpm-4.16.0/tests/testing/usr/bin/cut': Permission denied
rm: cannot remove 'rpm-4.16.0/tests/testing/usr/bin/sort': Permission denied
rm: cannot remove 'rpm-4.16.0/tests/testing/usr/bin/diff': Permission denied
rm: cannot remove 'rpm-4.16.0/tests/testing/usr/bin/touch': Permission denied
rm: cannot remove 'rpm-4.16.0/tests/testing/usr/bin/install': Permission denied
rm: cannot remove 'rpm-4.16.0/tests/testing/usr/bin/wc': Permission denied
rm: cannot remove 'rpm-4.16.0/tests/testing/usr/bin/xargs': Permission denied
rm: cannot remove 
'rpm-4.16.0/tests/testing/usr/share/locale/ar/LC_MESSAGES/rpm.mo': Permission 
denied
rm: cannot remove 
'rpm-4.16.0/tests/testing/usr/share/locale/br/LC_MESSAGES/rpm.mo': Permission 
denied
rm: cannot remove 
'rpm-4.16.0/tests/testing/usr/share/locale/ca/LC_MESSAGES/rpm.mo': Permission 
denied
rm: cannot remove 
'rpm-4.16.0/tests/testing/usr/share/locale/cmn/LC_MESSAGES/rpm.mo': Permission 
denied
rm: cannot remove 
'rpm-4.16.0/tests/testing/usr/share/locale/cs/LC_MESSAGES/rpm.mo': Permission 
denied
rm: cannot remove 
'rpm-4.16.0/tests/testing/usr/share/locale/da/LC_MESSAGES/rpm.mo': Permission 
denied
rm: cannot remove 
'rpm-4.16.0/tests/testing/usr/share/locale/de/LC_MESSAGES/rpm.mo': Permission 
denied
rm: cannot remove 
'rpm-4.16.0/tests/testing/usr/share/locale/el/LC_MESSAGES/rpm.mo': Permission 
denied
rm: cannot remove 
'rpm-4.16.0/tests/testing/usr/share/locale/eo/LC_MESSAGES/rpm.mo': Permission 
denied
rm: cannot remove 
'rpm-4.16.0/tests/testing/usr/share/locale/es/LC_MESSAGES/rpm.mo': Permission 
denied
rm: cannot remove 
'rpm-4.16.0/tests/testing/usr/share/locale/fi/LC_MESSAGES/rpm.mo': Permission 
denied
rm: cannot remove 
'rpm-4.16.0/tests/testing/usr/share/locale/fr/LC_MESSAGES/rpm.mo': Permission 
denied
rm: cannot remove 
'rpm-4.16.0/tests/testing/usr/share/locale/id/LC_MESSAGES/rpm.mo': Permission 
denied
rm: cannot remove 
'rpm-4.16.0/tests/testing/usr/share/locale/is/LC_MESSAGES/rpm.mo': Permission 
denied
rm: cannot remove 
'rpm-4.16.0/tests/testing/usr/share/locale/it/LC_MESSAGES/rpm.mo': Permission 
denied
rm: cannot remove 
'rpm-4.16.0/tests/testing/usr/share/locale/ja/LC_MESSAGES/rpm.mo': Permission 
denied
rm: cannot remove 
'rpm-4.16.0/tests/testing/usr/share/locale/ko/LC_MESSAGES/rpm.mo': Permission 
denied
rm: cannot remove 

Re: [Rpm-maint] [rpm-software-management/rpm] 4.15.1: problem with rpm and --root option (#1372)

2020-09-28 Thread Tomasz Kłoczko
Still it does not work ..
```
[root@barrel ~]# rm -rf var; mkdir -p var/lib/rpm; cp -r /var/lib/rpm 
var/lib/rpm; rpm -qa -r $(pwd) -vv
ufdio:   1 reads,17654 total bytes in 0.10 secs
ufdio:   1 reads, 5557 total bytes in 0.03 secs
ufdio:   1 reads,17654 total bytes in 0.08 secs
D: loading keyring from pubkeys in /root/var/lib/rpm/pubkeys/*.key
D: couldn't find any keys in /root/var/lib/rpm/pubkeys/*.key
D: loading keyring from rpmdb
D: opening  db environment /root/var/lib/rpm cdb:0x401
D: opening  db index   /root/var/lib/rpm/Packages 0x400 mode=0x0
D: opening  db index   /root/var/lib/rpm/Packages 0x1 mode=0x0
D: locked   db index   /root/var/lib/rpm/Packages
D: disabling fsync on database
D: opening  db index   /root/var/lib/rpm/Name 0x400 mode=0x0
D: opening  db index   /root/var/lib/rpm/Name 0x1 mode=0x0
D: index Name needs creating
D: opening  db index   /root/var/lib/rpm/Basenames 0x400 mode=0x0
D: opening  db index   /root/var/lib/rpm/Basenames 0x1 mode=0x0
D: index Basenames needs creating
D: opening  db index   /root/var/lib/rpm/Group 0x400 mode=0x0
D: opening  db index   /root/var/lib/rpm/Group 0x1 mode=0x0
D: index Group needs creating
D: opening  db index   /root/var/lib/rpm/Requirename 0x400 mode=0x0
D: opening  db index   /root/var/lib/rpm/Requirename 0x1 mode=0x0
D: index Requirename needs creating
D: opening  db index   /root/var/lib/rpm/Providename 0x400 mode=0x0
D: opening  db index   /root/var/lib/rpm/Providename 0x1 mode=0x0
D: index Providename needs creating
D: opening  db index   /root/var/lib/rpm/Conflictname 0x400 mode=0x0
D: opening  db index   /root/var/lib/rpm/Conflictname 0x1 mode=0x0
D: index Conflictname needs creating
D: opening  db index   /root/var/lib/rpm/Obsoletename 0x400 mode=0x0
D: opening  db index   /root/var/lib/rpm/Obsoletename 0x1 mode=0x0
D: index Obsoletename needs creating
D: opening  db index   /root/var/lib/rpm/Triggername 0x400 mode=0x0
D: opening  db index   /root/var/lib/rpm/Triggername 0x1 mode=0x0
D: index Triggername needs creating
D: opening  db index   /root/var/lib/rpm/Dirnames 0x400 mode=0x0
D: opening  db index   /root/var/lib/rpm/Dirnames 0x1 mode=0x0
D: index Dirnames needs creating
D: opening  db index   /root/var/lib/rpm/Installtid 0x400 mode=0x0
D: opening  db index   /root/var/lib/rpm/Installtid 0x1 mode=0x0
D: index Installtid needs creating
D: opening  db index   /root/var/lib/rpm/Sigmd5 0x400 mode=0x0
D: opening  db index   /root/var/lib/rpm/Sigmd5 0x1 mode=0x0
D: index Sigmd5 needs creating
D: opening  db index   /root/var/lib/rpm/Sha1header 0x400 mode=0x0
D: opening  db index   /root/var/lib/rpm/Sha1header 0x1 mode=0x0
D: index Sha1header needs creating
D: opening  db index   /root/var/lib/rpm/Filetriggername 0x400 mode=0x0
D: opening  db index   /root/var/lib/rpm/Filetriggername 0x1 mode=0x0
D: index Filetriggername needs creating
D: opening  db index   /root/var/lib/rpm/Transfiletriggername 0x400 mode=0x0
D: opening  db index   /root/var/lib/rpm/Transfiletriggername 0x1 mode=0x0
D: index Transfiletriggername needs creating
D: opening  db index   /root/var/lib/rpm/Recommendname 0x400 mode=0x0
D: opening  db index   /root/var/lib/rpm/Recommendname 0x1 mode=0x0
D: index Recommendname needs creating
D: opening  db index   /root/var/lib/rpm/Suggestname 0x400 mode=0x0
D: opening  db index   /root/var/lib/rpm/Suggestname 0x1 mode=0x0
D: index Suggestname needs creating
D: opening  db index   /root/var/lib/rpm/Supplementname 0x400 mode=0x0
D: opening  db index   /root/var/lib/rpm/Supplementname 0x1 mode=0x0
D: index Supplementname needs creating
D: opening  db index   /root/var/lib/rpm/Enhancename 0x400 mode=0x0
D: opening  db index   /root/var/lib/rpm/Enhancename 0x1 mode=0x0
D: index Enhancename needs creating
D: closed   db index   /root/var/lib/rpm/Packages
D: closed   db index   /root/var/lib/rpm/Enhancename
D: closed   db index   /root/var/lib/rpm/Supplementname
D: closed   db index   /root/var/lib/rpm/Suggestname
D: closed   db index   /root/var/lib/rpm/Recommendname
D: closed   db index   /root/var/lib/rpm/Transfiletriggername
D: closed   db index   /root/var/lib/rpm/Filetriggername
D: closed   db index   /root/var/lib/rpm/Sha1header
D: closed   db index   /root/var/lib/rpm/Sigmd5
D: closed   db index   /root/var/lib/rpm/Installtid
D: closed   db index   /root/var/lib/rpm/Dirnames
D: closed   db index   /root/var/lib/rpm/Triggername
D: closed   db index   /root/var/lib/rpm/Obsoletename
D: closed   db index   /root/var/lib/rpm/Conflictname
D: closed   db index   /root/var/lib/rpm/Providename
D: closed   db index   /root/var/lib/rpm/Requirename
D: closed   db index   /root/var/lib/rpm/Group
D: closed   db index   /root/var/lib/rpm/Basenames
D: closed   db index   

Re: [Rpm-maint] [rpm-software-management/rpm] 4.15.1: problem with rpm and --root option (#1372)

2020-09-28 Thread Tomasz Kłoczko
I don't think that rpm should be doing anything using chroot() for simple query.
To make query all what needs to be done is just add base root path (for 
/var/lib/rpm, /etc/rpm and /var/lib/rpm as well).
On install/upgrade/remove the same if will be done from non-root current checks 
is uid=0 is IMO enough to exit with non-zero code.
chroot() will be only necessary for install/upgrade/remove/verify operations 
(for (%verifyscript) from root or when rpm process will have necessary 
capabilities to call chroot().

Nevertheless currently -r/--root does not work even for queries.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1372#issuecomment-699862822___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] 4.15.1: problem with rpm and --root option (#1372)

2020-09-28 Thread Tomasz Kłoczko
Of course it doesn't wortk as well from root.
```
[root@barrel ~]# mkdir -p var/lib/rpm; cp -r /var/lib/rpm var/lib/rpm; rpm -r 
$(pwd)/var/lib/rpm -qavv
ufdio:   1 reads,17654 total bytes in 0.10 secs
ufdio:   1 reads, 5557 total bytes in 0.03 secs
ufdio:   1 reads,17654 total bytes in 0.09 secs
D: loading keyring from pubkeys in /root/var/lib/rpm/var/lib/rpm/pubkeys/*.key
D: couldn't find any keys in /root/var/lib/rpm/var/lib/rpm/pubkeys/*.key
D: loading keyring from rpmdb
D: created directory(s) /root/var/lib/rpm/var/lib/rpm mode 0755
D: created directory(s) /root/var/lib/rpm/var/lib/rpm mode 0755
D: created directory(s) /root/var/lib/rpm/var/lib/rpm mode 0755
D: opening  db environment /root/var/lib/rpm/var/lib/rpm cdb:0x401
D: opening  db index   /root/var/lib/rpm/var/lib/rpm/Packages 0x400 mode=0x0
D: opening  db index   /root/var/lib/rpm/var/lib/rpm/Packages 0x1 mode=0x0
D: locked   db index   /root/var/lib/rpm/var/lib/rpm/Packages
D: disabling fsync on database
D: opening  db index   /root/var/lib/rpm/var/lib/rpm/Name 0x400 mode=0x0
D: opening  db index   /root/var/lib/rpm/var/lib/rpm/Name 0x1 mode=0x0
D: index Name needs creating
D: opening  db index   /root/var/lib/rpm/var/lib/rpm/Basenames 0x400 
mode=0x0
D: opening  db index   /root/var/lib/rpm/var/lib/rpm/Basenames 0x1 mode=0x0
D: index Basenames needs creating
D: opening  db index   /root/var/lib/rpm/var/lib/rpm/Group 0x400 mode=0x0
D: opening  db index   /root/var/lib/rpm/var/lib/rpm/Group 0x1 mode=0x0
D: index Group needs creating
D: opening  db index   /root/var/lib/rpm/var/lib/rpm/Requirename 0x400 
mode=0x0
D: opening  db index   /root/var/lib/rpm/var/lib/rpm/Requirename 0x1 
mode=0x0
D: index Requirename needs creating
D: opening  db index   /root/var/lib/rpm/var/lib/rpm/Providename 0x400 
mode=0x0
D: opening  db index   /root/var/lib/rpm/var/lib/rpm/Providename 0x1 
mode=0x0
D: index Providename needs creating
D: opening  db index   /root/var/lib/rpm/var/lib/rpm/Conflictname 0x400 
mode=0x0
D: opening  db index   /root/var/lib/rpm/var/lib/rpm/Conflictname 0x1 
mode=0x0
D: index Conflictname needs creating
D: opening  db index   /root/var/lib/rpm/var/lib/rpm/Obsoletename 0x400 
mode=0x0
D: opening  db index   /root/var/lib/rpm/var/lib/rpm/Obsoletename 0x1 
mode=0x0
D: index Obsoletename needs creating
D: opening  db index   /root/var/lib/rpm/var/lib/rpm/Triggername 0x400 
mode=0x0
D: opening  db index   /root/var/lib/rpm/var/lib/rpm/Triggername 0x1 
mode=0x0
D: index Triggername needs creating
D: opening  db index   /root/var/lib/rpm/var/lib/rpm/Dirnames 0x400 mode=0x0
D: opening  db index   /root/var/lib/rpm/var/lib/rpm/Dirnames 0x1 mode=0x0
D: index Dirnames needs creating
D: opening  db index   /root/var/lib/rpm/var/lib/rpm/Installtid 0x400 
mode=0x0
D: opening  db index   /root/var/lib/rpm/var/lib/rpm/Installtid 0x1 mode=0x0
D: index Installtid needs creating
D: opening  db index   /root/var/lib/rpm/var/lib/rpm/Sigmd5 0x400 mode=0x0
D: opening  db index   /root/var/lib/rpm/var/lib/rpm/Sigmd5 0x1 mode=0x0
D: index Sigmd5 needs creating
D: opening  db index   /root/var/lib/rpm/var/lib/rpm/Sha1header 0x400 
mode=0x0
D: opening  db index   /root/var/lib/rpm/var/lib/rpm/Sha1header 0x1 mode=0x0
D: index Sha1header needs creating
D: opening  db index   /root/var/lib/rpm/var/lib/rpm/Filetriggername 0x400 
mode=0x0
D: opening  db index   /root/var/lib/rpm/var/lib/rpm/Filetriggername 0x1 
mode=0x0
D: index Filetriggername needs creating
D: opening  db index   /root/var/lib/rpm/var/lib/rpm/Transfiletriggername 
0x400 mode=0x0
D: opening  db index   /root/var/lib/rpm/var/lib/rpm/Transfiletriggername 
0x1 mode=0x0
D: index Transfiletriggername needs creating
D: opening  db index   /root/var/lib/rpm/var/lib/rpm/Recommendname 0x400 
mode=0x0
D: opening  db index   /root/var/lib/rpm/var/lib/rpm/Recommendname 0x1 
mode=0x0
D: index Recommendname needs creating
D: opening  db index   /root/var/lib/rpm/var/lib/rpm/Suggestname 0x400 
mode=0x0
D: opening  db index   /root/var/lib/rpm/var/lib/rpm/Suggestname 0x1 
mode=0x0
D: index Suggestname needs creating
D: opening  db index   /root/var/lib/rpm/var/lib/rpm/Supplementname 0x400 
mode=0x0
D: opening  db index   /root/var/lib/rpm/var/lib/rpm/Supplementname 0x1 
mode=0x0
D: index Supplementname needs creating
D: opening  db index   /root/var/lib/rpm/var/lib/rpm/Enhancename 0x400 
mode=0x0
D: opening  db index   /root/var/lib/rpm/var/lib/rpm/Enhancename 0x1 
mode=0x0
D: index Enhancename needs creating
D: closed   db index   /root/var/lib/rpm/var/lib/rpm/Packages
D: closed   db index   /root/var/lib/rpm/var/lib/rpm/Enhancename
D: closed   db index   /root/var/lib/rpm/var/lib/rpm/Supplementname
D: closed   db index   /root/var/lib/rpm/var/lib/rpm/Suggestname
D: closed   db index   

Re: [Rpm-maint] [rpm-software-management/rpm] 4.15.1: problem with rpm and --root option (#1372)

2020-09-28 Thread Tomasz Kłoczko
Of course it doesn't wortk as well from root.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1372#issuecomment-699851585___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] 4.15.1: problem with rpm and --root option (#1372)

2020-09-28 Thread Tomasz Kłoczko
You can try that even without container by for example what I just did:
```
$ mkdir -p var/lib/rpm; cp -r /var/lib/rpm var/lib/rpm; rpm -r 
$(pwd)/var/lib/rpm -qavv
ufdio:   1 reads,17654 total bytes in 0.11 secs
ufdio:   1 reads, 5557 total bytes in 0.02 secs
ufdio:   1 reads,17654 total bytes in 0.09 secs
D: loading keyring from pubkeys in 
/home/tkloczko/rpmbuild/BUILD/var/lib/rpm/var/lib/rpm/pubkeys/*.key
D: couldn't find any keys in 
/home/tkloczko/rpmbuild/BUILD/var/lib/rpm/var/lib/rpm/pubkeys/*.key
D: loading keyring from rpmdb
D: opening  db environment 
/home/tkloczko/rpmbuild/BUILD/var/lib/rpm/var/lib/rpm cdb:0x401
D: opening  db index   
/home/tkloczko/rpmbuild/BUILD/var/lib/rpm/var/lib/rpm/Packages 0x400 mode=0x0
D: locked   db index   
/home/tkloczko/rpmbuild/BUILD/var/lib/rpm/var/lib/rpm/Packages
D: opening  db index   
/home/tkloczko/rpmbuild/BUILD/var/lib/rpm/var/lib/rpm/Name 0x400 mode=0x0
D: closed   db index   
/home/tkloczko/rpmbuild/BUILD/var/lib/rpm/var/lib/rpm/Packages
D: closed   db index   
/home/tkloczko/rpmbuild/BUILD/var/lib/rpm/var/lib/rpm/Name
D: closed   db environment /home/tkloczko/rpmbuild/BUILD/var/lib/rpm/var/lib/rpm
D: removed  db environment /home/tkloczko/rpmbuild/BUILD/var/lib/rpm/var/lib/rpm
```



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1372#issuecomment-699850657___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] 4.15.1: problem with rpm and --root option (#1372)

2020-09-25 Thread Tomasz Kłoczko
Look one more time on what I've copied. I've been executing rpm from root user.
Issue is that despite some files have been stat()ed and opened nothing is 
displayed.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1372#issuecomment-698970689___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] 4.15.1: problem with rpm and --root option (#1372)

2020-09-24 Thread Tomasz Kłoczko
I've started experimenting with lxc and I'm trying to make some rpm database 
queries from outside lxc zone using `-r `.
Looks like it is some issue with that option:
```
[root@barrel ~]# lxc-attach -n fedora -- rpm -qa | wc -l
329
```
So using lxc to execute command inside zone it works however:
```
[root@barrel ~]# rpm -qa -r /var/lib/llxc/fedora/rootfs -vvv
ufdio:   1 reads,17654 total bytes in 0.23 secs
ufdio:   1 reads, 5557 total bytes in 0.05 secs
ufdio:   1 reads,17654 total bytes in 0.23 secs
D: loading keyring from pubkeys in 
/var/lib/llxc/fedora/rootfs/var/lib/rpm/pubkeys/*.key
D: couldn't find any keys in 
/var/lib/llxc/fedora/rootfs/var/lib/rpm/pubkeys/*.key
D: loading keyring from rpmdb
D: opening  db environment /var/lib/llxc/fedora/rootfs/var/lib/rpm cdb:0x401
D: opening  db index   /var/lib/llxc/fedora/rootfs/var/lib/rpm/Packages 
0x400 mode=0x0
D: locked   db index   /var/lib/llxc/fedora/rootfs/var/lib/rpm/Packages
D: opening  db index   /var/lib/llxc/fedora/rootfs/var/lib/rpm/Name 0x400 
mode=0x0
D: closed   db index   /var/lib/llxc/fedora/rootfs/var/lib/rpm/Packages
D: closed   db index   /var/lib/llxc/fedora/rootfs/var/lib/rpm/Name
D: closed   db environment /var/lib/llxc/fedora/rootfs/var/lib/rpm
D: removed  db environment /var/lib/llxc/fedora/rootfs/var/lib/rpm
D: Exit status: 0
```
Full strace output with tracing files oprtations:
```
[root@barrel ~]# strace -fe trace=file rpm -qa -r /var/lib/llxc/fedora/rootfs 
-vvv
execve("/usr/bin/rpm", ["rpm", "-qa", "-r", "/var/lib/llxc/fedora/rootfs", 
"-vvv"], 0x7ffdf20f8420 /* 26 vars */) = 0
access("/etc/ld.so.preload", R_OK)  = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/etc/ld.so.cache", O_RDONLY|O_CLOEXEC) = 3
openat(AT_FDCWD, "/lib64/libc.so.6", O_RDONLY|O_CLOEXEC) = 3
openat(AT_FDCWD, "/lib64/librpm.so.9", O_RDONLY|O_CLOEXEC) = 3
openat(AT_FDCWD, "/lib64/librpmio.so.9", O_RDONLY|O_CLOEXEC) = 3
openat(AT_FDCWD, "/lib64/libpopt.so.0", O_RDONLY|O_CLOEXEC) = 3
openat(AT_FDCWD, "/lib64/libcap.so.2", O_RDONLY|O_CLOEXEC) = 3
openat(AT_FDCWD, "/lib64/libacl.so.1", O_RDONLY|O_CLOEXEC) = 3
openat(AT_FDCWD, "/lib64/liblua-5.3.so", O_RDONLY|O_CLOEXEC) = 3
openat(AT_FDCWD, "/lib64/libdb-5.3.so", O_RDONLY|O_CLOEXEC) = 3
openat(AT_FDCWD, "/lib64/libdl.so.2", O_RDONLY|O_CLOEXEC) = 3
openat(AT_FDCWD, "/lib64/libpthread.so.0", O_RDONLY|O_CLOEXEC) = 3
openat(AT_FDCWD, "/lib64/libbz2.so.1", O_RDONLY|O_CLOEXEC) = 3
openat(AT_FDCWD, "/lib64/libz.so.1", O_RDONLY|O_CLOEXEC) = 3
openat(AT_FDCWD, "/lib64/liblzma.so.5", O_RDONLY|O_CLOEXEC) = 3
openat(AT_FDCWD, "/lib64/libzstd.so.1", O_RDONLY|O_CLOEXEC) = 3
openat(AT_FDCWD, "/lib64/libcrypto.so.1.1", O_RDONLY|O_CLOEXEC) = 3
openat(AT_FDCWD, "/lib64/libm.so.6", O_RDONLY|O_CLOEXEC) = 3
openat(AT_FDCWD, "/proc/sys/crypto/fips_enabled", O_RDONLY) = 3
access("/etc/system-fips", F_OK)= -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/usr/lib/locale/locale-archive", O_RDONLY|O_CLOEXEC) = 3
openat(AT_FDCWD, "/usr/lib/rpm/rpmpopt-4.15.1", O_RDONLY) = 3
openat(AT_FDCWD, "/etc/popt", O_RDONLY) = -1 ENOENT (No such file or directory)
stat("/etc/popt.d", {st_mode=S_IFDIR|0755, st_size=22, ...}) = 0
openat(AT_FDCWD, "/etc/popt.d", O_RDONLY|O_NONBLOCK|O_CLOEXEC|O_DIRECTORY) = 3
openat(AT_FDCWD, "/usr/lib64/gconv/gconv-modules.cache", O_RDONLY) = 4
stat("/etc/popt.d/pesign.popt", {st_mode=S_IFREG|0644, st_size=143, ...}) = 0
openat(AT_FDCWD, "/etc/popt.d/pesign.popt", O_RDONLY) = 3
openat(AT_FDCWD, "/root/.popt", O_RDONLY) = -1 ENOENT (No such file or 
directory)
openat(AT_FDCWD, "/etc/nsswitch.conf", O_RDONLY|O_CLOEXEC) = 3
openat(AT_FDCWD, "/etc/ld.so.cache", O_RDONLY|O_CLOEXEC) = 3
openat(AT_FDCWD, "/lib64/libnss_sss.so.2", O_RDONLY|O_CLOEXEC) = 3
openat(AT_FDCWD, "/var/lib/sss/mc/passwd", O_RDONLY|O_CLOEXEC) = 3
openat(AT_FDCWD, "/etc/ld.so.cache", O_RDONLY|O_CLOEXEC) = 5
openat(AT_FDCWD, "/lib64/libnss_files.so.2", O_RDONLY|O_CLOEXEC) = 5
openat(AT_FDCWD, "/etc/passwd", O_RDONLY|O_CLOEXEC) = 5
openat(AT_FDCWD, "/var/lib/sss/mc/group", O_RDONLY|O_CLOEXEC) = 5
openat(AT_FDCWD, "/etc/group", O_RDONLY|O_CLOEXEC) = 6
stat("/etc/resolv.conf", {st_mode=S_IFREG|0644, st_size=64, ...}) = 0
openat(AT_FDCWD, "/etc/host.conf", O_RDONLY|O_CLOEXEC) = 6
openat(AT_FDCWD, "/etc/resolv.conf", O_RDONLY|O_CLOEXEC) = 6
openat(AT_FDCWD, "/etc/hosts", O_RDONLY|O_CLOEXEC) = 6
openat(AT_FDCWD, "/etc/rpm/platform", O_RDONLY) = -1 ENOENT (No such file or 
directory)
stat("/root/.rpmrc", 0x7fff8689fc80)= -1 ENOENT (No such file or directory)
access("/usr/lib/rpm/rpmrc", R_OK)  = 0
openat(AT_FDCWD, "/usr/lib/rpm/rpmrc", O_RDONLY) = 6
ufdio:   1 reads,17654 total bytes in 0.59 secs
access("/usr/lib/rpm/redhat/rpmrc", R_OK) = 0
openat(AT_FDCWD, "/usr/lib/rpm/redhat/rpmrc", O_RDONLY) = 6
ufdio:   1 reads, 5557 total bytes in 0.42 secs
openat(AT_FDCWD, "/usr/lib/rpm/rpmrc", O_RDONLY) = 6
ufdio:   1 reads,17654 total bytes in 

Re: [Rpm-maint] [rpm-software-management/rpm] 4.15.1: issue with debug info stipping procedure (#1362)

2020-09-20 Thread Tomasz Kłoczko
I've spend a bit more time on that case and I think that you may be actually 
right
https://gitlab.gnome.org/GNOME/gnome-tour/-/issues/24

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1362#issuecomment-695844113___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] 4.15.1: issue with debug info stipping procedure (#1362)

2020-09-19 Thread Tomasz Kłoczko
If it would true all my meson builds would be reporting the same issue.
```
$ rpm -E %meson

export CFLAGS="${CFLAGS:--O2 -g -pipe -Wall -Werror=format-security 
-Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fstack-protector-strong 
-grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 
-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic 
-fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection 
-flto=auto -flto-partition=none}";
export CXXFLAGS="${CXXFLAGS:--O2 -g -pipe -Wall -Werror=format-security 
-Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fstack-protector-strong 
-grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 
-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic 
-fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection 
-flto=auto -flto-partition=none}";
export FFLAGS="${FFLAGS:--O2 -g -pipe -Wall -Werror=format-security 
-Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fstack-protector-strong 
-grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 
-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic 
-fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection 
-I/usr/lib64/gfortran/modules -flto=auto -flto-partition=none}";
export FCFLAGS="${FCFLAGS:--O2 -g -pipe -Wall -Werror=format-security 
-Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fstack-protector-strong 
-grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 
-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic 
-fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection 
-I/usr/lib64/gfortran/modules -flto=auto -flto-partition=none}";
export LDFLAGS="${LDFLAGS:--Wl,-z,relro -Wl,--as-needed  -Wl,-z,now 
-specs=/usr/lib/rpm/redhat/redhat-hardened-ld -flto=auto -flto-partition=none 
-fuse-linker-plugin}";
export AR="/usr/bin/gcc-ar" RANLIB="/usr/bin/gcc-ranlib" 
NM="/usr/bin/gcc-nm";
export CC="gcc" CXX="g++"

/usr/bin/meson --buildtype=plain --prefix=/usr --libdir=/usr/lib64 
--libexecdir=/usr/libexec --bindir=/usr/bin --sbindir=/usr/sbin 
--includedir=/usr/include --datadir=/usr/share --mandir=/usr/share/man 
--infodir=/usr/share/info --localedir=/usr/share/locale --sysconfdir=/etc 
--localstatedir=/var --sharedstatedir=/var/lib --wrap-mode=nodownload 
--auto-features=enabled . x86_64-redhat-linux-gnu
```
As you see `-g` is used.
As well I would point one more time on `file` and `ls -l` output at the end of 
the %install:
```
+ ls -l 
/home/tkloczko/rpmbuild/BUILDROOT/gnome-tour-3.38.0-2.fc34.x86_64/usr/bin/gnome-tour
-rwxr-xr-x. 1 tkloczko tkloczko 2379352 Sep 16 00:18 
/home/tkloczko/rpmbuild/BUILDROOT/gnome-tour-3.38.0-2.fc34.x86_64/usr/bin/gnome-tour
+ file 
/home/tkloczko/rpmbuild/BUILDROOT/gnome-tour-3.38.0-2.fc34.x86_64/usr/bin/gnome-tour
/home/tkloczko/rpmbuild/BUILDROOT/gnome-tour-3.38.0-2.fc34.x86_64/usr/bin/gnome-tour:
 ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), dynamically linked, 
interpreter /lib64/ld-linux-x86-64.so.2, 
BuildID[sha1]=da2bb66637ef92012ace0c18de70d27a43275c04, for GNU/Linux 3.2.0, 
not stripped, too many notes (256)
```
As you see `file` says about that binary **not stripped, too many notes (256)**
After rpm fails fecause none of the debug info files foud ls shows:
```
$ ls -l 
/home/tkloczko/rpmbuild/BUILDROOT/gnome-tour-3.38.0-2.fc34.x86_64/usr/bin/gnome-tour
-rwxr-xr-x. 1 tkloczko tkloczko 1776784 Sep 19 21:00 
/home/tkloczko/rpmbuild/BUILDROOT/gnome-tour-3.38.0-2.fc34.x86_64/usr/bin/gnome-tour
```
So something stripped that binart reducing its size from 2379352  to 1776784  
bytes.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1362#issuecomment-695351364___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] 4.15.1: issue with debug info stipping procedure (#1362)

2020-09-18 Thread Tomasz Kłoczko
Building my own gnome-tour I found strange case.
After `%meson_install` binary gnome-tour binary is not stripped but after `post 
installation of course it is stripped but there is no debug info file and by 
this  buid fails.
```
+ /usr/bin/meson install -C x86_64-redhat-linux-gnu --no-rebuild
Installing data/org.gnome.Tour.desktop to 
/home/tkloczko/rpmbuild/BUILDROOT/gnome-tour-3.38.0-2.fc34.x86_64/usr/share/applications
Installing data/org.gnome.Tour.metainfo.xml to 
/home/tkloczko/rpmbuild/BUILDROOT/gnome-tour-3.38.0-2.fc34.x86_64/usr/share/metainfo
Installing src/gnome-tour to 
/home/tkloczko/rpmbuild/BUILDROOT/gnome-tour-3.38.0-2.fc34.x86_64/usr/bin
This file does not have an rpath.
This file does not have a runpath.
Installing 
/home/tkloczko/rpmbuild/BUILD/gnome-tour-3.38.0/data/icons/org.gnome.Tour.svg 
to 
/home/tkloczko/rpmbuild/BUILDROOT/gnome-tour-3.38.0-2.fc34.x86_64/usr/share/icons/hicolor/scalable/apps
Installing 
/home/tkloczko/rpmbuild/BUILD/gnome-tour-3.38.0/data/icons/org.gnome.Tour-symbolic.svg
 to 
/home/tkloczko/rpmbuild/BUILDROOT/gnome-tour-3.38.0-2.fc34.x86_64/usr/share/icons/hicolor/symbolic/apps
Running custom install script '/usr/bin/meson --internal gettext install 
--subdir=po --localedir=share/locale --pkgname=gnome-tour'
Installing 
/home/tkloczko/rpmbuild/BUILD/gnome-tour-3.38.0/x86_64-redhat-linux-gnu/po/ca.gmo
 to 
/home/tkloczko/rpmbuild/BUILDROOT/gnome-tour-3.38.0-2.fc34.x86_64/usr/share/locale/ca/LC_MESSAGES/gnome-tour.mo
Installing 
/home/tkloczko/rpmbuild/BUILD/gnome-tour-3.38.0/x86_64-redhat-linux-gnu/po/cs.gmo
 to 
/home/tkloczko/rpmbuild/BUILDROOT/gnome-tour-3.38.0-2.fc34.x86_64/usr/share/locale/cs/LC_MESSAGES/gnome-tour.mo
Installing 
/home/tkloczko/rpmbuild/BUILD/gnome-tour-3.38.0/x86_64-redhat-linux-gnu/po/da.gmo
 to 
/home/tkloczko/rpmbuild/BUILDROOT/gnome-tour-3.38.0-2.fc34.x86_64/usr/share/locale/da/LC_MESSAGES/gnome-tour.mo
Installing 
/home/tkloczko/rpmbuild/BUILD/gnome-tour-3.38.0/x86_64-redhat-linux-gnu/po/de.gmo
 to 
/home/tkloczko/rpmbuild/BUILDROOT/gnome-tour-3.38.0-2.fc34.x86_64/usr/share/locale/de/LC_MESSAGES/gnome-tour.mo
Installing 
/home/tkloczko/rpmbuild/BUILD/gnome-tour-3.38.0/x86_64-redhat-linux-gnu/po/el.gmo
 to 
/home/tkloczko/rpmbuild/BUILDROOT/gnome-tour-3.38.0-2.fc34.x86_64/usr/share/locale/el/LC_MESSAGES/gnome-tour.mo
Installing 
/home/tkloczko/rpmbuild/BUILD/gnome-tour-3.38.0/x86_64-redhat-linux-gnu/po/en_GB.gmo
 to 
/home/tkloczko/rpmbuild/BUILDROOT/gnome-tour-3.38.0-2.fc34.x86_64/usr/share/locale/en_GB/LC_MESSAGES/gnome-tour.mo
Installing 
/home/tkloczko/rpmbuild/BUILD/gnome-tour-3.38.0/x86_64-redhat-linux-gnu/po/es.gmo
 to 
/home/tkloczko/rpmbuild/BUILDROOT/gnome-tour-3.38.0-2.fc34.x86_64/usr/share/locale/es/LC_MESSAGES/gnome-tour.mo
Installing 
/home/tkloczko/rpmbuild/BUILD/gnome-tour-3.38.0/x86_64-redhat-linux-gnu/po/eu.gmo
 to 
/home/tkloczko/rpmbuild/BUILDROOT/gnome-tour-3.38.0-2.fc34.x86_64/usr/share/locale/eu/LC_MESSAGES/gnome-tour.mo
Installing 
/home/tkloczko/rpmbuild/BUILD/gnome-tour-3.38.0/x86_64-redhat-linux-gnu/po/fa.gmo
 to 
/home/tkloczko/rpmbuild/BUILDROOT/gnome-tour-3.38.0-2.fc34.x86_64/usr/share/locale/fa/LC_MESSAGES/gnome-tour.mo
Installing 
/home/tkloczko/rpmbuild/BUILD/gnome-tour-3.38.0/x86_64-redhat-linux-gnu/po/fi.gmo
 to 
/home/tkloczko/rpmbuild/BUILDROOT/gnome-tour-3.38.0-2.fc34.x86_64/usr/share/locale/fi/LC_MESSAGES/gnome-tour.mo
Installing 
/home/tkloczko/rpmbuild/BUILD/gnome-tour-3.38.0/x86_64-redhat-linux-gnu/po/fr.gmo
 to 
/home/tkloczko/rpmbuild/BUILDROOT/gnome-tour-3.38.0-2.fc34.x86_64/usr/share/locale/fr/LC_MESSAGES/gnome-tour.mo
Installing 
/home/tkloczko/rpmbuild/BUILD/gnome-tour-3.38.0/x86_64-redhat-linux-gnu/po/fur.gmo
 to 
/home/tkloczko/rpmbuild/BUILDROOT/gnome-tour-3.38.0-2.fc34.x86_64/usr/share/locale/fur/LC_MESSAGES/gnome-tour.mo
Installing 
/home/tkloczko/rpmbuild/BUILD/gnome-tour-3.38.0/x86_64-redhat-linux-gnu/po/gl.gmo
 to 
/home/tkloczko/rpmbuild/BUILDROOT/gnome-tour-3.38.0-2.fc34.x86_64/usr/share/locale/gl/LC_MESSAGES/gnome-tour.mo
Installing 
/home/tkloczko/rpmbuild/BUILD/gnome-tour-3.38.0/x86_64-redhat-linux-gnu/po/hr.gmo
 to 
/home/tkloczko/rpmbuild/BUILDROOT/gnome-tour-3.38.0-2.fc34.x86_64/usr/share/locale/hr/LC_MESSAGES/gnome-tour.mo
Installing 
/home/tkloczko/rpmbuild/BUILD/gnome-tour-3.38.0/x86_64-redhat-linux-gnu/po/hu.gmo
 to 
/home/tkloczko/rpmbuild/BUILDROOT/gnome-tour-3.38.0-2.fc34.x86_64/usr/share/locale/hu/LC_MESSAGES/gnome-tour.mo
Installing 
/home/tkloczko/rpmbuild/BUILD/gnome-tour-3.38.0/x86_64-redhat-linux-gnu/po/id.gmo
 to 
/home/tkloczko/rpmbuild/BUILDROOT/gnome-tour-3.38.0-2.fc34.x86_64/usr/share/locale/id/LC_MESSAGES/gnome-tour.mo
Installing 
/home/tkloczko/rpmbuild/BUILD/gnome-tour-3.38.0/x86_64-redhat-linux-gnu/po/it.gmo
 to 
/home/tkloczko/rpmbuild/BUILDROOT/gnome-tour-3.38.0-2.fc34.x86_64/usr/share/locale/it/LC_MESSAGES/gnome-tour.mo
Installing 
/home/tkloczko/rpmbuild/BUILD/gnome-tour-3.38.0/x86_64-redhat-linux-gnu/po/ja.gmo
 to 

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: map ~ part of the VERSION to %{PREVERSION} (#1321)

2020-07-28 Thread Tomasz Kłoczko
Closing.
After few experiments I founfd that using `~` in version for non-release builds 
makes spec files more complicated so curretly it does not simplifies anything.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1321#issuecomment-665065962___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] RFE: map ~ part of the VERSION to %{PREVERSION} (#1321)

2020-07-28 Thread Tomasz Kłoczko
Closed #1321.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1321#event-3594576273___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


  1   2   >