Re: [Rpm-maint] [PATCH] find-debuginfo.sh: Handle application/x-pie-executable (file 5.33 output).

[Panu Matilainen]

On 05/30/2018 11:58 AM, Mark Wielaard wrote:

On Tue, 2018-05-22 at 22:20 +0200, Mark Wielaard wrote:

A new version of file (5.33) changed the output for PIE executables.
Which are now represented as application/x-pie-executable;
charset=binary.

The following change simply recognizes that binary format as one for
which -g applies. This fixes accidental stripping of the .symtab in
glibc (which use -g to keep that symbol table).

https://bugzilla.redhat.com/show_bug.cgi?id=1581224


Ping. Fedora has since backed out the upstream change to file which
caused this. But the patch is still useful/necessary when using a
newer/upstream file.


Sorry, I was on vacation and still recovering from inbox flood. Applied 
now, thanks for the patch!


- Panu -

___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [PATCH] find-debuginfo.sh: Handle application/x-pie-executable (file 5.33 output).

[Mark Wielaard]

On Tue, 2018-05-22 at 22:20 +0200, Mark Wielaard wrote:
> A new version of file (5.33) changed the output for PIE executables.
> Which are now represented as application/x-pie-executable;
> charset=binary.
> 
> The following change simply recognizes that binary format as one for
> which -g applies. This fixes accidental stripping of the .symtab in
> glibc (which use -g to keep that symbol table).
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1581224

Ping. Fedora has since backed out the upstream change to file which
caused this. But the patch is still useful/necessary when using a
newer/upstream file.

> Signed-off-by: Mark Wielaard 
> ---
>  scripts/find-debuginfo.sh | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/scripts/find-debuginfo.sh b/scripts/find-debuginfo.sh
> index a7c2db0..90a4494 100755
> --- a/scripts/find-debuginfo.sh
> +++ b/scripts/find-debuginfo.sh
> @@ -235,6 +235,7 @@ strip_to_debug()
>    $strip_g && case "$(file -bi "$2")" in
>    application/x-sharedlib*) g=-g ;;
>    application/x-executable*) g=-g ;;
> +  application/x-pie-executable*) g=-g ;;
>    esac
>    eu-strip --remove-comment $r $g ${keep_remove_args} -f "$1" "$2"
> || exit
>    chmod 444 "$1" || exit
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

[Rpm-maint] [PATCH] find-debuginfo.sh: Handle application/x-pie-executable (file 5.33 output).

[Mark Wielaard]

A new version of file (5.33) changed the output for PIE executables.
Which are now represented as application/x-pie-executable; charset=binary.

The following change simply recognizes that binary format as one for
which -g applies. This fixes accidental stripping of the .symtab in
glibc (which use -g to keep that symbol table).

https://bugzilla.redhat.com/show_bug.cgi?id=1581224

Signed-off-by: Mark Wielaard 
---
 scripts/find-debuginfo.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/find-debuginfo.sh b/scripts/find-debuginfo.sh
index a7c2db0..90a4494 100755
--- a/scripts/find-debuginfo.sh
+++ b/scripts/find-debuginfo.sh
@@ -235,6 +235,7 @@ strip_to_debug()
   $strip_g && case "$(file -bi "$2")" in
   application/x-sharedlib*) g=-g ;;
   application/x-executable*) g=-g ;;
+  application/x-pie-executable*) g=-g ;;
   esac
   eu-strip --remove-comment $r $g ${keep_remove_args} -f "$1" "$2" || exit
   chmod 444 "$1" || exit
-- 
1.8.3.1

___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint