Re: [Rpm-maint] [PATCH 0/3] find-debuginfo.sh speedup
On 08/23/2016 10:49 PM, Michal Marek wrote:
> On Tue, Aug 23, 2016 at 03:19:17PM +0200, Mark Wielaard wrote:
>> Hi Michal,
>>
>> On Sun, 2016-08-14 at 22:33 +0200, Michal Marek wrote:
>>> Note that I'm still planning to submit the rebased patch series. But I'm
>>> having issues with the tests in rpmbuild.at and rpmbuildid.at, both with
>>> and without my patches, so I can't verify the patches.
>>
>> What kind of failures do you see? The testcases PASS on my setup, but to
>> get zero FAIL I do need to set my hostname to "localhost" and use a
>> specific old version of fakechroot (2.9-32.fc21 installed on my Fedora
>> 24 system).
>
> I actually fixed some of the issues with fakechroot, see the attached
> patch. But it regressed in 2.17, so that opendir(".") no longer works.
> Thanks for the hint with the hostname, I'll try it and hopefully send
> the rebased find-debuginfo series soon.
*Arg* I should have checked the moderation queue for the ML right after
my vacation. But it is that rare that there's anything other than spam
in there...
Anyway, this is the fix I've been looking for quite a while (although I
suspect that fakechroot was even more broken when I attempted to find
out what was wrong back in the days)
Anyway: Thank you very much for the patch. I applied the same reasoning
to the other test cases, too, and the now all pass with the new
fakechroot version. I clearly owe you beer.
Florian
--
Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Paul Argiry, Charles Cachera, Michael Cunningham,
Michael O'Neill
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [PATCH 0/3] find-debuginfo.sh speedup
On 08/14/2016 10:33 PM, Michal Marek wrote: > Dne 2.7.2016 v 21:11 Michal Marek napsal(a): >> Dne 2.7.2016 v 16:28 Mark Wielaard napsal(a): >>> Hi, >>> >>> On Fri, 2016-07-01 at 22:43 +0200, Michal Marek wrote: this series allows find-debuginfo.sh to run in parallel. It also makes the duplicate build-id links predictable. >>> >>> The build-id link code was completely rewritten in one of the patches I >>> wrote some weeks ago: >>> http://lists.rpm.org/pipermail/rpm-maint/2016-June/004365.html >>> >>> Could you look at how your changes interact with that? I think your "3/3 >>> find-debuginfo.sh: Process files in parallel" patch should work as is >>> with that cleanup. >> >> OK, I will have a look. > > Note that I'm still planning to submit the rebased patch series. But I'm > having issues with the tests in rpmbuild.at and rpmbuildid.at, both with > and without my patches, so I can't verify the patches. Feel free to post the patches anyway. I (and probably Mark also) can have a look. The test suite is in deed a bit fragile. Florian -- Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243, Managing Directors: Paul Argiry, Charles Cachera, Michael Cunningham, Michael O'Neill ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [PATCH 0/3] find-debuginfo.sh speedup
Dne 2.7.2016 v 16:28 Mark Wielaard napsal(a): > Hi, > > On Fri, 2016-07-01 at 22:43 +0200, Michal Marek wrote: >> this series allows find-debuginfo.sh to run in parallel. It also makes the >> duplicate build-id links predictable. > > The build-id link code was completely rewritten in one of the patches I > wrote some weeks ago: > http://lists.rpm.org/pipermail/rpm-maint/2016-June/004365.html > > Could you look at how your changes interact with that? I think your "3/3 > find-debuginfo.sh: Process files in parallel" patch should work as is > with that cleanup. OK, I will have a look. > And do you have any testcases for this or could you check with the > testcases in the above patch set to see if it has the right behavior? > It adds a rpmbuildid.at that explicitly checks generating build-id > symlinks for binaries that are hard linked and/or have duplicate > build-ids. I do not have any systematic testcases, but in my random testing I found a race in patch 3/3: Using a named pipe was not a good idea, because a job might open it too late and hang forever. So I will be posting a v2 soon. Michal ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [PATCH 0/3] find-debuginfo.sh speedup
Hi, On Fri, 2016-07-01 at 22:43 +0200, Michal Marek wrote: > this series allows find-debuginfo.sh to run in parallel. It also makes the > duplicate build-id links predictable. The build-id link code was completely rewritten in one of the patches I wrote some weeks ago: http://lists.rpm.org/pipermail/rpm-maint/2016-June/004365.html Could you look at how your changes interact with that? I think your "3/3 find-debuginfo.sh: Process files in parallel" patch should work as is with that cleanup. And do you have any testcases for this or could you check with the testcases in the above patch set to see if it has the right behavior? It adds a rpmbuildid.at that explicitly checks generating build-id symlinks for binaries that are hard linked and/or have duplicate build-ids. Thanks, Mark ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [PATCH 0/3] find-debuginfo.sh speedup
Hi, this series allows find-debuginfo.sh to run in parallel. It also makes the duplicate build-id links predictable. Michal Michal Marek (3): find-debuginfo.sh: Split directory traversal and debuginfo extraction find-debuginfo.sh: Make the duplicate id links deterministic find-debuginfo.sh: Process files in parallel macros.in | 2 +- scripts/find-debuginfo.sh | 108 -- 2 files changed, 87 insertions(+), 23 deletions(-) -- 2.6.2 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
