Re: [Rpm-maint] [rpm-software-management/rpm] Add proper logic for debuginfo enablement (PR #3085)
Oh, yup. I thought I made a further comment here but apparently didn't... -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3085#issuecomment-2122295789 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add proper logic for debuginfo enablement (PR #3085)
> Just noting it here that since distros are widely overriding > %__spec_install_post, **they'll need to update that** ... I suppose this was obsoleted by https://github.com/rpm-software-management/rpm/pull/3098, correct? -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3085#issuecomment-2120485295 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add proper logic for debuginfo enablement (PR #3085)
Just noting it here that since distros are widely overriding %__spec_install_post, they'll need to update that to match the new logic in there. @ffesti's version placed the %_enable_debuginfo_packages test into %__spec_install_pre which isn't as widely overridden and so would be more backwards compatible, but then it wouldn't be all in one place. It's a hugely annoying mess :unamused: -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3085#issuecomment-2107200152 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add proper logic for debuginfo enablement (PR #3085)
Merged #3085 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3085#event-12783521877 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add proper logic for debuginfo enablement (PR #3085)
Release notes need to mention this and that distribution need to drop the
```
%install %{?_enable_debug_packages:%{?buildsubdir:%{debug_package}}}\
%%install\
%{nil}
```
hack in *-pm-config. So this probably needs to go into the "Compatibility"
section at least in parts.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3085#issuecomment-2106940575
You are receiving this because you are subscribed to this thread.
Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add proper logic for debuginfo enablement (PR #3085)
This is even cleaner than my own variant. Great so see we got this to the point where it can be done this cleanly. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3085#issuecomment-2106923789 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add proper logic for debuginfo enablement (PR #3085)
Had a brief look at killing %__debug_package, but that gets more complicated
than it should (and who's surprised?) So many packages rely on redefining
%debug_package to %{nil} for disabling debuginfo generation that we just have
to preserve that for the time being, and having %debug_package define something
else as a side-effect is an easy (if ugly) way to handle this. Not worth
messing with just now.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3085#issuecomment-2106828884
You are receiving this because you are subscribed to this thread.
Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add proper logic for debuginfo enablement (PR #3085)
Mentioned the %setup-less debuginfo case and added an explicit sub-test for it. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3085#issuecomment-2106811147 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add proper logic for debuginfo enablement (PR #3085)
@pmatilai pushed 1 commit. 8abfcff2ec15d750f9f92d7a8053413fe888172e Add proper logic for debuginfo enablement -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/3085/files/d8ad95f93cfb362390e3f0249d9bcbcad7eb4d5a..8abfcff2ec15d750f9f92d7a8053413fe888172e You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add proper logic for debuginfo enablement (PR #3085)
Yeah it's nice to be able to use the dynamic spec stuff for our own purposes. To clarify, #3084 is only needed for the "rpmbuild %caps" test which intentionally does not use %setup to test that case, and whose debuginfo now gets generated. So that's basically another bug fixed / limitation eliminated, I could've sworn we have a ticket on debuginfo requiring %setup but can't find it. I haven't tested but it may well cure #3042 too because the combo means it no longer requires the full %setup thing to run. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3085#issuecomment-2106780415 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add proper logic for debuginfo enablement (PR #3085)
@Conan-Kudo approved this pull request. This is a lot cleaner and I like this setup. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3085#pullrequestreview-2051465542 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add proper logic for debuginfo enablement (PR #3085)
It'd probably be possible to further drop the __debug_package logic and merge __debug_install_post into this, and maybe this should be in couple of separate commits, just wanted to get this out before the weekend :sweat_smile: -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3085#issuecomment-2104585532 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add proper logic for debuginfo enablement (PR #3085)
The first two commits are simply #3084 which is needed for this to work. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3085#issuecomment-2104577668 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Add proper logic for debuginfo enablement (PR #3085)
All these years, enabling debuginfo has required distros to hijack the spec
%install section with a macro like this:
%install %{?_enable_debug_packages:%{?buildsubdir:%{debug_package}}}\
%%install\
%{nil}
This for a widely used, longtime upstream supported feature is just gross, and
also very non-obvious, feeble and whatnot. And totally prevents the new
append/prepend options from being used with %install.
Take advantage of several newish features to make this happen: we need
expressions to properly handle the numeric %_enable_debug_packages value from a
macro, and if enabled, output the debuginfo template as a dynamic .specpart.
Enable debuginfo on Linux by default in the platform configuration. Notably
noarch should not have debuginfo so its disabled in the platform
configuration - since 96467dce18f264b278e17ffe1859c88d9b5aa4b6 we can now
actually rely on the platform configuration being valid, so we can drop the
%ifnarch noarch from the debug package check. Further streamlining
should be possible.
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/3085
-- Commit Summary --
* Simplify doBuildDir() and use appropriate macros as well
* Always create %specpartsdir on build
* Add proper logic for debuginfo enablement
-- File Changes --
M build/build.c (12)
M build/parsePrep.c (10)
M installplatform (6)
M macros.in (2)
M platform.in (3)
M tests/data/SPECS/specstep.spec (1)
M tests/data/macros.debug (10)
M tests/rpmbuild.at (1)
M tests/rpmspec.at (2)
-- Patch Links --
https://github.com/rpm-software-management/rpm/pull/3085.patch
https://github.com/rpm-software-management/rpm/pull/3085.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3085
You are receiving this because you are subscribed to this thread.
Message ID: rpm-software-management/rpm/pull/3...@github.com
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
