Re: [Rpm-maint] [rpm-software-management/rpm] Allow an optional argument for the %verbose macro (#1791)
Thanks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1791#issuecomment-951925391___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Allow an optional argument for the %verbose macro (#1791)
Merged #1791 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1791#event-5520530521___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Allow an optional argument for the %verbose macro (#1791)
I added the documentation and rebased the commit to the new macro code. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1791#issuecomment-951846887___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Allow an optional argument for the %verbose macro (#1791)
It's a bit strange perhaps but I don't have any better ideas for the compatibility either. Just update the docs and I'm fine with it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1791#issuecomment-942066714___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Allow an optional argument for the %verbose macro (#1791)
@mlschroe pushed 1 commit. a917182859f21602e5fa212542c0ddb08b753b90 Allow an optional argument for the %verbose macro -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1791/files/3e1f7c0baaa862c9cdc65989eed545e0b0b490bc..a917182859f21602e5fa212542c0ddb08b753b90 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Allow an optional argument for the %verbose macro (#1791)
(We could simplify this a bit if we change the ME_PARSE macros nargs definitions from -1 to 1.) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1791#issuecomment-936314427___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Allow an optional argument for the %verbose macro (#1791)
This improves compatibility with old rpm versions. If the argument is present, the macro expands to it in verbose mode and to an empty string if not in verbose mode. I created this patch because people were asking me for a way to check for verbose mode that works both in old and new rpm versions and I could not find a good answer. Feel free to reject if you dont like it. (The documentation change is still missing.) You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1791 -- Commit Summary -- * https://github.com/rpm-software-management/rpm/pull/1791/commits/3e1f7c0baaa862c9cdc65989eed545e0b0b490bc;>Allow an optional argument for the %verbose macro -- File Changes -- M rpmio/macro.c (9) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/1791.patch https://github.com/rpm-software-management/rpm/pull/1791.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1791 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint