Re: [Rpm-maint] [rpm-software-management/rpm] Always create %specpartsdir on build (PR #3084)
Merged #3084 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3084#event-12783120373 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Always create %specpartsdir on build (PR #3084)
Guess this is how the %specpartsdir should have been created in the first place. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3084#issuecomment-2106916674 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Always create %specpartsdir on build (PR #3084)
With this, %specpartsdir gets created *before* %prep. The idea being that %specpartsdir, just like %builddir, are rpm provided infrastructure that can be counted on always being there no matter what the spec does (or doesn't) -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3084#issuecomment-2106711798 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Always create %specpartsdir on build (PR #3084)
This should still get it created in `%prep`, right? It _seems_ like that's the case. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3084#issuecomment-2106394010 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Always create %specpartsdir on build (PR #3084)
@Conan-Kudo approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3084#pullrequestreview-2051465619 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Always create %specpartsdir on build (PR #3084)
Theres no reason %specpartsdir should be dependent on %setup use, just create it when we create the build directory too. Update tests accordingly. The spec parse test is noteworthy, the specparts dir creation no longer shows up in spec parse output, which certainly is the way it should be: this is rpm internal infrastructure stuff and nothing to do with spec *parse*, this all only takes place during builds. Fixes: #3063 You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/3084 -- Commit Summary -- * Simplify doBuildDir() and use appropriate macros as well * Always create %specpartsdir on build -- File Changes -- M build/build.c (11) M build/parsePrep.c (10) M tests/rpmbuild.at (1) M tests/rpmspec.at (2) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/3084.patch https://github.com/rpm-software-management/rpm/pull/3084.diff -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3084 You are receiving this because you are subscribed to this thread. Message ID: rpm-software-management/rpm/pull/3...@github.com ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
