Re: [Rpm-maint] [rpm-software-management/rpm] Code cleanups in tests/rpmpgppubkeyfingerprint.c (PR #3068)
Created https://github.com/rpm-software-management/rpm/pull/3072 -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3068#issuecomment-2090760401 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Code cleanups in tests/rpmpgppubkeyfingerprint.c (PR #3068)
Accidentally closed it, I will open a new PR. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3068#issuecomment-2090506199 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Code cleanups in tests/rpmpgppubkeyfingerprint.c (PR #3068)
Closed #3068. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3068#event-12681683498 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Code cleanups in tests/rpmpgppubkeyfingerprint.c (PR #3068)
> I took the liberty to make this whole source look better. Better is subjective. The indentation was mostly following rpm coding style, now it's not. See Coding style / Indentation in CONTRIBUTING.md. Never, ever make formatting changes at the same time as other changes, and in particular, don't break what wasn't broken. It's impossible to review a change like this. In the light of recent events, "small test stuff" certainly needs reviewing too. One thing that did catch my eye despite that is pointless NULL checks before freeing. Don't do that, free() will do it for you anyhow. In the meanwhile, there *are* real cleanups/simplifications to be made. Like manually calculating string sizes when it could use rasprintf(), and manual getcwd() when we have rpmGetCwd() and malloc() with OOM checking for what's a static buffer that wouldn't need freeing. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3068#issuecomment-2084396253 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Code cleanups in tests/rpmpgppubkeyfingerprint.c (PR #3068)
@ffesti I took the liberty to make this whole source look better. Please let me know if you want me to make changes in incremental commits. This is a small test file which is essentially testing a dummy function, so I made all changes in one commit. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3068#issuecomment-2083523347 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
